jeffqjiangNew
d24e374566
* AV1 error resilience: Added invalid stream syntax element checks in various places. ( #582 )
...
- Added checks for allowed values for various stream syntax elements, according to AV1 specification.
[ROCm/rocdecode commit: 17ef0c2d56 ]
2025-05-09 14:35:08 -04:00
Afzal Patel
47d8573462
add amdgpu drm include directory ( #579 )
...
* add amdgpu drm include directory
* modify find_path
* add additional paths to address ci fail
[ROCm/rocdecode commit: b84146fb42 ]
2025-05-06 21:59:00 -04:00
jeffqjiangNew
6e1cd70811
Error resilience: Added a few error handling measures. ( #581 )
...
* * Error resilience: Added a few error handling measures.
- AV1: Added check flags to sequence header and frame header to indicate if the headers are parsed without errors. The flags are used to check if the parsing process which refers to the headers can proceed or stop.
- AV1: Added divide by 0 check on tile columns in tile group parsing.
- AV1: Added invalid OBU size check in AV1 elementary stream parsing in bitstream reader.
- All codecs: Added divide by 0 check in display aspect ratio calculation.
* * Error resilience: Fixed a typo in an error message.
[ROCm/rocdecode commit: a861d6f1d2 ]
2025-05-06 12:02:51 -04:00
jeffqjiangNew
798a4a03f0
AV1 error resilience: Added tile size error detection and handling. ( #580 )
...
* * AV1 error resilience: Added tile size error detection and handling. Also added additional update to change log for PR#574.
* * Wording change in change log.
* * Updated change log based on review comments.
[ROCm/rocdecode commit: 41338c40f3 ]
2025-05-05 12:01:56 -04:00
Aryan Salmanpour
d64d6326f8
VideoDecodePerf sample: use a display delay of 1 by default ( #578 )
...
[ROCm/rocdecode commit: cf85e6c46c ]
2025-05-01 16:03:38 -04:00
jeffqjiangNew
a8f665e2be
* Roc decoder utility: Do not throw exceptions on picture decode or decoder reconfig errors. ( #577 )
...
- This allows the decoder to be able to handle more AV1 error streams.
[ROCm/rocdecode commit: d751b24ed5 ]
2025-05-01 12:50:28 -04:00
jeffqjiangNew
8483251c80
Decoder utility: Removed a couple of incorrect asserts. ( #574 )
...
* * Decoder utility: Removed a couple of incorrect asserts. Changed other asserts to error messages.
* * Changed rocDecode version from 0.12.0 to 0.13.0. Updated change log.
* * Decoder utility: Updated change log based on review comments.
* * Decoder utility: Minor format change based on review: removed the extra space.
[ROCm/rocdecode commit: 4b10fa5a1a ]
2025-04-29 16:41:36 -04:00
jeffqjiangNew
1a42a7238e
* CI: Added AV1 stability test to CI. ( #576 )
...
[ROCm/rocdecode commit: 7e5a3f6939 ]
2025-04-28 21:25:12 -04:00
jeffqjiangNew
e8981c5848
AV1 error resilience: Treated OBU header syntax errors as non-critical. Added invalid OBU size detection and handling. ( #570 )
...
* * AV1 error resilience: Treated OBU header syntax errors as non-critical. Added invalid OBU size detection and handling.
* * AV1 error resilience: Minor change.
[ROCm/rocdecode commit: e85ae200e5 ]
2025-04-25 13:57:37 -04:00
jeffqjiangNew
0558dee8c5
* CI: Do not do AV1 conformance test on MI2xx or MI1xx, which does not support AV1 decode. ( #573 )
...
[ROCm/rocdecode commit: 3f4d513c65 ]
2025-04-24 18:23:28 -04:00
jeffqjiangNew
4776553f61
CI: Added AVC and HEVC decode stability tests to CI. ( #572 )
...
* * CI: Added AVC and HEVC decode stability tests to CI.
* * CI: Do not run HEVC stability tests on MI2xx or MI1xx.
[ROCm/rocdecode commit: 6aab0c1375 ]
2025-04-24 10:46:17 -04:00
amd-garydeng
7173e17f16
Change Jenkins CI behavior to be more efficient ( #567 )
...
* Move all wgets out and add checks
* remove old line
* remove unzips
* remove double slash
[ROCm/rocdecode commit: 02fa4b5516 ]
2025-04-21 21:50:55 -04:00
jeffqjiangNew
357c33ac40
Revert "CTest: Added CTest for AV1 elementary stream decode on bitstream read…" ( #569 )
...
This reverts commit 5cdfca2a33 .
[ROCm/rocdecode commit: 2dea69d26b ]
2025-04-21 15:57:15 -04:00
Kiriti Gowda
468181845f
Update .codecov.yaml ( #568 )
...
[ROCm/rocdecode commit: afc605b328 ]
2025-04-21 08:49:49 -04:00
Aryan Salmanpour
5cfc550419
code cleanup - fix a typo ( #564 )
...
[ROCm/rocdecode commit: d946ffd212 ]
2025-04-16 22:26:10 -04:00
jeffqjiangNew
5cdfca2a33
CTest: Added CTest for AV1 elementary stream decode on bitstream reader. ( #561 )
...
* * CTest: Added CTest for AV1 elementary stream decode on bitstream reader.
* * CTest: Added the missing stream file.
* * CTest: Fixed the batch sample CTest failure on RHEL8 system where AV1 elementary stream is not supported by the installed FFMPEG demuxer. Now we do not run batch test on elementary streams.
* * CTest: Added two missing path changes.
[ROCm/rocdecode commit: 5472059e16 ]
2025-04-16 21:20:16 -04:00
Aryan Salmanpour
2a86f75813
CTest: Add a test to perform negative testing on all rocDecode APIs ( #562 )
...
[ROCm/rocdecode commit: 1d8ab16c52 ]
2025-04-16 16:46:50 -04:00
Aryan Salmanpour
fe0e639d08
close the drm_fd in the VaContext destructor ( #560 )
...
[ROCm/rocdecode commit: ed556199b0 ]
2025-04-14 19:13:57 -04:00
jeffqjiangNew
a65bc49a07
* AVC: Disabled support for gaps in frame_num. ( #559 )
...
[ROCm/rocdecode commit: 03f73357c7 ]
2025-04-14 16:23:15 -04:00
Aryan Salmanpour
ad9978f20f
Add extra error checking during decoder reconfiguration ( #558 )
...
[ROCm/rocdecode commit: 0f89c55157 ]
2025-04-14 14:36:08 -04:00
jeffqjiangNew
d9512d14df
AVC error resilience: Treat reference list setup errors as non-critical. Also minor wording correction in sample script output. ( #557 )
...
* * AVC error resilience: Treat reference list setup errors as non-critical. Also minor wordking correction in sample script output.
* * AVC error resilience: Minor change.
---------
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com >
[ROCm/rocdecode commit: 193423300f ]
2025-04-12 09:11:33 -04:00
Kiriti Gowda
9d0563486e
Code Coverage - Updates ( #556 )
...
* Code Coverage - Updates
* Jenkins - Fix LLVM Location
[ROCm/rocdecode commit: a1ead2a7c1 ]
2025-04-10 13:21:51 -07:00
jeffqjiangNew
a0dd3fc6b3
AVC: Added support for in stream DPB buffer size change. ( #553 )
...
* * AVC: Added support for in stream DPB buffer size change.
* * AVC: Updated change log.
---------
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com >
[ROCm/rocdecode commit: 3d1a1b638e ]
2025-04-09 20:57:52 -04:00
Kiriti Gowda
74da3a7457
Codecov - .codecov.yaml ( #554 )
...
* Create .codecov.yaml
* Update .codecov.yaml
* Update .codecov.yaml
[ROCm/rocdecode commit: c39e320756 ]
2025-04-09 14:43:10 -04:00
Aryan Salmanpour
20e919c6cf
Code Clean up - remove unused API ( #552 )
...
* Code Clean up - remove unused API
* clean up
[ROCm/rocdecode commit: d80f807b1a ]
2025-04-09 13:49:04 -04:00
Lakshmi Kumar
711f12d271
CI update - Add avc, av1 and vp9 conformance to CI ( #551 )
...
* add avc, av1 and vp9 conformance to CI
* address review comments
* fix directory structure
* fix directory structure
* Update common.groovy
---------
Co-authored-by: Kiriti Gowda <kiriti.nageshgowda@amd.com >
[ROCm/rocdecode commit: 038d618836 ]
2025-04-08 21:54:48 -07:00
jeffqjiangNew
8b5cf557df
* AVC: Fixed an issue in video size change cases, where the remaining decoded buffers of the previous video size in DPB are not output. ( #550 )
...
- We need to flush DPB before decoder reconfiguration.
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com >
[ROCm/rocdecode commit: 9127f2ccba ]
2025-04-07 20:34:01 -04:00
jeffqjiangNew
97d503139d
AVC error resilience: Added bitstream syntax error handling. ( #549 )
...
* * AVC error resilience: Added syntax error detection in SPS, PPS, and slice header parsing.
* * AVC error resilience: Added NAL unit size check before parsing.
* * AVC error resilience: Added parsing error handling.
* * AVC error resilience: Updated change log.
[ROCm/rocdecode commit: 0cb7c4594c ]
2025-04-07 16:16:49 -07:00
Kiriti Gowda
024a817e30
Jenkins - Install built packages ( #538 )
...
* Jenkins - Install built packages
* Update common.groovy
* Update common.groovy
[ROCm/rocdecode commit: 65118415cf ]
2025-04-01 08:42:12 -04:00
Kiriti Gowda
8c8601e1fd
CMakeLists - Set Std updates & Jenkins CodeCov ( #546 )
...
* CMakeLists - Set Std updates
* Jenkins - Code coverage
* Jenkins - Fix and cleanup
* Jenkins - Fix
* Jenkins - Fix
* Jenkins - Fix
* Jenkins - Fix
* Use amdclang compiler
* Remove slash in front of quote
* Jenkins - Fix
* Jenkins - Fix location
* Jenkins - Fix perf export
* Jenkins - .so fix
* Jenkins - lcov
* Install fix
* Use repo token for codecov
* Pass in sha to codecov
* Use clang19 for ubu24
* Use default clang
* CMakeLists - Set Std updates
* Jenkins - Code coverage
* Jenkins - Fix and cleanup
* Jenkins - Fix
* Jenkins - Fix
* Jenkins - Fix
* Jenkins - Fix
* Use amdclang compiler
* Remove slash in front of quote
* Jenkins - Fix
* Jenkins - Fix location
* Jenkins - Fix perf export
* Jenkins - .so fix
* Jenkins - lcov
* Install fix
* Use repo token for codecov
* Pass in sha to codecov
* Use clang19 for ubu24
* Use default clang
* Set proxy for codecov uploader
Needed for gfx90a
---------
Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com >
[ROCm/rocdecode commit: 5eab03d198 ]
2025-03-31 21:31:23 -07:00
jeffqjiangNew
a7b5c7df8c
* HEVC error resilience: Adjusted the range check for the total reference picture number so more errors can be detected. Also fixed a build warning of avc_parser.cpp in debug mode. ( #548 )
...
[ROCm/rocdecode commit: d10eacf05f ]
2025-03-31 19:04:34 -04:00
jeffqjiangNew
1294a57b37
Script: Added the decode status check mode to the rocDecode samples script. ( #544 )
...
* * rocDecode/script: Added the decode status check mode to the rocDecode samples script.
- In decode status check mode, we check if a stream can be decoded to the end without abortion due to errors. This mode is used for decoder error resilience test.
* * rocDecode/script: Fixed a typo.
[ROCm/rocdecode commit: bf8e715eec ]
2025-03-31 10:59:10 -04:00
jeffqjiangNew
13e8e15d7b
* rocDecode/HEVC error resilience: Added dependant slice error handling. ( #547 )
...
[ROCm/rocdecode commit: fc01d72aea ]
2025-03-28 16:35:03 -04:00
Aryan Salmanpour
bde6adab91
Revert "modify conformance script to exit with -1 ( #543 )" ( #545 )
...
This reverts commit 0be4a0c032 .
[ROCm/rocdecode commit: 9c41ddf29f ]
2025-03-26 09:21:47 -04:00
Lakshmi Kumar
0be4a0c032
modify conformance script to exit with -1 ( #543 )
...
Co-authored-by: Aryan Salmanpour <aryan.salmanpour@amd.com >
[ROCm/rocdecode commit: 3d420391fd ]
2025-03-26 08:24:55 -04:00
jeffqjiangNew
ae7b72631f
HEVC Error resilience: Added invalid syntax detection in SPS, PPS, and slice header parsing. ( #542 )
...
* * rocDecode/HEVC Error resilience: Added invaid syntax detection in SPS, PPS, and slice header parsing.
* * rocDecode/HEVC error resilience: Minor indent change.
[ROCm/rocdecode commit: 93711b5127 ]
2025-03-26 08:16:36 -04:00
jeffqjiangNew
affbcdba0d
Doc: Moved change log for PR#512 from 6.4 to 6.5 as PR#512 did not go into 6.4. ( #541 )
...
* * rocDecode/Doc: Moved change log for PR#512 from 6.4 to 6.5 as PR#512 did not go into 6.4.
* * rocDecode/Doc: Missing line deletion from last commit.
[ROCm/rocdecode commit: d72e9a2d26 ]
2025-03-24 15:38:54 -04:00
spolifroni-amd
969eb83653
adding some bitstream reader api doc ( #539 )
...
* adding some bitstream reader api doc
* changes based on Jeff and Aryan's review
[ROCm/rocdecode commit: 72e7d23d12 ]
2025-03-21 14:48:10 -04:00
Lakshmi Kumar
5157e8d7d0
Fix warnings ( #536 )
...
* fix warnings
* remove warning
---------
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com >
[ROCm/rocdecode commit: 0b1865e8b8 ]
2025-03-20 09:12:16 -04:00
Kiriti Gowda
437b816cd0
Dev Package fix ( #537 )
...
[ROCm/rocdecode commit: 35ed4e9b7a ]
2025-03-19 13:07:11 -04:00
jeffqjiangNew
ede21fffa0
HEVC: Added DPB size change handling through decoder reconfiguration. ( #531 )
...
* * rocDecode/HEVC: Added DPB size change handling through decoder reconfiguration.
* * rocDecode/HEVC: Minor fix.
[ROCm/rocdecode commit: 5988eb16b6 ]
2025-03-18 17:19:01 -04:00
jeffqjiangNew
cd31658919
Picture file sample: Bug fix. ( #533 )
...
* * rocDecode/Picture file sample: Fixed a bug that can result in incorrect output frame count when reconfiguration occurs and with more than one iterations.
* * rocDecode: Updated change log.
[ROCm/rocdecode commit: 34cdd7f709 ]
2025-03-18 15:17:52 -04:00
Lakshmi Kumar
54d6a5a6dc
Version header - Bug fix required for rocal ( #535 )
...
* rocm version check for targets
* check rocm targets for gfx
* space fixes to generate version file
[ROCm/rocdecode commit: 86d5d51d09 ]
2025-03-18 13:24:33 -05:00
Kiriti Gowda
26a67fb210
CMake config - updates and fixes ( #532 )
...
* CMake Config - updates and fixes
* Version - Updates
* Changelog - updates
* Update CHANGELOG.md
Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com >
---------
Co-authored-by: spolifroni-amd <Sandra.Polifroni@amd.com >
[ROCm/rocdecode commit: 6b026af151 ]
2025-03-17 12:38:01 -04:00
Aryan Salmanpour
68dee64275
Remove unused VA_CHECK_VERSION ( #530 )
...
[ROCm/rocdecode commit: d8e285ce1b ]
2025-03-13 10:43:57 -04:00
jeffqjiangNew
aacd035b6d
HEVC: Added bit depth change support in decoder reconfiguration. ( #527 )
...
* * rocDecode/HEVC: Added bit depth change support in decoder reconfiguration.
* * rocDecode/HEVC: Removed a comment line.
* * rocDecode/HEVC: Updated change log.
* * rocDecode/HEVC: Used the reserved space in RocdecReconfigureDecoderInfo structure for bit_depth_minus_8 field to be backward compatible. Added bit depth to the new sequence file name when we dump output in decoder reconfiguration case.
* * rocDecode/HEVC: Added bit depth change support in decoder reconfiguration.
* * rocDecode/HEVC: Removed a comment line.
* * rocDecode/HEVC: Updated change log.
* * rocDecode/HEVC: Used the reserved space in RocdecReconfigureDecoderInfo structure for bit_depth_minus_8 field to be backward compatible. Added bit depth to the new sequence file name when we dump output in decoder reconfiguration case.
* * rocDecode/HEVC: Changes based on review comments.
* * rocDecode: Fixed a bug related to 422 surface format assignment.
* * rocDecode: Fixed build warnings with some sample apps.
[ROCm/rocdecode commit: ab7546930f ]
2025-03-13 09:29:25 -04:00
jeffqjiangNew
cd98621eb9
* rocDecode/HEVC error resilience: Fixed a vulnerability with active PPS id. We should not assign the current active PPS id to an invalid value. ( #529 )
...
[ROCm/rocdecode commit: ac74540c19 ]
2025-03-12 17:49:52 -04:00
Lakshmi Kumar
083ef24843
Warning fixes ( #528 )
...
* rocm version check for targets
* check rocm targets for gfx
* fix warnings
* review comments
[ROCm/rocdecode commit: 2b4228a824 ]
2025-03-11 16:28:46 -04:00
spolifroni-amd
99b53ab2a5
added howto use for the utility classes ( #511 )
...
* added howto use for the utility classes
* Update docs/conceptual/rocDecode-memory-types.rst
Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com >
* Update docs/conceptual/rocDecode-memory-types.rst
Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com >
* Update docs/how-to/using-rocDecode-bitstream.rst
Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com >
* Update docs/how-to/using-rocDecode-bitstream.rst
Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com >
* Update docs/how-to/using-rocDecode-bitstream.rst
Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com >
* Update docs/how-to/using-rocDecode-bitstream.rst
Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com >
* Update docs/how-to/using-rocdecode.rst
Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com >
* Update docs/how-to/using-rocdecode.rst
Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com >
* Update using-rocDecode-ffmpeg.rst
* key frame -> keyframe
* `api` -> ``api``
* must -> need to
* added a sample walkthrough; removed the bitstream reader info; streamlined info
* Update docs/how-to/using-rocDecode-videodecode-sample.rst
Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com >
* Update docs/how-to/using-rocDecode-videodecode-sample.rst
Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com >
* Update docs/how-to/using-rocdecode.rst
Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com >
* Update rocDecode-samples.rst
* Update docs/how-to/using-rocdecode.rst
Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com >
* updated tables and other minor things
* updated with Leo's suggestion
* Update using-rocDecode-ffmpeg.rst
* added detail to information about the frame buffers
* small changes based on feedback
* updated
---------
Co-authored-by: Leo Paoletti <164940351+lpaoletti@users.noreply.github.com >
Co-authored-by: Lakshmi Kumar <lakshmi.kumar@amd.com >
[ROCm/rocdecode commit: dcddb9d5ea ]
2025-03-11 11:16:45 -04:00
jeffqjiangNew
23309b2e4c
Added syntax error handling in VPS parsing. ( #526 )
...
* * rocDecode/HEVC: Added error handling in VPS parsing.
* * rocDecode/HEVC: Updated change log.
* * rocDecode/Error resilience: Improved syntax error check logging: add the parameter name.
[ROCm/rocdecode commit: 263b57fde9 ]
2025-03-10 09:15:12 -04:00