Граф коммитов

806 Коммитов

Автор SHA1 Сообщение Дата
Giovanni LB d5e968989c SWDEV-409155: Adding ATT plugin tests
Change-Id: I684affa4a63ed1c6fd7d8a4bb18f83697c3181a3
2023-12-07 13:01:43 -03:00
Youssef Aly 9f30432dd7 SWDEV-411647: enabling kernel trace flag with sys-trace option
To allow results_<XXXXX>.csv to be regenerated as it contains extra information not present in hcc_ops_trace, hip_api_trace, hsa_api_trace CSV files. The extra information is Dispatch_ID,GPU_ID,Queue_ID,PID,TID,Grid_Size,Workgroup_Size,LDS_Per_Workgroup,Scratch_Per_Workitem,Arch_VGPR,Accum_VGPR,SGPR,Wave_Size.

Change-Id: Ief371b41aa41d77397c00e6b4281568e494b26dc
2023-12-06 12:29:57 -05:00
Youssef Aly bfd4730cb0 Disabling Tracer Gtest: Async_mem_copy
Test fails with a generic HsA_STATUS_ERROR

Change-Id: Icf076124304797169f848cdc524f3d52f161f54e
2023-12-06 00:30:35 +00:00
Giovanni LB f13f221780 Att param as unsigned integer
Change-Id: I4cd611c5e60e7c22d17c657a8ea5663dfb57e781
2023-12-04 15:23:48 -05:00
Giovanni LB ce9a578350 Adding file mode availability check
Change-Id: I586556a998996c0117d35d966dadf5490831bffb
2023-12-04 13:08:37 -03:00
Jatin Chaudhary 729d7415ae SWDEV-412457 - include missing assert header
Change-Id: If36574df6326b2e634fe3799372eda698b8a30a8
2023-11-15 23:35:02 +00:00
Benjamin Welton 7d39ba7510 Remove flaky ROCP_OPT_MODE test
This test fails occasionally on weekly builds of rocm. It looks like
the flag isn't even used outside of this test case (not even in docs).
Lets remove the test for this flag. Leaving the underlying code in place
in case we need to revive.

Change-Id: I4e0a36ad8a3e286f8ff64780583462711c73c1ba
2023-11-15 21:44:04 +00:00
Giovanni LB 526646211a SWDEV-431438: Disabling counter check for Navi3x on unittests
Change-Id: I3b716d1862b979c3ea5884170060a6e445cf35e5
2023-11-15 07:51:05 -05:00
Giovanni LB 4c94003018 SWDEV-283962: (Workaround) preventing v1 from failing on application replay.
Change-Id: I11eacd61b51134a32e245ea2529b6e30615f6670
2023-11-15 07:50:41 -05:00
Giovanni LB 0648bcdc4b SWDEV-414768: Fixes for perfetto kernel-trace
Change-Id: Icd2eab4a46c5f51c73ff9a37df490c20ef22ee93
2023-11-10 09:21:54 -03:00
Giovanni LB 9e625eb58a SWDEV-430460: Updated readme and fixed att.csv being generated only on current dir.
Change-Id: I81522a79e61ff0f35f74035b48ff594d7a05a424
2023-11-10 06:07:48 -03:00
Giovanni LB b1b55a0370 SWDEV-431750: Fixing ATT parsing of s_swappc and s_setpc
Change-Id: I1bc649f0a8c5b9c2f4991cf7b82890dca681a5c7
2023-11-10 04:34:05 -03:00
gobhardw f513e30b9f SWDEV-431667: Fixing counter listing
Change-Id: Ibcb80edcdc4e61f3d57911598ee7950f09b2e85e
2023-11-09 15:49:20 +00:00
Youssef Aly 369f9e5063 SWDEV-430410 Fixed hang with --basenames argument
rocprofv2 script: missing shift for --basenames argument

Change-Id: Ibb4b56bb4e5ca4a8dae473de3932d559d58f7ce1
2023-11-08 19:59:20 -05:00
Giovanni LB 99b14fc9f8 Added option to control how codeobj is dumped from ATT
Change-Id: Ie76aeea1193c7ba8fe7f51be159516f8a9eab55f
2023-11-08 17:48:28 -03:00
Ammar ELWazir 1c0149c21f Tool Version fix
Change-Id: Ieeff7263bfe697010383c28104fb9c127ec5badb
2023-11-08 16:53:48 +00:00
Giovanni LB 698522e901 SWDEV-431506: Fix for ATT network mode
A bug was introduced where network mode would only work when running file mode first

Change-Id: I32d0cf8f8a5584781d54fec130ec3d276ab52d1b
2023-11-08 08:37:26 -03:00
Ammar ELWazir e9d155c6a3 SWDEV-430422: Fixing the Hardware check to happen in the run function
Change-Id: I3a9112ea1707bb1a3df2e18cd9cd23f1609a3e01
2023-11-07 14:13:29 -05:00
Ammar ELWazir 216cb4edcf Fixing ROCProfv2 Kernel tracing in sys-trace mode
Change-Id: Ic4299beb88f53fed678bb98feeb0c78a7f252879
2023-11-07 15:17:45 +00:00
gobhardw 9954f937d0 Fixing build for opensuse
Change-Id: I7b68382224221e899f64c06cec67b969a212f21a
2023-11-03 17:04:08 +00:00
gobhardw 6ee20035dd rocporf binary update
Change-Id: I2ba07a213acc7db403b804d8136edce28df9dd14
2023-11-02 07:14:59 -04:00
Ammar ELWazir ae3c278d7a SWDEV-366827 - Fixing Issues with ASAN builds due to merging
Change-Id: I2da6607872b10e6a0211e08604254d4425fadb77
2023-10-31 14:47:49 -04:00
gobhardw 9cc2d896ac SWDEV-416735 Adding --merge-traces option to rocprof script
Change-Id: Ia6bc11c6265913d20ead85c50981893d147ff5eb
2023-10-31 14:30:36 -04:00
gobhardw ff9dc8cea0 SWDEV-426220 Removing dummy kernel from test app
Change-Id: I1576732399fcff924a88cd442f0dac0121bd5e12
2023-10-31 13:29:54 -04:00
Ammar ELWazir 56d060a4a9 Removing .github from the main repository
Change-Id: Ia91cbd4c5145a06d4867eb4649c81ba3b95c6d6b
2023-10-31 13:05:45 -04:00
Ammar ELWazir d033cf3ab7 SWDEV-428381: Moving rocminfo to use the one available in the path
Change-Id: I736cc2ca9ddabf35cbb24d3fba553e2cbec5e396
2023-10-31 10:08:28 -04:00
Mythreya 46e02a9866 Add MI200/MI300 counters
Revision - Addition [Impact SoC: MI200, MI300]
    Note: this set of counters are important help understand the
          bottleneck.
    1.	TCC_TAG_STALL
        a.	Metric:  TCC_TAG_STALL/TCC_CYCLE: percentage of time TCC
            tag lookup pipeline is stalled
    2.	TCP_TCR_TCP_STALL_CYCLES
        a.	Metric: TCP_TCR_TCP_STALL_CYCLES/TCP_GATE_EN1: percentage
            of time TCP is stalled by TCR

Revision - Addition [Impact SoC: MI300]
    3.	TCC_BUBBLE:
        a.	Definition: Number of 128-byte read requests sent to EA
        b.	Revised Metric #1, TCC-EA Read BW:
        ReadBW =   128 * TCC_BUBBLE
                + 64 * (TCC_EA0_RDREQ - TCC_BUBBLE - TCC_EA0_RDREQ_32B)
                + 32 * TCC_EA0_RDREQ_32B
        c.	Revised Metric #2: TCC_EA Read Latency
        ReadLatency = TCC_EA0_RDREQ_LEVEL / (TCC_BUBBLE + TCC_EA0_RDREQ)

    /* [Fineprint] More detailed arithmetic:
    * ReadLatency = TCC_EA0_RDREQ_LEVEL / (#32B_req + #64B_req + #128B_req * 2)
    */

Change-Id: I0a2dfc1b64ca97023b1e8ba0f9830330b3034946
2023-10-30 15:38:46 -04:00
gobhardw 49bd09b46c SWDEV-429377 : Fixing kernel name truncation for plugins
Change-Id: I5875048d1773959fdd73cbff5498854e61b92af8
2023-10-30 10:52:31 -04:00
Ammar ELWazir 32907ff14c Fixing Tool/Plugin Versioning and adding --version and adding proper documentation for those features
Change-Id: Icdb0d64e02943e638f183ab31759a37736d2dd61
2023-10-27 14:52:13 +00:00
Lancelot Six 372fc3910b src/core/isa_capture/code_object_track.cpp: remove unused dbgapi import
The src/core/isa_capture/code_object_track.cpp file includes the
amd-dbgapi header but does not use the library (and is not configured to
use the library).

Remove the unused import.

Change-Id: Icc6c46a1f52355e9e5631395dfad1b44365bdca4
2023-10-27 00:09:21 -04:00
Ammar ELWazir cca295d951 Fixing V2 tests to accept HIP function versioning
Change-Id: Ic68116feb51b396b27e858dcaf8b389d4d11a49b
2023-10-26 22:04:53 +00:00
Mythreya 1fae494b12 Remove non-functional counters for MI200 and MI300
Counters removed for MI300 (gfx940)
    TCP_TCC_WRITE_REQ_HOLE_LATENCY
    TCP_TCC_WRITE_REQ_LATENCY
    TCP_TCC_READ_REQ_LATENCY
    TCP_TCP_LATENCY

Counters removed for MI200 and MI300 (gfx90a and gfx940 respectively)
    TA_BUFFER_COALESCABLE_WAVEFRONT
    TA_FLAT_COALESCABLE_WAVEFRONT
    TCC_EA0_WRREQ_IO_CREDIT_STALL
    TCC_EA0_WRREQ_GMI_CREDIT_STALL
    TCC_EA0_WRREQ_DRAM_CREDIT_STALL
    TCC_EA0_RDREQ_IO_CREDIT_STALL
    TCC_EA0_RDREQ_GMI_CREDIT_STALL
    TCC_EA0_RDREQ_DRAM_CREDIT_STALL

Change-Id: Ic3d1e7bf35495f35b1239f03ca6420e949421386
2023-10-26 12:50:57 -04:00
gobhardw 1bc98d806d updating rocprof script for supported hw check
Change-Id: I41a8571682fd4c9ab227cc7d964f86d027d5c964
2023-10-26 12:48:47 -04:00
Parag Bhandari 8b9d8b966d Add gfx1031 support for building
Change-Id: Ie88d76404a09de07d66a84083a7a8549bff3d050
2023-10-26 11:33:02 -04:00
Ammar ELWazir b5fd31fb9b Fixing Versioned HIP Call
Change-Id: Ib768f8a53ffc6cc3bb89e6c867918b6440ce1cab
2023-10-26 14:50:16 +00:00
Ranjith Ramakrishnan 8babd28a50 SWDEV-427554 - Temporarily disable building of unittest in ASAN builds
Unittest is failing in ASAN builds. To unblock ASAN builds, disabling the same as a workaround
The test will run in non-asan builds

Change-Id: Ib3c8d7a2c77aa83e9c6260e9b47ccb0564f789e8
2023-10-25 17:45:54 -07:00
gobhardw 623d614d77 SWDEV-421283 : Fixing README for ATT
Change-Id: I4a85987b036dd27e344d0d2049ca8d22bf846dc2

Removed mention of deprecated SIMD_MASK
Removed duplicated ATT section

Change-Id: I4a85987b036dd27e344d0d2049ca8d22bf846dc2
2023-10-25 06:42:37 -04:00
gobhardw 296c935874 SWDEV-427842: Fixing ATT csv mode
Change-Id: I7b8f37867d7aaf6da1301d91028990c343e555f1

- Updated README for kernel name truncation.
- Updated CHANGELOG.
- By default enabled truncation for ATT because csv file names should be smaller

Change-Id: I7b8f37867d7aaf6da1301d91028990c343e555f1
2023-10-25 00:06:13 -04:00
Giovanni LB 3f5ddfa0ab Initial commit for counter correctness tests.
Change-Id: I74caa4ab89bd765e59686cfbaaf1ce44ab10fe19

- adds counter correctness tests for GRBM, SQWAVES and SQ INSTRUCTIONs
- pandas dependency
- made it compatible with test infra.

Change-Id: I74caa4ab89bd765e59686cfbaaf1ce44ab10fe19
2023-10-23 03:51:42 -04:00
Sriraksha Nagaraj c1884d70fc SWDEV-428099: Fixing hang with basenames option
Change-Id: I61c9ac03394bfde84c91d922e073690ef8655337
2023-10-23 00:38:16 -04:00
Ammar ELWazir c9b5d73ca8 Fixing Usage of session after free
If hsa_shut_down() is not called from the application then we may still have async calls back
to the rocprofiler to use session parameters, thats why we need to leak the session up till
this is fixed in the ROCR-Runtime

Change-Id: Ia8fcdaa859815d88a272296770d702968132e3e6
2023-10-19 23:29:39 -04:00
Benjamin Welton cb190b72f1 Migrate tracer performance fixes from roctracer
Change-Id: If9e1349537cce23b7be1d8530d795744a8cd07b1
2023-10-19 20:34:12 +00:00
Saurabh Verma 1e1692e6c0 SWDEV-427921: Fixing rocprof v1 counter collection for PAPI on MI300
Change-Id: I8589fe78fca481ed326e584ea1d01c0f90de655e
2023-10-19 13:40:32 -04:00
gobhardw ab066543b1 SWDEV-427969: Fixing kernel trace
Change-Id: I050120ba0dd0df84a46f022c0f9b8117057202b1

When we did file plugin changes for omniperf in v2, we removed 2 fields from header:
SIG and OBJ. However from the values we missed removing OBJ. Fix is to remove the OBJ from values.

Change-Id: I050120ba0dd0df84a46f022c0f9b8117057202b1
2023-10-19 05:56:55 -04:00
gobhardw 5d390717b5 SWDEV-427554 Fixing mainline ASAN build
Change-Id: I63cd047ceb75dea5f8ed6f84946e1ec209c7d812
2023-10-18 21:42:47 +05:30
Sriraksha Nagaraj ab288c8de8 SWDEV-399631 : Fixing the regression issue
Change-Id: I9b2866e69ca2969405d06ac267eb17461b643eec
2023-10-16 15:27:07 -04:00
Ammar ELWazir 4f40fb8a40 SWDEV-391589: Addressing changes requested by Omniperf:
Adding Versioning to rocprof main script
Adding Versioning to file plugins to support legacy v1 output and new v2 output
Fixing headers for v2 output

Change-Id: I352e8c8ed03871466269a792d1bfa572da58bd8a
2023-10-16 15:19:20 -04:00
gobhardw def7fa710a Solving timestamps and serialization merge
Change-Id: Icd14e49c06b19e4334adbdb98efed54af029b95b
2023-10-16 14:54:50 -04:00
Ammar ELWazir d816f133d1 SWDEV-302415: Fixing Kernel Dispatchs with trace-start off option
Change-Id: I225b88cb769d994f1007e7bc66f176e7fa40db05
2023-10-16 09:39:42 -04:00
Giovanni LB 60197d0f20 SWDEV-427013: Fixing ATT parser for tensile kernels and network mode
Change-Id: I07cd34f5606c0aaf718d9e3ffabd5a407523a943
2023-10-13 20:41:46 -04:00