Commit Graph

1025 Commits

Author SHA1 Message Date
Cole Ramos c9b6cb8f40 Throw error when we cannot read gfx942 details (#310)
* Throw error when we cannot read gfx942 details

Signed-off-by: colramos-amd <colramos@amd.com>

* Fixing my stupid typo

Signed-off-by: colramos-amd <colramos@amd.com>

---------

Signed-off-by: colramos-amd <colramos@amd.com>

[ROCm/rocprofiler-compute commit: 267f0842ec]
2024-03-11 15:26:26 -05:00
Karl W Schulz 9fb39d6bc5 add concurrency setting
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 748904df20]
2024-03-11 15:17:09 -05:00
Karl W Schulz b18b96593f update CI testing to include mi200
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: b8ec84061e]
2024-03-11 15:17:09 -05:00
Karl W Schulz 28f027c7bf move set_locale_encoding() to occur after logging is setup - allows
function to use console_error() directly (https://github.com/AMDResearch/omniperf/pull/308#discussion_r1519914083)

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: e85037fdfb]
2024-03-11 14:19:01 -05:00
Karl W. Schulz 6b0a36cb27 Update src/utils/utils.py
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: 5e21dc35fd]
2024-03-11 14:19:01 -05:00
Karl W. Schulz d4015bd76b Update src/utils/db_connector.py
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: ebc9108da0]
2024-03-11 14:19:01 -05:00
Karl W. Schulz f7fa0b6038 Update src/omniperf_profile/profiler_rocscope.py
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: e8ca48dc83]
2024-03-11 14:19:01 -05:00
Karl W. Schulz 65c1e2cb9c Update src/omniperf_profile/profiler_base.py
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: 8856480808]
2024-03-11 14:19:01 -05:00
Karl W. Schulz ed8d923155 Update src/utils/db_connector.py
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: 523639a7fd]
2024-03-11 14:19:01 -05:00
Karl W. Schulz eade3386b1 Update src/omniperf_profile/profiler_rocscope.py
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: af3f006a7e]
2024-03-11 14:19:01 -05:00
Karl W. Schulz f287aa0fc8 Update src/utils/utils.py
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: 8e45cc897f]
2024-03-11 14:19:01 -05:00
Karl W. Schulz 17565f7752 Update src/omniperf_profile/profiler_base.py
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: f6d996b085]
2024-03-11 14:19:01 -05:00
Karl W. Schulz c822d910be Update src/omniperf_base.py
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: a3b68c7042]
2024-03-11 14:19:01 -05:00
Karl W Schulz 35a983b85a allow color formatter via env variable OMNIPERF_COLOR=1
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 34070394eb]
2024-03-11 14:19:01 -05:00
Karl W Schulz fbf3711eb2 apply formatting
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: b27a2b2c10]
2024-03-11 14:19:01 -05:00
Karl W Schulz 9d7dde19b0 refactor setting of local encoding; remove from top-level omniperf
wrapper and push into base class via a companion utility function

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 27a57bdafb]
2024-03-11 14:19:01 -05:00
Karl W Schulz aada8d8e92 remove duplicate line after conflict cleanup due to rebase
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: dbba0d418a]
2024-03-11 14:19:01 -05:00
Karl W Schulz 4aa463a4e6 update log summary at begin of profiling mode
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 594875a974]
2024-03-11 14:19:01 -05:00
Karl W Schulz 1c3eec3f91 enable file-logger in profiling workflow; turn some info messages into debug
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: f4483e3c4e]
2024-03-11 14:19:01 -05:00
Karl W Schulz 2d84322ea1 update print_status() to use console logger; convert some info logs to debug logs
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 15c86ba424]
2024-03-11 14:19:01 -05:00
Karl W Schulz fdbc5565f3 rework of logger.py setup to introduce another setup_file_handler() -
this function enables file-based logger output for use with profile
mode

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 505e263279]
2024-03-11 14:19:01 -05:00
Karl W Schulz 4969416e5f use cached loglevel var in arguments to decide on status bar presence
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: a3a0eac80a]
2024-03-11 14:19:01 -05:00
Karl W Schulz 917b784ead refactor logging initialization into two steps:
(1) setup_logging_handler -> called prior to arg parsing
(2) setup_logging_priority -> called after arg parsing

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: e24e6c35a5]
2024-03-11 14:19:01 -05:00
Karl W Schulz 2381bba1cf apply formatter
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: df4f881ed3]
2024-03-11 14:19:01 -05:00
Karl W Schulz 9e06bcb624 adding --quiet and --verbose options to top-level help info; pass
quiet arg to setup_logging function

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 2dd72f7366]
2024-03-11 14:19:01 -05:00
Karl W Schulz 975c2dad8b add quietmode option to setup_logging function
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: abd3d20cb2]
2024-03-11 14:19:01 -05:00
Karl W Schulz a9cda2ad33 add a exit keyword to console_error function; allows multiple error
lines prior to code exit

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 2b24375e8d]
2024-03-11 14:19:01 -05:00
Karl W Schulz 7756a5b00b updates for run_prof() routine:
* add a profileMode keyword option, used to indent profiling output

* update logic if forked process is not successful, output is
  displayed directly with INFO logging or lower; also dispaly output
  in ERROR mode if the process fails

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 377c642ac2]
2024-03-11 14:19:01 -05:00
Karl W Schulz ab3ce5ecb8 remove duplicate process output within run_prof()
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: dcdef37c34]
2024-03-11 14:19:01 -05:00
Karl W Schulz 89bc098c59 include ERROR delimiter directly for console_error() messsages
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 61267ee262]
2024-03-11 14:19:01 -05:00
Karl W Schulz a5e23e17fe add a profileMode option to capture_subprocess_output() - includes
indented output with profiler selection when enabled

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: cc7a725ae8]
2024-03-11 14:19:01 -05:00
Karl W Schulz 587d55cd9d minor refactor of print_status()
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 6bb4210d94]
2024-03-11 14:19:01 -05:00
Karl W Schulz b948aa6ebf add indent support to console_log()
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 63129e4247]
2024-03-11 14:19:01 -05:00
Karl W Schulz 890154db8e include loglevel function argument to "run_prof" routine
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 34694f86c2]
2024-03-11 14:19:01 -05:00
Karl W Schulz efc9f72f7a assign loglevel attribute in omniperf base class
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 48de8ae490]
2024-03-11 14:19:01 -05:00
Karl W Schulz 16f580b992 update setup_logging function to return loglevel; disable inclusion of
loglevel delimiter in output

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: bdfc536ade]
2024-03-11 14:19:01 -05:00
Karl W Schulz a5c9180383 enable a progress bar for running in profile mode - only enabled when
loglevel is set to ERROR

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 47b32cb4b1]
2024-03-11 14:19:01 -05:00
Karl W Schulz 82bb59ce76 tighten-up profile usage examples
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>


[ROCm/rocprofiler-compute commit: 3e88132d73]
2024-03-11 14:19:01 -05:00
colramos-amd 91434bcebf Fix dangling merge conflict
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 6c5a3623b6]
2024-03-11 14:19:01 -05:00
colramos-amd 98e5e16d0e Fix python formatting
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: f2aac37178]
2024-03-11 14:19:01 -05:00
colramos-amd 6ee27efd16 Resolve merge conflict I missed in prev rebase
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 99bf4fae09]
2024-03-11 14:19:01 -05:00
colramos-amd 00c17f423c Replaced some straggling print statements with log functions
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 771644f5f7]
2024-03-11 14:19:01 -05:00
colramos-amd 569dff3627 Connect verbosity flag to loglevel
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 5ed9a5c902]
2024-03-11 14:19:01 -05:00
colramos-amd a1371462ba All logging should use call new functions
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 5bf38a4fed]
2024-03-11 14:19:01 -05:00
colramos-amd cfdf288cba Dedicated logging function for each log level
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 233905071c]
2024-03-11 14:19:01 -05:00
colramos-amd 39a9961060 Remove outdated remove_workload.py module
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 0611ce4582]
2024-03-11 14:19:01 -05:00
colramos-amd 15aac4690c Standalone logging module for cleaner omniperf_base.py
Signed-off-by: colramos-amd <colramos@amd.com>


[ROCm/rocprofiler-compute commit: 2e09f0be7e]
2024-03-11 14:19:01 -05:00
Jose Santos ebaf60bcc9 ipblocks to blocks in ctest
Signed-off-by: Jose Santos <josantos@amd.com>


[ROCm/rocprofiler-compute commit: ef6152dfa0]
2024-03-11 10:04:54 -05:00
Karl W. Schulz b8a9a8290d record return status from hipDeviceSynchronize() to avoid compilation warnings (#305)
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>

[ROCm/rocprofiler-compute commit: a0f5d25f74]
2024-03-11 09:30:40 -05:00
Jose Santos b1f08cc9d8 blocks -> block
Signed-off-by: Jose Santos <josantos@amd.com>


[ROCm/rocprofiler-compute commit: f9e806833b]
2024-03-08 16:27:19 -06:00