Commit Graph

64643 Commits

Author SHA1 Message Date
Luca Bruni 8ae6651357 Appropriately filter data based on -D and -H options (#163)
- Addresses concern that device metric tracks are still shown in Perfetto trace file even when only -H is specified to rocprof-sys-sample (and vice versa).
- Update sampling call-stack docs.
2025-04-30 09:50:51 -04:00
Assiouras, Ioannis 4efd624960 SWDEV-525593, SWDEV-527293 - Acquire active queue after xferQueue is created (#165)
For xferQueue VirtualGPU::create is called after ProfilingBegin
so the active queue needs to be acquired.

[ROCm/clr commit: d3fb8eda8b]
2025-04-30 09:21:11 +01:00
Assiouras, Ioannis d3fb8eda8b SWDEV-525593, SWDEV-527293 - Acquire active queue after xferQueue is created (#165)
For xferQueue VirtualGPU::create is called after ProfilingBegin
so the active queue needs to be acquired.
2025-04-30 09:21:11 +01:00
Swargam, Rambabu 7e8e711087 SWDEV-515926 - [catch2][dtest] Tests for Memory Manager for memory pool performance (#155)
[ROCm/hip-tests commit: 1b60d60f5a]
2025-04-30 10:11:33 +05:30
Swargam, Rambabu 1b60d60f5a SWDEV-515926 - [catch2][dtest] Tests for Memory Manager for memory pool performance (#155) 2025-04-30 10:11:33 +05:30
Bhardwaj, Gopesh 5dcb2cbdd7 updating fmt submodule to latest release tag (#13)
* updating fmt submodule to latest release tag

* fix configuration error

[ROCm/rocprofiler-register commit: 4427f2bd6d]
2025-04-30 09:57:37 +05:30
Bhardwaj, Gopesh 4427f2bd6d updating fmt submodule to latest release tag (#13)
* updating fmt submodule to latest release tag

* fix configuration error
2025-04-30 09:57:37 +05:30
David Yat Sin 4ed5950beb rocr: Fix logic for scratch reclaim
Fix logic error that can cause scratch memory to be reclaimed while a
dispatch is still using it.
2025-04-29 17:23:45 -04:00
David Yat Sin b48b401a09 rocr: Fix logic for scratch reclaim
Fix logic error that can cause scratch memory to be reclaimed while a
dispatch is still using it.


[ROCm/ROCR-Runtime commit: 4ed5950beb]
2025-04-29 17:23:45 -04:00
Cheruvally, Aravindan 9d3c82bc22 Update Pre/Post File Permissions to 0755 (#12)
[ROCm/rocm-core commit: 0578cf70ef]
2025-04-29 15:49:53 -04:00
Cheruvally, Aravindan 0578cf70ef Update Pre/Post File Permissions to 0755 (#12) 2025-04-29 15:49:53 -04:00
Godavarthy Surya, Anusha e4a499f22e SWDEV-522841 - Graph nodes must be created/launched on device where they are captured/created (#108)
[ROCm/clr commit: 2538d7f02b]
2025-04-29 22:20:39 +05:30
Godavarthy Surya, Anusha 2538d7f02b SWDEV-522841 - Graph nodes must be created/launched on device where they are captured/created (#108) 2025-04-29 22:20:39 +05:30
GunaShekar, Ajay d14f5ed76f SWDEV-524925 - hip-tests build with custom hip (#65)
[ROCm/hip-tests commit: 52e72e9e00]
2025-04-29 08:51:04 -07:00
GunaShekar, Ajay 52e72e9e00 SWDEV-524925 - hip-tests build with custom hip (#65) 2025-04-29 08:51:04 -07:00
Jiang, Julia 6ab34e0924 SWDEV-522634 - Fix device properties in hipInfo (#203)
[ROCm/clr commit: eb62fe9f62]
2025-04-29 11:29:47 -04:00
Jiang, Julia eb62fe9f62 SWDEV-522634 - Fix device properties in hipInfo (#203) 2025-04-29 11:29:47 -04:00
Guan, Zichuan bcdc86805c Fix CMakeLists.txt for square sample (#61)
Co-authored-by: Matthias Knorr <MKKnorr@web.de>

[ROCm/hip-tests commit: 184142b4b6]
2025-04-29 09:59:53 -04:00
Guan, Zichuan 184142b4b6 Fix CMakeLists.txt for square sample (#61)
Co-authored-by: Matthias Knorr <MKKnorr@web.de>
2025-04-29 09:59:53 -04:00
Sang, Tao 68deb3d10a SWDEV-520352 - Remove HostThread and legacy monitor (#230)
* SWDEV-520352 - Remove HostThread and legacy monitor

Remove HostThread, semaphore and  legacy monitor.
Make original logics of thread and command queue stricker.
Add more comments to make logics clearer.
Some other minor improvement.

Also part of SWDEV-458943.

[ROCm/clr commit: 96cadbc9e9]
2025-04-29 09:55:24 -04:00
Sang, Tao 96cadbc9e9 SWDEV-520352 - Remove HostThread and legacy monitor (#230)
* SWDEV-520352 - Remove HostThread and legacy monitor

Remove HostThread, semaphore and  legacy monitor.
Make original logics of thread and command queue stricker.
Add more comments to make logics clearer.
Some other minor improvement.

Also part of SWDEV-458943.
2025-04-29 09:55:24 -04:00
GunaShekar, Ajay c4567a9188 SWDEV-523028 - print PAL failure return values in logs (#81)
* print PAL failure return values in logs
* dump kernel info incase of PAL failure

[ROCm/clr commit: 99ef573399]
2025-04-29 11:23:43 +05:30
GunaShekar, Ajay 99ef573399 SWDEV-523028 - print PAL failure return values in logs (#81)
* print PAL failure return values in logs
* dump kernel info incase of PAL failure
2025-04-29 11:23:43 +05:30
Jayaprakash, Karthik 0071d33754 SWDEV-522707 - Set phys_mem_handle type to sizeof(size_t) to avoid blocking address range. (#105)
[ROCm/clr commit: 6811fd90b8]
2025-04-29 11:19:16 +05:30
Jayaprakash, Karthik 6811fd90b8 SWDEV-522707 - Set phys_mem_handle type to sizeof(size_t) to avoid blocking address range. (#105) 2025-04-29 11:19:16 +05:30
Jayaprakash, Karthik 49a527c826 SWDEV-506467 - Skip Abort in case of crash from the device. (#60)
Change-Id: I964b2f2647d068202e9c38fcddb1337da754df8d

[ROCm/clr commit: b2388dfb88]
2025-04-29 11:19:02 +05:30
Jayaprakash, Karthik b2388dfb88 SWDEV-506467 - Skip Abort in case of crash from the device. (#60)
Change-Id: I964b2f2647d068202e9c38fcddb1337da754df8d
2025-04-29 11:19:02 +05:30
Betigeri, Sourabh ae0640131e SWDEV-528351 - Removes unused code and asserts to improve coverage (#219)
[ROCm/clr commit: 9cf3f1e461]
2025-04-28 14:40:35 -07:00
Betigeri, Sourabh 9cf3f1e461 SWDEV-528351 - Removes unused code and asserts to improve coverage (#219) 2025-04-28 14:40:35 -07:00
cfallows-amd c8d67fc97e Enable roofline for MI350 series (#677)
Rework of roofline binaries generated from rocm-amdgpu-bench
- removed arch identifier in bin name
- removed rocm5 bins altogether

Updated required distros for roofline
- updated distro checks and bin naming
- moved up ubuntu20.04->22.04 and sles15.3->15.6 per rocm support

Enabled ctests for mi350 for test_roof_*
- removed mi350 series check to skip these specific tests

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: 41e73650d5]
2025-04-28 16:08:23 -04:00
cfallows-amd 41e73650d5 Enable roofline for MI350 series (#677)
Rework of roofline binaries generated from rocm-amdgpu-bench
- removed arch identifier in bin name
- removed rocm5 bins altogether

Updated required distros for roofline
- updated distro checks and bin naming
- moved up ubuntu20.04->22.04 and sles15.3->15.6 per rocm support

Enabled ctests for mi350 for test_roof_*
- removed mi350 series check to skip these specific tests

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-04-28 16:08:23 -04:00
cfallows-amd 668402042c Update CODEOWNERS (#680)
Add rp-compute technical writer directly for any documentation review.
Remove existing packaging review requests for single user; every repo owner should be notified.

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: ad17c4d587]
2025-04-28 16:05:51 -04:00
cfallows-amd ad17c4d587 Update CODEOWNERS (#680)
Add rp-compute technical writer directly for any documentation review.
Remove existing packaging review requests for single user; every repo owner should be notified.

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-04-28 16:05:51 -04:00
Daniel Su 935e2b53b8 Set rocprofV3 agent-index to absolute (#675)
Signed-off-by: Daniel Su <danielsu@amd.com>

[ROCm/rocprofiler-compute commit: b77fcf575e]
2025-04-28 15:38:07 -04:00
Daniel Su b77fcf575e Set rocprofV3 agent-index to absolute (#675)
Signed-off-by: Daniel Su <danielsu@amd.com>
2025-04-28 15:38:07 -04:00
Pryor, Adam 2db6ddea69 [SWDEV-523349/SWDEV-527257] Fix Rdci Config (#161)
Change-Id: Iae21ea8061205f186086a3ed59c6259ddeb1dbe7

Signed-off-by: adapryor <Adam.pryor@amd.com>
2025-04-28 11:57:51 -05:00
Pryor, Adam 2cb7903b06 [SWDEV-523349/SWDEV-527257] Fix Rdci Config (#161)
Change-Id: Iae21ea8061205f186086a3ed59c6259ddeb1dbe7

Signed-off-by: adapryor <Adam.pryor@amd.com>

[ROCm/rdc commit: 2db6ddea69]
2025-04-28 11:57:51 -05:00
xuchen-amd af114a1539 Add test for gfx942 number of xcds. (#674)
* Add test for 9fx942 number of xcds.

* Improve the structure of mi gpu specs, add num_xcds_spec_class test.

* Add to ctest.

---------

Signed-off-by: xuchen-amd <xuchen@amd.com>

[ROCm/rocprofiler-compute commit: 85bfa73e2c]
2025-04-28 11:29:14 -04:00
xuchen-amd 85bfa73e2c Add test for gfx942 number of xcds. (#674)
* Add test for 9fx942 number of xcds.

* Improve the structure of mi gpu specs, add num_xcds_spec_class test.

* Add to ctest.

---------

Signed-off-by: xuchen-amd <xuchen@amd.com>
2025-04-28 11:29:14 -04:00
Madsen, Jonathan 49486fee5e [CI] Fix code coverage and thread sanitizer workflows (#378)
* Fix code coverage workflow

* Relocate rocprofv3 conversion test script + rename tests

- these are rocprofv3 tests and were not properly located and not properly named

* Fix thread sanitizer

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: 4f03ebc360]
2025-04-28 10:19:04 -05:00
Madsen, Jonathan 4f03ebc360 [CI] Fix code coverage and thread sanitizer workflows (#378)
* Fix code coverage workflow

* Relocate rocprofv3 conversion test script + rename tests

- these are rocprofv3 tests and were not properly located and not properly named

* Fix thread sanitizer

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-04-28 10:19:04 -05:00
Critchley, Paul 4d3978e094 SWDEV-523611 - [Tools][OCL] OpenCL fails to capture with PalTrace (#198)
Finalize DevDriver initialization after device creation

[ROCm/clr commit: 7e9d5eab7c]
2025-04-28 08:02:34 -07:00
Critchley, Paul 7e9d5eab7c SWDEV-523611 - [Tools][OCL] OpenCL fails to capture with PalTrace (#198)
Finalize DevDriver initialization after device creation
2025-04-28 08:02:34 -07:00
anujshuk-amd 35b8748c20 Fix ROCPROFSYS_AMD_SMI_METRICS parsing (#178)
Fixes a bug where all the `ROCPROFSYSE_AMD_SMI_METRICS` values were being recorded by default.
Fixes bug with the 'all' and 'none' values giving an exception when specified for `ROCPROFSYSE_AMD_SMI_METRICS`.

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-systems commit: 8d48048bd3]
2025-04-28 09:22:20 -04:00
anujshuk-amd 8d48048bd3 Fix ROCPROFSYS_AMD_SMI_METRICS parsing (#178)
Fixes a bug where all the `ROCPROFSYSE_AMD_SMI_METRICS` values were being recorded by default.
Fixes bug with the 'all' and 'none' values giving an exception when specified for `ROCPROFSYSE_AMD_SMI_METRICS`.

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-04-28 09:22:20 -04:00
Godavarthy Surya, Anusha ff69bcc903 SWDEV-469422 - Avoid using of hipStream_t in internal methods (#69)
Change-Id: Ifd5362f371c846a88241927383cb95cf046548ef

[ROCm/clr commit: fb92683d86]
2025-04-28 15:09:11 +05:30
Godavarthy Surya, Anusha fb92683d86 SWDEV-469422 - Avoid using of hipStream_t in internal methods (#69)
Change-Id: Ifd5362f371c846a88241927383cb95cf046548ef
2025-04-28 15:09:11 +05:30
Godavarthy Surya, Anusha 0eb2e5e8f2 SWDEV-469422 - hipGraphNodeDOTAttribute change std::string members to const char* (#70)
Compiler creates global variables for every unique string

Change-Id: I4cf8dd3e763d16740096e345da67a7ef72f61515

[ROCm/clr commit: bbcb1f9c70]
2025-04-28 14:57:36 +05:30
Godavarthy Surya, Anusha bbcb1f9c70 SWDEV-469422 - hipGraphNodeDOTAttribute change std::string members to const char* (#70)
Compiler creates global variables for every unique string

Change-Id: I4cf8dd3e763d16740096e345da67a7ef72f61515
2025-04-28 14:57:36 +05:30
Madsen, Jonathan 394d3dcf45 Fix evaulate_ast.evaulate_hybrid_counters test (#377)
- broken by #348

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: 032c06db9a]
2025-04-27 22:42:10 -05:00