Commit Graph

5286 Commits

Author SHA1 Message Date
Jatin Chaudhary e01445a69d SWDEV-277697 - Make sure hipcc can handle standard CXX options when being used with nvcc
Change-Id: I76b1f2943a660eefda858397218a775083b99228


[ROCm/hip commit: a4c9db8e17]
2021-05-25 07:35:02 -04:00
Jatin Chaudhary 62548cce56 SWDEV-277697 - [CatchTest] Fix Documentation, Add test to AMD specific, Add HIP Macros, New Binary for multiproc tests
Change-Id: I3783caf85c694b724ed55b778220b8ef9a39f84b


[ROCm/hip commit: c088ddbe7c]
2021-05-25 07:12:54 -04:00
Jatin Chaudhary abc33df0f4 SWDEV-280067 - Document hipErrorNoBinaryForGpu error in hip faq
Change-Id: Ie8cab47ecac5a1b0972041d6e3e58e4fca278c41


[ROCm/hip commit: f7a2758bdf]
2021-05-25 15:14:08 +05:30
Satyanvesh Dittakavi a951797224 SWDEV-286830 - Fix hipStreamACb_ThrdBehaviour on windows
use sleep_for which works cross-platform
for other tests as well

Change-Id: I915444d620e9fad0b9eda93bcdd244f9956ab8d5


[ROCm/hip commit: 03ae7251de]
2021-05-24 03:18:36 -04:00
Aaron En Ye Shi 4eba23b825 SWDEV-283266 - Workaround RTC macro in vector types
Temporarily disable __HIPCC_RTC__ in hip_vector_types.h
while the upstream clang headers are outdated on mainline.
Once upstream patch has landed in mainline, revert this
change. This is a workaround for hiprtc testing.

Change-Id: Ib2cf6023b71431bbfbe3c699076caa4f90f7170c


[ROCm/hip commit: 3899687b8d]
2021-05-21 15:53:59 +00:00
Satyanvesh Dittakavi cbc620f5e7 SWDEV-278464 - Update unit test hipEventMultiThreaded
Run with multiple threads to catch possible race condition
Disable running the test by default on CI as this takes lot of time

Change-Id: I1c1a66fd5c72f8d2bf7ad120461384488b46abbd


[ROCm/hip commit: f300d11931]
2021-05-21 02:57:14 -04:00
Satyanvesh Dittakavi 802fee3078 SWDEV-285521 - SWDEV-284626 - Fix P2P and Caffe2 test failures
- waitList was released before the awaitcompletion
causing stream sync after the async copies fail

- Enable the hipPeerToPeer_simple test

Change-Id: I1eeaa7e6320ab38c106902078f034dfec4c3f3ea


[ROCm/hip commit: acafb344c0]
2021-05-21 02:54:22 -04:00
Aaron En Ye Shi 06e0e6be13 SWDEV-283266 - Fix hipRTC mcin missing symbol
Add back the .type directive needed for ELF
format to add the section to symbol table.
For COFF format the symbol is already added
to the symbol table.

Change-Id: I4920e8dae0af23b4dcabd324b47abc228fcab10f


[ROCm/hip commit: ad570e3b99]
2021-05-20 20:24:55 +00:00
Julia Jiang 6bef7b2b86 SWDEV-286322 - Fix EOL in files
Change-Id: I1746e80aceeeaa4fc5df65c858f4816d99010186


[ROCm/hip commit: f8a08e2429]
2021-05-19 14:48:53 -04:00
cjatin ee8e6078f9 SWDEV-277697 - Adding Infra and dependent libs: Catch2 and json parser, for new HIP Testing framework
Change-Id: Iedfa041ec9acc13eeb631ff67e1677e2fe29463d


[ROCm/hip commit: 8084df7b49]
2021-05-19 00:47:00 -04:00
kjayapra-amd a1bba9ca4c SWDEV-286346 - Implement Arena Memory Object for externally created memory.
Change-Id: I1aae0d24b28eebaf7f67e941aaa475a53831e9b8


[ROCm/hip commit: 871c167fd0]
2021-05-18 10:24:40 -04:00
German Andryeyev f65b1f0dee SWDEV-240804 - Allow system memory creation.
Always allocate managed memory in ROCclr and backend will decide
what kind of memory to use. Currently ROCclr should fall to
GPU accessible system memory if HMM isn't available

Change-Id: I71328687b2dd4a3f563571f2b755079d82dca433


[ROCm/hip commit: 6430a308fc]
2021-05-18 09:32:57 -04:00
Tao Sang 7a0c6880b6 SWDEV-282588 - Improve clock64()
Let clock64() read s_memtime to prevent rolling over
Add wall_clock64() to read s_memrealtime

Change-Id: I706387355add75852c570be2656131ef99e8968f


[ROCm/hip commit: 7373112d74]
2021-05-17 13:19:04 -04:00
cjatin 032c98880b SWDEV-285685 - Make sure the output of hipconfig is without quotes on linux
Change-Id: I620cd41c7e6087b0d3d7da9ef7f9cecaf2f740ba


[ROCm/hip commit: 0d146dd9b8]
2021-05-17 20:50:36 +05:30
Aaron En Ye Shi 4b9326b6b3 SWDEV-263959 - Fix device decl with long and llong
Windows may expect long and ulong to be 4 bytes, while
Linux expects 8 bytes. Instead, use uint64_t for
unsigned long, and unsigned long long, and use int64_t
for long and long long to be consistent.

Change-Id: I6ed1cdde43721bcaaab0245644d607b1adbf9884


[ROCm/hip commit: 2d6881e26b]
2021-05-14 11:59:27 -04:00
Julia Jiang 275c5e1c0d SWDEV-286322 - Fix EOL
Change-Id: Ie266135ebf754b5af27c1dc768bda1ca0245d936


[ROCm/hip commit: fee2250433]
2021-05-14 11:32:55 -04:00
Aaron En Ye Shi bb65b865c6 SWDEV-283266 - Add hiprtc option to generate preprocessor expansion
Add -r/--generate_rtc option to hip_embed_pch.sh to generate the
preprocessor expansion output of the HIP headers for hipRTC mode.
Generates an object hiprtc_header.o and shared library libhiprtc.so
which can be used for hipRTC online compilations. Enable
__HIP_ENABLE_RTC by default in the CMake files.

Change-Id: Ief51b695c9b31941d929e06f16872f95eea3619b


[ROCm/hip commit: 4dedd2436d]
2021-05-14 10:20:38 -04:00
Saleel Kudchadker f4269ccb1b SWDEV-283726 - Indicate profiler attached
Set profiler attached flag in VirtualGPU to inform ROCclr of it

Change-Id: I776c9fcd762cf02f3ce0f3c386d02384a224126c


[ROCm/hip commit: fac2a9fbc8]
2021-05-12 13:40:47 -07:00
Sourabh Betigeri 31089e6ce9 SWDEV-282354 - Some AMD GPUs cause clock64() to roll over faster, this changeset prevents infinite loops due to that.
Change-Id: I19d026073afa16104ffbee4705b74d37003a04d9


[ROCm/hip commit: 6bcbb61e5f]
2021-05-11 20:40:23 -04:00
Sourabh Betigeri 8ee995bc42 SWDEV-281034 - Occupancy calculations for gfx10.3 adjustments based on available VGPRs, SIMDs per CU and number of waves per SIMD.
Change-Id: I0e34decebc9f730fe0e0c3c3258f301de5748e72


[ROCm/hip commit: 09a41f2cf4]
2021-05-11 20:39:49 -04:00
Vladislav Sytchenko 79b6187feb SWDEV-273235 - Fix HIP PCH build
hip_rtc.cpp refers to the symbol __hipGetPCH(), but that one can only be
found in hip_global.cpp. It's not referenced anywhere else, hence it
should be moved.

Change-Id: Ifc67b2f3b1b8344dec0e6c30d083d62288fb5e24


[ROCm/hip commit: 6debae4a14]
2021-05-11 17:40:32 -04:00
Julia Jiang 38d123f1bd SWDEV-282350 - Add managed memory support in HIP document
Change-Id: Iea4479058b4c40c36d71c9302834396a4088ac6f


[ROCm/hip commit: 4549478f52]
2021-05-11 16:04:46 -04:00
pghafari 8de2b45056 SWDEV-245532 - HIP - Vulkan interop semaphores
Change-Id: I89be5ee84d4728d76e1987d5016c944c0dbc9a96


[ROCm/hip commit: 86a5e82a4b]
2021-05-11 11:44:59 -04:00
Jason Tang 68fdcc833b SWDEV-277566 - Add amd::Program::load interface
Change-Id: Iba32fd6add7b1c51b33a9ea899732044c0a064f6


[ROCm/hip commit: ba42be8018]
2021-05-11 10:51:45 -04:00
Vladislav Sytchenko a1791e6afd SWDEV-240806 - Fix Windows build
hipGraphAddHostNode and hipGraphAddMemcpyNode1D are not part of the HIP
graph implementation, hence they should not be exported.

Change-Id: Ia3d0188895fb4f64ebfa23d4a0a09c44438f878d


[ROCm/hip commit: 86486b2c4a]
2021-05-11 10:07:49 -04:00
German Andryeyev fa498d73d0 SWDEV-240804 - HMM changes
- Accept hipMemAttachHost flag
- Don't allocate HMM memory if HMM is disabled in KFD

Change-Id: I3d386eb0a109a19c16a87a728944a3a6669f643a


[ROCm/hip commit: 31ae72a164]
2021-05-10 13:50:21 -04:00
Aaron En Ye Shi 8ce60e4a44 SWDEV-283266 - __HIPCC_RTC__ macro added to HIP headers
For hipRTC on Windows, add macro __HIPCC_RTC__ to allow
online compilation of with device functions excluding standard
C/C++ headers, system headers, and host HIP APIs.

Change-Id: I1d91f042baf1359856ec83ab7030dc58785e0334


[ROCm/hip commit: 811bc363c8]
2021-05-10 17:28:07 +00:00
Julia Jiang f90ac5cd5e SWDEV-272921 - Remove non-existing link for square sample
Change-Id: If8c87a6ded6aacaa4301b1b80ee218897219a6fb


[ROCm/hip commit: 73964037c1]
2021-05-10 12:09:28 -04:00
Anusha Godavarthy Surya a76f840701 SWDEV-240806 - Initial commit for hipGraph and stream capture infrastructure
On StreamBegincapture captures the parameters passed to APIs and respective node will be created and added to graph
All parameters are passed to STREAM_CAPTURE macro, it checks if stream in capture mode and redirects the call to the capture function and returns
Updated hipStream and hipEvent with capture parameters
Added handling for hipStreamBeginCapture & hipStreamEndCapture

Change-Id: Ic8926a7b4336c2cc81f0b3a9a224aa392c474134


[ROCm/hip commit: c35ba37287]
2021-05-07 17:38:16 -04:00
Ravi C Akkenapally d5ee250204 SWDEV-281998 - TEST: StreamOperations : Split StreamWait and Update into two seperate threads
Change-Id: I0fda25857dd9f097f36ce1bafedb7689ca2beecc


[ROCm/hip commit: db7421cb10]
2021-05-07 11:11:28 -07:00
Julia Jiang e3873dec5a SWDEV-282350 - update HIP documents
Change-Id: Iff3a49e75279b1ecee0672a6d35f6b84a8256296


[ROCm/hip commit: ba1c5a955a]
2021-05-07 12:38:13 -04:00
Maneesh Gupta a486ce6f0c SWDEV-252801 - Fail if launch params exceeds launch_bounds
Change-Id: I90c8d0f1897ca63f00c3eec7c99d649a5c43416d


[ROCm/hip commit: 2b04d249fc]
2021-05-06 22:38:50 -07:00
German Andryeyev 4835549bd8 SWDEV-272496 - disable direct dispatch by default
Change-Id: I706387355add75852c570be2656131ef99e8958c


[ROCm/hip commit: 192c47e251]
2021-05-06 16:17:26 -04:00
Vladislav Sytchenko 30fa6d3d92 SWDEV-273235 - Allow explicitly disabling LF support
Currently LiquidFlash cannot be supported from Github Enterprise,
hence we need to be able to build with out it.

Allow this by setting -DWITH_LIQUID_FLASH=0.

Change-Id: If59afe45c02a1623639360dbcc3927360f16ebd3


[ROCm/hip commit: 9e545007bc]
2021-05-06 13:05:12 -04:00
Julia Jiang 312d81c819 SWDEV-282350 - Adding hip_debugging
Change-Id: I18f52a76f88bcd3a0628030a6798d546a3973f4d


[ROCm/hip commit: b4158d2bc0]
2021-05-06 11:48:52 -04:00
Anusha GodavarthySurya f1f38679e5 SWDEV-271978 - Function __byte_perm to match CUDA behavior
Selector indices are as follows (the upper 16-bits of the selector are not used): selector[0] = s<2:0> selector[1] = s<6:4> selector[2] = s<10:8> selector[3] = s<14:12>

Change-Id: Ibf76c6ec2374f1f5b9bba8bd9dbd73660f830eea


[ROCm/hip commit: 1cc65c48a2]
2021-05-05 03:00:32 -04:00
Christophe Paquot 9d1462020d SWDEV-270599 - Refactored the way we get time from start/stop events in all cases
Change-Id: Id3f9bcad45d643e493daf9d5f47b3a032a427177


[ROCm/hip commit: 74a75f88d0]
2021-05-03 13:16:36 -07:00
Aaron En Ye Shi 34625c7a88 SWDEV-283930 - Fix bugs in HIP Tests on Windows
Windows doesn't have headers unistd.h, sys/wait.h, so
remove them for _WIN64. Also, Windows doesn't have rand_r
so define it. Fixes builds for HIP tests:
d2dMemCpyWithPinnedHostMemory, hipMemset3DFunctional,
hipModuleLoadMultProcessOnMultGPU,
hipModuleLoadUnloadStress, hipModuleNegative,
hipStreamACb_ThrdBehaviour, hipMemcpyNegativeMThrdMSize,
hipStreamACb_MStrm_Mgpu, StreamAddCallback,
hipStreamACb_StrmSyncTiming, hipStreamACb_MultiCalls,
hipMallocConcurrency, hipMemset3DRegressMultiThread,
and hipSetGetDevice.

Change-Id: Id2f98d664716026c590d879e464ba467d4c071be


[ROCm/hip commit: 9edd31100d]
2021-04-30 21:38:45 +00:00
kjayapra-amd 06e4e7ee8f SWDEV-245533 - Implementing Mipmap array APIs
Change-Id: I222c8d0fcbd50cdefd702462e689463bb36366d2


[ROCm/hip commit: 9c07201c6b]
2021-04-30 16:33:43 -04:00
agodavar 2ec091086a SWDEV-283897 - SWDEV-283901 - Fix directed and performance test failure
Change-Id: Ia0e9ab5d172802403af7bf6568f985b82e799baf


[ROCm/hip commit: ace2cf2840]
2021-04-30 17:56:44 +00:00
Jatin Chaudhary f8c8e4b502 SWDEV-283959 - Make hipcc recognize -xc -xc++ -xhip options and add CXX flags when user mentiones filetype as -x hip
Change-Id: I737fba3db77eef21eb88ccf648b4134218249456


[ROCm/hip commit: 6c01fb7ab8]
2021-04-30 04:58:07 -04:00
Satyanvesh Dittakavi a2b81ae792 SWDEV-278464 - Unit Test For Suspected race condition
Change-Id: I561ec3073a6e6813c5f7aa50983fcf098c6ac54a


[ROCm/hip commit: 98d1acf1f2]
2021-04-29 23:40:43 -04:00
Tao Sang bed2381766 SWDEV-283515 - Fix crashing in kernel launch on MGPUS
Fix wrong mixing of current device and stream device in
ihipModuleLaunchKernel() and hipLaunchCooperativeKernel().

Fix missing hipSetDevice() in hipMemcpyWithStream* tests.

Change-Id: I09333bb40d239bb42c832df5ea16d17eeaeff5e7


[ROCm/hip commit: a95ff95bf7]
2021-04-29 14:46:47 -04:00
Anton Gorenko 4ed5ed1db8 SWDEV-272536 - (PR-2229) Fix conversion of texture addressing mode
hipAddressModeClamp corresponds to CL_ADDRESS_CLAMP_TO_EDGE.
This change fixes incorrect sampling near texture edges.

https://github.com/ROCm-Developer-Tools/HIP/pull/2229

Change-Id: Ia2af9f3cb582a74af7b1f65bad1ed0310eab2628


[ROCm/hip commit: 6b14050424]
2021-04-29 12:19:15 -04:00
Satyanvesh Dittakavi ae26a2f818 SWDEV-283388 - Fix hipMemRangeGetAttributes on Nvidia Platform
Change-Id: I5daeacd9dd5c6ce7f914d6e6e45dd41fb2a675a5
hipMemRangeGetAttributes was returning hipErrorInvalidValue due to improper
mapping of the arguments to cudaMemRangeGetAttributes.


[ROCm/hip commit: c81a7136d2]
2021-04-29 06:06:03 -04:00
cjatin b664ce3985 SWDEV-277903 - Add HIP_ROCCLR_HOME under HIP_PLATFORM==amd
Change-Id: I00e156eb0a51f505300e288af59a0cf39b606e26


[ROCm/hip commit: a717608f93]
2021-04-29 03:08:34 -04:00
Satyanvesh Dittakavi 594462055c SWDEV-283213 - Fix hipMemset2D, 3D failures in Debug mode
If the width is 0, hipMemset2D or 3D APIs should return success
doing nothing
Change-Id: I97f8825d090a73ee63145e52d2b6d2cc0eddade3

Change-Id: I9d62fee70929ad0c79b947aa4cbbc8ab898fb64a


[ROCm/hip commit: 2122a32034]
2021-04-28 18:53:53 -04:00
Rahul Garg b9bae02fa1 SWDEV-266973 - Add missing HIP_RETURN
Change-Id: Ib569a8cb030179b71406d47fd08c7e1e7ab6eb7c


[ROCm/hip commit: 429b4ffd1f]
2021-04-27 19:55:28 -04:00
Rahul Garg 60547b8830 SWDEV-280672 - Support HIP_PLATFORM=hcc in hipcc with warning
Change-Id: I6b199ea5ebed828a7f82c20d50fdf0fcfb887a64


[ROCm/hip commit: 3ef911cb14]
2021-04-27 19:53:56 -04:00
Aaron En Ye Shi 3fcf5799ed SWDEV-222423 - Add HIP Sample 2_Cookbook/15_static_library
HIP supports emitting two types of static libraries. One type
will export host functions and is compatible with host linkers.
The second type exports device functions, but is generated with
ar manually. Also, add a README with steps on how to run these
samples with Makefile or CMake.

Change-Id: I1be15c2884583b370092bc8e4bf04f726f8f5a27


[ROCm/hip commit: cfcf04d502]
2021-04-27 16:05:15 -04:00