提交線圖

5560 次程式碼提交

作者 SHA1 備註 日期
Jenkins e1af6830ad Merge 'amd-master-next' into 'amd-npi-next'
Change-Id: I935fc8f681fad2df4e932407287a29a6a797351a
2020-08-14 09:09:52 +00:00
Freddy Paul 95729c31e8 Enable developers to build hip without CMAKE_PREFIX_PATH
With recent changes in ROCclr to take HSA cmake target it require
HIP to have CMAKE_PREFIX_PATH added for install location for HSA,
amd_comgr,llvm.

User can provide CMAKE_PREFIX_PATH if above
packages are built/installed at custom location as:
cmake -DCMAKE_PREFIX_PATH="<path_hsa> <path_amd_comgr> <path_llvm>"

For default ROCm installation adding a default path will help.

Change-Id: Iefa443dc198da76b57422a641c9821c63cde4922
2020-08-13 23:13:40 -04:00
Aryan Salmanpour de1e14b252 [HipPerf] relocating/renaming some hip perf tests
Change-Id: Ie85d242cd68cd14a858e07ed27875a5196014688
2020-08-13 17:28:11 -04:00
Aryan Salmanpour 1a2622dd60 [HipPerf] report performance based on wall time only for hipPerfDevMemReadSpeed/hipPerfDevMemWriteSpeed
Change-Id: I1fda2ec76da6fad6852d328e0a3fc39e28af57bb
2020-08-13 14:23:58 -04:00
Jason Tang d5c97e0c31 SWDEV-232197 - Remove refering to gfxipVersion_
Change-Id: I91b6b972e26b18dabf6deda5a142bff491c8bb45
2020-08-12 16:34:18 -04:00
German Andryeyev b73673bc74 Allow prefetch on the null stream
Change-Id: I87e950460361fab65ab140988fc2288bcb194f08
2020-08-12 13:07:43 -04:00
Rahul Garg 236ef94166 Return error from hipMallocManaged for size =0
Change-Id: Ida0cecf05e1df731176d41e59422d1e606cc9bd9
2020-08-10 18:25:31 +00:00
Vlad Sytchenko 963c6fe4e9 Don't align 2D image buffer size
Cuda allows creating 2D textures from memory with unaligned size.
Aligning it will cause us to overshoot the size of the underlying
allocation.

Change-Id: Ia20dec2105e36ca4a8448c9c6299d0001b388d25
2020-08-09 15:53:52 -04:00
Julia jiang e93f7b6a56 SWDEV-246878-Update document HIP_porting_guide
Change-Id: I7f4c92637f31da76293048133fff5af816c752ca
2020-08-07 14:50:01 -04:00
Aryan Salmanpour b98727505d [HipPerf] add two subtests for measuring maximum device memory read/write speed
SWDEV-245290 / SWDEV-246220 [HIPPerf] Port OCLPerfDevMemWriteSpeed/OCLPerfDevMemReadSpeed into hip performance subtests

Change-Id: I5dc323c75cebbc17596dcb4ed9492e18c5246868
2020-08-07 14:21:27 -04:00
David Salinas 996df70de9 correct -x option in hip::device
Change-Id: I8c288e678b4357019144a024395cda1fcead61fc
2020-08-07 12:33:43 -04:00
Aryan Salmanpour 61dafa0397 [HipPerf] add a test for measuring shared memory read speed
SWDEV-245290/SWDEV-247330

Change-Id: If78fa0879ff58aab84775e412a86665c7e5959e7
2020-08-07 10:07:05 -04:00
Yaxun (Sam) Liu c1a498c219 Let hipcc not escape space between obj files extracted from library
hipcc extracts bundles from static libraries and pass them to clang. It should
not escape spaces between objects extracted from library.

Fixes: SWDEV-246544
Change-Id: Iad3902f28a43a3986917ee37a49f10382c329940
2020-08-07 09:34:27 -04:00
Jatin Chaudhary fb2760a8aa Bring .clang-format file in sync with ROCclr's
Change-Id: I1990722c0779d61f66d79a5d0649d1b64e42eaf7
2020-08-07 05:34:44 -04:00
Jatin Chaudhary f0d9df0b71 Fixing the memchannel calculation
Change-Id: Ib5f5931cc0e1ee5b7cb356c2ede0cb951ee8c9de
2020-08-07 05:34:23 -04:00
Jatin Chaudhary 94bfd485ef Cuda 11 changes: https://docs.nvidia.com/cuda/cuda-runtime-api/structcudaPointerAttributes.html\#structcudaPointerAttributes
Change-Id: I8a5389b88df286043c365a734983a4c5de352102
2020-08-07 05:33:33 -04:00
Saleel Kudchadker dec95e58e3 Enable queue profile only if we attach a profiler
Submit explicit profile marker for hipEventRecord to record
timestamps. Enable explicit signal profiling if the API specifies
start and stop events.

Toggle this with env var HIP_FORCE_QUEUE_PROFILING=0

Change-Id: Iae449a63ec3ebf6c2880e65d7b1dd1031a29018f
2020-08-06 11:28:16 -04:00
Payam c24f884c76 adding duration to print log for hip api calls
Change-Id: Icffa8fcacfb8ba24861d980b9553faeee4efec8c
2020-08-06 06:42:21 -04:00
Sarbojit Sarkar bc76760452 Added free device memory info
Recently there were few OOM(out of Memory) issues poped. Adding trace will help know genuine OOM issue. 
Change-Id: Ie2a56bba95cead24caf1af5c807e73c383c2f5d9
2020-08-06 01:16:36 -04:00
Anusha Godavarthy Surya 8481524416 SWDEV-243961 Added overflow check for globalWorkSize
Change-Id: I153d99398eb4619baad8c0a52466e0d5d5f898ca
2020-08-05 11:18:07 -04:00
Aryan Salmanpour cc0f0bae74 [dtest] disable hipStreamCreateWithPriority test temporarily as it fails randomly on Jenkins
Change-Id: I4edcd555653ef8e7562245da3a6f310d60884fe0
2020-07-30 16:18:04 -04:00
jujiang 5ac8672fb2 SWDEV-242207-Update deprecated APIs
Change-Id: Icb64227be0eb44497de99240c0044a162ff3c085
2020-07-30 15:15:41 -04:00
Rahul Garg e3617167f5 Support empty sources in add_executable and add_library
Change-Id: I1441f2c045aeda2bba99bffe1c99fcc4a59cea9b
2020-07-30 13:34:46 -04:00
Rahul Garg 2140833421 Bump version to 3.8
Change-Id: I710ee1456aa108eb979eb5bef8f32081dda593d9
2020-07-30 13:30:55 -04:00
Jatin Chaudhary d251c2db57 Fixing/Disabling tests on nvcc path
Change-Id: I7ed4a1246943867482ff595d5f98bb25bd79074b
2020-07-30 00:39:07 -04:00
Freddy Paul b0438e6e99 hip-rocclr:Remove dependency to rocm-utils
rocm-utils is a meta-pacakge that pull in lot more pacakges than
what is required for hip.

Correct dependency to set as of today will be rocminfo.

Change-Id: I065ca74b4520e0c9ce183d82d6026554ff43e1f0
2020-07-28 11:42:09 -04:00
Jason Tang e430506f70 SWDEV-243576 - Fix hipMemcpy regression.
If the queue device doesn't match the device on any memory object, use the queue device from the memory object.

Change-Id: I5fdcf00494f8391574f4443332c01788b8da44ef
2020-07-28 03:04:00 -04:00
Jatin Chaudhary 78fcbab8c2 Removing redundant .hipInfo Install
Change-Id: Id8f7a4668d8b6965a47a464c94c19bc1036f3537
2020-07-28 02:01:53 -04:00
Rahul Garg c919a88795 Remove libhip_hcc symlinks to libamdhip64
Change-Id: I7b5b47fc7ca9760316c2424c16b454d7919c665c
2020-07-27 23:58:29 +00:00
jujiang c1d65e57a1 SWDEV-242344-hipMemcpyAll failed on MGPU
Change-Id: I01671e322c84213964d3d48bd6b5dc704dba731a
2020-07-27 13:30:30 -04:00
Tao Sang e9cc570be8 Remove __gnu_h2f_ieee and __gnu_f2h_ieee
Change-Id: Ide24d245d851e20961020323e52f33322a33fff9
2020-07-23 14:50:24 -04:00
Vlad Sytchenko fe6b645f3b 2D/3D copy optimizations
SWDEV-244798

If {src/dst} ptr is marked as hipMemoryTypeHost, check if the memory was
prepinned. If it was, upgrade the copy type to hipMemoryTypeDevice to
avoid extra pinning.

Change-Id: Id287ef5b14ae67dfbcf80c4caa1b08a311191948
2020-07-23 11:24:16 -04:00
Tao Sang f7cc49c0b2 Apply constexpr on global constant varaibles
When HIP_ENABLE_DEFERRED_LOADING=0, many global variables will be
referenced but they are not initialized in that early time. The patch
will use constexpr to initialze global constant varables in compile
time.

Change-Id: I9837c42e6bab38a894ece4e0f34b64f81b38fef0
2020-07-22 22:15:03 -04:00
kjayapra-amd fd783c1e88 SWDEV-236178 - Remove use of old routines functions()/modules().
Change-Id: I3a1ed967227c91b0d8cdf39e1360ade685e0bc73
2020-07-22 14:55:02 -04:00
kjayapra-amd 311fc8c513 SWDEV-240800 - Adding initial support for hipDeviceGetP2PAttribute. Some attr support still pending.
Change-Id: I0611aed136270db497dfa374144f6f5e35352a8f
2020-07-22 14:54:34 -04:00
Payam 274fded47d modify cmake to strip debug symbols from rel blds
Change-Id: Ia67261fc3c4a20f3f1bbe439a70384a3f6aefa91
2020-07-22 11:53:54 -04:00
Tao Sang eba78710dc Support numa if libnume-dev is installed
Let rocclr decide numa dependence

Change-Id: I65bdfba7ec0d06b550f86632318bcfd1f765cfa9
2020-07-22 08:55:28 -04:00
Satyanvesh Dittakavi 6f5e63ebac SWDEV-244772 - Fix dtest hipMemcpyWithStreamMultiThread.cpp.
hipSetDevice is not used correctly to allocate on multiple devices in mGPU setup.
Due to which hipMalloc was called on the same device on multiple threads leading to out of memory issues on some devices with lesser memory.

Change-Id: I0e5b1bc028b9ecb11bd40c3a5edf715f8bd721ff
2020-07-22 00:52:14 -04:00
Saleel Kudchadker 603546cd45 Print devPtr and size for hip*Symbol* api
Change-Id: I07be6949cca005700ee1d1708d86220c793c9728
2020-07-21 13:49:10 -04:00
Rahul Garg 19ede4fd23 Handle size 0 symbols
Change-Id: Ie282b37cf6bbccae4611dfc17c5c7f31977feea7
2020-07-21 10:09:26 -04:00
Aryan Salmanpour e27d53043c Add missing stream null check for some hipStreamCreate APIs
Change-Id: I716d71e4ec59b0bd7922869bfa0ed908c22c289e
2020-07-20 18:07:03 -04:00
jujiang 797d2761d4 SWDEV-242337-Fix hipHostRegister test failure for MGPU
Change-Id: I748dac0c5a47fa00184f065d9ef716573aa70b12
2020-07-20 11:40:49 -04:00
Vlad Sytchenko 6be1b7ce2b Merge branch 'amd-master-next' into amd-npi-next
Change-Id: Id241c60d6c2ceb4049c3ec15d9fe06baf28bcb3a
2020-07-20 09:49:15 -04:00
Sudheer Kumar 94c4462848 [dtest] Compare hipDeviceGetPCIBusId output with lscpi output
SWDEV-238517 for enhancing hip unit tests

Change-Id: I5507dd19fc22e7f8806655eefaa69fbd61c98f56
2020-07-20 04:31:48 -04:00
German Andryeyev 5ef00cf6e9 Grab the event lock before fetching the last command
Hip applications assume that hipEventRecord called from multiple
threads will contain exactly the last queued command to the stream.

Change-Id: I1da3259f143d7670d0870d9a47c08e32336b2222
2020-07-20 02:01:16 -04:00
Ashutosh Mishra 7d3d8c8e6d Adapting to static libaray changes for hipcc
Since the introduction of BUILD_SHARED_LIBS there is only one target created : libamdhip64
Which is static ( libamdhip64.a ) or Dynamic ( libamdhip64.so ) depending on whichever it is
being compiled for. After this change we do not have any target libamdhip64_static which is
mentioned in the hipcc for linking. Hence cleaning the same.

Change-Id: Ia45c145e17b111b3f6a32299a11962b10f1cc539
2020-07-17 14:42:07 -04:00
jujiang 50b299da66 SWDEV-243933-update HIP README document
Change-Id: Ie303698ae92c7fa1b1202c1ee06beda1005ba065
2020-07-17 12:26:05 -04:00
Christophe Paquot a838e6e108 Remove use of setLastQueuedCommand
Change-Id: I07bf54dc09905d9a17b059a476df9282eb6f1f51
2020-07-17 11:45:25 -04:00
Evgeny 49091c2463 cleanup: unneeded '\'
Change-Id: I0276312fdb0e4829d678de4281ccfd12eb7f232e
2020-07-16 01:57:07 -05:00
Ashutosh Mishra a77c7e21be Adding "BUILD_SHARED_LIBS" flag to cmake files
JIRA : SWDEV-234471
With this change compilation of the ibamdhip64 to be decied by arguments to build_hip_on_rocclr.sh file
build_hip_on_rocclr.sh -r (current) shall conitnue to create libamdhip64.so;
build_hip_on_rocclr.sh -r a (new) shall create libamdhip64.a
other options remain the same

Changed the targets according to requirement of stage2 dependencies.
Changed find_lib with find_package

Adpated the review comments

Change-Id: I719918f73ab33cd8031a32db6fe9b8adaa1b4b87
2020-07-16 00:29:14 -04:00