e2d2fad56c
SWDEV-440746 - Fix a crash during RGP capture
...
With multiple HIP streams it's possible to have a race condition when
one thread stops the traces, but another still performs submisisons.
That may cause a crash on the barrier callback.
Change-Id: Ic56f8277fcfd2c2142a4821d927b938b9f313add
2024-02-22 23:53:35 -05:00
4177b4b675
SWDEV-359287 - uniform_work_group_size is interger type is 1 for true and 0 for false.
...
Change-Id: Iac5584c3cdd3bf78e3f1e89033b9ce7e07afefca
2024-02-22 22:37:31 -05:00
8f9a20738e
SWDEV-404889 - Don't report trap handler
...
Trap handler shouldn't be reported for debugger and RGP
Change-Id: I149dacfed49584503c1874120d5f552fdec323a7
2024-02-22 14:49:54 -05:00
b954d0d6e0
SWDEV-443760 - Disable HIP_FORCE_DEV_KERNARG by default
...
Change-Id: I8c3d8e65aa954bd28499eebefbc532d1177445dc
2024-02-22 04:37:51 -05:00
821ae6a103
SWDEV-426272 - hipPointerGetAttribute shouldn't segfault when host ptr is passed
...
Check the pointer if its present in the arrayset before trying to dereference
it as it can cause access violation if the pointer is allocated using malloc
Change-Id: Ida72b9015dc22269fc1fbe0728e66e3de29fda3d
2024-02-21 16:37:21 +00:00
4c28f4aefd
SWDEV-446296 - Update README for the repos link change
...
Change-Id: I13f73e3c9a066c5e92f630bcd06f777790087e5e
2024-02-20 18:53:07 -05:00
1f6d416684
SWDEV-446399 - Fixed segfault in hipMemSetAccess
...
Change-Id: Ia1200d9bee03e8abade211287505f081e635ceec
2024-02-20 18:51:05 -05:00
7bfee3481b
SWDEV-333557 - Enable PAL_HIP_IPC_FLAG by default
...
Change-Id: Ibb2ca0b9521aff4eca190e4817dcc5f8d697b172
2024-02-20 18:45:25 -05:00
f138e0d113
SWDEV-443760 - Enable device kern args
...
- Implement workaround to ensure HDP writes are done by writing and
reading the HDP MMIO register.
- Implement the same workaround for graphs, we no longer need sentinel
write/readback
Change-Id: I0d3027b46a1f61131ec62e3c8c669ff5184fa6b2
2024-02-20 02:03:14 -05:00
81b8598af9
SWDEV-301667 - Cleanup code and better log
...
Change-Id: Ie2345264e84026156a9f81b421eed3cf4aeeeffc
2024-02-19 05:42:47 -05:00
848a36b631
SWDEV-446014 - Use branch ASIC definition to build PAL
...
Change-Id: I80f70b5c963184ef9ae22517c23cbc5a26fbeafd
2024-02-16 19:09:56 -05:00
7d09e1abed
SWDEV-444767 - Fix graph tests for context change between Inst & launch with DEBUG_CLR_GRAPH_PACKET_CAPTURE
...
When graph is Instantiate on device 0 graph and launch on device1 switch to command creation and enqueue during launch.
Change-Id: Ied34dc99b2a776130d1354ed3830c6ccab9068e4
2024-02-14 17:02:36 +00:00
d1b75659f2
SWDEV-445539, SWDEV-445549 - Restore kernel launch prof data.
...
Issue is due to INIT_hipLaunchKernel_CB_ARGS_DATA turns out to be empty when we generate new hip_prof_str.h with since
extra space introduced by https://gerrit-git.amd.com/c/compute/ec/clr/+/846275/77/hipamd/src/hip_module.cpp#667
Change-Id: Id251956c1663483cc7ab11a3722769cb5b0d3664
2024-02-14 00:05:41 -05:00
3a5e8bac40
SWDEV-437230 - Add CODEOWNERS file
...
Add @gargrahul, @rakesroy, and @mangupta as CODEOWNERS.
This is for GitHub upstream.
Signed-off-by: David Galiffi <David.Galiffi@amd.com >
Change-Id: I563a7cf860cca56ae5fb5e05dcfaf1751b3692e4
2024-02-13 23:53:44 -05:00
243555959f
SWDEV-438299 - Remove unused variables
...
Change-Id: Id2908fe851d566ec2515161090f1e21b60cf6447
2024-02-13 19:39:11 -05:00
4f6b0da028
SWDEV-311271 - Fix Windows mempool management
...
Windows path still uses multi threading implementation. Hence, in graphs
all nodes are executed in a queue thread and that requires to manage
mempool in the queue thread. However, the spec allows to destory memory,
allocated in a graph, outside of the graph's execution. That may cause
mempool management to go out of sync.
Change-Id: I0ffb2244b3cb720455ed44d1b3e2487fa8959a77
2024-02-13 17:16:06 -05:00
bfa469ddc4
SWDEV-445692 - Query OS for free memory
...
Latest VidMM can provide free memory available on the system.
Use PAL interface to report free memory on the system instead
of per process.
Change-Id: I0e78b9d340299c16829177a8c5182d21cc353384
2024-02-13 09:53:36 -05:00
853abeb75e
SWDEV-445013 - During CaptureAQLPackets correct sentinal value to copy integer size bytes
...
Read and write int bytes sentinal value to dev_ptr or PCIE connected devices at the tail end of the kernarg surface.
Change-Id: I993d552ac872b3cd56aef4746c4d1d92c58d38b4
2024-02-13 07:05:57 +00:00
4d61237a6f
SWDEV-445576 - Return error when hipMemPoolDestroy is invoked on the default mempool
...
Change-Id: I7a7ab499f781cf7e92cad1ae39a40b4f37f62653
2024-02-12 12:48:21 +00:00
5e6ad190ff
SWDEV-445221 - Fix the memory reported for hipMemPoolAttrReservedMemHigh
...
Change-Id: I894a836643612c73feb322f29a9236ada4d8cbda
2024-02-08 23:40:51 +00:00
0479cdb3dd
SWDEV-437702 - implement hipGetProcAddress
...
This should be used in place of dlsym or GetProcAddress (linux and windows respectively)
Change-Id: I5501b538e03892e8e5a2282678d848fcaf21d911
2024-02-08 11:26:02 -05:00
d6bc40e822
SWDEV-445084 - Add DEBUG_CLR_GRAPH_PACKET_CAPTURE support for hipGraphInstantiateWithFlags/Params
...
Change-Id: I5096b4c8d73d1faf972dfd23ab86a53d888946c4
2024-02-08 04:55:53 -05:00
ca0b50c9ca
SWDEV-444558 - SWDEV-444418 - Fix capturing of AQL packets when kernel arg size is 0
...
When graph doesn't have kernel nodes.
Change-Id: I6b3b476654d7eedc9ff0cec4b7269168aa115360
2024-02-08 06:12:16 +00:00
f964975db0
SWDEV-421025 - Graph Instantiate with Params API Update
...
Change-Id: I3ed821ced02420858d360e8dab5e1e931c350c7e
2024-02-07 11:35:21 -05:00
7d5b4a8f7a
SWDEV-437832 - Changes to update host unified memory and iommuv2 flags.
...
Change-Id: I88998cf57c21fc446fa28e250f826c607923670b
2024-02-07 06:27:47 -05:00
a6841e3f43
SWDEV-400448 - SWDEV-392872 - Optimize to add lock only if its null stream
...
Change-Id: Ia905109a295614e8ce4e2bd24261c86ba8138178
2024-02-07 04:51:54 -05:00
24e1c34320
SWDEV-395996 - Add ChangeLog for hipRTC header support
...
Change-Id: Ibd3cae127185831f46cd704a354508d8586731bd
2024-02-07 04:50:57 -05:00
a1b2cbe44e
SWDEV-439637 - Updated to compile with clang compiler
...
Change-Id: Ib0a8e1cc007f083fb1d1f4363cf89ba76ad3c4f2
2024-02-06 23:57:13 -05:00
e37aaeae09
SWDEV-443537 - Fix cmake build warning
...
Update cmake minimum requirement on deprecated cmake version (2.8.11) to non-deprecated version (3.5)
Change-Id: Ib76d241babf475a26464e8b12b91d67e48f72b60
2024-02-06 14:51:56 -05:00
5303cd2740
SWDEV-439637 - Fix undefined symbol error hipTexRefGetArray & hipTexRefGetBorderColor (github id- #3382 )
...
Change-Id: Iae1956779e84759f23011151b60a01cef0d0ef32
2024-02-06 03:04:07 -05:00
32d49d55ec
SWDEV-443796 - Translate CL_INVALID_GL_OBJECT error for DX/CL interop
...
Change-Id: If87bb9d0fb275dd4d9a8a949f4016a082a300144
2024-02-05 10:29:00 -05:00
8d265838cb
SWDEV-400448 - SWDEV-392872 - Add lock to NullStream
...
Fetching null stream's logic has changed earlier from amd::HostQueue
to hip::Stream. This seem to cause some timing difference between
checking for null stream and creating it due to which issues are
observed in multithreaded applications using default stream.
Change-Id: Ie02365dec537275d23a1d225de9811e2fd3a9c55
2024-02-05 02:58:23 -05:00
dca7bb22b6
SWDEV-443796 - Fixed regression in DX11->OpenCL texture sharing case
...
Change-Id: Ia7d6cb08706ce9b15252f5412c9f9c57d53b2e6e
2024-02-05 05:08:11 +00:00
1a3901fa49
SWDEV-421025 - hipGraphInstantiateWithParams API changes
...
Change-Id: Ib07d4dd1698220b68ed27f91d58d3bd315a8804c
2024-02-05 05:08:11 +00:00
ceffb24416
SWDEV-421025 - Hip Launch Attribute ID/Value datatype for rocprof
...
Change-Id: Icfcd1ecf2f2956ba015820ba250f06b438169a6a
2024-02-05 05:08:11 +00:00
0567c3b720
SWDEV-301667 - Better log
...
Display queue base pointer in the log. This can be co-related with AQL
packets
Change-Id: I544f9b6db6ae01c85e57e4b3f0b3fffefcd7c2ed
2024-02-05 05:08:11 +00:00
ae0368d12d
SWDEV-422207 - Enable DEBUG_CLR_GRAPH_PACKET_CAPTURE environiment variable
...
Change-Id: I9bf72b9c1a56980352109bd4d42b54ecb2d1b8f9
2024-02-05 05:08:11 +00:00
43c811bdd2
SWDEV-418291 - Add changelog for bfloat16 types
...
HIP now has bfloat16 types via amd_hip_bf16.h in hipamd, hip_bf16.h in
hip folder.
Change-Id: Ic4d227936c5013e4b5d577725b8f55bebdc15499
2024-02-05 05:08:11 +00:00
370ff6ea3e
SWDEV-443538 - Fix cmake build warning
...
Use GLVND versin of GL
Change-Id: I1d6b0ec8672a232d017ad27a01803556992e8a49
2024-02-05 05:08:11 +00:00
5b72582474
SWDEV-443018 - Restrict input range for value argument in hipPointerSetAttribute
...
Change-Id: I17b6448bf49aed49315a0b4c1426dcbe011735d9
2024-02-05 05:08:11 +00:00
a2a8dad980
SWDEV-442719 - Set CMP0074 to NEW to make sure find_package works correctly
...
If a system has LLVM installed, `find_package` could choose that one
even if we set `HIP_LLVM_ROOT`. `LLVM_ROOT` is ignored because of this
CMake policy is set to `OLD` by default.
Change-Id: I18fa0453afe170c229e92d6ddc386b43eb0c44f6
2024-02-05 05:08:11 +00:00
9a6ddae7b2
SWDEV-301667 - Reset profiler correlation_id_
...
- The correlation_id had random junk values which we were inserting in
the dispatch AQL packet even when no profiler was attached but if we had
a valid timestamp.
- Also make sure we dont even write the reserved2 field in the AQL
packet if no profiler attached.
Change-Id: Icdb7493198c1bb5e2d786a97e027288660854cd7
2024-02-05 05:08:11 +00:00
60549b101c
SWDEV-438503 - Always report hipDeviceAttributeUnifiedAddressing as true.
...
Change-Id: I3119bd8f99c079280bde1ba32b3d26b474899e7d
2024-02-05 05:08:11 +00:00
f28b1f1f1d
SWDEV-443109 - Fix for CXX compiler check in hip-config-amd.cmake
...
Change-Id: Ib6b8bc59a889ad2e4f440e847d9f2e7e8fb2cda2
2024-02-05 05:08:11 +00:00
842eda5e7f
SWDEV-440746 - Remove pending dispatch check for SDMA P2P
...
Change-Id: I7290345cfc60cd878fb39a06b03105441793c27b
2024-02-05 05:08:11 +00:00
dcd2fcff16
SWDEV-404889 - Switch to FreezeExecutable()
...
Debugger support requires FreezeExecutable() call inside the loader interface.
Change-Id: Iff01840a5980500d8d51da8d73c3f24b2960c44a
2024-02-05 05:08:11 +00:00
d80168eb87
SWDEV-295298: hide warp sync builtins with a macro in ROCm 6.1
...
Change-Id: Ie2efd233c0bcf8ad0e06223ee854fe4bd1060443
2024-02-05 05:08:11 +00:00
243b86dd23
SWDEV-368741 - Check for uninstalled hsa-amd-aqlprofile to avoid Segmentation Fault
...
Change-Id: I0c0c7a2ea7c35237332ddd7c2461e4d9ff8e2f1c
2024-02-05 05:08:11 +00:00
9fd8b4d3f1
SWDEV-440029 - Fix hipMemcpyFrom/ToSymbol directions allowed
...
Change-Id: Ib0b3d737cd5d297ac2d3c1ba549902b96e29c18c
2024-02-05 05:08:11 +00:00
b53fcb4d02
SWDEV-440718 - Suffix hip bin name with _6.
...
Link to amd_comgr_2.dll
Change-Id: I5d21af0cc91f2082099273f75ebe1c3279b6365d
2024-02-05 05:08:11 +00:00
German Andryeyev
Jaydeep Patel
Rahul Garg
Satyanvesh Dittakavi
jujiang
Ioannis Assiouras
Todd tiantuo Li
Saleel Kudchadker
Alex Xie
Anusha GodavarthySurya
David Galiffi
Ilya Panfilov
jiabaxie
Rahul Manocha
kjayapra-amd
cadolphe
Jatin Chaudhary
Shilei Tian
Sameer Sahasrabuddhe
Ajay