e305d3fc94
Add missing file.
2017-11-29 02:16:44 +00:00
37c1811b2a
Fix oversight in selection mechanism which led to erroneous code to be compiled for the grid_launch_GGL component.
2017-11-29 01:37:52 +00:00
c6ab6f292b
Choose whether or not to use functional grid_launch based on the version of HCC used to compile.
2017-11-29 00:17:44 +00:00
45a9f4f7b1
Remove leftover agent allocated globals.
2017-11-28 19:56:04 +00:00
d5c8de3f41
Change memset kernel to use memcpy instead of placement new. Simplify indexers.
2017-11-28 19:45:47 +00:00
6a0efb7ed2
Re-sync with upstream and re-factor platform global management for texture references.
2017-11-28 19:15:29 +00:00
d37a5a6008
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
# Conflicts:
# src/hip_module.cpp
2017-11-28 17:29:11 +00:00
cc418da654
Fix float2int rounding functions
...
Change-Id: I67943859a6344c5eec0eaa23418c9b802ef72468
2017-11-28 17:23:43 +00:00
bb35299560
This actually (tries) to do the right thing all the way, by using memcpy for bitcasting, and not rely on undefined behaviour of a different flavour as a substitute for the original undefined behaviour. Note that the compiler will (should) optimise down to the same emitted code, since this is a pattern it understands.
2017-11-28 17:23:06 +00:00
4b7cb0624e
This fixes some outright quaint choices made when implementing HIP's bitwise conversion functions, by using simple reinterpret_casts, as is idiomatic. These functions are supposed to be re-entrant, correct and efficient. Sadly, they were neither: they hid a massive race condition against a value stored in global memory, which means that they were also unreasonably slow if they ever managed to be correct, and relied on union based type punning which is in a grey area of the standard. It is difficult to ascertain what may have been the reason for coming up with this quirky solution.
2017-11-28 17:23:06 +00:00
7761f63bbc
Add hipify mappings for all CUDA headers that have HIP equivalents
...
I'm particularly running into issues with `device_types.h` in real
CUDA code...
2017-11-28 17:23:06 +00:00
e93a24bdbe
Merge pull request #256 from gargrahul/texture_driver_api_support
...
Texture driver APIs support
2017-11-27 13:52:39 -06:00
6c18df987d
Added note in Release notes for texture driver APIs
2017-11-27 22:06:50 +05:30
b25d199111
Merge pull request #262 from ChrisKitching/frontendaction
...
[HIPIFY] Mostly fix preprocessor-or-template induced issues
2017-11-27 17:30:11 +03:00
3e9a4cfdd1
Porting guides update for texture APIs usage
2017-11-24 12:00:55 +05:30
77de4b96cf
Merge pull request #273 from mangupta/swdev-129574
...
Fix float2int rounding functions
2017-11-23 12:04:36 -06:00
822743845c
Fix float2int rounding functions
...
Change-Id: I67943859a6344c5eec0eaa23418c9b802ef72468
2017-11-23 09:57:24 +05:30
dfa532db98
Remove leftover comment.
2017-11-22 19:37:03 +00:00
6bddac1cfa
Merge pull request #263 from ChrisKitching/headers
...
[HIPIFY] Add hipify mappings for all CUDA headers that have HIP equivalents
2017-11-22 21:24:21 +03:00
0755f1fc26
Modify the set component of the memcpy test (unclear why there is a memset component to begin with).
2017-11-21 17:52:01 +00:00
38029f2849
Fixed review comments
2017-11-21 21:19:06 +05:30
fb1021cc0a
This corrects how addresses are formed for symbols which reside in shared objects. For this case, the .value component of an ELF symbol holds the offset from the base VA where the shared object was loaded. Thus, to correctly obtain the VA of the object refered by the symbol, we must add the offset to the VA where the shared object is loaded. We were already doing this correctly for symbols denoting functions, but we were incorrect for those denoting objects.
2017-11-21 13:15:13 +00:00
24307fe5c4
Changed function hipMemcpy_2D to hipMemcpyParam2D
2017-11-21 12:36:24 +05:30
f8c1c1b38e
Refactor the __device__ versions of memset and memcpy to be less awkward i.e. not return nullptr as opposed to the destination pointer (it can only be assumed it was done for maximum confusion) and actually unroll as they claim to. Change all of the {to, from}Symbol functions to use hipModuleGetGlobal, as opposed to hc::accelerator::get_symbol_address which is no longer valid with module based dispatch.
2017-11-21 02:40:34 +00:00
24f8a93ff7
Clean-up some remaining noise in program_state.cpp.
2017-11-20 22:41:46 +00:00
27bc487635
Correct ill-formed merge in earlier commit and adjust for differences with the new CUDA natural indexing mechanism.
2017-11-20 16:33:52 +00:00
30d90dab38
Re-sync with upstream.
2017-11-20 15:34:50 +00:00
a1e0c96689
Merge pull request #264 from pzins/missing_end_marker
...
Fix missing MARKER_END
2017-11-20 06:08:01 -06:00
eff09fcd86
-Moved coGlobals in hipModule class (takes care of multi module case)
...
-Used mutex scope for updating coGlobals
2017-11-20 16:23:18 +05:30
4477d3d314
Merge pull request #266 from gargrahul/fix_half2_gfx900
...
Fixed half2 issue on gfx900
2017-11-20 07:28:41 +05:30
29c0ab8401
Merge pull request #265 from phani544/nvccTests
...
[nvccTests]Enabled inline_asm_vadd on nvcc
2017-11-20 07:28:29 +05:30
aeadc3f18f
Fix test on cuda
2017-11-19 15:31:02 -06:00
a43262e699
Merge branch 'feature_natural_indexing' of https://github.com/AlexVlx/HIP
2017-11-19 15:25:17 -06:00
fc34fd6f03
Temporarily disable P2P on nvidia (fails on dual GPU)
2017-11-19 15:21:37 -06:00
76f174b536
Update hipModuleGetTexRef API
2017-11-19 22:10:46 +05:30
0cc921f103
This implements the trivial change needed to move back from the hip{Something}_{x, y, z} macros to the natural CUDA syntax of Something.{x, y, z}. This is contained in lines 384-404 in hip_runtime.h. All of the other changes have to do with changing unit tests to use this syntax. The macros are retained for backwards compatibility.
2017-11-19 01:54:12 +00:00
45ac5b70df
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
2017-11-16 23:20:15 +00:00
cfc9f87465
Fixed test case for GFX900
2017-11-16 09:34:52 +05:30
20947f80fb
Fixed half2 issue on gfx900
2017-11-15 18:52:59 +05:30
e2e499461a
Removed redundant desc variable
2017-11-15 18:28:27 +05:30
edbfeeb141
-Fixed texture driver API sample
...
-Added hipTexRefSetAddress and hipTexRefSetAddress2D APIs
2017-11-15 18:23:28 +05:30
9fa3ed4f6f
[nvccTests]Enabled inline_asm_vadd on nvcc
2017-11-14 16:37:59 +05:30
e536eb038d
Texture code reorganized
2017-11-14 11:09:35 +05:30
e60a95d7dd
Fix missing MARKER_END
...
Logging status of hipCtxSynchronize was missing
Test if hip profiling is active for MARKER_END in ihipPostLaunchKernel
Add MARKER_END after the completion of a kernel launched through
the "grid launch"
2017-11-13 16:13:19 -05:00
642af94492
Add an explicit check for proper rewriting of CUDA includes
2017-11-13 21:02:42 +00:00
e8c1e7bb11
Add a preprocessor conditional to one of the tests
...
Hurrah, we can cope with ifdefs now (except for kernel launches)
2017-11-13 20:58:55 +00:00
506deca07f
Use proper clang diagnostics for printing warnings
...
Much pretty. Very wow
This gives users all the usual power when it comes to manipulating
clang diagnostics. People can pass -Werror can have hipify fail if
it doesn't completely translate a file, for example. Much nicer
than reinventing the wheel.
2017-11-13 20:58:55 +00:00
7a441aef10
Use a custom FrontendAction to simplify identifier translation
...
Most of what hipify does is really just replacing CUDA idenitifers
with HIP ones. CUDA function calls, preprocessor macro calls,
enum references, types, etc.
This is problematic: calls/types/enum-refs require name resolution
for the AST matcher to work. This fails in the presence of code
deleted by the preprocessor, and in two-pass template compilation.
Instead, we can simply hook the lexer and have it rewrite the
identifiers for us.
This approach means identifier transformations will work correctly
regardless of where they appear (and we get to delete lots of code)
- Fixes #260
- Helps a bit with #207 - it will still fail to translate kernel
calls in preprocessor-ignored code, but everything except kerel
launches should translate correctly now, even in
preprocessor-deleted code.
2017-11-13 20:58:54 +00:00
9014c89f04
Add hipify mappings for all CUDA headers that have HIP equivalents
...
I'm particularly running into issues with `device_types.h` in real
CUDA code...
2017-11-13 17:20:07 +00:00
0afc6b2e95
Add a test that exposes #260
2017-11-13 16:18:15 +00:00
Alex Voicu
Maneesh Gupta
Chris Kitching
Ben Sander
Rahul Garg
Evgeny Mankov
Phaneendr-kumar Lanka
Pierre