I ran a test that exercised this code in dev mode and ASAN found a memory access issue due to the iterator returned by lower_bound being dereferenced unconditionally. I believe the right fix is to check if the iterator is within the map and if not go to the else branch
Change-Id: I34fdce634791a09a89eee76c8b2b64a9607d57f9
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
[ROCm/amdsmi commit: 2066872297]
number of compute units `amdgpu_gpu_info.num_of_compute_units` is exposed through amdsmi_get_gpu_asic_info().
Code changes related to the following:
* API
* CLI
* Unit tests
* Examples
Change-Id: Ibeb612d079ed87437a0e56124b8504098fc2dcfd
Signed-off-by: Oliveira, Daniel <daniel.oliveira@amd.com>
[ROCm/amdsmi commit: b05849dad0]
Driver info `amdgpu_gpu_info.vram_bit_width` is exposed through amdsmi_get_gpu_vram_info().
Code changes related to the following:
* API
* CLI
* Unit tests
* Examples
Change-Id: I8abd8db7a603078b2b1c008b2685cecf35caf3d2
Signed-off-by: Oliveira, Daniel <daniel.oliveira@amd.com>
[ROCm/amdsmi commit: 893f13ab98]
GPU Metrics info `gpu_metrics.vcn_activity` is exposed through amdsmi_get_utilization_count().
Code changes related to the following:
* API
* CLI
* Unit tests
Change-Id: I831b2a81bdc0e090a6698dcb689d10f91ed87dd9
Signed-off-by: Oliveira, Daniel <daniel.oliveira@amd.com>
[ROCm/amdsmi commit: af3670d758]
- Fix updates API to have correct enum names (PM->SMU)
- Python API/CLI now reports correct versions and names for
SMC/TA_XGMI/TA_RAS
Change-Id: Icbe115b3070b9f252ef15b09b781b9b3f5861e50
Signed-off-by: Charis Poag <Charis.Poag@amd.com>
[ROCm/amdsmi commit: d7c583d422]
Latest updates need to use a wrapper defined value. Breaks basic CLI
functionality.
$ /opt/rocm/bin/amd-smi list
Traceback (most recent call last):
File "/opt/rocm/bin/amd-smi", line 44, in <module>
from amdsmi_commands import AMDSMICommands
File "/opt/rocm/libexec/amdsmi_cli/amdsmi_commands.py", line 30, in <module>
from amdsmi_helpers import AMDSMIHelpers
File "/opt/rocm/libexec/amdsmi_cli/amdsmi_helpers.py", line 35, in <module>
from amdsmi_init import *
File "/opt/rocm/libexec/amdsmi_cli/amdsmi_init.py", line 35, in <module>
from amdsmi import amdsmi_interface
File "/usr/local/lib/python3.8/dist-packages/amdsmi/__init__.py", line 26, in <module>
from .amdsmi_interface import amdsmi_init
File "/usr/local/lib/python3.8/dist-packages/amdsmi/amdsmi_interface.py", line 1725, in <module>
reg_type: amdsmi_reg_type_t,
NameError: name 'amdsmi_reg_type_t' is not defined
Change-Id: I628c811c137f57f3177a718c9bce859bc553bf7d
Signed-off-by: Charis Poag <Charis.Poag@amd.com>
[ROCm/amdsmi commit: a2dc934b05]
v2: drop depend on libc
v3: whitespace
Signed-off-by: Tom St Denis <tom.stdenis@amd.com>
Change-Id: I2eff7aa9d4f0ca8635796f82b106ac0d36176346
[ROCm/amdsmi commit: f4506cfd65]
First look locally following these heuristics
Either as a user specified option -DBUILD_KERNEL_ASM_DIR=<PATH>
or from the running kernel's src
and then from hints at where it could be.
When these fail, download from the upstream kernel
Change-Id: If8d62a4f84a929f550e4a83cda93e4d671e92d02
Signed-off-by: Tom Rix <Tom.Rix@amd.com>
[ROCm/amdsmi commit: f3cb51c08e]
ecc is not supported on VM
Added static --ras because ras features are still detectable
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: Ied4132b863989dfd67897e00904f04d140fd2773
[ROCm/amdsmi commit: 210680b570]
amd-smi is installed in /opt/rocm-ver/bin, but not as a soft link in wheel package
For amd-smi to work from bin directory, it need the extra path to find the dependent python scripts in /opt/rocm-ver/libexec/amd_smi
Change-Id: I4ff63a8f55949aaac51d85eae849ecc890f4c694
[ROCm/amdsmi commit: 7591eec971]
CPACK is converting /usr/bin/env python3 to /usr/libexec/platform-python in RHEL8.
Undefining __brp_mangle_shebangs will prevent the same
Change-Id: I5120274b90aeaf783b62414ac2aeba9e84029205
[ROCm/amdsmi commit: 92a4093256]
Maisam Arif
Xiaodong Wang
gabrpham
muthusamy
Charis Poag
Zhang Ava
Oliveira, Daniel
Tom St Denis
Bill(Shuzhou) Liu
Tom Rix
Galantsev, Dmitrii
Ranjith Ramakrishnan