AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
13,501 Commits 3 Branches 0 Tags
e56ff3716d7b8d04ee60e42d2ebb6ebf5d0d58db
Commit Graph

13501 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Giovanni LB e5e2c6041d SWDEV-310289: Adding SPI pipe selection 
Change-Id: I4856d284df3dccaa100a2341211ae09e11c63ecd
 2024-10-12 01:14:49 -04:00
Giovanni LB 896404efb3 SWDEV-310289: Adding SPI pipe selection 
Change-Id: I4856d284df3dccaa100a2341211ae09e11c63ecd


[ROCm/rocprofiler commit: e5e2c6041d]
 2024-10-12 01:14:49 -04:00
Benjamin Welton 6d80088c84 Added FP64_ACTIVE and ENGINE_ACTIVE 
Should replicate DCGM_FI_PROF_EVAL_FLOPS_64 and
DCGM_FI_PROF_GR_ENGINE_ACTIVE respectively. See
https://ontrack-internal.amd.com/browse/SWDEV-490046
and
https://ontrack-internal.amd.com/browse/SWDEV-490031

Change-Id: Ia79f6a1601beac48a350493f2e83ce322c1d8d33
 2024-10-11 15:51:09 -07:00
Benjamin Welton 4dd298f312 Added FP64_ACTIVE and ENGINE_ACTIVE 
Should replicate DCGM_FI_PROF_EVAL_FLOPS_64 and
DCGM_FI_PROF_GR_ENGINE_ACTIVE respectively. See
https://ontrack-internal.amd.com/browse/SWDEV-490046
and
https://ontrack-internal.amd.com/browse/SWDEV-490031

Change-Id: Ia79f6a1601beac48a350493f2e83ce322c1d8d33


[ROCm/rocprofiler commit: 6d80088c84]
 2024-10-11 15:51:09 -07:00
coleramos425 38df31b863 Update CODEOWNERS for product team 
Signed-off-by: coleramos425 <colramos@amd.com>


[ROCm/rocprofiler-compute commit: e633d17372]
 2024-10-11 20:25:43 +00:00
coleramos425 e633d17372 Update CODEOWNERS for product team 
Signed-off-by: coleramos425 <colramos@amd.com>
 2024-10-11 20:25:43 +00:00
David Yat Sin ead3aafcda rocrtst: Fix VirtMemory_Basic_Test permissions 
Fix VirtMemory_Basic_Test permissions to adjust for previous change to
the hsa_amd_vmem_set_access behavior change that was done with this
patch:

rocr/vmm: Only modify permisions for specified agents

Change-Id: I97230600b9b9144459b08ca3da3a5bfbdbb98231
 2024-10-11 10:41:11 -04:00
gobhardw d1e0c2cbb2 SWDEV-479505 Updating ROCtracer spec for device ids 
Change-Id: I9b65d91b36b77183d5fa55f23e4926510e0b5832


[ROCm/roctracer commit: d5bbc8aa77]
 2024-10-11 09:26:42 -04:00
gobhardw d5bbc8aa77 SWDEV-479505 Updating ROCtracer spec for device ids 
Change-Id: I9b65d91b36b77183d5fa55f23e4926510e0b5832
 2024-10-11 09:26:42 -04:00
jokim 1d6ff45673 rocr: Workaround segfault on GFX9 devices older than GFX90a 
Devices older than GFX90a hit a segfault on queue unmap when an
SDMA queue has been assigned a fixed engine.  Bypass fixing the
engine for these devices for now.

Change-Id: I7d2f882d2377f004a7bb65f3b397396db07ce6d3
 2024-10-10 14:41:10 -04:00
Pramendra Kumar 43c4613984 Revert "Adding rocm-llvm-dev package as req." 
This reverts commit f014c03f30.

Reason for revert: <Imapcting driver install to QA due to timeout>

Change-Id: If5d98341e9ac3e803965064e3f5dc435b9310a0b


[ROCm/roctracer commit: f3df78f746]
 2024-10-10 06:59:50 -04:00
Pramendra Kumar f3df78f746 Revert "Adding rocm-llvm-dev package as req." 
This reverts commit b42028fcc0.

Reason for revert: <Imapcting driver install to QA due to timeout>

Change-Id: If5d98341e9ac3e803965064e3f5dc435b9310a0b
 2024-10-10 06:59:50 -04:00
Gopesh Bhardwaj 00a28487fe Adding Node-id for debugging with log level trace (#1090) 
[ROCm/rocprofiler-sdk commit: 8ab1ed78d8]
 2024-10-10 11:00:28 +05:30
Gopesh Bhardwaj 8ab1ed78d8 Adding Node-id for debugging with log level trace (#1090) 2024-10-10 11:00:28 +05:30
adapryor e20bc58b1c Add XGMI read/write sum metrics 
Change-Id: I898b779ea7f5336edf0d047fb1e5d3ec40085baa
 2024-10-09 17:02:55 -05:00
Kent Russell ccd80d19ba kfdtest: Fix in-tree scriptless build 
If you build thunk following the instructions in the thunk's README,
there is no /lib folder in the build folder. Adjust the include path,
and clean up the docs to reflect that. The header include is already
defined in the CMake file as ../../include, so we don't use
LIBHSAKMT_PATH for that linking, just the lib location

Change-Id: I73435d59adb9d01f527a28b1935086260e9d3d70
Signed-off-by: Kent Russell <kent.russell@amd.com>
 2024-10-08 14:42:33 -04:00
Gopesh Bhardwaj b426c65c43 mem copy direction field update (#1124) 
[ROCm/rocprofiler-sdk commit: 81e93a6ddb]
 2024-10-08 15:15:48 +05:30
Gopesh Bhardwaj 81e93a6ddb mem copy direction field update (#1124) 2024-10-08 15:15:48 +05:30
Benjamin Welton c69cb447ee clang-18 build fix for RCCL (#1123) 
Removes ambiguity on const usage, which clang-18 complains about
(preventing build with warn error).

[ROCm/rocprofiler-sdk commit: b46966e96b]
 2024-10-07 15:58:41 -07:00
Benjamin Welton b46966e96b clang-18 build fix for RCCL (#1123) 
Removes ambiguity on const usage, which clang-18 complains about
(preventing build with warn error).
 2024-10-07 15:58:41 -07:00
Mythreya cbf61d5a66 Fix PSDB change (#1120) 
Reverts change to `source/include/rocprofiler-sdk/callback_tracing.h`
from commit c77e4d3b80

[ROCm/rocprofiler-sdk commit: a3b41d04fc]
 2024-10-07 17:37:19 -05:00
Mythreya a3b41d04fc Fix PSDB change (#1120) 
Reverts change to `source/include/rocprofiler-sdk/callback_tracing.h`
from commit 9b2ece76c3
 2024-10-07 17:37:19 -05:00
Giovanni Lenzi Baraldi 6361ff50a5 SWDEV-487621: Fixes for metric definitions (#1118) 
* Fixes for metric definitions

* Removing gfx8

* Update changelog

* Fixing unit tests

* Small fixes

* Fix for write size

[ROCm/rocprofiler-sdk commit: 9652a6e738]
 2024-10-08 02:44:31 +05:30
Giovanni Lenzi Baraldi 9652a6e738 SWDEV-487621: Fixes for metric definitions (#1118) 
* Fixes for metric definitions

* Removing gfx8

* Update changelog

* Fixing unit tests

* Small fixes

* Fix for write size
 2024-10-08 02:44:31 +05:30
Giovanni Lenzi Baraldi 43684c07c6 SWDEV-488948: PC Sampling - Correlation class to provide some thread safety. Adding multithread tests. (#1112) 
* SWDEV-488948: PC Sampling - Correlation class to provide some thread safety. Adding multithread tests.

* Update source/lib/rocprofiler-sdk/pc_sampling/parser/correlation.hpp

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

* Update source/lib/rocprofiler-sdk/pc_sampling/parser/correlation.hpp

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

* Adding backlog for codeobj changes

* Formatting

* Update source/lib/rocprofiler-sdk/pc_sampling/code_object.hpp

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

* Update source/lib/rocprofiler-sdk/pc_sampling/code_object.hpp

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

---------

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

[ROCm/rocprofiler-sdk commit: a6be3f9660]
 2024-10-07 20:00:59 +00:00
Giovanni Lenzi Baraldi a6be3f9660 SWDEV-488948: PC Sampling - Correlation class to provide some thread safety. Adding multithread tests. (#1112) 
* SWDEV-488948: PC Sampling - Correlation class to provide some thread safety. Adding multithread tests.

* Update source/lib/rocprofiler-sdk/pc_sampling/parser/correlation.hpp

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

* Update source/lib/rocprofiler-sdk/pc_sampling/parser/correlation.hpp

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

* Adding backlog for codeobj changes

* Formatting

* Update source/lib/rocprofiler-sdk/pc_sampling/code_object.hpp

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

* Update source/lib/rocprofiler-sdk/pc_sampling/code_object.hpp

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

---------

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>
 2024-10-07 20:00:59 +00:00
vstempen a83747166a Documented Docker container OpenSSL abilities being affected by Host network proxy services (#440) 
* Documented Docker container OpenSSL abilities being affected by host
network proxy services, causing network certificates verification
problem during Docker container build stage of Grafana server setup.

Signed-off-by: Vladimir Stempen <vladimir.stempen@amd.com>

* Update docs/install/grafana-setup.rst

Co-authored-by: Peter Park <peter.park@amd.com>
Signed-off-by: vstempen <147086176+vstempen@users.noreply.github.com>

---------

Signed-off-by: Vladimir Stempen <vladimir.stempen@amd.com>
Signed-off-by: vstempen <147086176+vstempen@users.noreply.github.com>
Co-authored-by: Peter Park <peter.park@amd.com>

[ROCm/rocprofiler-compute commit: ba94cb8370]
 2024-10-07 15:53:48 -04:00
vstempen ba94cb8370 Documented Docker container OpenSSL abilities being affected by Host network proxy services (#440) 
* Documented Docker container OpenSSL abilities being affected by host
network proxy services, causing network certificates verification
problem during Docker container build stage of Grafana server setup.

Signed-off-by: Vladimir Stempen <vladimir.stempen@amd.com>

* Update docs/install/grafana-setup.rst

Co-authored-by: Peter Park <peter.park@amd.com>
Signed-off-by: vstempen <147086176+vstempen@users.noreply.github.com>

---------

Signed-off-by: Vladimir Stempen <vladimir.stempen@amd.com>
Signed-off-by: vstempen <147086176+vstempen@users.noreply.github.com>
Co-authored-by: Peter Park <peter.park@amd.com>
 2024-10-07 15:53:48 -04:00
Giovanni LB bddd5b51dd SWDEV-487621: Fixing BW measurement in MI300 
Change-Id: Ib513009616214a1f3f3568571e58d79259692cfc
 2024-10-07 16:29:09 -03:00
Giovanni LB 8b22cf86a7 SWDEV-487621: Fixing BW measurement in MI300 
Change-Id: Ib513009616214a1f3f3568571e58d79259692cfc


[ROCm/rocprofiler commit: bddd5b51dd]
 2024-10-07 16:29:09 -03:00
Shweta Khatri 8bc4efc8ca hsakmt: pmc_table.c: Fix Coverity reported warnings 
Eliminate out-of-bounds access in get_block_properties

Change-Id: I3abee1e36fafdda053d4bc4a611698d676b01d5c
 2024-10-07 14:15:26 -04:00
Shweta Khatri 52e7fd1480 hsakmt: debug.c: Fix Coverity reported warnings 
Fix potential  memory leak reported by Coverity warnings

Change-Id: Iacbaa99be3f4fe7fae5fb6a10bd41dfc34b96059
 2024-10-07 14:14:26 -04:00
Shweta Khatri c9454794b6 hsakmt: fmm.c: Fix Coverity reported warnings 
Fixed multiple issues related to memory management, atomicity,
and error handling across various functions: handle null checks,
use-after-free, unchecked returns, and memory leaks.

Change-Id: Ia7c76320cc20e24001052fbba2dd0600bd412140
 2024-10-07 13:54:03 -04:00
Giovanni LB dfa81b0cab Fix for s_delay_alu followed by s_waitcnt on gfx11 
Change-Id: I3254ee80a0a5542467da5c61cf60f9e27aab9a36
 2024-10-07 14:11:24 -03:00
Giovanni LB 6f37da626f Fix for s_delay_alu followed by s_waitcnt on gfx11 
Change-Id: I3254ee80a0a5542467da5c61cf60f9e27aab9a36


[ROCm/rocprofiler commit: dfa81b0cab]
 2024-10-07 14:11:24 -03:00
Gopesh Bhardwaj c77e4d3b80 Fixing installed pacakge tests in CI (#1119) 
* Fixing installed pacakge tests in CI

* Formatted rocprofv3.py with black formatter

[ROCm/rocprofiler-sdk commit: 9b2ece76c3]
 2024-10-07 20:55:35 +05:30
Gopesh Bhardwaj 9b2ece76c3 Fixing installed pacakge tests in CI (#1119) 
* Fixing installed pacakge tests in CI

* Formatted rocprofv3.py with black formatter
 2024-10-07 20:55:35 +05:30
Gopesh Bhardwaj 0b356e16aa updating rocprofv3 help options (#1113) 
* updating rocprofv3 help options

* updating CHANGELOG

[ROCm/rocprofiler-sdk commit: f2f267bcc0]
 2024-10-05 12:40:27 +05:30
Gopesh Bhardwaj f2f267bcc0 updating rocprofv3 help options (#1113) 
* updating rocprofv3 help options

* updating CHANGELOG
 2024-10-05 12:40:27 +05:30
David Yat Sin dbae8da515 rocr: Fix memory leak on non-visible GPUs 
Fix memory leak for memory regions objects when GPU is masked using
ROCR_VISIBLE_DEVICES.

Change-Id: I610842a18adbc3cdc854b12650844e271bc00592
 2024-10-04 17:40:47 -04:00
Peter Park c444ba6131 Update documentation requirements (#402) (#5) 
* Bump rocm-docs-core to 1.8.2

* Remove empty package-ecosystem in dependabot

Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com>

[ROCm/rocprofiler-systems commit: dc63370a1f]
 2024-10-04 15:27:02 -04:00
Peter Park dc63370a1f Update documentation requirements (#402) (#5) 
* Bump rocm-docs-core to 1.8.2

* Remove empty package-ecosystem in dependabot

Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com>
 2024-10-04 15:27:02 -04:00
Jonathan Kim 0ae064fe2d rocr: Use new extended graphics handle registration call on IPC import 
To correctly map to all GPUs after an import, use the new extended
registration call that can import a virtual address without having to
specify a target node.

Change-Id: Ifca8f6f6ee24fa99b2af357dcc3ea1de3ab234f7
 2024-10-03 14:06:37 -04:00
Jonathan Kim 03463ed2c0 hsakmt: Enable graphics handle registration with a virtual address 
Currently registering graphics memory without specifying a target
node will return a memory handle that's not a virtual address.

As a result, ROCr is forced to register with a target node for
IPC usage.

Mapping memory without specifying a target node afterwards will
result in mapping to the target node that was imported because the
previous import call flags this node targeting action to future mapping.

For ROCr IPC usage, ROCr wants to map to all GPU nodes if the target node
is not specified.

Allow the caller to register graphics handles that returns a virtual
address without having to specify the target node so that the caller
can make a subsequent map call to all GPUs.

Change-Id: I5a935092b885cc3568e4f3a5dd951c7ec6c84fca
 2024-10-03 14:06:31 -04:00
Giovanni Lenzi Baraldi 9038cfac07 Fixing some accumulate metrics (#1089) 
* Fixing some accumulate metrics

* Fixing some more accumulate metrics

---------

Co-authored-by: Benjamin Welton <bewelton@amd.com>

[ROCm/rocprofiler-sdk commit: fa7fc7ec5d]
 2024-10-03 09:44:31 -07:00
Giovanni Lenzi Baraldi fa7fc7ec5d Fixing some accumulate metrics (#1089) 
* Fixing some accumulate metrics

* Fixing some more accumulate metrics

---------

Co-authored-by: Benjamin Welton <bewelton@amd.com>
 2024-10-03 09:44:31 -07:00
Giovanni Lenzi Baraldi dc85966562 SWDEV-467350: Skipping tool counter iteration for unsupported hardware (#1083) 
[ROCm/rocprofiler-sdk commit: 1d6a0b5c80]
 2024-10-03 09:04:42 -07:00
Giovanni Lenzi Baraldi 1d6a0b5c80 SWDEV-467350: Skipping tool counter iteration for unsupported hardware (#1083) 2024-10-03 09:04:42 -07:00
Ben Richard 4da8b0dc46 Skip output lines that have UTF8 decoding error (#441) 
* Avoid crash if non-UTF8 character is encountered in output

Signed-off-by: benrichard-amd <ben.richard@amd.com>

* Ignore lines with non-UTF-8 characters. Do not print error.

Signed-off-by: benrichard-amd <ben.richard@amd.com>

* Remove trailing whitespace

Signed-off-by: benrichard-amd <ben.richard@amd.com>

---------

Signed-off-by: benrichard-amd <ben.richard@amd.com>

[ROCm/rocprofiler-compute commit: fb210abcd0]
 2024-10-03 11:27:55 -04:00
Ben Richard fb210abcd0 Skip output lines that have UTF8 decoding error (#441) 
* Avoid crash if non-UTF8 character is encountered in output

Signed-off-by: benrichard-amd <ben.richard@amd.com>

* Ignore lines with non-UTF-8 characters. Do not print error.

Signed-off-by: benrichard-amd <ben.richard@amd.com>

* Remove trailing whitespace

Signed-off-by: benrichard-amd <ben.richard@amd.com>

---------

Signed-off-by: benrichard-amd <ben.richard@amd.com>
 2024-10-03 11:27:55 -04:00