Commit Graph

89 Commits

Author SHA1 Message Date
Aryan Salmanpour e5d5bd4abb Return an error if the ExportSurface function fails. Add extra error logging in the destructor of the VaapiVideoDecoder class (#87) 2023-11-27 13:08:34 -05:00
jeffqjiangNew 624c3c0f09 End of stream flush (#86)
* * rocDecode/HEVC: Added picture output operation in DPB and display callback function.
  - To avoid serialization of decode submissions and/or display callback in certain cases, increased DPB buffer size by 1 and tweaked picture bumping procedure.

* * rocDecode/HEVC: Added flushing of the remaining pictures from DPB at the end of decode session.

* * rocDecode/HEVC: Changed output_pic_num to num_output_pics to void some confusion. Set top_field_first to 1.

* * rocDecode/HEVC: Added a few return error checks.
2023-11-27 13:03:26 -05:00
Aryan Salmanpour 8898af78a6 D not fuse - zwhen runnnin gthesmake test. Don't force b_force_latency ofr Perf/Fork sample (#85) 2023-11-27 12:33:28 -05:00
jeffqjiangNew 57c040eff8 Added picture output operation in DPB and display callback function. (#83)
* * rocDecode/HEVC: Added picture output operation in DPB and display callback function.
  - To avoid serialization of decode submissions and/or display callback in certain cases, increased DPB buffer size by 1 and tweaked picture bumping procedure.

* * rocDecode/HEVC: Added a few error checks and minor format changes.
2023-11-27 11:04:01 -05:00
Kiriti Gowda 90e6d30383 Package - updates (#81)
* Package - updates

* Package - Info
2023-11-23 08:57:45 -05:00
Aryan Salmanpour a8e39c95c9 Fix a bug in VideoDecodePerf app to cepturn he number of decoded frames (#82) 2023-11-22 17:35:52 -05:00
Kiriti Gowda e2f7e47bb3 Documentation - ReadtheDocs
Add configuration for ReadtheDocs
2023-11-21 14:46:20 -08:00
Sam Wu 3f7e3fe7d8 Add configuration for ReadtheDocs 2023-11-21 13:25:56 -07:00
jeffqjiangNew ad186a90da Re-enabled SEI message processing. (#79)
* * rocDecode/HEVC: Re-enabled SEI message processing.
  - Added "-sei" command option to extract SEI messages from stream.
  - Added support for SEI info parsing for multiple SEI NAL units with multiple payloads.
  - Fixed a SEI syntax parsing issue and several procssing issues.
  - Fixed a double free memory issue in SEI data buffer handling in HandlePictureDisplay().

* * rocDecode/HEVC: Coding format changes.

* * rocDecode/HEVC: Minor format changes.
2023-11-21 14:33:15 -05:00
Rajy Rawther 012f96c8c5 Rr/check sei function pointer (#78)
* commending out ParseSeiMessage because it is causing segfault

* CMake changes for valgrind

* added function pointer validity for sei callback

* fix review comments
2023-11-21 11:23:47 -05:00
Rajy Rawther 628e1d2610 rr: Add debug flags for valgrind (#77)
* commending out ParseSeiMessage because it is causing segfault

* CMake changes for valgrind
2023-11-20 12:07:13 -05:00
Rajy Rawther 210976616f commending out ParseSeiMessage because it is causing segfault (#76) 2023-11-17 20:56:05 -05:00
Rajy Rawther cbf6857f74 Rr/parser clean up (#75)
* minor clean_up on parser struct allocation

* minor clean_up

* address review comments
2023-11-17 20:55:53 -05:00
Rajy Rawther 81abe58fb4 Rr/vaapi decoder mem check (#74)
* add some checks for buffer requirements

* address review comments
2023-11-17 17:33:12 -05:00
jeffqjiangNew c528f46843 * rocDecode/HEVC: Removed parsing of entry_point_offset_minus1[] and beyond in slice header since these syntax elements are not used by HW decode. (#73) 2023-11-17 15:59:29 -05:00
jeffqjiangNew b6d0c41a59 * rocDecode/HEVC: Fixed the segmentation fault at the end of decode session on stream chimei_demo_1080p_h265_60fps.mp4 or similar streams. (#72)
Root cause: num_entry_point_offsets in the slice header of frame #2164 is 674, exceeding the entry_point_offset_minus1[440] array size. Parser writes beyond the array boundary, corrupting memory. Frame #2164 is not in conformance of the HEVC spec.

We need to put the constraint from the spec on the num_entry_point_offsets parsed from the stream. Also need to change the array size to the max possible for 8K.
2023-11-17 12:57:19 -05:00
Aryan Salmanpour 071b37b3bd Code clean up - remove unused headers from demuxer, unused ffmpeg dependencies, and redundent info from videodecode sample (#71) 2023-11-17 12:46:27 -05:00
Kiriti Gowda b94b4f7947 Dev Package - Add FFMPEG Deps (#70)
* Dev Package - Add FFMPEG Deps

* Print Deps

* Deps Fix

* CI - Package Details
2023-11-16 16:34:47 -05:00
Aryan Salmanpour 5d5db9a017 Add additional debug info if we couldn't find the matching pic in reference list and return error (#69)
* Add additional debug info if we couldn't find the matching pic in refrence list and return error

* Correct the debug info message
2023-11-16 12:39:23 -05:00
Aryan Salmanpour 28c86ba813 update the videodecode sample to call GetFrame/ReleaseFrame regradless of dumping frames (#68) 2023-11-16 12:08:15 -05:00
Kiriti Gowda f67f9033c8 rocDecode - runtime, dev, ASAN package (#52)
* rocDecode - runtime, dev, ASAN

* Package - Updates & cleanup

* Package - Fix

* Package - Deps Info

* rocDecode - Package Depends Cleanup

* CI - Verify Runtime & Dev Packages

* Jenkins - Save all built packages

* Jenkins - Groovy Updates

* Package - Cleanup

* CMakeList - updates

* CI - save all packages

* CI - Save Test Logs
2023-11-15 21:32:10 -05:00
jeffqjiangNew 69c2243c9c IRAP POC calculation fix. (#66)
* * rocDecode/HEVC: Fixed a bug in IRAP picture order count calculation. Added a few picture type check utilities.

* * rocDecode/HEVC: Minor coding style changes. No functional changes.
2023-11-15 16:07:18 -05:00
Aryan Salmanpour 851c537904 code cleanup - use google style for videodecode sample and RocVideoDecoder class - no functional change (#65)
* code cleanup - use google style for videodecode sample and RocVideoDecoder class - no functional change

* rename SaveSurfToFile to SaveFrameToFile
2023-11-15 15:49:16 -05:00
Rajy Rawther a4652d6a53 Rr/fix output surface dims (#64)
* fix output surface dimensions

* fix bug
2023-11-15 13:46:37 -05:00
Aryan Salmanpour c44a000c73 Update the make test and Readme by removing the H.264 (#63) 2023-11-15 10:57:55 -05:00
jeffqjiangNew 1d4f038695 Do not set up slice ref list for intra frames for VAAPI calls. (#62)
* * rocDecode/HEVC: Do not set up slice ref list for intra frames.

* *rocDecode/HEVC: Condensed slice type check code. No functionaly changes.
2023-11-14 15:44:35 -05:00
jeffqjiangNew 3357aba104 * rocDecode/HEVC: Fixed a few issues in reference list setup. Also looks like we need to use VA surface IDs on all buffers including the reference (need to confirm with VA driver team). (#61) 2023-11-14 11:42:13 -05:00
Aryan Salmanpour 592426595e Fix a seg fault when saving a frame in SaveSurfToFile (#60) 2023-11-13 14:38:29 -05:00
Rajy Rawther d163eb1764 Rr/add low latency (#59)
* added picture_index associated with frame and fixed bug

* added option to force low_latency display

* add force_zero_latency option for videodecode sample
2023-11-13 13:53:19 -05:00
Aryan Salmanpour eb5614d250 Add support for the rocDecUnMapVideoFrame API (#58) 2023-11-13 12:54:32 -05:00
Rajy Rawther ddded3a6d2 added picture_index associated with frame and fixed bug (#56) 2023-11-13 12:22:22 -05:00
Aryan Salmanpour 730b80b600 Close fds after importing the surVAAPI face to HIP memory (#55) 2023-11-10 18:24:21 -05:00
jeffqjiangNew 3c7f29dab4 Added picture decode submission to VA-API driver. (#54)
* * rocDeocde/HEVC: Added several "reserved" fields to structs to match the corresponding VA-API structs.

* * rocDecode/HEVC: Added decode submission to VA-API driver.

* * rocDecode/HEVC: Corrected data buffer id type.
2023-11-10 17:15:47 -05:00
Aryan Salmanpour 7a90c0c054 Add support for rocDecMapVideoFrame API (#53) 2023-11-10 17:02:57 -05:00
Rajy Rawther 55ebf353cc fix exception handling to gracefully exit (#49)
* fix exception handling to gracefully exit

* addressed review comments
2023-11-10 15:44:40 -05:00
Lakshmi Kumar 146d243f69 Add a sample for measuring the video decoding performance using multi-forks (#51)
* fork example

* review comments

* change logic to find vcn
2023-11-10 11:28:24 -05:00
Lakshmi Kumar 5bac02fab3 Add a sample for measuring the video decoding performance using multi-threads (#50)
* introducing perf example

* chnages for google standards

* adding exception handling

* review comments

* change logic to find vcn devices

* adding comments
2023-11-10 11:23:44 -05:00
jeffqjiangNew 80845837af * rocDecode/HEVC: Fixed a regression introduced by PR#30. We should not abort parsing when we see NAL unit types that we are not interested in. Instead, we should just ignore and continue. (#48) 2023-11-09 14:57:22 -05:00
jeffqjiangNew 8ed03b5ad0 Decode callback implementation step 3: completion. (#47)
* * rocDecode/HEVC: Filled HEVC picture parameter structures for decode callback. Added some missing inferences in tile size and weighted prediction table parsing.

* * rocDecode/HEVC: Changed CurrPicIdx assignment from POC to pic_idx.

* * rocDecode/HEVC: Rmoved one TODO comment, which has been done.

* * rocDecode/HEVC: Corrected two typos in comment.

* * rocDecode/HEVC: No need to set up scaling lists in decode callback when scaling list is not enabled.
2023-11-09 13:52:02 -05:00
Aryan Salmanpour 6ab31ce40e Add support for rocDecGetDecodeStatus API (#46) 2023-11-09 08:47:58 -05:00
Aryan Salmanpour 9afec26af0 Return an error if the video parser creation fails (#45) 2023-11-08 11:54:35 -05:00
Aryan Salmanpour 3a5fc3608b Add support to GetDecoderCaps to correctly return decoder caps for gfx arch names with a suffix (#43) 2023-11-08 10:25:45 -05:00
Aryan Salmanpour ecbd787e4a Add nullptr check for parser APIs before dereferencing the parser's handle (#44) 2023-11-08 10:18:17 -05:00
Aryan Salmanpour 2c940dd9d0 Add support for creating a vaapi context and surfaces for decoding (#41) 2023-11-07 13:47:53 -05:00
Aryan Salmanpour ba484a91a9 Create the correct render node names on MI300A/MI300X (#38) 2023-11-07 11:08:20 -05:00
jeffqjiangNew 2f64a10c5a * rocDecode/HEVC: Updated RocdecPicParams structure to align with VA-API. (#40) 2023-11-06 22:06:03 -05:00
jeffqjiangNew f56a64d832 Decode callback step 1: Added skeleton decode callback to get the flow going. (#39)
* * rocDecode/HEVC: Added skeleton decode callback to get the flow going.

* *rocDecode/HEVC: Added error handling for decode call.
2023-11-06 22:04:25 -05:00
Kiriti Gowda b351972fb0 Documentation - readme updates
Update README
2023-11-06 10:49:10 -08:00
Aryan cefdfb7405 Update README 2023-11-06 12:10:12 -05:00
Kiriti Gowda d34d85027c FFMPEG - Updates (#33)
* FFMPEG - Updates

* Readme - Updates

* Sample - Install

* Install Sample Deps

* Samples - Updates

* Sample - Added missing header
2023-11-06 11:51:47 -05:00