SWDEV-215533 - [HIP][Windows]Output mismatch with tex3D()
When calculating the pitch for hipMallocPitch() align it to the device's image pitch alignment. If we don't, PAL backend will overalign the pitch when creating an image buffer.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/18496/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#96 edit
=> New ROCr calculates pitch as per HSA specification and addrlib is used to check whether HW can support that configuration. Hence few texture tests are failing with HSA_EXT_STATUS_ERROR_IMAGE_PITCH_UNSUPPORTED.
=> Determine pitch for linear images and always pass rowpitch to HSA API's.
SWDEV-219341 - Free memory correctly. hiprtcProgram is a pointer by itself. So release *prog
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#10 edit
SWDEV-205925 - Update HIP texture APIs for issue in hipTexRefSetAddress in HIP/PAL on Windows
-Update HIP texture function parameter to use hipChannelFormatDesc& desc
http://ocltc.amd.com/reviews/r/18456/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#33 edit
The randomly generated offset+width may exceeds 32, which causes
a left shift operation with 32-offset-width. As an unsigned number
that is greater than 32 and causes undefined behavior. When the
test is compiled without -mavx it is still OK. However when
the test is compiled with -mavx, the undefined behavior causes
wrong results and test failure.
This patch adjusts width so that offset+width<=32 always.
Fixes SWDEV-218626 and SWDEV-218629
Changes:
- Revert "`static inline` in a header, just like excess sugar in a diet, causes bloat (#1692)"
This reverts commit be70b9f7e7.
- Revert "Fix rocFFT build failure (#1777)"
This reverts commit 753277422a.
SWDEV-215533 - [HIP][Windows]Output mismatch with tex3D()
1. Implement hipMemcpy3DAsync().
2. Add logic in hipMemcpy3D() to determine based on src/dst parameters if the user intended on calling cudaMemcpy3D() or cuMemcpy3D().
ReviewBoardURL = http://ocltc.amd.com/reviews/r/18444/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#38 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#36 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#95 edit
* Fix hipcc warning related to hipVersion
* Rename hipVersion.h to hip_version.h
* Remove HIP_VERSION splitting
* Update .gitignore
- Ignore generated include/hip/hip_version.h
- Removed some stale entries
- Added executables from samples/1_Utils/*/ for consistency with bin/ entries.
SWDEV-213000 - Backout change to notifyCmdQueue as the real issue has been identified
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#53 edit
HIP_VERSION_MAJOR, HIP_VERSION_MINOR, HIP_VERSION_PATCH and HIP_VERSION pre-processor macros are now defined in hipVersion.h instead of being set by hipcc.
This PR is a follow-up on PR# #1698 and it makes two more APIs (hipLaunchCooperativeKernel/hipLaunchCooperativeKernelMultiDevice) inline so that they can work correctly with lazy binding.
SWDEV-151670: Issue with 3D texture with 4 components
SWDEV-151671: Issue with 2D layered texture with 4 components
Fixed memcpy when memory is allocated with driver API's.
Github issues: #1755
Fixed 3D default case when array type is not set during memory allocation.
SWDEV-203814 - Change the return type of the hiprtcGetTypeName to have compatibility across ABIs
ReviewBoardURL = http://ocltc.amd.com/reviews/r/18392/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#9 edit
Laurent Morichetti
foreman
Jenkins
paulfreddy
Evgeny Mankov
ansurya
kpyzhov
Aakanksha Patil
Jatin Chaudhary
Yaxun (Sam) Liu
Maneesh Gupta
Siu Chi Chan
satyanveshd
Rick Ho
Rahul Garg
Sarbojit2019
Aryan Salmanpour
saleelk
Alex Voicu