SWDEV-218016 - There is a bug in the OCL/DX interop
- Initialize event query value to FALSE and correct the loop condition to make sure query waits for the end.
http://ocltc.amd.com/reviews/r/18447/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_d3d10.cpp#18 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_d3d11.cpp#28 edit
SWDEV-207835 - Implement uniform package versioning for cmake version of OpenCL.
Need to generate the same style of packages name as the Makefile version does.
Affected files ...
... //depot/stg/opencl/drivers/opencl/CMakeLists.txt#29 edit
SWDEV-198863 - Options for hip-clang-vdi path to provide the chicken bits, or functional equivalents to HCC_DB (phase 1)
1. The log macros is turned off for release build. So log functions has zero impact to release build.
2. The log macros have level, mask, condition control. So we can have more control to avoid log flooding.
I also adjusted some existing log to use new log functions.
1. To excercise and test the new log functions.
2. To improve performance slightly.
3. The change is mainly for HIP-ROCM, we can move more in next phases for PAL or ORCA.
4. I make these log feature unavailable for release build. We can revert to old log functions for release build in a case by case method.
Tests:
1. http://ocltc.amd.com:8111/viewModification.html?modId=128289&personal=true&tab=vcsModificationBuildshttp://ocltc.amd.com:8111/viewModification.html?modId=128358&personal=true&tab=vcsModificationBuilds
2. release build, run hip program, there is no log
3. fastdebug build, run hip program,
export LOG_LEVEL=3
export GPU_LOG_MASK=4294967295
There was a lot of logs.
4. fastdebug build, run hip program,
export LOG_LEVEL=2
export GPU_LOG_MASK=4294967295
There was no logs.
5. fastdebug build, run hip program,
export LOG_LEVEL=3
export GPU_LOG_MASK=4294967294
There was much less logs.
6. fastdebug build, run hip program,
export LOG_LEVEL=3
export GPU_LOG_MASK=47102
There was even much less logs. The logs was expected according to the mask.
7. Tested step 2 to 6 similarily in Windows and Linux
ReviewBoard: http://ocltc.amd.com/reviews/r/18215
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#46 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#82 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#26 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hiprtc_internal.hpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_svm.cpp#29 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/comgrctx.cpp#6 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devkernel.cpp#29 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.cpp#68 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#137 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.cpp#91 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.cpp#100 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/commandqueue.cpp#32 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/runtime.cpp#40 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/debug.hpp#10 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#323 edit
SWDEV-79445 - Don't use amdgizcl. This has been unnecessary for a long time.
Affected files ...
... //depot/stg/opencl/drivers/opencl/CMakeLists.txt#23 edit
SWDEV-79445 - OCL generic changes and code clean-up
1. Fill out out NULL entries in the cltrace dispatch table with original api calls.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/17691/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_icd_amd.h#21 edit
... //depot/stg/opencl/drivers/opencl/tools/cltrace/cltrace.cpp#16 edit
SWDEV-79445 - OCL generic changes and code clean-up
1. Don't modify user passed arguments that should be constant. This saves sanity when debugging.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/17567/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_program.cpp#52 edit
SWDEV-189012 - Fix Reg entry from REG_MULTI_SZ to REG_SZ to conform to Khronos standard. The installer has to be fixed next
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/opencl/khronos/icd/icd_windows_dxgk.c#5 edit
SWDEV-185452 - Offline compilation failing on a VM, producing error CL_PLATFORM_NOT_FOUND_KHR
1. Don't load a platform if there are no devices available for it. If there is no platform that has visible devices, only allow the PAL platform to load.
ReviewBoardURL = http://ocltc.amd.com/reviews/r/17419/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_icd.cpp#34 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.cpp#19 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#309 edit
SWDEV-189012 - Fix Reg entry from REG_MULTI_SZ to REG_SZ to conform to Khronos standard. The installer has to be fixed next
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/opencl/khronos/icd/icd_windows_hkr.c#3 edit
SWDEV-190565 - [HIP] Don't use clSetEventWaitList and just add the event to the list in HIP.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#10 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_common.hpp#24 edit
SWDEV-189140 - Add P2P support in PAL path
- PAL requires P2P resource open on the usage device. Add the new interface to open the resource
- Add a hidden P2P device object creation into amd::Memory. It can be activated with OCL context that has a single device.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_p2p_amd.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#337 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#134 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palmemory.cpp#25 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.cpp#74 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palresource.hpp#28 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palsettings.cpp#80 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palsettings.hpp#23 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#133 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#126 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.cpp#93 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/memory.cpp#136 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/memory.hpp#109 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#306 edit
SWDEV-182808 - Prevent ICD from loading outdated amdocl binary
1. Keep track of library name in KHRicdVendorRec
2. Check if library with the same name has already been loaded before adding it in ICD list
http://ocltc.amd.com/reviews/r/16989/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/opencl/khronos/icd/icd.c#12 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/khronos/icd/icd.h#11 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/khronos/icd/icd_linux.c#11 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/khronos/icd/icd_windows.c#11 edit
SWDEV-165960 - Add check for duplicate vendors of different libraries using vendor suffix after vendor info is loaded from library
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/opencl/khronos/icd/icd.c#11 edit
SWDEV-125823 - Use ccache if ROCM_OPENCL_CCACHE_BUILD=ON
This is a preparation for enabling ccache in our Jenkins jobs.
Change-Id: I3d0ae3fbf0f14afdd828fc51120f24b130ee105d
Reviewed and tested: http://git.amd.com:8080/c/compute/ec/opencl/+/208573
Affected files ...
... //depot/stg/opencl/drivers/opencl/CMakeLists.txt#22 edit
SWDEV-79445 - OCL generic changes and code clean-up
- Separate DVR and Adobe interop paths for RGB101010 format
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_gl.cpp#63 edit
SWDEV-79445 - OCL generic changes and code clean-up
- Add 101010 GL interop formats mapping into CL_RGBA. The change will make sure the channel order consistency between OGL and OCL
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_gl.cpp#62 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldefs.hpp#47 edit
SWDEV-171895 - No Video playback while 10 bit pixel format is enable
- Add GL_RGB10_EXT recognition. The format isn't officially supported in the Khronos OCL specification for GL interop. Thus GL_RGB10_EXT doesn't have any test coverage.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_gl.cpp#61 edit
SWDEV-165756 - [ROCm] Backport cmake back into perforce to resolve cmake build broken issue
(Resubmitted CL1613181 with a bug fix)
- porting CMAKE changes in http://git.amd.com:8080/#/c/173995/
- add new source file names in runtime/CMakeLists.txt
-- required additional changes of CMAKE files from Konstantin to build the current OCL driver using CMAKE
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/CMakeLists.txt#17 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/libUtils.cpp#34 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/libUtils.h#34 edit
... //depot/stg/opencl/drivers/opencl/runtime/CMakeLists.txt#13 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/CMakeLists.txt#15 edit
SWDEV-165756 - [ROCm] Backport cmake back into perforce to resolve cmake build broken issue
- porting CMAKE changes in http://git.amd.com:8080/#/c/173995/
- add new source file names in runtime/CMakeLists.txt
-- required additional changes of CMAKE files from Konstantin to build the current OCL driver using CMAKE
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/CMakeLists.txt#15 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/libUtils.cpp#32 edit
... //depot/stg/opencl/drivers/opencl/compiler/lib/utils/v0_8/libUtils.h#32 edit
... //depot/stg/opencl/drivers/opencl/runtime/CMakeLists.txt#11 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/CMakeLists.txt#13 edit
SWDEV-1 - Also catch clGetPlatformIDs error, so clinfo won't get a page fault when no platform is found.
Instead clinfo now shows:
ERROR: clGetPlatformIDs(-1001)
Affected files ...
... //depot/stg/opencl/drivers/opencl/tools/clinfo/clinfo.cpp#5 edit
Payam
German Andryeyev
Laurent Morichetti
foreman
foreman