Grafik Komit

5484 Melakukan

Penulis SHA1 Pesan Tanggal
jujiang e73e0d2fb3 SWDEV-241903-Add document HIP_logging.md
Change-Id: I348218218b305e845b7e26afaeb4e287bf0387de
2020-07-08 11:19:33 -04:00
Rahul Garg 27002fd792 Bump version to 3.7
Change-Id: Id077c317573e95833c8bc7f16951df776de2a273
2020-07-08 01:54:05 -04:00
Aryan Salmanpour 8f862becd0 add an error message before aborting if a wrong GPU target was used for compilation
Change-Id: I7b41e93d420dbc47978238a681f2956a0def01cb
2020-07-07 14:50:44 -04:00
Lakhan singh Thakur 18f8b15523 [dtest] Enhancing hipStreamAddCallback() api test
-Scenario-1:: This test case is used to verify if the callback function
              called through  hipStreamAddCallback() api completes the
	      execution in order as hipStreamAddCallback() api queued
	      in their respective streams: hipStreamACb_AltEnqueue.cpp
-Scenario-2:: This test case tests if Host thread continues with next
              command after hipStreamAddCallback() api or wait for
	      callback() call to finish. Ideally Host thread should not
              wait for callback to
              finish: hipStreamACb_ThrdBehaviour.cpp
-Scenario-3:: Streams are launched in individual GPUs with different
              kernel Verify that all the kernels queued are executed
	      before the callback is hit: hipStreamACb_MStrm_Mgpu.cpp
-Scenario-4:: Checks the callback execution in the same order it was
              added. Also, it checks if the number of callbacks
	      executed are same as the number of callbacks added:
	      hipStreamACb_order.cpp
-Scenario-5:: This test case checks whether hipStreamSynchronize() is
              taking less time than the time taken by Callback()
	      function launched by hipStreamAddCallback() api :
	      hipStreamACb_StrmSyncTiming.cpp
-Scenario-6:: This test case is used to check if the runtime is ok when
              hipStreamAddCallback() is called back to back multiple
	      calls: hipStreamACb_MultiCalls.cpp
-Scenario-7:: This test case is used to check the behaviour of HIP when
              multiple hipStreaAddCallback() are called over multiple
	      Threads:hipStreamACb_MultiThread.cpp
              (Currently disabled)

SWDEV-238517 for enhancing hip unit tests

Change-Id: I9c7b7df6766c728b2b201df18726b9fbdd434c06
2020-07-07 00:43:32 -04:00
Michael LIAO b39195b639 [hipcc] Only add -x hip on HIP-Clang compilation.
Change-Id: I19704c713ad00f92196d7586498e62f80b8cd177
2020-07-06 15:16:51 -04:00
Yaxun (Sam) Liu b72e8b54e0 Add pow(float/double/_Float16,int)
Change-Id: Ie65d15cd3df9853a3bbd613d8c7188ae39c327c7
2020-07-06 07:38:57 -04:00
Jatin Chaudhary 3173dbdec0 Fix error: cannot pass object of non-trivial type string through variadic function when building in debug mode
Change-Id: Idd55ed422addc815fb56c57b05bd4afa9563f2ac
2020-07-06 00:48:40 -04:00
Jason Tang c371b4e3b0 SWDEV-242879 - Not to use fixnames
Change-Id: I3d0e2f3fe6c773e020c8bf8cdfd75fd565d61505
2020-07-02 08:15:07 -04:00
kjayapra-amd 2f963728f7 SWDEV-236178 - Fixing func_attributes that was over written on redesign.
Change-Id: I157913ae4fa4a3a149817e901f10475b7750188b
2020-07-01 11:52:45 -04:00
German Andryeyev 11b7842f71 Remove hipMemcpyDeviceToDevice check.
There is hipMemcpyDefault that requires validation also.

Change-Id: I5ae0ffa1c023b7774547acbdc049b84a0c2cb4c5
2020-06-30 12:59:54 -04:00
Ronak Chauhan 133251a6e1 Support passing macros to hipLaunchKernelGGL
This makes hipLaunchKernelGGL take a variable argument list, that will be
expanded before being fed to hipLaunchKernelGGLInternal.

This is different from fb6bb04f03.

We try to accomodate the case when a kernel template has multiple
type parameters.

Change-Id: I87577d402c92b0f3b51e298f8293f4065e1f6de8
2020-06-30 10:44:55 -04:00
Daniil Fukalov 359ea4fcaf Add __attribute__((const)) to grid related functions declarations
This is cherrypick of Daniil Fukalov's PR https://github.com/ROCm-Developer-Tools/HIP/pull/2110
which has been committed to master branch.

Make declarations consistent with https://github.com/RadeonOpenCompute/ROCm-Device-Libs/blob/amd-stg-open/ockl/src/workitem.cl
Without the attribute these functions don't have "readnone" LLVM IR attribute. Without it some optimizations fails, e.g. Loop Invariant Code Motion doesn't hoist these calls out of a loop.

Change-Id: Idb599570d142152cc4f6a3c8986384ad7f0c4729
2020-06-29 13:33:18 -04:00
Cole Nelson 0b7703560a packaging/hip-rocclr.txt: multi-version install broken because of 'hip_rocclr'
Versioning understands 'hip-rocclr' not the deprecated 'hip_rocclr'.
Remove this.

Leaving Provides hip-hcc until package shifts settle down.

SWDEV-242143:

Change-Id: I489fa28dd1394625bc6016a3adda4f73d02da202
Signed-off-by: Cole Nelson <cole.nelson@amd.com>
2020-06-25 14:17:16 -04:00
rohit pathania c14e95741b [dtest] hipMemcpyWithStream API multithreaded test scenarios
1.hipMemcpyWithStream with one stream
2.hipMemcpyWithStream with two streams
3.hipMemcpyWithStream multiGPU with one stream
4.hipMemcpyWithStream with kind DtoH
5.hipMemcpyWithStream with HtoH
6.hipMemcpyWithStream with DtoD
7.hipMemcpyWithStream with Default kind
8.hipMemcpyWithStream with Default kind on same device
9.hipMemcpyWithStream with DtoD on same device

SWDEV-238517 for enhancing hip unit tests

Change-Id: I5f55a12bdd7c8d28fcb06db94a491c2ad5ee3004
2020-06-25 12:51:23 -04:00
Ronak Nilesh Chauhan b15e835d9e Revert "Support passing macros to hipLaunchKernelGGL"
This reverts commit fb6bb04f03.

Reason for revert: This patch breaks ROCPrim tests

Change-Id: Ib2235f719861c9f4317c33e86b6c1f8bc669cfd4
2020-06-24 04:28:46 -04:00
Evgeny c148adf362 HIP-PROF: fixing pointers tracing
Change-Id: Id2c35972e1d134012980c95a3649ddfdf9303494
2020-06-23 14:02:35 -04:00
kjayapra-amd a5c437c82e SWDEV-209747 - Staging Copy will not be supported in HIP, adjust test case accordingly.
Change-Id: Iad616ef3990d539cdb82bbd8a22ea2124f7abe50
2020-06-23 13:14:17 -04:00
agodavar 6a47458764 SWDEV-239297:hipMemset fix, getMemoryObject with unaligned ptr
Change-Id: I37b8139c5099d37b42f34d728a3d694fdf9cb55d
2020-06-23 08:56:09 -04:00
German Andryeyev 265d84bab9 Disable flush on marker
Change-Id: I04d0fd995fb4b29a6bc372e1543902a053017d6a
2020-06-22 13:27:39 -04:00
Tao Sang d536a661ac Fix static lib crashing issue
Initialize HIP_ENABLE_DEFERRED_LOADING = 1

Change-Id: I432ccf1926b953c4391fdd086cde7da2380962bb
2020-06-22 13:24:40 -04:00
Michael LIAO 41aedf5273 [hip] Disable assert workaround for HCC on HIP-Clang.
- HIP-Clang follows the standard assert definition by providing
  `__assert_fail`.  But, `assert` macro is added as an HCC-specific
  workaround due to the missing implementation. Only enable that on the
  HCC compilation to avoid unexpected behaviors on HIP-Clang
  compilation.

Change-Id: I1c9a707baff9b85c30faef58c52ebfe07e3fc3fc
2020-06-22 10:33:56 -04:00
Ronak Chauhan fb6bb04f03 Support passing macros to hipLaunchKernelGGL
This makes hipLaunchKernelGGL take a variable argument list, that will be
expanded before being fed to hipLaunchKernelGGLInternal.

Change-Id: Id76e2bf91acd5d68f56a24fc39f219f2eeb06d33
2020-06-22 04:35:29 -04:00
Tao Sang 71c64e98a0 Support numa policy set by user
Add hipHostMallocNumaUser flag to hipHostMalloc() in order to support
numa policy set by user.

Change-Id: I6d70ed539a5f97f27187f2242b68849c0e27e4d6
2020-06-19 21:23:58 -04:00
Vlad Sytchenko 81b15ed36e Correct texture element size calculations
hipChannelFormatDesc contains size of each channel in bits. There's 8 bits per byte, not 4, so we should divide by 8.

Change-Id: I38ae2d28ad54740823c98908ca2afecad0ba0183
2020-06-19 11:39:03 -04:00
Yaxun (Sam) Liu 2461135d8a Fix missing ldexp(float,int)
Change-Id: I2c1553407dfc26948d3ab7aa532eef42a0f6b204
2020-06-18 15:16:59 -04:00
rohit pathania 226c438559 [ dtest ] Added different test scenario with hipMemcpyWithStream
- Test with one, two streams
- Test Multi-gpu (one stream per gpu)
- Test D-D (on same device/different devices).  Can discover issues
  when devices are on same or different root complexes.
- Test H-D/Default

SWDEV-238517 for enhancing hip unit tests

Change-Id: I8031a7eebe2f9c8c0e0996e2c7accb09ac0b96d4
2020-06-18 10:31:01 -04:00
Vlad Sytchenko ba2d3fbbb3 Support creating textures from user ptr with offset
Change-Id: Ied0af9a842fc6ef067e068a9d89dde63ff5dfce1
2020-06-17 14:10:14 -04:00
Vlad Sytchenko 8db45328d9 Fix -Wsign-compare warnings
Change-Id: I874dc007ac657c25a72c6752c1a2da74c028a822
2020-06-17 11:20:45 -04:00
Jason Tang 8933c078f6 Add asicRevision
Change-Id: I59f3ad20b9bdadf77bd1e0725f7a401d7ad423a3
2020-06-16 17:54:20 -04:00
Tao Sang 63ce69224a Make hipHostMalloc() respect hipSetDevice()
Change-Id: I2410240f91b108c24597ee0fa7cf31e7b1f3ac5d
2020-06-15 23:20:09 -04:00
kjayapra-amd 2467e37f3f SWDEV-240589 - Remove guarantee @ __hipRegisterFunction flow for now.
Change-Id: Ic51e2a1f951ac7745c2bbd11cfd2b92521c6966a
2020-06-15 22:32:24 -04:00
Vlad Sytchenko 509a38f50c Enable the use of some warnings when building HIP-ROCclr
Similar to http://gerrit-git.amd.com/c/compute/ec/vdi/+/375385, except no -Wno-strict-aliasing.

With this change only two warnings show up during the build - -Wsign-compare and -Wmisleading-indentation.

Change-Id: Iffa436c65ab6312aeaa6def71ee6af38ed1b4a4e
2020-06-15 20:33:30 -04:00
German Andryeyev b182ad9574 Initial support for HIP managed memory
- Call the new ROCclr interfaces for HMM

Change-Id: I2cd1bf438f712a9e9e328340e7d0c025257ca6c1
2020-06-15 18:10:41 -04:00
Aryan Salmanpour 02c62165b8 expose five missing memcpy hip APIs
exposing the following hip APIs which have been previously implemented:

hipMemcpy2DFromArray
hipMemcpy2DFromArrayAsync
hipMemcpyAtoH
hipMemcpyHtoA
hipMemcpyParam2DAsync

Change-Id: I3f8635bd4265d2bf5aa2084f4eabb51f74fb18ba
2020-06-15 12:30:31 -04:00
kjayapra-amd 0b788c4c67 SWDEV-236178 - Store texture reference metadata for dynamically loaded modules.
Change-Id: I99ecc80da7e29c691341a01a09e4532972f1e3e5
2020-06-11 22:34:50 -04:00
kjayapra-amd 3fab381493 SWDEV-236178 - Remove __hip_pinned_shadow reference from dtests and add hipModuleUnload for all corresponding hipModuleLoad calls.
Change-Id: I405789b430ffbb8fccda1cebdb5d18e83a85c926
2020-06-11 22:34:36 -04:00
Rahul Garg 2d4b865d63 Addback __mbcnt_lo and __mbcnt_hi
Change-Id: Ic3facba2e2245461515799f6a17842da0f5d9933
2020-06-11 21:21:36 -04:00
Vlad Sytchenko e82e9355f2 Revert "Let hipcc not pass -mllvm option to HIP-Clang on Windows"
This reverts commit e796a1ed78.

Change-Id: If29906b9c63f03d6e51144f510d3a956d90935e8
2020-06-11 16:36:48 -04:00
kjayapra-amd 840347f0d0 SWDEV-236178 - Reorganizing Platform/Modules code for easy access.
Change-Id: Ie8920260ffc4ff01e44b48af8cec9ea5aed1aa9b
2020-06-11 10:11:20 -04:00
Siu Chi Chan 32f3374af9 fix uninitialized value in hipcc
Change-Id: I90b070c491f0efc328fcf97de0e111658ec772de
2020-06-10 16:07:51 -04:00
jujiang bb32492438 Fix for SWDEV-239415 to handle hipGetDevice properly while no GPU present
Change-Id: I252cbbf9a89fc76fe1be1fbb8f45778e96c70fb2
2020-06-10 14:18:56 -04:00
kjayapra-amd 9ff22151d2 SWDEV-231701 - Remove amd::memory->svm_ptr from MemObj, instead of the ptr to the object.
Change-Id: I5aab450a2320cfa5417c284e2a8454102df6f99d
2020-06-10 11:49:02 -04:00
Dittakavi Satyanvesh bb785840b9 SWDEV-236670 Address Eigen unit test failure by adding __host__ attribute to half2 functions
Change-Id: Ifdc852c30a1b3704871e0ee58cb7a55d3d37fc6e
2020-06-10 03:01:42 -04:00
Christophe Paquot 20ae4d709f Do not deferred stream creation now that we multiplex HW queues
SWDEV-239856

Change-Id: I156650faf832f86891f00ee167269509edd844ec
2020-06-09 19:16:25 -04:00
Yaxun (Sam) Liu 0a513d8a02 Fix include path and wrapper header
Currently std::complex and some other std functions require uses to
include hip_runtime.h before any other headers to work, which is not
reliable.

changes are made in clang to fix this issue:
https://reviews.llvm.org/D81176

which requires hipcc and HIP headers to make corresponding changes.

This patch will make sure the clang change will not break
HIP/ROCclr during this transition.

After the transition is done, we can remove explicitly setting
include path for HIP-Clang and HIP header in hipcc and hip config
cmake files and rely on clang driver to set it automatically.

Change-Id: I5d226861c2560ffa6c5ab17343a43cc378048061
2020-06-09 17:37:20 -04:00
jujiang 06c6951205 To fix a format in hip_porting_guide.md
Change-Id: I5faa4ec9b3d17625b7cb5cea86b9f44766b1cfa9
2020-06-09 13:14:52 -04:00
Rahul Garg 6aab5fa993 Bump version to 3.6
Change-Id: I739a7bd03a4ed102bbc7c2f60d108e20132f5423
2020-06-09 11:22:20 -04:00
Saleel Kudchadker fbba37070c Modify HIP_RETURN to print useful details
Change-Id: I23892c2d9a738b0298cdf24106d688a792937c73
2020-06-06 02:05:21 -04:00
kjayapra-amd ee2ff4bc5e SWDEV-239327 - Remove amd_mem_obj during unregistervar
Change-Id: I2130eaa21369b9634a9459680061138c61eaaaa4
2020-06-05 23:24:38 -04:00
kjayapra-amd 1dc24194a3 SWDEV-235295 - Move addDeviceProgram() to lazy loading
Change-Id: I8fe07e370e58844496e18c858bb528393556854f
2020-06-05 18:03:32 -04:00