Evgeny Mankov
e90a76a1ef
[HIPIFY][fix][ #211 ] Algorithm for explicit insert of hip include directive
...
If in source CUDA file main header (cuda_runtime.h or cuda.h) is not presented, corresponding HIP main header (hip_runtime.h) should be explicitly included in output hipified file.
[Algorithm]
1. If #pragma once is presented, HIP main header should be placed just after it;
2. Otherwise if any other (not CUDA main) header is presented, HIP main header should be placed just before it;
3. Otherwise HIP main header should be placed in the beginning of output file.
P.S.
There might be one more situation when #ifndef #define ... #endif guard for the entire file is presented (make sense for *.h, *.hpp, *.cuh files). In this case HIP main include should be placed just after such #ifdef, or after #pragma once, if it is also presented. This situation will be handled in a separate change.
2018-01-15 21:05:05 +03:00
Evgeny Mankov
422adb64a1
Merge pull request #318 from ROCm-Developer-Tools/emankov
...
[HIPIFY][#311 ][fix] Get rid of socat in run_test.sh
2018-01-15 15:35:04 +03:00
emankov
f83df46b8c
[HIPIFY][ #311 ][fix] Get rid of socat in run_test.sh
2018-01-15 14:20:37 +03:00
Evgeny Mankov
a42671d133
Merge pull request #315 from emankov/win_testing
...
[HIPIFY][tests][win] CUDA samples root env. var is changed
2018-01-14 19:18:07 +03:00
Evgeny Mankov
0953fa4a6b
Merge pull request #316 from emankov/cmake
...
[HIPIFY][cmake] Version compatibility checks of CUDA and clang are added
2018-01-13 19:59:56 +03:00
Evgeny Mankov
d11dccdd44
[HIPIFY][cmake] Version compatibility checks of CUDA and clang are added
2018-01-12 17:36:41 +03:00
Evgeny Mankov
39a0372077
[HIPIFY][tests][win] CUDA samples root env. var is changes
...
Env. var NVCUDASAMPLES_ROOT is changed to NVCUDASAMPLESX_Y_ROOT where X - major ver, Y - minor ver.
Reason: NVCUDASAMPLES_ROOT contains path to CUDA SDK installed last, while NVCUDASAMPLESX_Y_ROOT contains samples of the same version as of CUDA_TOOLKIT_ROOT_DIR.
2018-01-12 17:15:37 +03:00
Evgeny Mankov
1b7c9c6480
Merge pull request #310 from emankov/win_testing
...
[HIPIFY][tests] Add Windows testing support
2018-01-12 16:41:56 +03:00
Evgeny Mankov
5b7d733fc1
Merge pull request #307 from emankov/issue_306
...
[HIPIFY][FIX][#306 ] Eliminate second cuda main include directive
2018-01-10 22:50:44 +03:00
Evgeny Mankov
cc133b09aa
[HIPIFY][fix][ #306 ] Code improve
2018-01-10 21:26:05 +03:00
Evgeny Mankov
5c15cc77cb
[HIPIFY][cmake] Exclude socat from Win config
2018-01-10 21:06:06 +03:00
Evgeny Mankov
b32639d1a8
[HIPIFY][tests] Add setlocal to batch script
2018-01-10 21:03:02 +03:00
Evgeny Mankov
2f4fc9fd9f
Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP into win_testing
2018-01-10 20:37:06 +03:00
Evgeny Mankov
bc973fae70
Merge pull request #309 from emankov/issue_308
...
[HIPIFY][#308 ][fix] Consume error returned by Replacements::add(...)
2018-01-10 20:30:14 +03:00
Evgeny Mankov
257bc4748c
[HIPIFY][tests] Add Windows testing support
2018-01-09 20:20:28 +03:00
Evgeny Mankov
7b060535c0
[HIPIFY][ #308 ][fix] Consume error returned by Replacements::add(...)
2018-01-09 20:03:53 +03:00
Evgeny Mankov
5a45d3ca84
[HIPIFY][FIX][ #306 ] Eliminate second cuda main include directive
...
// hipified to #include<hip/hip_runtime.h>
#include<cuda.h> // 1st cuda main include (Driver API)
// to eliminate
#include<cuda_runtime.h> // 2nd cuda main include (Runtime API)
HIP has one header hip_runtime.h for both CUDA APIs, thus second cuda main include directive is eliminated entirely.
2017-12-26 20:54:54 +03:00
Maneesh Gupta
d0001e5b89
Merge pull request #304 from kknox/docker2
...
Upgrade to nvidia-docker2 for CUDA testing
2017-12-22 11:05:52 +05:30
Kent Knox
a1abbea28d
Disable CUDA build/test while upgrading to nvidia-docker2
...
This enables us to remove the driver version from startup string
2017-12-21 11:10:55 -06:00
Maneesh Gupta
a8e146d0ce
Merge pull request #298 from emankov/master
...
[HIPIFY][cmake] Fix require_program function
2017-12-19 08:42:27 +05:30
Evgeny Mankov
eff6831217
[HIPIFY][cmake] Fix require_program function
...
Function require_program erroneously doesn't report "Can't find program" on any missing program except the first one due to the cached FOUND_PROGRAM value.
Additionally:
+ Do not throw FATAL_ERROR on missing program in order to obtain the whole list of missing programs (if any).
+ Report also found program location.
2017-12-18 19:57:04 +03:00
Maneesh Gupta
b0920e3281
Merge pull request #297 from phani544/nvccTests3
...
[nvccTests] Resubmit hipMemcpyDtoD & inline_asm_vadd
2017-12-18 15:41:19 +05:30
Maneesh Gupta
c124899669
Merge pull request #282 from gargrahul/texture_driver_3d_support
...
Added support for 3D texture driver apis
2017-12-18 15:39:26 +05:30
Phaneendr-kumar Lanka
89bedb74e7
[nvccTests] Resubmit hipMemcpyDtoD & inline_asm_vadd
2017-12-18 14:46:19 +05:30
Maneesh Gupta
1fe07cbbca
Merge pull request #295 from mangupta/static_check
...
[cmake] Added target static_check for static code analysis
2017-12-15 10:25:58 +05:30
Maneesh Gupta
b7855e0fc7
Merge pull request #294 from phani544/nvccWarnings
...
[nvccWarnings] Fix warnings seen with dtests on nvcc path
2017-12-14 15:58:38 +05:30
Phaneendr-kumar Lanka
0ac125e3db
[nvccWarnings] Fix warnings seen with dtests on nvcc path
2017-12-14 14:10:37 +05:30
Maneesh Gupta
379cbfedcf
[cmake] Added target static_check for static code analysis
...
- Added static code analysis using cppcheck
- Fixed couple of warnings reported by cppcheck
Change-Id: Ie3b9b06e95ada322e7dc2ce3d6b91831e870198d
2017-12-14 12:16:44 +05:30
Maneesh Gupta
f485e8433d
Merge pull request #293 from phani544/nvccWarnings
...
[nvccWarnings] Fix gpu deprecated targets warnings
2017-12-13 09:58:59 +05:30
Phaneendr-kumar Lanka
7a3e0bc5d0
[nvccWarnings] Fix gpu deprecated targets warnings
2017-12-12 16:00:14 +05:30
Maneesh Gupta
123d719f0c
Merge pull request #290 from gargrahul/fix_hipPeerToPeer_simple
...
Fixed hipPeerToPeer_simple test
2017-12-12 12:50:14 +05:30
Maneesh Gupta
574797cdff
Merge pull request #286 from gargrahul/fix_hipDeviceGetAttribute_nvcc
...
Fix hipGetDeviceAttribute dtest for HIP/NVCC
2017-12-12 12:49:23 +05:30
Maneesh Gupta
c4192eec7d
Merge pull request #285 from aaronenyeshi/fix-ilogb-unreachable
...
Fix ilogb/ilogbf functions to return int
2017-12-12 10:47:33 +05:30
Rahul Garg
2de0f1cafd
Fixed hipPeerToPeer_simple test
...
- Moved test inside p2p dir
- Updated HIPCHECK to ignore hipErrorPeerAccessAlreadyEnabled
- Added check for mGPUs
2017-12-11 15:23:18 +05:30
Ben Sander
f245fe8a6c
Merge pull request #283 from emankov/master
...
[HIPIFY] Disable cudaBuiltin matcher.
2017-12-07 12:38:02 -08:00
Evgeny Mankov
45befb73d3
[HIPIFY] Remove cudaBuiltin matcher
2017-12-06 20:22:14 +03:00
Rahul Garg
a62ef42c09
Fix hipGetDeviceAttribute dtest for HIP/NVCC
2017-12-06 15:49:06 +05:30
Aaron En Ye Shi
b439b45641
Fix ilogb/ilogbf functions to return int
...
This patch will fix hipDoublePrecisionMathDevice test on ThinLTO, which uncovered that hip math_function's ilogb/ilogbf should return type int instead of double. This will match rocdl.
2017-12-05 23:14:10 +00:00
Ben Sander
faef491778
Merge pull request #281 from mangupta/issue126
...
[samples] Adds a sample that shows using HIP with cmake
2017-12-05 11:42:11 -06:00
Evgeny Mankov
ccc959fdc9
[HIPIFY] Disable cudaBuiltin matcher.
...
As HIP has started to support vanilla CUDA syntax for threadIdx, blockIdx, blockDim and gridDim.
Other CUDA builtins are not tracked for now.
2017-12-05 20:28:51 +03:00
Evgeny Mankov
43f0a14005
[HIPIFY] remove duplicates from CUDA_IDENTIFIER_MAP
2017-12-05 19:46:53 +03:00
Evgeny Mankov
360702f70a
Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP
2017-12-05 18:19:15 +03:00
Maneesh Gupta
5451441fc3
Merge pull request #278 from bensander/update_docs_and_square
...
Update docs and square
2017-12-05 15:57:36 +05:30
Rahul Garg
105df94cd0
Added support for
...
- 3D texture driver APIs
- hipMalloc3D
- hipMemcpy3D for destination other than array
2017-12-05 14:11:13 +05:30
Maneesh Gupta
ccc3fc1de6
Simplify square sample's Makefile
...
Change-Id: I44349a880a3c57ca0e833d67d9c380b706655b1e
2017-12-05 11:54:50 +05:30
Maneesh Gupta
f52662da24
[samples] Adds a sample that shows using HIP with cmake
...
Change-Id: Ief983ea0894d7b5d1ea46a755f9134dda0a1bb8f
2017-12-05 10:48:29 +05:30
Ben Sander
c7f9dbf789
Merge pull request #279 from AlexVlx/feature_use_module_based_dispatch_instead_of_pfe
...
Clean up kernel retrieval code / module management
2017-12-03 18:41:27 -06:00
Ben Sander
4dfcd401b0
Merge pull request #276 from bensander/temp_disable_tests
...
Temporarily disable a couple tests pending some HCC work
2017-12-03 18:33:47 -06:00
Alex Voicu
76614f15af
Re-sync with upstream.
2017-12-03 23:14:58 +00:00
Alex Voicu
e186bd9533
This is primarily intended as an additional cleanup of the module functionality, in the aftermath of adopting module based dispatch. The main effort was associated with refactoring the questionable ihipModuleGetSymbol. It was quaintly written and misleading, in that it had little to do with getting symbols, and was exactly retrieving a kernel object. Error handling is modified so as to reduce branching depth. Functions which serve as interfaces to the HSA RT are moved in a separate helper header. Code object readers are properly deleted. Some leftover dead functionality pertaining to associating namespace scope variables with their allocated memory is removed. Executable loading is changed to use a string which holds the ELF image of the code object being loaded, thus avoiding some corner cases where using a istream would fail.
2017-12-03 23:09:06 +00:00