Commit grafiek

6024 Commits

Auteur SHA1 Bericht Datum
Vladislav Sytchenko eb028aa92e SWDEV-288814 - Revert back to old target naming
HIP exports the runtime target as amdhip64. This target was recently
renamed to amdhip. It is unclear as to who uses this target, as HIP
clients need to use the device/host targets instead, but we still need
to support it for backwards compatability.

Change-Id: I68b9798ab967420e0642d50621d3c8b577a05435


[ROCm/clr commit: e037632fbd]
2021-06-01 17:37:30 -04:00
Vladislav Sytchenko 241d5bab38 SWDEV-288814 - Remove dependency on ROCclr
HIP only has a dependency on ROCclr at build time. When exporting HIP,
ROCClr is already embedded into the shared/static library. There is no
reason to search for it.

Change-Id: I8d7e8e58164e5585a1dfc9c998ecf02ca42d8aac


[ROCm/clr commit: 815e8dd2a3]
2021-06-01 17:37:30 -04:00
Vladislav Sytchenko f0e57d7538 SWDEV-273235 - Partial cleanup of HIP installation logic
Don't install HIP source code.

Correctly install the HIP shared library based on platform. On Linux,
it will be installed to lib/, but on Windows it will be installed to
bin/. CMake will handle this for us.

Change-Id: I00cc074ad8e13b1b953b21444f0c2b5f50dc03c0


[ROCm/clr commit: 60e9b25650]
2021-06-01 17:37:30 -04:00
Vladislav Sytchenko 6140159d8f Revert "SWDEV-255979 - Enable __managed__ test for amd platform"
This reverts commit 99188c6f3b.

Change-Id: Ib1be007535dcfb24d9e4eddbdb706d3be4acc20c


[ROCm/clr commit: 59b98a3949]
2021-06-01 17:37:30 -04:00
Joseph Greathouse 5037dd6a4c SWDEV-288361 - Implement funnel shift operators
Change-Id: I0c73809366f2d21e75f98fdeac7fed0c7591ee34


[ROCm/clr commit: 3212fdf4d6]
2021-06-01 11:10:11 -04:00
cjatin cf86d418c0 SWDEV-277697 - [CatchTest] Disable CXX Extensions (gnu++11 etc) on CMake
Change-Id: I17abd329c16cf0a61316186558828d0524b98281


[ROCm/clr commit: 895e83851c]
2021-06-01 06:48:05 -04:00
Anusha GodavarthySurya b07207b6c4 SWDEV-255979 - Add support for dynamic __managed__ variables
Change-Id: I62b790853ea3ab3b7ac57bab389046c627fdecce


[ROCm/clr commit: 995e6bff13]
2021-06-01 05:09:51 -04:00
agodavar d5896f5826 SWDEV-288708 - Rationalize HIP runtime and device version reporting
Change-Id: I49a7ee1fa9ae3ef5f26d99d18c0b8bb58cb9d5ce


[ROCm/clr commit: c654059c17]
2021-06-01 05:09:36 -04:00
Tao Sang 7aad531c84 SWDEV-276853 - Add kernelVerify
Add kernelVerify for data verification and memory
reading performance checking in kernel.

Change-Id: Id3f9bcad75d643f493daf9d5f47b3a012a427179


[ROCm/clr commit: f7e3347215]
2021-05-31 12:45:10 -04:00
Anusha GodavarthySurya 99188c6f3b SWDEV-255979 - Enable __managed__ test for amd platform
Change-Id: I0cb31c1983e68e9010340770a56fc45b2a619dcd


[ROCm/clr commit: 25f190a645]
2021-05-31 05:35:05 -04:00
Satyanvesh Dittakavi b7003a59a4 SWDEV-286231 - Fix hipMallocManaged tests failure
Test is modified as hipMemAttachHost is accepted now by hipMallocManaged

Change-Id: If73d210297cde7a92960eef57a902dbd6402a173


[ROCm/clr commit: 3488785a89]
2021-05-31 04:10:47 -04:00
Anusha GodavarthySurya 7fd69efe49 SWDEV-287027 - Improve launch bounds error log message
Change-Id: I3229580daa97f141de89bacddfce45cd43f24b19


[ROCm/clr commit: d25dc8af85]
2021-05-31 01:51:58 -04:00
German Andryeyev d100715c28 SWDEV-240804 - Fix typos in the comments
Change-Id: Ic1385daf1e685772b02a11d43fb13f6cde74c4b7


[ROCm/clr commit: 0e11c59272]
2021-05-29 00:31:46 -04:00
Vladislav Sytchenko 58072982e2 SWDEV-273235 - Fix warning in the cmake build
Change-Id: I8f9d51ea676cb015abf47a2998fa053c2d4a6e81


[ROCm/clr commit: 691c77c0f9]
2021-05-28 11:20:52 -04:00
Vladislav Sytchenko fe309cb62e SWDEV-273235 - Disable versioning for Windows
Not yet supported.

Change-Id: I9840120e1e5c40c6d3004229c4a5b06fd42cf4b6


[ROCm/clr commit: 8e9e26b1a9]
2021-05-28 11:20:37 -04:00
Vladislav Sytchenko d6efc45278 SWDEV-273235 - Fix Windows CMake build
Change-Id: Idcf89ac20b4f275de33e9f6edd009706f8c432fb


[ROCm/clr commit: 2884650eb8]
2021-05-28 11:20:23 -04:00
Vladislav Sytchenko 019425fb9a SWDEV-273235 - Restore 2ec524b
Change-Id: Id2d3e54dc4f35974c12ecbec661a005cac90e5b1


[ROCm/clr commit: d013aa2639]
2021-05-28 11:08:17 -04:00
German Andryeyev 9a599494f6 SWDEV-287137 - Add extra blocking marker
HIP should block the stream until callback is done. This change
will introduce extra marker that will block the queue.
Note: MT path doesn't really require extra marker, but the logic
is identical to avoid extra checks for direct dispatch

Change-Id: Ib90fd2d751adf337f5e43ac6098e84767530233b


[ROCm/clr commit: 8716b0f4de]
2021-05-27 21:17:18 -04:00
Vladislav Sytchenko 6b24f92d0f SWDEV-273235 - Initial support for Windows CMake
This change is tied to the ROCclr cmake rework. ROCclr will now be built
as part of HIP itself.

All the dependencies on comgr and rocr have been moved into ROCclr
itself. This allows HIP to pull in all the required compiler/runtime
dependencies by simply linking against ROCclr. Note that ROCclr needs to
be configured from HIP cmake command line. If not, we will default to
LC + ROCr support.

Since HIP depends on ROCclr and ROCclr depends on OpenCL, HIP will
transitevly pull in all the required OpenCL headers. No need to keep a
local copy of them anymore.

Change-Id: Ib39f4929e88da1248be962490c150b10fc7abd3a


[ROCm/clr commit: e34a7e8c0c]
2021-05-27 15:21:05 -04:00
Anusha GodavarthySurya c20cfdcdde SWDEV-288065 - allow hipcc to recognize .C files
Change-Id: I0ec884eb6e083e823cf27ca1251c354a7f3b744c


[ROCm/clr commit: ba28a01258]
2021-05-26 10:25:57 -07:00
Aaron En Ye Shi 2ec524b86d SWDEV-283266 - Fix Linux Pro build for hiprtc
Linux Pro build uses the LLVM_ROOT variable to
specify where llvm is located. We must use a different
name, HIP_LLVM_ROOT for LLVM's prefix location.

Change-Id: I28baf8672217a438a5dd45829d9af04b3553f615


[ROCm/clr commit: ec22410ca5]
2021-05-26 10:37:44 -04:00
Tao Sang d3df3bc2a9 SWDEV-288106 - Fix g++/hipMalloc
Fix a typo

Change-Id: I71328687b2dd4a3f563571f2b755079d83dca63e


[ROCm/clr commit: b9d70a3da9]
2021-05-25 17:23:36 -04:00
jujiang c8bdbc1723 SWDEV-286322 - add an attribute file to modify EOL
Change-Id: I5ca49a0107e129a2f949d767d2d6e0169140191d


[ROCm/clr commit: 401fabbf13]
2021-05-25 15:19:29 -04:00
Tao Sang da014f748f SWDEV-276853 - Add test for mem perf
Add memory filling performance test for large bar device memory,
hip managed memory, conherent/non-coherent host memory and fine
grained device memory

Change-Id: Id3f9bcad45d643e493daf9d5f47b3a012a427178


[ROCm/clr commit: e594ae6581]
2021-05-25 12:32:44 -04:00
Jatin Chaudhary 650d6031fa SWDEV-277697 - Make sure hipcc can handle standard CXX options when being used with nvcc
Change-Id: I76b1f2943a660eefda858397218a775083b99228


[ROCm/clr commit: bfc6eed3d5]
2021-05-25 07:35:02 -04:00
Jatin Chaudhary 0db4210a86 SWDEV-277697 - [CatchTest] Fix Documentation, Add test to AMD specific, Add HIP Macros, New Binary for multiproc tests
Change-Id: I3783caf85c694b724ed55b778220b8ef9a39f84b


[ROCm/clr commit: 8749e231e6]
2021-05-25 07:12:54 -04:00
Jatin Chaudhary 83e7ce2dce SWDEV-280067 - Document hipErrorNoBinaryForGpu error in hip faq
Change-Id: Ie8cab47ecac5a1b0972041d6e3e58e4fca278c41


[ROCm/clr commit: ed4c4fbcba]
2021-05-25 15:14:08 +05:30
Satyanvesh Dittakavi 6eeee12ccc SWDEV-286830 - Fix hipStreamACb_ThrdBehaviour on windows
use sleep_for which works cross-platform
for other tests as well

Change-Id: I915444d620e9fad0b9eda93bcdd244f9956ab8d5


[ROCm/clr commit: 5738bf4a29]
2021-05-24 03:18:36 -04:00
Aaron En Ye Shi c9f19b9d26 SWDEV-283266 - Workaround RTC macro in vector types
Temporarily disable __HIPCC_RTC__ in hip_vector_types.h
while the upstream clang headers are outdated on mainline.
Once upstream patch has landed in mainline, revert this
change. This is a workaround for hiprtc testing.

Change-Id: Ib2cf6023b71431bbfbe3c699076caa4f90f7170c


[ROCm/clr commit: 414c80644b]
2021-05-21 15:53:59 +00:00
Satyanvesh Dittakavi be7955896f SWDEV-278464 - Update unit test hipEventMultiThreaded
Run with multiple threads to catch possible race condition
Disable running the test by default on CI as this takes lot of time

Change-Id: I1c1a66fd5c72f8d2bf7ad120461384488b46abbd


[ROCm/clr commit: 247a1e1fee]
2021-05-21 02:57:14 -04:00
Satyanvesh Dittakavi 09ff27b5c1 SWDEV-285521 - SWDEV-284626 - Fix P2P and Caffe2 test failures
- waitList was released before the awaitcompletion
causing stream sync after the async copies fail

- Enable the hipPeerToPeer_simple test

Change-Id: I1eeaa7e6320ab38c106902078f034dfec4c3f3ea


[ROCm/clr commit: e9ac835e0e]
2021-05-21 02:54:22 -04:00
Aaron En Ye Shi 2fdac08d13 SWDEV-283266 - Fix hipRTC mcin missing symbol
Add back the .type directive needed for ELF
format to add the section to symbol table.
For COFF format the symbol is already added
to the symbol table.

Change-Id: I4920e8dae0af23b4dcabd324b47abc228fcab10f


[ROCm/clr commit: 561310c6d6]
2021-05-20 20:24:55 +00:00
Julia Jiang 2991b08b29 SWDEV-286322 - Fix EOL in files
Change-Id: I1746e80aceeeaa4fc5df65c858f4816d99010186


[ROCm/clr commit: e1a640bfc2]
2021-05-19 14:48:53 -04:00
cjatin c22c94e709 SWDEV-277697 - Adding Infra and dependent libs: Catch2 and json parser, for new HIP Testing framework
Change-Id: Iedfa041ec9acc13eeb631ff67e1677e2fe29463d


[ROCm/clr commit: 93bd76672e]
2021-05-19 00:47:00 -04:00
kjayapra-amd 39c5893f82 SWDEV-286346 - Implement Arena Memory Object for externally created memory.
Change-Id: I1aae0d24b28eebaf7f67e941aaa475a53831e9b8


[ROCm/clr commit: 7fc700c348]
2021-05-18 10:24:40 -04:00
German Andryeyev 9a580288eb SWDEV-240804 - Allow system memory creation.
Always allocate managed memory in ROCclr and backend will decide
what kind of memory to use. Currently ROCclr should fall to
GPU accessible system memory if HMM isn't available

Change-Id: I71328687b2dd4a3f563571f2b755079d82dca433


[ROCm/clr commit: 302e527225]
2021-05-18 09:32:57 -04:00
Tao Sang fad72a437f SWDEV-282588 - Improve clock64()
Let clock64() read s_memtime to prevent rolling over
Add wall_clock64() to read s_memrealtime

Change-Id: I706387355add75852c570be2656131ef99e8968f


[ROCm/clr commit: 26235f49e6]
2021-05-17 13:19:04 -04:00
cjatin 71ae783de1 SWDEV-285685 - Make sure the output of hipconfig is without quotes on linux
Change-Id: I620cd41c7e6087b0d3d7da9ef7f9cecaf2f740ba


[ROCm/clr commit: 82610fe3d5]
2021-05-17 20:50:36 +05:30
Aaron En Ye Shi 3a23df8893 SWDEV-263959 - Fix device decl with long and llong
Windows may expect long and ulong to be 4 bytes, while
Linux expects 8 bytes. Instead, use uint64_t for
unsigned long, and unsigned long long, and use int64_t
for long and long long to be consistent.

Change-Id: I6ed1cdde43721bcaaab0245644d607b1adbf9884


[ROCm/clr commit: dd643ec517]
2021-05-14 11:59:27 -04:00
Julia Jiang c036d21f61 SWDEV-286322 - Fix EOL
Change-Id: Ie266135ebf754b5af27c1dc768bda1ca0245d936


[ROCm/clr commit: 77ba798177]
2021-05-14 11:32:55 -04:00
Aaron En Ye Shi 1099d6fb81 SWDEV-283266 - Add hiprtc option to generate preprocessor expansion
Add -r/--generate_rtc option to hip_embed_pch.sh to generate the
preprocessor expansion output of the HIP headers for hipRTC mode.
Generates an object hiprtc_header.o and shared library libhiprtc.so
which can be used for hipRTC online compilations. Enable
__HIP_ENABLE_RTC by default in the CMake files.

Change-Id: Ief51b695c9b31941d929e06f16872f95eea3619b


[ROCm/clr commit: 9c873353cc]
2021-05-14 10:20:38 -04:00
Saleel Kudchadker 76847519e0 SWDEV-283726 - Indicate profiler attached
Set profiler attached flag in VirtualGPU to inform ROCclr of it

Change-Id: I776c9fcd762cf02f3ce0f3c386d02384a224126c


[ROCm/clr commit: 7b88ba5b57]
2021-05-12 13:40:47 -07:00
Sourabh Betigeri 75d3c6deb3 SWDEV-282354 - Some AMD GPUs cause clock64() to roll over faster, this changeset prevents infinite loops due to that.
Change-Id: I19d026073afa16104ffbee4705b74d37003a04d9


[ROCm/clr commit: 66b9a34f06]
2021-05-11 20:40:23 -04:00
Sourabh Betigeri 17c5725f28 SWDEV-281034 - Occupancy calculations for gfx10.3 adjustments based on available VGPRs, SIMDs per CU and number of waves per SIMD.
Change-Id: I0e34decebc9f730fe0e0c3c3258f301de5748e72


[ROCm/clr commit: ddff87b413]
2021-05-11 20:39:49 -04:00
Vladislav Sytchenko 7995ec9e38 SWDEV-273235 - Fix HIP PCH build
hip_rtc.cpp refers to the symbol __hipGetPCH(), but that one can only be
found in hip_global.cpp. It's not referenced anywhere else, hence it
should be moved.

Change-Id: Ifc67b2f3b1b8344dec0e6c30d083d62288fb5e24


[ROCm/clr commit: 20eff6c298]
2021-05-11 17:40:32 -04:00
Julia Jiang 992143919d SWDEV-282350 - Add managed memory support in HIP document
Change-Id: Iea4479058b4c40c36d71c9302834396a4088ac6f


[ROCm/clr commit: c68bff088b]
2021-05-11 16:04:46 -04:00
pghafari f0e63eb72f SWDEV-245532 - HIP - Vulkan interop semaphores
Change-Id: I89be5ee84d4728d76e1987d5016c944c0dbc9a96


[ROCm/clr commit: ccff5216f0]
2021-05-11 11:44:59 -04:00
Jason Tang 8532c31eb3 SWDEV-277566 - Add amd::Program::load interface
Change-Id: Iba32fd6add7b1c51b33a9ea899732044c0a064f6


[ROCm/clr commit: 744dfa6d9d]
2021-05-11 10:51:45 -04:00
Vladislav Sytchenko daa056f19d SWDEV-240806 - Fix Windows build
hipGraphAddHostNode and hipGraphAddMemcpyNode1D are not part of the HIP
graph implementation, hence they should not be exported.

Change-Id: Ia3d0188895fb4f64ebfa23d4a0a09c44438f878d


[ROCm/clr commit: 0782883cb3]
2021-05-11 10:07:49 -04:00
German Andryeyev bb785af04f SWDEV-240804 - HMM changes
- Accept hipMemAttachHost flag
- Don't allocate HMM memory if HMM is disabled in KFD

Change-Id: I3d386eb0a109a19c16a87a728944a3a6669f643a


[ROCm/clr commit: 5d8cafef2d]
2021-05-10 13:50:21 -04:00