Commit Graph

5762 Commits

Author SHA1 Message Date
agodavar ee1d7a339a SWDEV-265171 Remove hcc compiler support from hipcc
Change-Id: Ibd06e68dd1f079b2f9e46606bdbfc0a0a780b638
2020-12-30 06:26:09 -05:00
agodavar 2a4568d416 SWDEV-266089: hipStreamAddCallback argument validation
Change-Id: I3e61006796e88b4e2ba029118c95f3499959257b
2020-12-29 05:42:54 -05:00
Sarbojit Sarkar df686db4d8 SWDEV-262810: skip duplicate compile flag inclusion
Change-Id: I02ebfb3cbaf6ec25819de0c4952795c6cc949e4d
2020-12-20 23:26:55 -05:00
Sarbojit Sarkar 133843bd33 SWDEV-265344: fix for dtest build issue
Change-Id: I561546cb792fc0b33c03b17ba2ccf62802f05656
2020-12-20 23:26:20 -05:00
agodavar c1dedbd3a0 SWDEV-263180 : Fix null ptr dereference
Change-Id: Iefc9fa3f195af45a5c5ebe075056246c930a6d84
2020-12-19 02:02:54 -05:00
jujiang 021bb7fc61 SWDEV-265003-Fix hip faq
Change-Id: Ifd29fd9c20ecc905c63fa39fd0768eaca3953aac
2020-12-18 12:21:36 -05:00
Rahul Garg 08f827b28b Fix hipmemset to match CUDA behavior
Make hipMemset asynchronous with respect to the host unless
destination pointer refers to pinned host memory.

Change-Id: I5ba230e0cc622aa076dc94692a4c43a57dd2df7b
2020-12-17 19:13:31 +00:00
Evgeny 343f6aafc8 SWDEV-263773 : adding CMAKE_TESTING_TOOL cmake argument
Change-Id: I28df2344d000a0dbef07f45971a9dc92fe07fb27
2020-12-15 17:52:30 -05:00
Evgeny d4df2e880d SWDEV-259683 : hipprof: adding hipApiIdByName() method
Change-Id: I1ad2be76efc9fb690ed7c9c2b1091f7eb0c04a31
2020-12-15 15:42:10 -05:00
Satyanvesh Dittakavi 5b10098da9 SWDEV-258754 Fix seg fault hipMemset with device pointer mapped from hipHostRegister
Change-Id: Ifab66b67df172812ebb6eb25c2bac71821f4d614
2020-12-15 07:44:34 -05:00
Satyanvesh Dittakavi a7b5347c90 Fix hipPointerGetAttributes
Modified hipPointerGetAttributes to support hipHostRegister ptrs and mapped device ptrs from hipHostRegister
Change-Id: I2f4cf12e09578768308f644123d6d4bdccbd77a8
2020-12-15 01:40:24 -05:00
jujiang 942419f217 SWDEV-249486-Add doxygeny for API hipExtModuleLaunchKernel
Change-Id: Id7451ef4f669238a38ed92ec72008326c85afc4a
2020-12-14 15:34:32 -05:00
Tony b573d6233f Correct parsing of target names and supported targets
Change-Id: I6aed72759e6fb4da6834aa80131897dad641e693
2020-12-14 18:20:56 +00:00
Sarbojit Sarkar 7c3b1cca22 Updated review comment
Change-Id: Ic7f9f33dd23c975f2a7a0f0d485a3d2a457c62bb
2020-12-13 11:30:28 -05:00
Tao Sang d074c2491f Some improvements on hip cmake file
1.Fix unexpected repeated hip runtime lib building
2.Seperate test cmake from top cmake.

Change-Id: I1ae457effd639d6c25bca293c1724b026be21ecd
2020-12-11 13:32:15 -05:00
Aaron En Ye Shi 09a1c22208 Fix hipTestFMA to support older compiler
The older compiler does not promote integral
arguments to double, instead it uses float.
This patch tries to support the old compiler
headers, and also the newer one.

Change-Id: I01e0b96a82ecddc6230cb5baf2573a318b25445b
2020-12-10 14:27:42 -05:00
Rahul Garg 15ecdcf084 Handle overflow
Fixes SWDEV-261712

Change-Id: I730fcdca8c2640fde9cfdfe2f4b4cf4894807fed
2020-12-09 19:09:43 -05:00
Tao Sang 186f95ea30 Remove hip-hcc codes: Part one
Remove hip-hcc codes from hip code base
Simplify hip CMakeLists.txt to exclude hip-hcc
Simplify cmake cmd for hip-rocclr building
Some minor fixes

Change-Id: I1ae357ecfd638d6c25bca293c1724b026be21ecd
2020-12-09 15:49:47 -05:00
Aaron En Ye Shi 8a5b8a36f2 Add HIP Sample 2_Cookbook/17_llvm_ir_to_executable
HIP supports compiling kernels from LLVM IR into executable.
The device LLVM IR needs to be compiled into a fat binary
object. This device object is embedded into a host object using
llvm-mc directives. Then, any host linker may link the host and
device objects together into an executable. A README was added.

Change-Id: I8ebb6ae86b7ab4290f7cba2eea5584d73a7c453e
2020-12-09 15:48:53 -05:00
Aaron En Ye Shi 33f0a41c7a Add HIP Sample 2_Cookbook/16_assembly_to_executable
HIP supports compiling kernels from assembly into exec.
The device assembly needs to be compiled into a fat binary
object. This device object is embedded into a host object using
llvm-mc directives. Then, any host linker may link the host and
device objects together into an executable. A README is added.

Change-Id: I59d3a8b5363073810ffc3aa0d57f21b0df272369
2020-12-09 15:48:41 -05:00
Saleel Kudchadker 6da16e90d2 Honor hipEventDisableTiming event flag
Change-Id: Ia949db96e81b9af467f04ab40d143e8d6faa9394
2020-12-09 15:10:18 -05:00
Jatin Chaudhary d056171a20 Updating the gcnArchName to now have target id
Change-Id: Ibd5576e0fb5b46e8f212de4ec57cd96eb1d3c157
2020-12-09 01:22:08 -05:00
Aaron En Ye Shi 1f0037eefc Fix hipTestFMA to align with libcxx
The HIP-Clang math headers upstream have been updated
to perform type promotion on math function overloads.
If any argument has integral type, it will be cast to
double.

Change-Id: I38d9e6240c40c4092b946851469498b2ae6500ae
2020-12-08 10:48:29 -08:00
Jatin Chaudhary 1242375bf9 Adding -Wl,@response_file and @response_file mechanism to hipcc
Change-Id: Ic2053a38034b9366cf82fc01b7ea6b52e0f17077
2020-12-07 13:38:35 -05:00
Jatin Chaudhary 91ca6e6ab3 Adding checks for function, size and params in ihipModuleLaunchKernel to have common message for hipModuleLaunch and hipExtModuleLaunch
Change-Id: I11921ad753930872572571dbfd1c12daba83a725
2020-12-07 03:17:14 -05:00
Sudheer Kumar 913de5cc5e compiler argument update for nvcc
Change-Id: If40caf20543cc29301482deddfb03d6fccb6f3c9
2020-12-06 23:21:14 -05:00
sumanthtg 2ae49daff2 [dtest] hipOccupancyMaxActiveBlocksPerMultiprocessorWithFlags() - Additional test
Additional test for flag

SWDEV-238517 for enhancing hip unit tests

Change-Id: Ieca443678c122e291b9d4cd16f7198505cd5d6c3
2020-12-06 23:19:23 -05:00
Satyanvesh Dittakavi 019c556c7d Modify atomicAdd float to use clang builtin
SWDEV-261229: Change atomicAdd float implementation to use clang builtin
along with deprecating atomicAddNoRet
Change-Id: I5e98034fec54ee1a2b85d5f56273e34945d49ea3
2020-12-03 23:59:10 -05:00
Saleel Kudchadker 390d8c54cb Add a new flag for profilingInfo to record gpu TS
Add a flag to record gpu TS in a marker, also disable marker flush
if there was already a marker submitted before.

Change-Id: I9cdf8e49137690c0050fe9370764dd059855a2f8
2020-12-03 13:45:39 -05:00
agodavar 77e5c4110e SWDEV-256810 : hipMemcpy2D API handle width, src/dst pitch 0
Change-Id: I4f60b220624f4235c0c3daf68adcd5a496e93696
2020-12-03 10:34:12 -05:00
Sarbojit Sarkar 4c1f86699d SWDEV-258579: hipMemcpy2D better error handling
Change-Id: I09378d6e31da99451e22cbe9276a5ff1ad4a1840
2020-12-03 05:50:42 -05:00
agodavar 9d56e96725 SWDEV-259210 : Handle invalid inputs for hipDeviceGetByPCIBusId and hipDeviceGetPCIBusId APIs
Change-Id: Iab48604941c4c715ee3357ace2e2d26dbc8cad33
2020-12-02 00:01:54 -05:00
Sourabh Betigeri 33c98873fa SWDEV-255397: Added new perf test for hipMemset* APIs
Change-Id: Icb12360ebde003e006cc4dceccac7ebe42712a3f
2020-12-01 12:30:58 -05:00
Yaxun (Sam) Liu fe70aa4930 Update documentation for supported clang options
Change-Id: I5d7017cd5c4335959fe5bae322e90aa46cdbc672
2020-12-01 12:00:10 -05:00
Michael LIAO be786dff8e Fix hostcall test build.
- As `long`/`ulong` on Windows has different bit sizes from Linux
  platforms, even compiled in 64-bit mode. Need to use portable data
  type `int64_t`/`uint64_t` as possible or use `long long` ones to
  match the prototype in LLVM IR.

Change-Id: I62fe16a2e53aa0f2f2b4069b8a1596b8db7050c9
2020-11-30 16:47:16 -05:00
Siu Chi Chan 5df9b3d7cc Update HIP docs
Purge all obsoleted information that is only relevant to HCC

Change-Id: Ice6ae174a73ccac9dfe2ca05027d1ecdb32558d7
2020-11-27 14:48:09 -05:00
Rupam Chetia 0a05c79606 [dtest] Tests for hipExtGetLinkTypeAndHopCount() API
1. Negative Test Cases
2. API functionality tests for hopcount and linktype using rocm-smi library.
3. API functionality test for hopcount when devices are reversed.
4. Disabling test case 7.
5. Implemented External Review Comments.
6. Created a new header file hipP2pLinkTypeAndHopFunc.h.
7. Removed test case 0x7 from directed test.
8. Put testMaskedDevice() under __linux__, placed TODO in line 404 (comments) and replaced '&=' with '='.

SWDEV-238517 for enhancing hip unit tests

Change-Id: I1ae256ecfd637d6c25bca293c1724b026be20eca
2020-11-26 09:30:38 -05:00
Sudheer Kumar 8a8af8e992 [dtest] Additional tests for d2d transfer
- Test d2d transfer after doing copy from pinned host buffer
- Test d2d transfer after doing copy from unpinned host buffer

SWDEV-238517 for enhancing hip unit tests

Change-Id: Ib262185ce2692036e11c0f95ccb850eb3bce1c81
2020-11-26 08:22:55 -05:00
Rupam Chetia 9d92c90b55 [dtest] Tests for hipModuleGetTexRef() API
1. Negative Test Cases
2. API functionality test using multiple streams.
3. API functionality validation using multiple GPUs.
4. Setting hipTexRefSetFlags() with HIP_TRSF_READ_AS_INTEGER flag instead of 0 as suggested in SWDEV-256096.
5. Enabling test cases 0x03 (short) and 0x04 (char).
6. Implemented external code review comments.

SWDEV-238517 for enhancing hip unit tests

Change-Id: If42796047ec1cf2e3695dc2b7f40a2d9dd50f5bd
2020-11-26 06:51:49 -05:00
Satyanvesh Dittakavi 44d6914ef3 Fix hipLaunchCooperativeKernel failure on nvidia platform
SWDEV-262064 - compilation fails when hipLaunchCooperativeKernel C++ routine is invoked 
on nvcc path.
Change-Id: Icde35dd1a7008b406401bb3996c06d7acfb27d8d
2020-11-25 01:15:55 -05:00
Sarbojit Sarkar c607c85451 SWDEV-260281: Fixed rpm dependencies
Change-Id: Ifd05db15d5d2098a0623fd6dd9e977d050a9c4a6
2020-11-25 00:24:37 -05:00
Michael LIAO 4ac8346383 Add initalize _wassert support.
Change-Id: I8922867ec77c975cdb235276fffc3c6272253a11
2020-11-24 11:24:54 -05:00
Tony aec1c87f34 Add additional targets
Add support for loading the following targets:

- gfx705
- gfx805
- gfx90c
- gfx1031
- gfx1032
- gfx1033

Change-Id: Ib7f61c33662619757409e95fb0b50068f9e11065
2020-11-23 20:31:45 +00:00
Aryan Salmanpour 2d84056764 [dtest] add a test case for hipExtStreamGetCUMask API
Change-Id: I2b03f06fc96c4af0c3dcf4efc0b83126971aab46
2020-11-20 14:08:02 -05:00
Aryan Salmanpour d9a335bccf Add support for hipExtStreamGetCUMask API
Change-Id: I0fa67ad581dd75556f17c7410af2c1d5cb6ae99a
2020-11-20 13:41:38 -05:00
jujiang 5e43a6defb SWDEV-249486-add disclaimer
Change-Id: Ic2f478a354ddb6520c8fb762c8978676eb7d3835
2020-11-20 11:27:18 -05:00
Satyanvesh Dittakavi ee32c0407a SWDEV-255614: Fix Caffe2 Test Failure
Change-Id: I043caa89b2a43dace7f18c739f30d2a7bfa644ca
Fixes the issue when memcpy DtoH is performed on device 0 where the device buffer 
is allocated on device1 and the destination pinned buffer is allocated from device 0.
2020-11-20 10:24:50 -05:00
Vladislav Sytchenko fb04bdc4f2 Report maxTexture1DLinear property
Change-Id: If562bbee80d8b98712806cb8258b5a7482d33bf6
2020-11-20 10:18:20 -05:00
cjatin f7a0587203 Adding hip support email to cmake packaging
Change-Id: Ibef7ae5a631ba759bc378478c91d562d4fde3079
2020-11-19 02:08:51 -05:00
Jatin Chaudhary 7d40a13245 Adding -x hip/c/none after each input file, this should allow compilations like 'hipcc a.cc b.o c.c'
Change-Id: If35571c0f8ff8bf51aebd793fc0c81c0e418ca5c
2020-11-19 02:04:33 -05:00