74d82a8145
enable more events for LL128 NPKIT trace collection ( #1827 )
2025-08-07 11:19:36 -05:00
3f8cac388e
Compiler warnings fix 2 ( #1801 )
...
* Changes to device code
* Changes to src/misc
* Changes to graph
* src/include changes
* src/transport changes
* changes in init, enqueue, proxy
* Changes to CMakeLists.txt
* Additional changes to device code
* Additional changes to net.cc
* adding 'compiler warning' tag to ease upstream merge'
* typo correction
* Addessing comments
* Additional changes for new commits
2025-08-05 17:36:23 -05:00
6fc228e247
Disable context tracking for the current version. ( #1839 )
2025-08-04 10:48:00 -05:00
bd55f876e9
[DEVICE] Add unroll=2 for gfx950 multi-node ( #1824 )
2025-07-31 02:35:26 -05:00
874cd657ef
Add collective latency profiler ( #1785 )
...
* [LatencyProfiler] Initial commit
* [LatencyProfiler] Add unit tests
* [LatencyProfiler] add more
* [LatencyProfiler] Pass unit tests
* [LatencyProfiler] Add hooks to integrate with meta internal tools
* [LatencyProfiler] Restore install.sh
* [LatencyProfiler] Resolved comments 1. add proper license 2. use proper namespace
* [LatencyProfiler] Add header
2025-07-30 14:59:28 -07:00
4ce3df8d3a
Optimize alltoall for 64 GPUs and above for gfx942 ( #1828 )
...
Add pxn and p2p net chunksize mi300x tuning
2025-07-30 15:14:43 -04:00
c84ee3d298
Upcast FP8 to Half (FP16) for Sum Operation ( #1775 )
...
* adding hadd and hadd2 support using builtin functions.
---------
Co-authored-by: Marzieh Berenjkoub <mberenjk@amd.com >
2025-07-29 11:33:06 -05:00
783c073a03
passing down NET_OPTIONAL_RECV_COMPLETION hint to n/w plugin to enable optimizations ( #1752 )
...
Co-authored-by: Sarat Kamisetty <sakamiset@amd.com >
2025-07-25 10:26:58 -05:00
0ce20e7e07
Add optional bf16 software-triggered pipelining for reduceCopyPacks ( #1758 )
...
- Introduced double-buffering to reduce copy overhead and overlap BF16 arithmetic with data prefetching.
- Aimed to improve performance of reduction-based collectives by up to 10%.
- Implemented based on recommendations from Guennadi Riguer (AMD)
- Added --force-reduce-pipeline option to install.sh to activate this optimization for BF16 reductions.
- Feature is disabled by default to prevent regressions with large messages until auto-tuning logic is upstreamed.
---------
Co-authored-by: Jeffrey Novotny <jnovotny@amd.com >
Co-authored-by: Pedram Alizadeh <pmohamma@amd.com >
2025-07-25 10:57:05 -04:00
1c3d1b3842
Added new unit tests for src/transport/shm.cc ( #1689 )
2025-07-25 05:54:42 -05:00
3c9c22bb52
Fix segfault when libibverbs returns 0 device. ( #1820 )
...
Fix: SWDEV-543816
2025-07-23 15:18:52 -05:00
9a4213356d
Support fused all reduce and elementwise operations ( #1729 )
...
* Support fused all reduce and elementwise operations
Add additional "acc" parameter to RCCL Replayer logs
Add flag which indicates availability of new API
* Fix Recorder json parsing
* Remove unreachable code
* Remove extra acc pointer check
* .
* Revert "[DEVICE] Adding ability to choose unroll factor at runtime (#1734 )"
This reverts commit 9d72be7b2ftimhu102@amd.com >
Co-authored-by: BertanDogancay <bertan.dogancay@gmail.com >
2025-07-23 09:04:17 -07:00
11fabf1de1
Cheaper threadfence for gfx942 in postPeer [1/N]: enable for single node allreduce ( #1766 )
...
Boosts single node bfloat16 allreduce performance by up to 20% for some data sizes and provides gating with the RCCL_GFX942_CHEAP_FENCE_OFF environment variable
2025-07-22 07:15:15 -07:00
c28d3d26a3
Add datatype validation for MSCCLPP AllGather ( #1816 )
...
Signed-off-by: rahulvaidya20 <ravaidya@amd.com >
2025-07-21 11:50:45 -05:00
275fdd43c1
Code coverage improvements ( #1665 )
...
* Increased max stack size to 640
* Added new binary for executing unit tests
Added new unit tests for argcheck.cc and alt_rsmi.cc files
Modified the method to execute unit tests to cover static methods
by using a bash script to convert static to non-static functions
and variables on the fly restricted to debug build type.
2025-07-17 11:20:49 -05:00
6632183efe
[GRAPH] Match maxChannels for gfx942 CUs ( #1302 )
2025-07-16 09:07:02 -05:00
106024b0db
Fix inline compilation issue with LL ( #1806 )
2025-07-15 08:39:18 -07:00
8d0f1a1cef
gfx950 updated on LL thresholds for allreduce/allgather, update treeCorrection ( #1803 )
...
* change LL thresholds for allreduce/allgather and update treeCorrectionFactor
* update allGather LL cutoff
* adjust allgather LL/LL128 thresholds
2025-07-15 09:10:19 -05:00
708ad75f7a
Disable P2P net option by default ( #1793 )
2025-07-14 08:55:39 -07:00
7158adb57f
[GEN] Fix typo in IFC code gen ( #1796 )
2025-07-11 09:19:39 -04:00
6b4ad0fd74
[BUILD] Use fmt-header instead of libfmt ( #1791 )
2025-07-10 17:19:53 -05:00
2c099fe29a
[INIT] Fix fallback for unsupported user-specified runtime unroll factor ( #1780 )
...
* [INIT] Fix fallback for unsupported user-specified runtime unroll factor
* Add CollTrace guard
* Move `commSetUnrollFactor()` to rccl_wrap.cc
* Modify comments in the device-code generator script
2025-07-10 10:56:18 -05:00
68d6f99e0f
[DEVICE] Fix validation errors for multi-node LL with gfx950 non-coherent system memory ( #1795 )
2025-07-10 09:05:46 -05:00
058264b3f3
Fix AllReduce regression due to previous max range increase for LL64/LL128 ( #1787 )
...
* Adjust tuning factor impacting more than 2 nodes
* Scale max LL128 size for > 2 nodes
* Retune max LL128 range for N > 2
2025-07-09 19:17:10 -05:00
697bee4ee8
Improving build time by removing the gfx11xx and host code from rccl_float8.h ( #1789 )
...
* removing extra build time by removing the gfx11xx arch from using hip_fp8
---------
Co-authored-by: Marzieh Berenjkoub <mberenjk@amd.com >
2025-07-09 14:03:47 -05:00
9c89573580
[GRAPH] Pass rank instead of busId due to a change in an internal function signature ( #1792 )
2025-07-08 08:45:54 -04:00
e96c8473a1
[DEVICE] Enable PAT algo for RCCL 1ppn ( #1756 )
...
* Enable PAT algo for RCCL 1ppn
2025-07-04 13:45:18 -04:00
ae9642d4bc
msccl: use special send for LL on gfx950 ( #1788 )
2025-07-03 04:16:18 -05:00
9d35581d5e
Adding #include <dlfcn.h> in nccl_net.h to pass build ( #1786 )
2025-07-02 19:21:53 -05:00
4640ab19b3
Add support for extended fine grained system memory pool ( #1770 )
...
* Add support for extended fine-grained system memory pool
* Use hipHostRegisterUncached
* Add "sc0 sc1" flags for LL store on gfx950
* Update after HIP flag is changed to hipExtHostRegisterUncached
2025-07-01 16:38:49 -05:00
8d3a5542fb
[RAS] Add support for RAS client ( #1748 )
...
Enable RAS client binary `rcclras`
2025-06-29 18:53:16 -05:00
75d22b47cb
added tuning table for gfx950 ( #1779 )
...
* added tuning table for mi350
* remove erroneous string
2025-06-29 15:45:39 -05:00
358dc1bc84
Switch to linear channel mapping for 2 nodes ( #1777 )
2025-06-28 09:10:18 -05:00
265b1b3775
add warning if workFIFO is not available after multiple retries. ( #1772 )
...
* add warning if workFIFO is not available after multiple retries.
* Update src/enqueue.cc
Co-authored-by: corey-derochie-amd <161367113+corey-derochie-amd@users.noreply.github.com >
---------
Co-authored-by: corey-derochie-amd <161367113+corey-derochie-amd@users.noreply.github.com >
2025-06-26 19:49:52 -05:00
71c788d4d7
Update plugin to look for librccl-net.so. ( #1768 )
2025-06-26 16:59:38 -05:00
5fb9d8f828
changing the HIP-VERSION to 6.3 to avoid using hip_fp8 for older ROCm versions ( #1764 )
...
Co-authored-by: Marzieh Berenjkoub <mberenjk@.amd.com>
2025-06-26 11:15:01 -05:00
7e2ac00980
Revert LL64 cutoff points based on internal tuning ( #1771 )
2025-06-26 11:59:42 -04:00
020dcf0a7c
Add proxyTrace ( #1732 )
...
This feature tracks the proxy events and status of each send/recv op. ProxyTrace keeps a fixed number of active ops in host mem and dumps the status of each op when the program crashes or hangs.
2025-06-25 23:01:34 -05:00
675b495a00
[NPKit] Create dump dir regardless of default or user provided path ( #1757 )
2025-06-21 21:18:20 -05:00
aaf023976a
Merge remote-tracking branch 'nccl/master' into develop
2025-06-20 07:54:49 -05:00
fa0422f174
generic net plugin ctxt that is extensible for use in multiple APIs ( #1735 )
...
Co-authored-by: Sarat Kamisetty <sakamiset@amd.com >
2025-06-16 14:48:08 -07:00
39211c6b41
[NPKit] Use default output directory when env var is not set ( #1747 )
2025-06-16 15:26:53 -04:00
ba97c9c18b
replayer update v0 ( #1733 )
...
* First version of new replayer, with comments on future TODOs
* plus minor fixes for UT
* Updated format of recorder, especially in binary department, according to replayer's need
2025-06-13 15:05:34 -04:00
4486d091b8
Enable -Wdeprecated-copy-with-user-provided-copy ( #1643 )
2025-06-13 08:23:31 -07:00
6c37ae9470
Added missing copyright message. ( #1742 )
...
* Added missing copyright message.
* addressed comments.
2025-06-12 09:58:01 -05:00
03fba66e71
Deprecated MSCCL API functions ( #1740 )
2025-06-11 17:52:09 -06:00
75c3c8215c
msccl: adjust msccl threshold for bf16 ( #1736 )
...
* msccl: adjust msccl threshold for bf16
* Update src/collectives.cc
Co-authored-by: corey-derochie-amd <161367113+corey-derochie-amd@users.noreply.github.com >
---------
Co-authored-by: corey-derochie-amd <161367113+corey-derochie-amd@users.noreply.github.com >
2025-06-11 09:09:57 -05:00
600ace7f19
Fixed errorneous parenthesis. ( #1739 )
2025-06-11 09:08:00 -05:00
9d72be7b2f
[DEVICE] Adding ability to choose unroll factor at runtime ( #1734 )
...
* Adding runtime unroll factor selection via RCCL_UNROLL_FACTOR
* [BUILD] Add support for user-defined UNROLL for debugging
* Update CHANGELOG.md
* Fix COLLTRACE errors in CI
* Add debug statements for unroll and resolve warnings
* Incorporate UNROLL into ONLY_FUNCS for debugging
---------
Signed-off-by: nileshnegi <Nilesh.Negi@amd.com >
Co-authored-by: gilbertlee-amd <44450918+gilbertlee-amd@users.noreply.github.com >
Co-authored-by: Jeffrey Novotny <jnovotny@amd.com >
2025-06-11 00:07:59 -05:00
b926203c05
[DEVICE] Use threadfence on gfx950 for LL protocol ( #1686 )
...
Signed-off-by: nileshnegi <Nilesh.Negi@amd.com >
2025-06-09 01:26:07 -05:00
isaki001
Avinash
Arm Patinyasakdikul
Nilesh M Negi
ycui1984
Mustafa Abduljabbar
mberenjk
Sarat Kamisetty
Atul Kulkarni
Wenkai Du
alex-breslow-amd
Rahul Vaidya
Bertan Dogancay
ryanhankins
Dingming Wu
BertanDogancay
Tim
Richard Barnes
corey-derochie-amd
Nusrat Islam