The device library now provides functions to specify the host stderr
stream in a hostcall printf message. This change implements an
assert() macro which can construct such a message. The end result is
that assertions on the device are now correctly printed on the host
stderr instead of stdout.
Change-Id: I85ab8f7848bcf28303cb8dbb8a798bc6aece7d75
[ROCm/hip commit: 96be8a7b73]
Define the following for workarround of rocThrust building failure,
HIP_INCLUDE_HIP_HCC_DETAIL_DRIVER_TYPES_H
HIP_INCLUDE_HIP_HCC_DETAIL_HOST_DEFINES_H
Change-Id: I1ae48677eafd749d6c25bca204c1724b026be22f
[ROCm/hip commit: ef8110da22]
This particular cleanup is limited to just two functions defined in
the HIP headers.
Change-Id: Ib529685265f2fda90e009b24e7e756e0cf363012
[ROCm/hip commit: 05cc647684]
Remove __HCC__, __HCC_ONLY__, __HCC_CPP__, __HCC_C__,
__HCC_OR_HIP_CLANG__, __HIP_ROCclr__ and their guarded codes.
Remove Hcc codes from directed_tests and samples.
Remove __HIP_PLATFORM_HCC__ and __HIP_PLATFORM_NVCC__ from
some files where they are not necessary.
Add deprecation notice.
Change-Id: I1ae467eafd749d6c25bca204c1724b026be21fce
[ROCm/hip commit: b34dd95124]
1.Rename include/hip/hcc_detail/ as include/hip/amd_detail/
2.Rename include/hip/nvcc_detail/ as include/hip/nvidia_detail/
3.Create __HIP_PLATFORM_AMD__ to replace __HIP_PLATFORM_HCC__
4.Create __HIP_PLATFORM_NVIDIA__ to replace __HIP_PLATFORM_NVCC__
After hcc_detail, nvcc_detail, __HIP_PLATFORM_HCC__ and __HIP_PLATFORM_NVCC__
have been removed from upstream, they will be removed from hip runtime.
Change-Id: I1ae457effd739d6c25bca203c1724b026be21fce
[ROCm/hip commit: c2adc70d4d]
Remove hip-hcc codes from hip code base
Simplify hip CMakeLists.txt to exclude hip-hcc
Simplify cmake cmd for hip-rocclr building
Some minor fixes
Change-Id: I1ae357ecfd638d6c25bca293c1724b026be21ecd
[ROCm/hip commit: 186f95ea30]
SWDEV-261229: Change atomicAdd float implementation to use clang builtin
along with deprecating atomicAddNoRet
Change-Id: I5e98034fec54ee1a2b85d5f56273e34945d49ea3
[ROCm/hip commit: 019c556c7d]
SWDEV-262064 - compilation fails when hipLaunchCooperativeKernel C++ routine is invoked
on nvcc path.
Change-Id: Icde35dd1a7008b406401bb3996c06d7acfb27d8d
[ROCm/hip commit: 44d6914ef3]
Add ifndef for __OPENMP_AMDGCN__ target, which shares
these header files with HIP.
Change-Id: I720693cfbcfb7836cd2f361d48530fb55ee3557a
[ROCm/hip commit: 2005c3437e]
The __ocml_sqrt_* functions only accept a single arg,
not two args. Also, change ifdef for if because the flag
__HCC_OR_HIP_CLANG__ is always defined.
Change-Id: Id9dc4eaf0f25df1df27a1bf643cb545ac23653f8
[ROCm/hip commit: 20999c719d]
The device side assertion calls printf to write out a message. In the
device compiler, printf is expanded into a series of hostcalls that
transmit the printf payload to the host. This expansion increases the
length of the kernel, resulting in sub-optimal compilation. The
solution is to ensure that the assert() implementation is not inlined
into the kernel.
Change-Id: Ia3a075461a755cf007218f262b0863e1926c76aa
[ROCm/hip commit: c36c0bad22]
[background] There is currently a compilation issue when both hip/hip_runtime.h and hip/hip_cooperative_groups.h included
in a file and hipcc used to compile it on NV platform. The issue is that an abort is defined in hip/nvcc_detail/hip_runtime.h
and it is also defined in the CUDA cooperative groups header (/cuda/include/cooperative_groups/details/helpers.h).
this is problematic and leads to a compilation issue in hipcc on NV platform.
Change-Id: I2ab6982ac4103822a1a4a0ced942cd604d6c19c1
[ROCm/hip commit: 3c72e7beea]
The static members __HIP_Coordinates::x, ::y and ::z must be defined
outside the class. Otherwise, linker throws `undefined reference error`
when these definitions are needed in the HIP application.
Change-Id: Iabc09744b478c22e4b13cf9824877ec9cfdd4f7a
[ROCm/hip commit: b8640f1f0d]
Julia Jiang
Sarbojit Sarkar
Satyanvesh Dittakavi
Tao Sang
Sameer Sahasrabuddhe
Michael LIAO
Saleel Kudchadker
Rahul Garg
Jatin Chaudhary
Aryan Salmanpour
Vladislav Sytchenko
Sourabh Betigeri
German Andryeyev
Aaron En Ye Shi
agodavar
Yaxun (Sam) Liu
mshivama