Commit Graph

8938 Commits

Author SHA1 Message Date
Mihai Preda fa0c182325 Free the malloc'ed event on page alloc failure
Change-Id: I009a9a6e2f67545c51470e86eac1adb78d6181b4
Signed-off-by: Mihai Preda <preda@users.noreply.github.com>
Signed-off-by: Kent Russell <kent.russell@amd.com>
2024-03-26 09:57:26 -04:00
James Zhu daf99471a4 kfdtest: add kfdtest test cases for pc sampling
Add kfdtest test cases for pc sampling.

Change-Id: I49f4f8ebfa6569803acdc7dec895c1902ce0b280
Signed-off-by: James Zhu <James.Zhu@amd.com>
2024-03-26 02:06:19 -04:00
Ammar ELWazir eb005aac74 Update .gitignore 2024-03-25 12:51:38 -05:00
Ammar ELWazir 1e59ce3620 Update sync-mainline.yaml 2024-03-25 12:46:08 -05:00
Ammar ELWazir 52dfa074ae Update sync-staging.yaml 2024-03-25 12:44:54 -05:00
Ammar ELWazir 7b8b97e028 Update sync-staging.yaml 2024-03-25 12:40:16 -05:00
Ammar ELWazir 88e3460af7 Update sync-staging.yaml 2024-03-25 12:31:04 -05:00
Ammar ELWazir a0054a7513 auto sync public (#58)
* Create sync-staging.yaml

* Create sync-mainline.yaml
2024-03-25 12:27:05 -05:00
David Yat Sin f94e2530fb libhsakmt: add PC sampling support
Add pc sampling support.

Change-Id: I08199024ba5a8eb2845c048d499fc8fcd260d2e8
Signed-off-by: David Yat Sin <David.YatSin@amd.com>
Signed-off-by: James Zhu <James.Zhu@amd.com>
2024-03-25 15:53:38 +00:00
Shweta.Khatri 02a40e9272 Convert some comments to Doxygen-style comments
hsa_ext_amd.h - Fix provided by github developer - Mátyás Aradi
Github request - https://github.com/ROCm/ROCR-Runtime/pull/187

Change-Id: I63e4175caebd10be0151f21bd5f048dd011aaf06
2024-03-25 11:47:14 -04:00
David Yat Sin 4f554988b6 libhsakmt: Update Linux header for PC Sampling
Add pc sampling support

Change-Id: I2c472ce00ff8648904cf7e585687e81d3f493049
Signed-off-by: David Yat Sin <David.YatSin@amd.com>
Signed-off-by: James Zhu <James.Zhu@amd.com>
2024-03-22 15:06:10 +00:00
Jonathan R. Madsen 1addfed9f6 Fix agent node id + randomize offset id (#625)
* Fix agent node id + randomize offset id

- fixes the node_id value
- randomizes a constant offset for the id.handle values
- switch to using node ids in rocprofiler-sdk-tool library
- update tests related to agents

* Logical node id

- sequential node id values from 0 to (N-1) where N is the number of agents
2024-03-21 20:04:21 -05:00
Jonathan R. Madsen 2f9b1767e9 Handle hsa_queue_destroy after finalization (#679)
* Handle hsa_queue_destroy after finalization

- fixes issue where hsa_queue_destroy(...) is invoked after rocprofiler-sdk has finalized
- hsa::get_queue_controller() returns pointer
- if queue controller is a null pointer, skip invoking QueueController::destroy_queue

* Update HIP/HSA/marker update_table logging

* Update rocprofv3 tests

- remove HSA_TOOLS_LIB env variable
- remove setting ROCPROFILER_LOG_LEVEL env variable
- add timeouts to tests which are missing them

* Disable thread sanitizer deadlock detection

* Update CI workflow

- rename vega20-ubuntu job to core-ci
- enable navi32 in core-ci and sanitizers

* Update run-ci.py

- set gcovr html medium and high threshold

* Update lib/rocprofiler-sdk/hsa/queue_controller.cpp

- remove this capture from enable/disable serialization

* Update lib/rocprofiler-sdk/hsa/{hsa_barrier,profile_serializer}.*

- hsa_barrier::set_barrier accepts const-ref to queue map
- profile_serializer::enable and profile_serializer::disable accept const-ref to queue map

* Logging for HIP/HSA/marker/profile_serializer

* Logging for HIP/HSA/marker/queue_controller

* Improve test_retired_correlation_ids asserts

* Fix tests/counter-collection/validate.py

- scale expected SQ_WAVES counter value based on warp size of GPU

* Tweak github comment for code coverage

* Remove gcovr html high/medium threshold args

* Fix tests/counter-collection/validate.py

- round before casting to int in test_counter_values

* operator bool for profile_serializer

- only wait on CV if profile_serializer is used

* Logging updates (profile_serializer + code_object)

* Update counter-collection validate.py

* QueueController does not wait on CV if finalizing/finalized

* Update CI workflow

- remove navi32 from core job

* Improve HIP/HSA/marker tracing get_functor/functor

- remove lambda wrapper around functor

* Update lib/rocprofiler-sdk/hsa/queue_controller.cpp

- do not acquire cvmutex lock during finalization

* Update lib/rocprofiler-sdk/hsa/hsa_barrier.*

- move ctor and dtor to implementation
- skip signal store screlease and destroy if already finalized

* Update CI workflow

- remove navi32 runners

* bwelton fixes for hangs

* CMake improvements + simplified demangle

- remove amd-comgr from common target (and thus removed from roctx DT_NEEDED)

---------

Co-authored-by: Benjamin Welton <bewelton@amd.com>
2024-03-21 17:52:15 -05:00
Bill(Shuzhou) Liu 750704720b Unlock the mutex when process is dead
After the dead process is detected, pthread_mutex_consistent() will
be called. After that, the pthread_mutex_unlock() should also be
called to unlock it: "It is the responsibility of the application to
recover the state so it can be reused."

Change-Id: I45d3e2e68c3b06779f3acb1e908dbec0c6a39297
2024-03-21 15:31:10 -05:00
Karl W. Schulz 68ea629c14 restore missing run directive
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2024-03-21 11:19:43 -05:00
Karl W. Schulz ad65ec14f8 reorder job step - start with checkout
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2024-03-21 11:13:05 -05:00
Karl W. Schulz 5e99f039f6 fixing yaml syntax
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2024-03-21 11:08:14 -05:00
Karl W. Schulz 79aba89337 remove --user option for container, try chown instead
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2024-03-21 11:05:15 -05:00
Karl W. Schulz 01d41bd428 test addition of user option for container launch
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2024-03-21 11:00:00 -05:00
Karl W. Schulz 1ae67a179d update checkout action and use concurrency instead of cancel-workflow-action
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2024-03-21 10:52:43 -05:00
Karl W. Schulz 65486cb9d5 update branch for 2.x documentation builds
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2024-03-21 10:41:15 -05:00
David Galiffi f5712875aa Updated links in documentation. (#328)
Updated to reflect new GitHub organization.
Fixed broken links to GitHub pages.

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2024-03-21 10:14:37 -05:00
guanyu12 8d4261c5c5 Merge amd-staging into amd-master 20240321
Signed-off-by: guanyu12 <guanyu12@amd.com>
Change-Id: I006fc6c187f134a4851e262fa53ab6bf8d58759d
2024-03-21 14:03:51 +08:00
Galantsev, Dmitrii 534d00e31f Update CHANGELOG.md for ROCm 6.1
Change-Id: I50fd82a14f26f0f23f3c3931e242fddf46c5bd62
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2024-03-20 10:16:16 -05:00
Philip Yang 9fbe853fea libhsakmt: Add memory alloc flag GTTAccess
To allocate GTT memory for MES AQL queue structure, KFD will create GART
mapping for the memory to be accessed by MES.

Change-Id: Iae7b33d1e70861109f1551d3a71dc60dfde9de61
Signed-off-by: Philip Yang <Philip.Yang@amd.com>
2024-03-20 10:41:51 -04:00
Charis Poag c5acd4ee88 Update ROCm 6.0/6.1 CHANGELOG.md & README.md
* Updates:
    - [CHANGELOG.md] Provide 6.1 and 6.0 changes
    - [README.md] Update readme with relavant changes
    - [CLI] Updated --showpower to expand on types of power provided to users

Change-Id: Ic653cc81f80b7973654e2c23e1ab70567b930aa7
Signed-off-by: Charis Poag <Charis.Poag@amd.com>
2024-03-20 00:17:33 -05:00
Galantsev, Dmitrii 67578106c4 Fix links and add certificate gen guide
Change-Id: Ieece04baade54ee3a7cde968aa08077e0d0d8391
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2024-03-19 14:41:16 -05:00
Ori Messinger 656234abb8 kfdtest: Exclude KFDQMTest.QueueLatency test
The purpose of this patch is to add KFDQMTest.QueueLatency to
kfdtest.exclude file temporarily for the following ASIC filters:
  -GFX940
  -GFX941
  -GFX942

This test is failing due to an issue with the way it was coded,
not due to an issue with the ASICs it is now blacklisted on.

Signed-off-by: Ori Messinger <Ori.Messinger@amd.com>
Change-Id: Ic993629a2400449f598e73fe616a4572a38e2310
2024-03-19 14:37:49 -04:00
David Belanger e738648c8f kfdtest: Update QueuePriority* tests for emulation
Reduce test case size if running on emulator.
Also, refactor code as both test cases had more than 80% same code.

Signed-off-by: David Belanger <david.belanger@amd.com>
Change-Id: I5899ee24244a6f0aa6b56fa8a4701b0b1e344b9f
2024-03-19 11:30:05 -04:00
David Belanger 66e3a09a42 kfdtest: Update PM4EventInterrupt for emulation
Reduce number of iteration for test case to run in reasonable amount of
time.

Signed-off-by: David Belanger <david.belanger@amd.com>
Change-Id: I19a7ec0d5f03c54d6691aae3cf7432754c7481cc
2024-03-19 11:29:38 -04:00
colramos-amd 62221383a7 Fixing visualization for Compute Pipeline SOL. Need to consider 'Pct of Peak' rather than 'Avg'
Signed-off-by: colramos-amd <colramos@amd.com>
2024-03-18 14:28:14 -05:00
Karl W Schulz 4fc30eb5c4 apply formatter
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-03-15 16:40:13 -05:00
Karl W. Schulz 9d268d76c6 update name for docs 2.x job
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2024-03-15 16:36:51 -05:00
Karl W. Schulz 03ddba538d update doc watermark for release candidate
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2024-03-15 16:31:42 -05:00
Karl W Schulz cabca9cbb8 include alternate profilers during testing
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-03-15 16:26:05 -05:00
Karl W Schulz f4070e3654 apply formatter
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-03-15 14:04:49 -05:00
Karl W Schulz 0e3809f20b apply formatter
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-03-15 14:04:49 -05:00
Karl W Schulz e6a00789b4 restore test_analyze_workloads to a single ctest
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-03-15 14:04:49 -05:00
Karl W Schulz 8b49bd2e51 add two missing calls to clean_output_dir
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-03-15 14:04:49 -05:00
Karl W Schulz 30d75066b9 updating test_analyze_commands test configuration to be thread safe
for parallel execution; done via use of setup_workload_dir() which
copies contents into unique directory path; no change if running serially

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-03-15 14:04:49 -05:00
Vladimir Indic 78939e705a PCS parser is aware of external correlation IDs (#639)
* PCS parser is aware of external correlation IDs

* source formatting (clang-format v11) (#640)

Co-authored-by: vlaindic <139573562+vlaindic@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-03-15 14:04:06 -05:00
colramos-amd b436415784 Update docs for MI300 support
Signed-off-by: colramos-amd <colramos@amd.com>
2024-03-15 12:48:00 -05:00
colramos-amd 2dcad38028 Update roofline distro_map for Ubuntu22.04 (#319)
Signed-off-by: colramos-amd <colramos@amd.com>
2024-03-15 12:47:30 -05:00
Ammar ELWazir 1fa0b51263 Update continuous_integration.yml (#638)
* Update continuous_integration.yml

Adding a more stable docker image to use

* Fixing jobs dependencies

* Fixing job image url
2024-03-15 11:18:55 -05:00
Karl W Schulz 69de978d35 tweak logger formatter to suppor OMNIPERF_COLOR=2 which includes the
loglevel name in output, but without color

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-03-15 09:31:22 -05:00
Karl W Schulz 357d225716 tighten up [analyze] help to be consistent with [profile] help
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-03-15 09:31:22 -05:00
Karl W Schulz c29f28e25e bug fix for df tracing output - add more function demarcation
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-03-15 09:31:22 -05:00
Karl W Schulz 76121f20a9 enable more function demarcation for analyze tracing
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-03-15 09:31:22 -05:00
Karl W Schulz 3438bc9d0f logger update: assign color for TRACE level
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-03-14 17:37:30 -05:00
Karl W Schulz 69af2ffc83 update logging formatter handling for consistent behavior with error messsages
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-03-14 17:37:30 -05:00