AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
8,938 Commits 3 Branches 0 Tags
f15d0467bcbecafdea95d8771c8dbeb0d5771052
Commit Graph

8938 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Karl W Schulz 04c0c8ad46 updating version file for RC1 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-14 14:46:41 -05:00
David Yat Sin 9d842dd1d8 Fix uninialized variables 
Change-Id: Ie5da4547fa764e55162aff287cbb338ed4324093
 2024-03-14 15:20:56 -04:00
Karl W Schulz b38dcfd2c9 update analyze_commands tests to demarcate a subset of tests which 
should be run serially; needed to avoid file output race conditions in
a common directory

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-14 13:39:10 -05:00
Nick Curtis b610e1c27b fixup MI300 MFMA rate disagreement between SOL and pipeline (#315) 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Co-authored-by: Nicholas Curtis <nicurtis@amd.com>
 2024-03-14 10:41:35 -05:00
Jonathan R. Madsen 0fdb21c050 Context Updates (#624) 
* Improve error checks related to context create/start/stop/is_valid

* Bump version to 0.2.1

* Track number of kernels associated with correlation id

- add atomic kernel counter variable to context::correlation_id

* Update lib/rocprofiler-sdk/hsa/queue.cpp

- apply the +/- kernel count
 2024-03-14 04:40:58 -05:00
Jonathan R. Madsen 7ab1a8015f Fix tracing context domain logic for operations (#621) 
* Fix tracing context domain logic for operations

- logic error: domain enabled (all operations all implicitly enabled) + domain enabled for subset of operations resulted in only explicitly enabled operations being treated as enabled
- domain_context: split single bitset for operations in all domains into array of bitsets for each domain

* Update lib/common/mpl.hpp

- assert_false for static_asserts in if constexpr expressions

* Update lib/rocprofiler-sdk/tests/contexts.cpp

- Tests for validating logic regarding domain and operations for callback and buffer tracing
 2024-03-14 01:25:43 -05:00
guanyu12 ab8ebd4dea Merge amd-staging into amd-master 20240314 
Signed-off-by: guanyu12 <guanyu12@amd.com>
Change-Id: I1d79ce09196cf101c2a885fd6be8f1094e8d5f9f
 2024-03-14 11:15:44 +08:00
colramos-amd b3d63ea24e Trying patch for test_device_filter(). HIP_VISABLE_DEVICES should not dictate expected device 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-13 16:30:52 -05:00
Ammar ELWazir 2bfce8b86d Temporary move CI to hip staging (#615) 
* Update continuous_integration.yml

* Update ostream.hpp
 2024-03-13 12:34:29 -05:00
JoseSantosAMD 4a86e39a25 Pytest remove kernel verbose (#314) 
* Remove kernel-verbose from pytests

Signed-off-by: Jose Santos <josantos@amd.com>

* remove kernel-vebose from profile in cmake

Signed-off-by: Jose Santos <josantos@amd.com>

* update expected csvs for test_block_TCC

Signed-off-by: Jose Santos <josantos@amd.com>

* Remove stubbed binary

Signed-off-by: Jose Santos <josantos@amd.com>

* always clean workload_dir
Signed-off-by: Jose Santos <josantos@amd.com>

---------

Signed-off-by: Jose Santos <josantos@amd.com>
 2024-03-13 11:30:28 -05:00
Benjamin Welton a06eef3488 Use static_object for dimension map (#616) 2024-03-13 09:28:33 -05:00
Xinmudotmoe 0c06bec272 Update doorbell->size to support large default PAGE_SIZE kernels 
Change-Id: I6fbe10ae3309f2f935d6782366cedb56dc1438c3
Signed-off-by: Xinmudotmoe <xinmu@xinmu.moe>
Signed-off-by: Kent Russell <kent.russell@amd.com>
 2024-03-13 09:18:42 -04:00
Stella Laurenzo 7c10e1e4f5 Link CMAKE_DL_LIBS. 
Was failing to link on AlmaLinux8.

Change-Id: Id7df245f1063c2bebd0f07efc352f1b9017eda0e
Signed-off-by: Stella Laurenzo <stellaraccident@gmail.com>
Signed-off-by: Kent Russell <kent.russell@amd.com>
 2024-03-13 09:18:03 -04:00
Jonathan R. Madsen 8591ed1c96 Use small_vector for API iterate_args (#597) 
* Use small_vector for API iterate_args

- replace dim3 value arguments with rocprofiler_dim3_t
  - dim3 has a non-trivial destructor
- common::mpl::unqualified_type
- common::stringified_argument_array_t<N> alias
- assert_public_data_type_properties()
- common::container::small_vector<T>::at function
- stringize returns small_vector<stringified_argument>
  - stack allocated vector
- remove has_pc_sampling condition (HSA, HIP)
  - this will be handled in queue interception

* Misc tweaks
 2024-03-13 07:36:55 -05:00
Benjamin Welton 2a262235db Disable test that checks dims (need AQL fake data support) (#612) 
* Disable test that checks dims (need AQL fake data support

* source formatting (clang-format v11) (#613)

Co-authored-by: bwelton <1683479+bwelton@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bwelton <1683479+bwelton@users.noreply.github.com>
 2024-03-12 23:20:14 -05:00
colramos-amd bfef420099 Update doc samples for new logging output 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-12 20:17:46 -05:00
colramos-amd 2acc8e98c1 Found a bug in kernel filtering and fixed 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-12 18:21:35 -05:00
colramos-amd 945da7d83c Update expected pytest value for same workload case 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-12 16:49:41 -05:00
colramos-amd cac4b1aff5 Python format 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-12 16:47:18 -05:00
colramos-amd fa7c82de75 Throw error if user analyzes two of same path (#260, #67) 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-12 16:46:36 -05:00
colramos-amd e7cc326d5a Fix missing argv in console_warning() 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-12 16:44:02 -05:00
colramos-amd 17262172a8 Update dashboard globals to reflect new (v2) sysinfo keys 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-12 16:23:12 -05:00
JoseSantosAMD efb8f131ec change stubbed values to hbm bw (#302) 
* change stubbed values to hbm bw

Signed-off-by: Jose Santos <josantos@amd.com>

* Reformat

Signed-off-by: Jose Santos <josantos@amd.com>

* Update analysis_webui.py

remove print statements

Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com>

* Update src/omniperf_analyze/analysis_webui.py

Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com>

* Update src/omniperf_analyze/analysis_webui.py

Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com>

---------

Signed-off-by: Jose Santos <josantos@amd.com>
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com>
Co-authored-by: Cole Ramos <colramos@amd.com>
 2024-03-12 16:08:30 -05:00
JoseSantosAMD 4424f320ad Kernel no overwrite (#303) 
* Removing kernel name shortener from profile

-  Kernel name shortener now in analyze
-  db import uses pymongo to import

Signed-off-by: Jose Santos <josantos@amd.com>

* collections now added using pymongo

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>

* kernel_name_shortener shortens dataframes and not a workload

-  argparser: --kernel-verbose to connection group
-  analysis_cli, profiler_rocprof_v2: remove kernel_name_shortener, so that it doesnt overwrite workload
-  db_import: demangle kernel_name dfs

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>

* fix db name in pymongo command

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>

* reformat

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>

* fix typo

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>

* remove checker for verbose in profiler_base

Signed-off-by: Jose Santos <josantos@amd.com>

* kernel_name_shortener now called in create_df_kerenel_top_stats and
create_df_pmc

Signed-off-by: Jose Santos <josantos@amd.com>

* add kernel_verbose to analysis_webui, remove stubbed values

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>

* Update src/utils/kernel_name_shortener.py

keep console_debug

Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com>

* Update src/utils/kernel_name_shortener.py

Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com>

---------

Signed-off-by: Jose Santos <josantos@amd.com>
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com>
Co-authored-by: Cole Ramos <colramos@amd.com>
 2024-03-12 15:54:52 -05:00
Ranjith Ramakrishnan b09eede016 Start rdc.service after installing the rdc package 
The starting of rdc.service was done in preinstall scripts. It should be started after installing rdc package.
Moved the functionality to postinstall scripts

Change-Id: I9a8c733beea43f95474b990a35a431db287b9a8e
 2024-03-12 13:30:27 -07:00
Jose Santos 43bc78c1dd remove binaries from tests directory 
Signed-off-by: Jose Santos <josantos@amd.com>
 2024-03-12 13:06:11 -05:00
Jose Santos c4bd700a2d Check for CI_VISIBLE_DEVICES num_devices 
-  add vcopy_MI200

Signed-off-by: Jose Santos <josantos@amd.com>
 2024-03-12 13:06:11 -05:00
colramos-amd 706d3bb9f0 Update DB module for new sysinfo keys 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-12 12:24:49 -05:00
Karl W Schulz 35ed3a4366 fix yaml syntax 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-12 11:45:23 -05:00
Karl W Schulz 6b76289abe echo CI_VISIBLE_DEVICES setting 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-12 11:43:14 -05:00
Karl W Schulz 6e05a8bc2a add CI_VISIBLE_DEVICES env variable to distinguish between CI 
execution in parallel vs serial run by hand

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-12 11:41:26 -05:00
Karl W Schulz 458087b425 apply formatting 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-12 09:09:46 -05:00
Karl W. Schulz 455645b9c7 add concurrency setting, bump setup-python version 
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
 2024-03-12 09:05:54 -05:00
Karl W. Schulz 534552282e update setup-python version 
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
 2024-03-12 09:05:35 -05:00
Karl W. Schulz 59212922bf remove cancel-workflow-action, superseded by concurrency option 
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
 2024-03-12 09:02:29 -05:00
Karl W. Schulz d669e6bd8d updating checkout action version 
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
 2024-03-12 08:58:17 -05:00
Karl W. Schulz 35b703376b update lcov action version 
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
 2024-03-12 08:52:26 -05:00
pvanhout a93c18dc90 [libamdhsacode] Support COV6/Generic Targets 
Change-Id: I4680577eb56dc436fbc134b169f172dd476bff37
 2024-03-12 07:37:32 -04:00
Jonathan R. Madsen 5402842d5f Add hsa_api_trace_version.h 
- hsa_api_trace.h contains C++
- rocprofiler-sdk needs to include the table version number defines (*_MAJOR_VERSION and *_STEP_VERSION) for the HSA API in it's public headers
- rocprofiler-sdk needs it's public headers to be C-compatible so hsa_api_trace_version.h was created

Change-Id: Ieece990b3b7775cb0446b545c9e3391c5f691c61
 2024-03-12 01:17:34 -04:00
Cole Ramos 267f0842ec Throw error when we cannot read gfx942 details (#310) 
* Throw error when we cannot read gfx942 details

Signed-off-by: colramos-amd <colramos@amd.com>

* Fixing my stupid typo

Signed-off-by: colramos-amd <colramos@amd.com>

---------

Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-11 15:26:26 -05:00
Karl W Schulz 748904df20 add concurrency setting 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-11 15:17:09 -05:00
Karl W Schulz b8ec84061e update CI testing to include mi200 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-11 15:17:09 -05:00
Karl W Schulz e85037fdfb move set_locale_encoding() to occur after logging is setup - allows 
function to use console_error() directly (https://github.com/AMDResearch/omniperf/pull/308#discussion_r1519914083)

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-11 14:19:01 -05:00
Karl W. Schulz 5e21dc35fd Update src/utils/utils.py 
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>
 2024-03-11 14:19:01 -05:00
Karl W. Schulz ebc9108da0 Update src/utils/db_connector.py 
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>
 2024-03-11 14:19:01 -05:00
Karl W. Schulz e8ca48dc83 Update src/omniperf_profile/profiler_rocscope.py 
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>
 2024-03-11 14:19:01 -05:00
Karl W. Schulz 8856480808 Update src/omniperf_profile/profiler_base.py 
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>
 2024-03-11 14:19:01 -05:00
Karl W. Schulz 523639a7fd Update src/utils/db_connector.py 
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>
 2024-03-11 14:19:01 -05:00
Karl W. Schulz af3f006a7e Update src/omniperf_profile/profiler_rocscope.py 
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>
 2024-03-11 14:19:01 -05:00
Karl W. Schulz 8e45cc897f Update src/utils/utils.py 
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>
 2024-03-11 14:19:01 -05:00