Commit Graph

8938 Commits

Author SHA1 Message Date
Elwazir, Ammar 5c6b03801d Changing the Github Runner Sets (#446)
* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml
2025-06-12 10:32:01 -05:00
David Yat Sin 17b8f9b24d cmake: Remove unused file 2025-06-12 10:38:58 -04:00
David Yat Sin 24ce840732 rocr: Remove support for Kaveri GPUs
Kaveri GPUs are EoL
2025-06-12 10:38:58 -04:00
David Yat Sin 96d0f07b15 rocr: Fix compile warning when using clang 2025-06-12 10:38:58 -04:00
jamessiddeley-amd f004aeebe9 fixed long kernel names cut off in --kernel-names option (#728)
* reformatted kernel roofline PDF to use table

* restored kernel symbol icons

* enhance code readability

* restored cell text wrap

---------

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>
2025-06-12 10:23:40 -04:00
jamessiddeley-amd 97dad3f7f1 increased utils.py code coverage to ~84% (#742)
* code coverage file cover: utils.py

* added code coverage 82% for utils.py

* reverted unused_code rebase
2025-06-12 10:21:40 -04:00
David Galiffi 877fa671cc Updated Dockerfile.ubuntu (#245)
Using miniforge instead of miniconda

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-06-12 10:19:01 -04:00
David Galiffi d9381c3e0a SWDEV-525474 - Fixed CMake 4 configuration error (#244)
Update Timemory / GOTCHA modules

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-06-12 10:14:55 -04:00
Bhardwaj, Gopesh eca6739e13 Adding tests for code coverage (#82)
* Adding tests for code coverage

* integration tests

* Fixing gtest dependencies

* Removing gmock linkage

* build fixes

* Fixing Analyze job

* CMake updates

* Fixing PSDB

* Addressing feedback

* Adding licenses

* Addressing feedback

* updating dashboard

* more API tests

* Addressing feedback

* correcting Macro

* preloading libintercept
2025-06-12 19:13:44 +05:30
David Yat Sin ed7a2104ef Remove unnecessary dependency on hsakmt 2025-06-12 09:36:19 -04:00
Pranjal Swarup c00070ddbf Change docker scripts to use miniforge instead of miniconda (#242) 2025-06-11 23:43:34 -04:00
Alysa Liu 77b86ca908 rocr: Prevent int overflow in arithmetic operation
Cast range->x and range->y to uint64_t before performing multiplication

Signed-off-by: Alysa Liu <Alysa.Liu@amd.com>
2025-06-11 19:36:36 -04:00
David Yat Sin df5d66eae5 rocr: document pseudo-code for scratch reclaim
Document CP FW and ROCr pseudo-code for asynchronous reclaim.
No code change.
2025-06-11 16:19:59 -04:00
David Galiffi 28bee27253 Fix OpenMP-Target ctest (#241)
Test is missing from rocm-7.0 stack because of a HIP version check.
In these builds, hip_version.h is still reporting 6.5.0.
This check was originally put in to skip the test on older versions
of ROCm, which should no longer be required

- For SWDEV-537718

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-06-11 16:00:48 -04:00
cfallows-amd 0415bb9740 Add roofline cli_generate_plot method (#737)
Add option to print out roofline plot in terminal using plotext.
Takes in one datatype and returns the str from plot.build() which contains the visual plot of roofline analysis for said datatype.

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-06-11 15:38:21 -04:00
Ranjith Ramakrishnan ff7561607e SWDEV-534264 - Add liboam.a to static package
liboam.a was missing in static package. The library is gettting created but not packaged.
Fixed the same
2025-06-11 13:45:21 -05:00
Elwazir, Ammar 67fee2f03f Update kws-caller.yml (#103) 2025-06-10 18:49:16 -05:00
vedithal-amd dcbc7b15e2 Mount rocprofiler-sdk directory in docker (#743) 2025-06-10 16:43:16 -04:00
cfallows-amd 24d3e7eecd Update roofline binaries (#741)
Update roofline binaries from rocm-amdgpu-bench
- uses hip to find number of CUs dynamically instead of hardcoded values in table

Remove duplicate AI plot points printing
- only print ai points once on plot since we are measuring using total flops and value is same
- remove datatype from legend labels

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-06-10 15:43:56 -04:00
Elwazir, Ammar c9af289d66 Updating Github Actions Runner Sets (#101)
* Update continuous_integration.yml

* Update continuous_integration.yml

* Update dashboard.cmake

* Update codeql.yml

* Update continuous_integration.yml
2025-06-10 13:49:56 -05:00
dependabot[bot] 0d3d0518d2 Bump rocm-docs-core[api_reference] from 1.20.0 to 1.20.1 in /docs/sphinx (#239)
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.20.0 to 1.20.1.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.20.1/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.20.0...v1.20.1)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.20.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-06-10 14:22:42 -04:00
Baraldi, Giovanni 2fa95e6d6d Enable PC sampling to be run alongside ATT. Add ATT to changelog. (#445)
* Enable PC sampling to be run alongside ATT. Add ATT to changelog.

* Fix tests

* Review comments

---------

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>
2025-06-10 20:19:00 +02:00
Elwazir, Ammar 80e058bf08 [CMake] Removing the mention of failed while running rocminfo (#409)
* Making sure if GPU_TARGETS is given as input that we ignore the usage of rocminfo

* Update rocprofiler-sdk-utilities.cmake

* Update rocprofiler-sdk-utilities.cmake
2025-06-10 10:46:40 -05:00
cfallows-amd ce3ef1400e Fix load_kernel_top arg for GUI analyze mode (#740)
--gui option for analyze mode failing due to missing arg in load_kernel_top call in pre_processing

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-06-10 11:27:03 -04:00
Kandula, Venkateshwar reddy 1c91774c6a [DOCS] SWDEV-534589 Update docs with new info in kernel_trace csv output (#438)
* Update docs with new info in kernel_trace csv output and add flag for csv in docs.

* Misc.

---------

Co-authored-by: Venkateshwar Reddy Kandula <vkandula@amd.com>
Co-authored-by: Vaddireddy, Sushma <Sushma.Vaddireddy@amd.com>
Co-authored-by: Bhardwaj, Gopesh <Gopesh.Bhardwaj@amd.com>
2025-06-10 08:20:07 +05:30
Nagaraj, Sriraksha 00f5f398e3 avail-fix (#444)
* avail-fix

* formating

* adding dimension info in rocprofv3

* review comments
2025-06-09 16:53:02 -05:00
Chris Freehill a34604bddb rocr: Add hsa_amd_portable_export_dmabuf_v2
The original version of hsa_amd_portable_export_dmabuf() did not
consider the conditions under which a dmabuf could be shared.
In the new version (hsa_amd_portable_export_dmabuf_v2()), the caller
can specify the flag HSA_AMD_DMABUF_MAPPING_TYPE_PCIE, which means they
want to share the dmabuf over PCIe. In that case, the new code will check
that if it is a PCIe GPU and it is not in a XGMI Hive then if
large-BAR is not supported, we will return an error.
2025-06-09 15:42:58 -05:00
Chris Freehill 3a9d14bb66 rocr: Add hsa_amd_portable_export_dmabuf_v2
The original version of hsa_amd_portable_export_dmabuf() did not
consider the conditions under which a dmabuf could be shared.
In the new version (hsa_amd_portable_export_dmabuf_v2()), the caller
can specify the flag HSA_AMD_DMABUF_MAPPING_TYPE_PCIE, which means they
want to share the dmabuf over PCIe. In that case, the new code will check
that if it is a PCIe GPU and it is not in a XGMI Hive then if
large-BAR is not supported, we will return an error.
2025-06-09 15:42:58 -05:00
vedithal-amd a1ef3425c6 Revert default interface to rocprof v1 (#738)
* Add deprecation warning for rocprof v1 / v2 / v3 interfaces to use
  rocprofiler-sdk interface
2025-06-09 16:39:11 -04:00
Kian Cossettini 0380cf58ba Improve rocprof-sys-avail to report VCN and JPEG metrics on supported devices (#226)
* SWDEV-535445: rocprof-sys-avail shows jpeg_activity even when unsupported

* Added vcn tracking

* jpeg and vcn description now includes supported gpus

* Add getter methods per device to check vcn and jpeg support

Add logic to check if vcn activity and vcn busy values are supported for each device.
Add logic to check if jpeg activity and jpeg busy values are supported for each device.

Co-authored-by: Sajina P Kandy <sputhala@amd.com>

* Add getter methods per device to check vcn and jpeg support (#228)

* Formatting

* Variable fix

* List of supported GPUs are now ordered

* Removed the ability to see which gpu supports jpeg and vcn activity to reduce clutter

* Formatting

* Testing for busy support

* jpeg and vcn only show if supported

* Removed commented code

* Formatting

* Applied amd_smi cpp/hpp fixes

* Added break condition for xcp loop

* Modified loops for efficiency

* Removed unneccessary macro

* Removed unneccessary includes

---------

Co-authored-by: Sajina Kandy <sputhala@amd.com>
Co-authored-by: Sajina PK <Sajina.PuthalathKandy@amd.com>
2025-06-09 16:14:53 -04:00
Sunday Clement dce52be686 rocr: Fix Unintentional Integer Overflow
Its safer to have the integer literal explicitly be an unsigned long
in this expression as that's what the type of the errorCode variable
resolves to, preventing any overflow errors.

Signed-off-by: Sunday Clement <Sunday.Clement@amd.com>
2025-06-09 15:16:10 -04:00
Sunday Clement d00ca2e9b7 rocr: Fix Unintended Sign Extension
ehdr->e_shentshize and ehdr->e_shnum are both 16-bit unsigned integers
and so their types get implicitly promoted to signed int automatically
during the multiplication, they must be explicitly cast into a larger
unsigned type, otherwise if the signed product is large enough the
value is sign extended resulting in incorrect values.

Signed-off-by: Sunday Clement <Sunday.Clement@amd.com>
2025-06-09 15:16:10 -04:00
Pryor, Adam 8663702737 [SWDEV-531379] Fix config (#183)
* [SWDEV-531379] Fix config

Signed-off-by: adapryor <Adam.pryor@amd.com>
Change-Id: Ie1bd6903235016a185dd93fbac0a87658fb12a62

* Fix group field find

Signed-off-by: adapryor <Adam.pryor@amd.com>
Change-Id: I1f8c62615327df4b5ca916b158b4882a3d5a59d0

* fixes

Signed-off-by: adapryor <Adam.pryor@amd.com>
Change-Id: I971f3e12e293ea9e5d4d67db64d8d7217b87561c

---------

Signed-off-by: adapryor <Adam.pryor@amd.com>
2025-06-09 13:55:15 -05:00
Alysa Liu 9b3d15e68d rocr: Remove structurally dead code
Remove unreachable return statement.

Signed-off-by: Alysa Liu <Alysa.Liu@amd.com>
2025-06-09 14:01:39 -04:00
Fei Zheng 96aa04fb13 TUI improvement (#732) 2025-06-09 11:29:10 -06:00
David Galiffi 92b636a219 Update opensuse.yml (#236) 2025-06-09 12:47:24 -04:00
vedithal-amd 721053bd03 Bugfix for rocprofiler sdk interface not working in MI 200 (#733) 2025-06-09 12:33:25 -04:00
Bhardwaj, Gopesh 2c6a4834d4 Gobhardw/readme update (#443)
* README update

* updating README
2025-06-09 21:00:09 +05:30
Luu, Jonathan 7f7f1c0fd5 SWDEV-531400 - Remove file reorganization backward compatibility (rocprofiler) (#35)
remove backwards compatibility

Co-authored-by: Jonathan Luu <jonatluu@amd.com>
2025-06-09 11:11:41 -04:00
Jason Bonnell 8acfe40113 add pull_request_template.md (#729)
* add pull_request_template.md

* add bug fix or feature checkboxes

* Address feedback and align more with sdk implementation

* Add other category under PR type if needed
2025-06-09 10:24:59 -04:00
U, Srihari 282834aaa7 Fix calculation for counter collection in perfetto (#395)
* Fix counter values acuumulation

* Updated change log

* Fix warnings

* Address comment
2025-06-09 00:44:55 -07:00
Pranjal Swarup 96df9b6d3e Update dyninst to v13 (#190)
Update Dyninst submodule
Refactoring of build scripts to build TBB, Boost, ElfUtils, and LibIberty, since Dyninst build scripts no longer do.
Workflows are now building Dyninst and its dependencies.

---------

Co-authored-by: marantic-amd <marantic@amd.com>
Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-06-06 22:52:23 -04:00
Fei Zheng e5b31af2a4 CLI: enable mem_chart for single run (#643) 2025-06-06 16:15:56 -06:00
Charis Poag 12b78439d2 [SWDEV-530035] Fix tests ran with partitioned configurations (CPX, DPX, QPX, etc.)
Changes: - Updates to APIs to handle null pointers or RSMI_STATUS_NOT_SUPPORTED
  - Fixes to tests to handle partitioned configurations correctly
  - Synced with latest AMD SMI API changes
Change-Id: I7a932f9336ef29ccb01d3b15e2101f6136b45720
2025-06-06 16:39:29 -05:00
Pratik Basyal ed05c00103 Formatting issue in code block and TOC fixed for PC Sampling (#731)
* Formatting issue in code block and TOC fixed

* Performance model reverted
2025-06-06 16:16:55 -04:00
Luu, Jonathan 8885887302 SWDEV-531400 - Remove file reorganization backward compatibility (aqlprof) (#90)
remove backwards compatibility

Co-authored-by: Jonathan Luu <jonatluu@amd.com>
2025-06-06 16:02:49 -04:00
vedithal-amd 25f21715bc Add SQLite3 package to test docker container (#730) 2025-06-06 14:55:32 -04:00
Nagaraj, Sriraksha 80d60d8535 [rocprofv3-avail] Rework rocprofv3-avail tool (#312)
---------

Co-authored-by: vlaindic_amdeng <vladimir.indic@amd.com>
2025-06-06 11:51:37 -07:00
Fei Zheng d756aeb3fd Support stochastic pc sampling 2025-06-06 12:43:52 -06:00
Indic, Vladimir a24f486732 [ROCm 7.0] [PC sampling] Disable PC sampling tests if the GFX arch doesn't support it (#436)
Disable PC sampling tests if the GFX arch doesn't support it
2025-06-06 18:47:47 +02:00