Commit Graph

4055 Commits

Author SHA1 Message Date
Vladislav Sytchenko f4440817cb _aligned_malloc() on Windows first takes size, then alignment, which is the opposite of how the similar function behaves on Linux. Memory allocated by it also has to be freed using _aligned_free(), unlike Linux where we can use regular free().
Edit aligned_alloc() macro and add a aligned_free() one to align with the above behaviour.
2019-10-17 18:58:32 -04:00
Evgeny Mankov ab9072cecd Merge pull request #1557 from emankov/hipify-clang
[HIPIFY][doc] Update README.md
2019-10-17 22:28:16 +03:00
Evgeny Mankov 1165e6bd71 [HIPIFY][doc] Update README.md
+ Versions, testing
2019-10-17 22:26:48 +03:00
Rahul Garg 446718f990 Revert "hipcc defaults to code object v3 (#1298)"
This reverts commit c8f38a139a.
2019-10-17 13:27:28 -04:00
Evgeny Mankov 27adf6911d Merge pull request #1554 from emankov/clang
[HIPIFY][cmake] Add install rule for clang-resource-headers
2019-10-17 16:50:25 +03:00
Evgeny Mankov 8c3dff7ab9 [HIPIFY][cmake] Add install rule for clang-resource-headers
+ Fix: set destination for all installing files to ${CMAKE_INSTALL_PREFIX}
2019-10-17 15:05:55 +03:00
Rahul Garg a21fe1443b Merge pull request #1544 from vsytch/master
QoL changes to the hipMemset family
2019-10-16 18:54:20 -07:00
Evgeny Mankov ada37f1b78 Merge pull request #1551 from emankov/clang
[HIPIFY][CUB][#1460] Add cub:: namespace support in TemplateInstantiation of cudaLaunchKernel
2019-10-16 19:05:18 +03:00
Evgeny Mankov e557563947 [HIPIFY][CUB][#1460] Add cub:: namespace support in TemplateInstantiation of cudaLaunchKernel
+ Update cub_02.cu test accordingly
2019-10-16 19:02:13 +03:00
Vladislav Sytchenko 86d0c5fa5a hipMemset2D and hipMemset3D tests should be passing by default. 2019-10-16 11:02:38 -04:00
Evgeny Mankov 2d9b5b25e9 Merge pull request #1548 from emankov/clang
[HIPIFY] Refactor a couple of matcher functions
2019-10-16 13:45:59 +03:00
Evgeny Mankov 0a20048759 [HIPIFY] Refactor a couple of matcher functions
+ Separate out GetSubstrLocation function for finding substr SourceLocation in a given SourceRange
2019-10-16 13:43:56 +03:00
Evgeny Mankov b4fd41169e Merge pull request #1547 from emankov/clang
[HIPIFY][CUB][#1460] Implement cubFunctionTemplateDecl matcher
2019-10-16 13:09:49 +03:00
Evgeny Mankov 5555d46e66 [HIPIFY][CUB][#1460] Implement cubFunctionTemplateDecl matcher
+ Add cub_02.cu test
+ Partial fixes #1460
2019-10-16 13:08:11 +03:00
kjayapra-amd 9d571e3c9e Use the correct return type in runTest in 11_texture_driver sample. (#1546)
Fixes SWDEV-203394.
Currently in runTest() returns true, even if the texture reference copy does not happen. Using the existing testResult Flag to return from runTest().
2019-10-16 10:52:15 +05:30
vsytch c2aadd4d12 Update hipMathFunctions, hipTestHalf and hipTestNativeHalf tests to support Navi10 and Navi14. (#1545) 2019-10-16 10:51:48 +05:30
kpyzhov 9773f94c71 [hipcc] Temporary add -D_OPENMP to clang options to workaround cmake issue (#1540)
* Temporary add -D_OPENMP to clang options in hipcc to allow using CMake OpenMP detection with hip-clang (until updated CMake version is available).
2019-10-16 10:51:28 +05:30
Nick Curtis d16963c9d5 Guard against division by zero for no VGPR usage (e.g., in an empty kernel) (#1528)
* guard against division by zero for no VGPR usage (e.g., in an empty kernel)

* fix bracket format

* clean up parenthesis
2019-10-16 10:49:56 +05:30
Jatin Chaudhary b3351561c5 Adding code object manager to rtc (#1526)
Adding Code Object Manager file to rtc to resolve address of Bundled_code_object in libhiprtc.so
2019-10-16 10:49:16 +05:30
Xiaozhu Meng f9b8a01c77 Fix struct declaration for C (#1524)
This change is necessary for HPCToolkit to use Roctracer to produce code centric profiling view.
2019-10-16 10:48:55 +05:30
Vladislav Sytchenko cc5abec092 In the hipMemset2D and hipMemset3D tests synchronize with the default stream after performing an async memset. 2019-10-15 17:15:49 -04:00
Vladislav Sytchenko f402b6d01a Update indentation in the hipMemset3D test. Replace all tabs with four spaces. 2019-10-15 15:29:14 -04:00
Vladislav Sytchenko c83b6adb33 Add async subtest to hipMemSet3D 2019-10-15 14:24:04 -04:00
Vladislav Sytchenko 39e42d4056 hipMemset2D test should pass only if both async and sync subtests pass. 2019-10-15 14:20:14 -04:00
Vladislav Sytchenko 0200aa3a21 Update the declarations of hipMemsetD8, hipMemsetD8Async, hipMemsetD16, hipMemsetD16Async. These functions are type aware and take in as their third argument the number of elements in the buffer, not the buffer size. Change the name of this argument from sizeBytes to count to align with the above description. 2019-10-15 14:18:42 -04:00
Evgeny Mankov aa4e34cfcf Merge pull request #1541 from emankov/doc
[HIPIFY][cmake] Make CMakeLists.txt compatible with default cmake 3.5.2 for Ubuntu 16.04
2019-10-15 17:11:39 +03:00
Evgeny Mankov 3614da5dd7 Merge pull request #1542 from emankov/clang
[HIPIFY][tests] Exclude tests for the libs, which are not defined in cmake command line
2019-10-15 14:23:00 +03:00
Evgeny Mankov c0f7d02ced [HIPIFY][tests] Exclude tests for the libs, which are not defined in cmake command line
+ affects cuDNN and CUB tests, paths to libraries of which are defined by CUDA_DNN_ROOT_DIR and CUDA_CUB_ROOT_DIR
+ Warn about excluding and why, for instance:
  "WARN: cuDNN tests are excluded due to unset CUDA_DNN_ROOT_DIR"
2019-10-15 14:20:23 +03:00
Evgeny Mankov 5dae577d67 [HIPIFY][cmake] Make CMakeLists.txt compatible with default cmake 3.5.2 for Ubuntu 16.04
+ Update README.md accordingly
2019-10-15 11:26:03 +03:00
Evgeny Mankov 2b27046ace Merge pull request #1536 from emankov/doc
[HIPIFY] HipifyAction code clean-up
2019-10-14 18:10:14 +03:00
Evgeny Mankov 0025c24fe9 [HIPIFY] HipifyAction code clean-up 2019-10-14 18:08:29 +03:00
Evgeny Mankov be348facff Merge pull request #1535 from emankov/doc
[HIPIFY][build fix] Add missing new source file
2019-10-14 16:34:33 +03:00
Evgeny Mankov 01ae988fab [HIPIFY][build fix] Add missing new source file 2019-10-14 16:32:57 +03:00
Evgeny Mankov 7f24109cf2 Merge pull request #1534 from emankov/hipify-clang
[HIPIFY][CUB] Initial support (hipify-clang only)
2019-10-14 15:57:09 +03:00
Evgeny Mankov 9887a178d4 Merge pull request #1527 from emankov/doc
[HIP][fix] Prefix libraryPropertyType to fix build of rocFFT and TensorFlow
2019-10-14 15:55:19 +03:00
Evgeny Mankov 0dfe8423e7 [HIPIFY][CUB] Add missing unit test 2019-10-14 12:03:20 +03:00
Evgeny Mankov 97df38903a [HIPIFY][CUB] Initial support (hipify-clang only)
+ Add one matcher (will be more)
+ Update Maps and Statistics
+ Add cub_01.cu unit test
+ Update lit harness to support standalone CUB
+ Update README.md
+ Update hipify-perl (only CUB header is supported for now)

[IMPORTANT]
clang (and hipify-clang) works correctly only with official NVLabs version on GitHub.
Compilation of CUB from official CUDA release has conflicts with THRUST.
Thus, to compile CUB sources, option "-I" should be specified to the cloned CUB from NVLAB on GitHub.
2019-10-14 11:55:55 +03:00
Evgeny Mankov 7a1301eab9 [HIP] Fix typo in a comment 2019-10-11 15:20:58 +03:00
Evgeny Mankov 3a83b3a62c [HIP][fix] Prefix libraryPropertyType to fix build of rocFFT and TensorFlow 2019-10-11 15:18:08 +03:00
Evgeny Mankov f363044153 Merge pull request #1520 from emankov/hipify-clang
[HIPIFY][perl] Add "important" notice
2019-10-10 18:29:01 +03:00
Evgeny Mankov 0ee069bad7 [HIPIFY][perl] Add "important" notice
# IMPORTANT: Do not change this file manually: it is generated by hipify-clang --perl
2019-10-10 18:25:26 +03:00
Jatin Chaudhary 444177ffac Re enable test RTC (#1516)
Adding target resolution in hiprtc tests and reenable them.
2019-10-10 19:59:55 +05:30
Maneesh Gupta 3a5baaeeef tracing layer unifying with hcc: removing API_ID_ANY (#1514) 2019-10-10 19:59:05 +05:30
ansurya 9bb22c4e0f Fix for directed tests failure (#1511)
directed_tests/runtimeApi/module/hipLaunchCooperativeKernel.tst - Disabling test temporarily until driver support is available.
directed_tests/runtimeApi/memory/hipArray.tst - Disabling test temporarily to reimplement it correctly.
2019-10-10 19:58:41 +05:30
Evgeny Mankov d8d9f16f17 [HIP] Introduce library_types.h as a common header for libs (#1509)
* [HIP] Introduce library_types.h as a common header for libs

[Reason]
Currently, hipFFT, hipBLAS and other HIP libs use their own data types, prefixed with HIPFFT or HIPBLAS, whereas in CUDA those types are common and declared in library_types.h

[TODO]
Switch hipFFT, hipBLAS and other HIP libs to use common library_types.h.

* [HIP] Move include for library_types.h to hip_runtime.h

[Reason]
Repeat CUDA's behaviour, where library_types.h is included in cuda_runtime.h
2019-10-10 19:57:28 +05:30
srinivamd 706e4498e3 remove dependencies on /opt/rocm path (#1379)
* remove hard coded dependencies on /opt/rocm path
2019-10-10 19:56:55 +05:30
Evgeny Mankov 656c0979bb Merge pull request #1519 from emankov/hipify-clang
[HIPIFY][test] Update allocators.cu test
2019-10-10 17:22:33 +03:00
Evgeny Mankov e3319acbf8 [HIPIFY][test] Update allocators.cu test 2019-10-10 17:20:41 +03:00
Evgeny ed29c10394 tracing layer unifying with hcc: removing API_ID_ANY 2019-10-08 19:09:43 -05:00
Evgeny Mankov 7c3f5a387d Merge pull request #1513 from emankov/hipify-clang
[HIPIFY][doc] Add a few words about hipify-perl
2019-10-08 22:30:25 +03:00