Graphe des révisions

810 Révisions

Auteur SHA1 Message Date
Giovanni LB f446834082 SWDEV-432445: Handling multiple agents for ATT
Change-Id: I41d30baf2c469d8ddb58e3385b88a7b04a30422e


[ROCm/rocprofiler commit: b93d5e7e79]
2023-12-12 17:43:24 -05:00
Giovanni LB f275cdd602 SWDEV-432445: ATT continuous mode update part2. Added codeobj tracking.
Change-Id: I1b58af70d221bbeb9b4cab960d26357a504045dd


[ROCm/rocprofiler commit: edf93d48ab]
2023-12-12 17:40:59 -05:00
Giovanni LB 34fd4840d1 SWDEV-432445: ATT continuous mode
Change-Id: I52732fc1dba41df3373ef6a19a428b00d729bf04


[ROCm/rocprofiler commit: aba6a1d986]
2023-12-12 10:55:23 -03:00
vlaindic 96510269a5 SWDEV-428255: CTF plugin shows hipDeviceReset
rocprofv2's CTF plugin is adapted to show hipDeviceReset in the
HIP API trace. Credits to Philippe Proulx <pproulx@efficios.com>

Change-Id: I870458758402e76f736007f8f2ca807059a02559


[ROCm/rocprofiler commit: 8d80b2969d]
2023-12-11 08:56:10 +01:00
Giovanni LB c22968c3ac SWDEV-409155: Adding ATT plugin tests
Change-Id: I684affa4a63ed1c6fd7d8a4bb18f83697c3181a3


[ROCm/rocprofiler commit: d5e968989c]
2023-12-07 13:01:43 -03:00
Youssef Aly 5f72f481ad SWDEV-411647: enabling kernel trace flag with sys-trace option
To allow results_<XXXXX>.csv to be regenerated as it contains extra information not present in hcc_ops_trace, hip_api_trace, hsa_api_trace CSV files. The extra information is Dispatch_ID,GPU_ID,Queue_ID,PID,TID,Grid_Size,Workgroup_Size,LDS_Per_Workgroup,Scratch_Per_Workitem,Arch_VGPR,Accum_VGPR,SGPR,Wave_Size.

Change-Id: Ief371b41aa41d77397c00e6b4281568e494b26dc


[ROCm/rocprofiler commit: 9f30432dd7]
2023-12-06 12:29:57 -05:00
Youssef Aly 286450a07a Disabling Tracer Gtest: Async_mem_copy
Test fails with a generic HsA_STATUS_ERROR

Change-Id: Icf076124304797169f848cdc524f3d52f161f54e


[ROCm/rocprofiler commit: bfd4730cb0]
2023-12-06 00:30:35 +00:00
Giovanni LB 3615f5e3af Att param as unsigned integer
Change-Id: I4cd611c5e60e7c22d17c657a8ea5663dfb57e781


[ROCm/rocprofiler commit: f13f221780]
2023-12-04 15:23:48 -05:00
Giovanni LB d4a2b49f86 Adding file mode availability check
Change-Id: I586556a998996c0117d35d966dadf5490831bffb


[ROCm/rocprofiler commit: ce9a578350]
2023-12-04 13:08:37 -03:00
Jatin Chaudhary cccbe0ee26 SWDEV-412457 - include missing assert header
Change-Id: If36574df6326b2e634fe3799372eda698b8a30a8


[ROCm/rocprofiler commit: 729d7415ae]
2023-11-15 23:35:02 +00:00
Benjamin Welton 7ce022f69a Remove flaky ROCP_OPT_MODE test
This test fails occasionally on weekly builds of rocm. It looks like
the flag isn't even used outside of this test case (not even in docs).
Lets remove the test for this flag. Leaving the underlying code in place
in case we need to revive.

Change-Id: I4e0a36ad8a3e286f8ff64780583462711c73c1ba


[ROCm/rocprofiler commit: 7d39ba7510]
2023-11-15 21:44:04 +00:00
Giovanni LB 29d1500db5 SWDEV-431438: Disabling counter check for Navi3x on unittests
Change-Id: I3b716d1862b979c3ea5884170060a6e445cf35e5


[ROCm/rocprofiler commit: 526646211a]
2023-11-15 07:51:05 -05:00
Giovanni LB cb7e35d9e4 SWDEV-283962: (Workaround) preventing v1 from failing on application replay.
Change-Id: I11eacd61b51134a32e245ea2529b6e30615f6670


[ROCm/rocprofiler commit: 4c94003018]
2023-11-15 07:50:41 -05:00
Giovanni LB 9b82a542a5 SWDEV-414768: Fixes for perfetto kernel-trace
Change-Id: Icd2eab4a46c5f51c73ff9a37df490c20ef22ee93


[ROCm/rocprofiler commit: 0648bcdc4b]
2023-11-10 09:21:54 -03:00
Giovanni LB 2d3edde2a4 SWDEV-430460: Updated readme and fixed att.csv being generated only on current dir.
Change-Id: I81522a79e61ff0f35f74035b48ff594d7a05a424


[ROCm/rocprofiler commit: 9e625eb58a]
2023-11-10 06:07:48 -03:00
Giovanni LB a88e4c9d34 SWDEV-431750: Fixing ATT parsing of s_swappc and s_setpc
Change-Id: I1bc649f0a8c5b9c2f4991cf7b82890dca681a5c7


[ROCm/rocprofiler commit: b1b55a0370]
2023-11-10 04:34:05 -03:00
gobhardw 773b707ec6 SWDEV-431667: Fixing counter listing
Change-Id: Ibcb80edcdc4e61f3d57911598ee7950f09b2e85e


[ROCm/rocprofiler commit: f513e30b9f]
2023-11-09 15:49:20 +00:00
Youssef Aly 9a4516bf6e SWDEV-430410 Fixed hang with --basenames argument
rocprofv2 script: missing shift for --basenames argument

Change-Id: Ibb4b56bb4e5ca4a8dae473de3932d559d58f7ce1


[ROCm/rocprofiler commit: 369f9e5063]
2023-11-08 19:59:20 -05:00
Giovanni LB ec895dfb2a Added option to control how codeobj is dumped from ATT
Change-Id: Ie76aeea1193c7ba8fe7f51be159516f8a9eab55f


[ROCm/rocprofiler commit: 99b14fc9f8]
2023-11-08 17:48:28 -03:00
Ammar ELWazir 129c7e9d4e Tool Version fix
Change-Id: Ieeff7263bfe697010383c28104fb9c127ec5badb


[ROCm/rocprofiler commit: 1c0149c21f]
2023-11-08 16:53:48 +00:00
Giovanni LB adfdf014e9 SWDEV-431506: Fix for ATT network mode
A bug was introduced where network mode would only work when running file mode first

Change-Id: I32d0cf8f8a5584781d54fec130ec3d276ab52d1b


[ROCm/rocprofiler commit: 698522e901]
2023-11-08 08:37:26 -03:00
Ammar ELWazir d099aba199 SWDEV-430422: Fixing the Hardware check to happen in the run function
Change-Id: I3a9112ea1707bb1a3df2e18cd9cd23f1609a3e01


[ROCm/rocprofiler commit: e9d155c6a3]
2023-11-07 14:13:29 -05:00
Ammar ELWazir f429cb3fc4 Fixing ROCProfv2 Kernel tracing in sys-trace mode
Change-Id: Ic4299beb88f53fed678bb98feeb0c78a7f252879


[ROCm/rocprofiler commit: 216cb4edcf]
2023-11-07 15:17:45 +00:00
gobhardw 67e16c37c1 Fixing build for opensuse
Change-Id: I7b68382224221e899f64c06cec67b969a212f21a


[ROCm/rocprofiler commit: 9954f937d0]
2023-11-03 17:04:08 +00:00
gobhardw 51a6df35d1 rocporf binary update
Change-Id: I2ba07a213acc7db403b804d8136edce28df9dd14


[ROCm/rocprofiler commit: 6ee20035dd]
2023-11-02 07:14:59 -04:00
Ammar ELWazir be079032bb SWDEV-366827 - Fixing Issues with ASAN builds due to merging
Change-Id: I2da6607872b10e6a0211e08604254d4425fadb77


[ROCm/rocprofiler commit: ae3c278d7a]
2023-10-31 14:47:49 -04:00
gobhardw 4593d17cf5 SWDEV-416735 Adding --merge-traces option to rocprof script
Change-Id: Ia6bc11c6265913d20ead85c50981893d147ff5eb


[ROCm/rocprofiler commit: 9cc2d896ac]
2023-10-31 14:30:36 -04:00
gobhardw c4363e2493 SWDEV-426220 Removing dummy kernel from test app
Change-Id: I1576732399fcff924a88cd442f0dac0121bd5e12


[ROCm/rocprofiler commit: ff9dc8cea0]
2023-10-31 13:29:54 -04:00
Ammar ELWazir e03b0c066b Removing .github from the main repository
Change-Id: Ia91cbd4c5145a06d4867eb4649c81ba3b95c6d6b


[ROCm/rocprofiler commit: 56d060a4a9]
2023-10-31 13:05:45 -04:00
Ammar ELWazir bff9a1bf61 SWDEV-428381: Moving rocminfo to use the one available in the path
Change-Id: I736cc2ca9ddabf35cbb24d3fba553e2cbec5e396


[ROCm/rocprofiler commit: d033cf3ab7]
2023-10-31 10:08:28 -04:00
Mythreya 6a4321c4e3 Add MI200/MI300 counters
Revision - Addition [Impact SoC: MI200, MI300]
    Note: this set of counters are important help understand the
          bottleneck.
    1.	TCC_TAG_STALL
        a.	Metric:  TCC_TAG_STALL/TCC_CYCLE: percentage of time TCC
            tag lookup pipeline is stalled
    2.	TCP_TCR_TCP_STALL_CYCLES
        a.	Metric: TCP_TCR_TCP_STALL_CYCLES/TCP_GATE_EN1: percentage
            of time TCP is stalled by TCR

Revision - Addition [Impact SoC: MI300]
    3.	TCC_BUBBLE:
        a.	Definition: Number of 128-byte read requests sent to EA
        b.	Revised Metric #1, TCC-EA Read BW:
        ReadBW =   128 * TCC_BUBBLE
                + 64 * (TCC_EA0_RDREQ - TCC_BUBBLE - TCC_EA0_RDREQ_32B)
                + 32 * TCC_EA0_RDREQ_32B
        c.	Revised Metric #2: TCC_EA Read Latency
        ReadLatency = TCC_EA0_RDREQ_LEVEL / (TCC_BUBBLE + TCC_EA0_RDREQ)

    /* [Fineprint] More detailed arithmetic:
    * ReadLatency = TCC_EA0_RDREQ_LEVEL / (#32B_req + #64B_req + #128B_req * 2)
    */

Change-Id: I0a2dfc1b64ca97023b1e8ba0f9830330b3034946


[ROCm/rocprofiler commit: 46e02a9866]
2023-10-30 15:38:46 -04:00
gobhardw 7aaf49a641 SWDEV-429377 : Fixing kernel name truncation for plugins
Change-Id: I5875048d1773959fdd73cbff5498854e61b92af8


[ROCm/rocprofiler commit: 49bd09b46c]
2023-10-30 10:52:31 -04:00
Ammar ELWazir 7f9ec63c49 Fixing Tool/Plugin Versioning and adding --version and adding proper documentation for those features
Change-Id: Icdb0d64e02943e638f183ab31759a37736d2dd61


[ROCm/rocprofiler commit: 32907ff14c]
2023-10-27 14:52:13 +00:00
Lancelot Six 929ea5d950 src/core/isa_capture/code_object_track.cpp: remove unused dbgapi import
The src/core/isa_capture/code_object_track.cpp file includes the
amd-dbgapi header but does not use the library (and is not configured to
use the library).

Remove the unused import.

Change-Id: Icc6c46a1f52355e9e5631395dfad1b44365bdca4


[ROCm/rocprofiler commit: 372fc3910b]
2023-10-27 00:09:21 -04:00
Ammar ELWazir ef2428fb96 Fixing V2 tests to accept HIP function versioning
Change-Id: Ic68116feb51b396b27e858dcaf8b389d4d11a49b


[ROCm/rocprofiler commit: cca295d951]
2023-10-26 22:04:53 +00:00
Mythreya 1471dc8a76 Remove non-functional counters for MI200 and MI300
Counters removed for MI300 (gfx940)
    TCP_TCC_WRITE_REQ_HOLE_LATENCY
    TCP_TCC_WRITE_REQ_LATENCY
    TCP_TCC_READ_REQ_LATENCY
    TCP_TCP_LATENCY

Counters removed for MI200 and MI300 (gfx90a and gfx940 respectively)
    TA_BUFFER_COALESCABLE_WAVEFRONT
    TA_FLAT_COALESCABLE_WAVEFRONT
    TCC_EA0_WRREQ_IO_CREDIT_STALL
    TCC_EA0_WRREQ_GMI_CREDIT_STALL
    TCC_EA0_WRREQ_DRAM_CREDIT_STALL
    TCC_EA0_RDREQ_IO_CREDIT_STALL
    TCC_EA0_RDREQ_GMI_CREDIT_STALL
    TCC_EA0_RDREQ_DRAM_CREDIT_STALL

Change-Id: Ic3d1e7bf35495f35b1239f03ca6420e949421386


[ROCm/rocprofiler commit: 1fae494b12]
2023-10-26 12:50:57 -04:00
gobhardw 8f5a295356 updating rocprof script for supported hw check
Change-Id: I41a8571682fd4c9ab227cc7d964f86d027d5c964


[ROCm/rocprofiler commit: 1bc98d806d]
2023-10-26 12:48:47 -04:00
Parag Bhandari 54208cd7d0 Add gfx1031 support for building
Change-Id: Ie88d76404a09de07d66a84083a7a8549bff3d050


[ROCm/rocprofiler commit: 8b9d8b966d]
2023-10-26 11:33:02 -04:00
Ammar ELWazir 37ca411965 Fixing Versioned HIP Call
Change-Id: Ib768f8a53ffc6cc3bb89e6c867918b6440ce1cab


[ROCm/rocprofiler commit: b5fd31fb9b]
2023-10-26 14:50:16 +00:00
Ranjith Ramakrishnan 57d8b98c56 SWDEV-427554 - Temporarily disable building of unittest in ASAN builds
Unittest is failing in ASAN builds. To unblock ASAN builds, disabling the same as a workaround
The test will run in non-asan builds

Change-Id: Ib3c8d7a2c77aa83e9c6260e9b47ccb0564f789e8


[ROCm/rocprofiler commit: 8babd28a50]
2023-10-25 17:45:54 -07:00
gobhardw a668f1b56e SWDEV-421283 : Fixing README for ATT
Change-Id: I4a85987b036dd27e344d0d2049ca8d22bf846dc2

Removed mention of deprecated SIMD_MASK
Removed duplicated ATT section

Change-Id: I4a85987b036dd27e344d0d2049ca8d22bf846dc2


[ROCm/rocprofiler commit: 623d614d77]
2023-10-25 06:42:37 -04:00
gobhardw c505fd6a2b SWDEV-427842: Fixing ATT csv mode
Change-Id: I7b8f37867d7aaf6da1301d91028990c343e555f1

- Updated README for kernel name truncation.
- Updated CHANGELOG.
- By default enabled truncation for ATT because csv file names should be smaller

Change-Id: I7b8f37867d7aaf6da1301d91028990c343e555f1


[ROCm/rocprofiler commit: 296c935874]
2023-10-25 00:06:13 -04:00
Giovanni LB 976c0e6717 Initial commit for counter correctness tests.
Change-Id: I74caa4ab89bd765e59686cfbaaf1ce44ab10fe19

- adds counter correctness tests for GRBM, SQWAVES and SQ INSTRUCTIONs
- pandas dependency
- made it compatible with test infra.

Change-Id: I74caa4ab89bd765e59686cfbaaf1ce44ab10fe19


[ROCm/rocprofiler commit: 3f5ddfa0ab]
2023-10-23 03:51:42 -04:00
Sriraksha Nagaraj 45d34bb867 SWDEV-428099: Fixing hang with basenames option
Change-Id: I61c9ac03394bfde84c91d922e073690ef8655337


[ROCm/rocprofiler commit: c1884d70fc]
2023-10-23 00:38:16 -04:00
Ammar ELWazir c0bc40fd5d Fixing Usage of session after free
If hsa_shut_down() is not called from the application then we may still have async calls back
to the rocprofiler to use session parameters, thats why we need to leak the session up till
this is fixed in the ROCR-Runtime

Change-Id: Ia8fcdaa859815d88a272296770d702968132e3e6


[ROCm/rocprofiler commit: c9b5d73ca8]
2023-10-19 23:29:39 -04:00
Benjamin Welton 1e6d394c7a Migrate tracer performance fixes from roctracer
Change-Id: If9e1349537cce23b7be1d8530d795744a8cd07b1


[ROCm/rocprofiler commit: cb190b72f1]
2023-10-19 20:34:12 +00:00
Saurabh Verma 87654ec8b2 SWDEV-427921: Fixing rocprof v1 counter collection for PAPI on MI300
Change-Id: I8589fe78fca481ed326e584ea1d01c0f90de655e


[ROCm/rocprofiler commit: 1e1692e6c0]
2023-10-19 13:40:32 -04:00
gobhardw f16ad5d59d SWDEV-427969: Fixing kernel trace
Change-Id: I050120ba0dd0df84a46f022c0f9b8117057202b1

When we did file plugin changes for omniperf in v2, we removed 2 fields from header:
SIG and OBJ. However from the values we missed removing OBJ. Fix is to remove the OBJ from values.

Change-Id: I050120ba0dd0df84a46f022c0f9b8117057202b1


[ROCm/rocprofiler commit: ab066543b1]
2023-10-19 05:56:55 -04:00
gobhardw ea5ecec246 SWDEV-427554 Fixing mainline ASAN build
Change-Id: I63cd047ceb75dea5f8ed6f84946e1ec209c7d812


[ROCm/rocprofiler commit: 5d390717b5]
2023-10-18 21:42:47 +05:30
Sriraksha Nagaraj facca4fd12 SWDEV-399631 : Fixing the regression issue
Change-Id: I9b2866e69ca2969405d06ac267eb17461b643eec


[ROCm/rocprofiler commit: ab288c8de8]
2023-10-16 15:27:07 -04:00