SWDEV-2 - Change OpenCL version number from 3052 to 3053.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2800 edit
SWDEV-2 - Change OpenCL version number from 3051 to 3052.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2799 edit
SWDEV-2 - Change OpenCL version number from 3050 to 3051.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2798 edit
SWDEV-2 - Change OpenCL version number from 3049 to 3050.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2797 edit
SWDEV-2 - Change OpenCL version number from 3048 to 3049.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2796 edit
SWDEV-2 - Change OpenCL version number from 3047 to 3048.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2795 edit
SWDEV-204782 - introduce hostcall
Hostcall is a service that allows a kernel to submit requests to the
host using shared buffers, and block until a response is received. This
will eventually replace the shared buffer currently used for printf, and
repurposes the same hidden kernel argument.
When the runtime launches a kernel that requires the hostcall service it
performs the following actions:
- Launch a hostcall listener thread if it is not already running.
- Locate the hostcall buffer for the corresponding hardware queue, or
create a new one.
- Register the new hostcall buffer with the listener thread.
- Set the hostcall buffer pointer as an implicit argument to the kernel.
Affected files ...
... //depot/stg/opencl/drivers/opencl/make/hip.git/tests/Makefile#21 edit
... //depot/stg/opencl/drivers/opencl/make/hip.git/tests/build/Makefile.hip_tests#31 edit
... //depot/stg/opencl/drivers/opencl/make/hip.git/tests/scripts/hip_hostcall_tests.txt#1 add
... //depot/stg/opencl/drivers/opencl/make/hip.git/tests/scripts/run_all_tests.sh#22 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devkernel.cpp#30 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devkernel.hpp#19 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#143 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.hpp#45 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rochostcall.cpp#1 add
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rochostcall.hpp#1 add
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.cpp#92 edit
SWDEV-2 - Change OpenCL version number from 3046 to 3047.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2794 edit
SWDEV-2 - Change OpenCL version number from 3045 to 3046.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2793 edit
SWDEV-79445 - OCL generic changes and code clean-up
- Don't sync on the scratch buffer if the executed kernel is unchanged, since the number of scratch regs remains the same
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#158 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.hpp#65 edit
SWDEV-2 - Change OpenCL version number from 3044 to 3045.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2792 edit
SWDEV-2 - Change OpenCL version number from 3043 to 3044.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2791 edit
SWDEV-2 - Change OpenCL version number from 3042 to 3043.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2790 edit
SWDEV-2 - Change OpenCL version number from 3041 to 3042.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2789 edit
SWDEV-2 - Change OpenCL version number from 3040 to 3041.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2788 edit
SWDEV-2 - Change OpenCL version number from 3039 to 3040.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2787 edit
SWDEV-2 - Change OpenCL version number from 3038 to 3039.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2786 edit
SWDEV-2 - Change OpenCL version number from 3037 to 3038.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2785 edit
SWDEV-2 - Change OpenCL version number from 3036 to 3037.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2784 edit
SWDEV-207835 - Implement uniform package versioning for cmake version of OpenCL.
Need to generate the same style of packages name as the Makefile version does.
Affected files ...
... //depot/stg/opencl/drivers/opencl/CMakeLists.txt#29 edit
SWDEV-2 - Change OpenCL version number from 3035 to 3036.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2783 edit
SWDEV-2 - Change OpenCL version number from 3034 to 3035.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2782 edit
SWDEV-198863 - Options for hip-clang-vdi path to provide the chicken bits, or functional equivalents to HCC_DB (phase 3)
Use ClPrint to implement other log functions.
Move some funtion to use new log functions.
This is the final change of the JIRA.
Tests:
1. Linux HIP ROCM platform. VEGA10. Driver is release build.
1.1 export LOG_LEVEL=3
./hipModule
There are many logs.
1.2 export GPU_LOG_MASK=0
./hipModule
There is no log
2. Windows HIP PAL platform. VEGA10, Driver is release build.
2.1 set LOG_LEVEL=3
run test hipPrintfKernel
There are many logs
2.2 set GPU_LOG_MASK=0
run test hipPrintfKernel
There is no log
3. http://ocltc.amd.com:8111/viewModification.html?modId=128588&personal=true&tab=vcsModificationBuilds
ReviewBoard: http://ocltc.amd.com/reviews/r/18259/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#177 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#157 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/debug.cpp#6 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/debug.hpp#14 edit
SWDEV-2 - Change OpenCL version number from 3033 to 3034.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2781 edit
SWDEV-198859 - Options for hip-clang-vdi path to provide the chicken bits, or functional equivalents to HCC_DB
There are regression caused by this change in ocltst test.
Back out changelist 2026859
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#176 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#156 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/debug.hpp#13 edit
SWDEV-198863 - Options for hip-clang-vdi path to provide the chicken bits, or functional equivalents to HCC_DB (phase 3)
Use ClPrint to implement other log functions.
Move some funtion to use new log functions.
This is the final change of the JIRA.
Tests:
1. Linux HIP ROCM platform. VEGA10. Driver is release build.
1.1 export LOG_LEVEL=3
./hipModule
There are many logs.
1.2 export GPU_LOG_MASK=0
./hipModule
There is no log
2. Windows HIP PAL platform. VEGA10, Driver is release build.
2.1 set LOG_LEVEL=3
run test hipPrintfKernel
There are many logs
2.2 set GPU_LOG_MASK=0
run test hipPrintfKernel
There is no log
3. http://ocltc.amd.com:8111/viewModification.html?modId=128490&personal=true&tab=vcsModificationBuilds
ReviewBoard: http://ocltc.amd.com/reviews/r/18247/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#175 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#155 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/debug.hpp#12 edit
SWDEV-2 - Change OpenCL version number from 3032 to 3033.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2780 edit
SWDEV-79445 - OCL generic changes and code clean-up
- Fix the detection of all devices for P2P. The previous logic worked only if GPU_ENABLE_PAL was forced to 1.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#174 edit
SWDEV-198863 - Options for hip-clang-vdi path to provide the chicken bits, or functional equivalents to HCC_DB (phase 2)
Enable the log functions for release build.
Tests:
1. Linux HIP ROCM platform. VEGA10. Driver is release build.
1.1 export LOG_LEVEL=3
./hipModule
There are many logs.
1.2 export GPU_LOG_MASK=0
./hipModule
There is no log
2. Windows HIP PAL platform. VEGA10, Driver is release or fastdbg build.
2.1 set LOG_LEVEL=3
run test hipPrintfKernel
There are many logs
2.2 set GPU_LOG_MASK=0
run test hipPrintfKernel
There is no log
3. http://ocltc.amd.com:8111/viewModification.html?modId=128481&personal=true&tab=vcsModificationBuilds
ReviewBoard: http://ocltc.amd.com/reviews/r/18240/
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/debug.hpp#11 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#324 edit
SWDEV-2 - Change OpenCL version number from 3031 to 3032.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2779 edit
SWDEV-209969 - SQTT missing event instrumenting token in OpenCL trace
- SQTT trace reports memory clears if program load occurs during the capture. Avoid memory clears with GPU if CPU backing store is available
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palprogram.cpp#100 edit
SWDEV-198863 - Options for hip-clang-vdi path to provide the chicken bits, or functional equivalents to HCC_DB (phase 1)
1. The log macros is turned off for release build. So log functions has zero impact to release build.
2. The log macros have level, mask, condition control. So we can have more control to avoid log flooding.
I also adjusted some existing log to use new log functions.
1. To excercise and test the new log functions.
2. To improve performance slightly.
3. The change is mainly for HIP-ROCM, we can move more in next phases for PAL or ORCA.
4. I make these log feature unavailable for release build. We can revert to old log functions for release build in a case by case method.
Tests:
1. http://ocltc.amd.com:8111/viewModification.html?modId=128289&personal=true&tab=vcsModificationBuildshttp://ocltc.amd.com:8111/viewModification.html?modId=128358&personal=true&tab=vcsModificationBuilds
2. release build, run hip program, there is no log
3. fastdebug build, run hip program,
export LOG_LEVEL=3
export GPU_LOG_MASK=4294967295
There was a lot of logs.
4. fastdebug build, run hip program,
export LOG_LEVEL=2
export GPU_LOG_MASK=4294967295
There was no logs.
5. fastdebug build, run hip program,
export LOG_LEVEL=3
export GPU_LOG_MASK=4294967294
There was much less logs.
6. fastdebug build, run hip program,
export LOG_LEVEL=3
export GPU_LOG_MASK=47102
There was even much less logs. The logs was expected according to the mask.
7. Tested step 2 to 6 similarily in Windows and Linux
ReviewBoard: http://ocltc.amd.com/reviews/r/18215
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#46 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#82 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#26 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hiprtc_internal.hpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_svm.cpp#29 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/comgrctx.cpp#6 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devkernel.cpp#29 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.cpp#68 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#137 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocvirtual.cpp#91 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.cpp#100 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/commandqueue.cpp#32 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/runtime.cpp#40 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/debug.hpp#10 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#323 edit
foreman