Commit grafiek

1115 Commits

Auteur SHA1 Bericht Datum
vedithal-amd f775c7cdbd Band aid fix for MI 100 no counters collected (#614)
* rocprofv3 might not collect any counters for MI 100, handle this case gracefully to prevent test failures

[ROCm/rocprofiler-compute commit: 64ccd588de]
2025-03-18 11:26:17 -04:00
Ben Richard d43675860b Remove dependency on en_US.UTF-8 locale (#613)
Set locale to C.utf8 instead of en_US.UTF-8

Avoid forcing the user to use en_US.UTF-8. Most Linux systems have C.utf8.

[ROCm/rocprofiler-compute commit: 96a25e8cbc]
2025-03-17 16:40:36 -04:00
ywang103-amd 83edd97f78 replace rocm-smi with amd-smi cmd (#612)
[ROCm/rocprofiler-compute commit: 0c6cec5671]
2025-03-17 16:20:41 -04:00
cfallows-amd eba173de5e Debug logging during intensities calculations when no flops recorded (#608)
Added debug log for when no flops are recorded (total_flops is 0), so AI points will not be plotted.
Removed commented out print statement that is not functional- contains nonexistent method call.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: 1c237c1382]
2025-03-14 12:37:19 -04:00
vedithal-amd 30a3751a42 Fix tests on MI 100 (#609)
[ROCm/rocprofiler-compute commit: 6827330135]
2025-03-13 12:07:03 -04:00
vedithal-amd e4fce70067 selective counter bugfix (#602)
Allow block filter of the form xx.x

[ROCm/rocprofiler-compute commit: 30752d1547]
2025-03-11 13:34:48 -04:00
vedithal-amd 0f4b5e91bd Standalone binary no self execute fix (#603)
* Fix nuitka command

[ROCm/rocprofiler-compute commit: 15edbf475e]
2025-03-11 13:34:37 -04:00
cfallows-amd 1eb6fef1b3 Add fp8 graph to standalone gui in analysis mode (#600)
Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: 097d30dc5c]
2025-03-11 13:32:37 -04:00
Fei Zheng 1ce11882a6 Fix counter collection inconsistency with rocprofv3
[ROCm/rocprofiler-compute commit: 7e8d2d2c0e]
2025-03-10 21:05:40 -06:00
vedithal-amd 2167d9d295 Update sphinx docs version in develop (#601)
* Update sphinx docs version in develop instead of amd-staging branch
* Add repo admins to pr review

[ROCm/rocprofiler-compute commit: 51c9c6fad3]
2025-03-10 18:01:37 -04:00
cfallows-amd 8109228f02 Force kaleido version to be no greater than 0.2.1 (#599)
Higher versions (eg. 0.4.1) have external dependencies that are causing errors and forcing early exits without creating roof plots

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: fd288e6d13]
2025-03-10 15:16:14 -04:00
vedithal-amd 7968645191 Analysis report block based filtering for profiling (#566)
* Analysis report block based filtering for profiling

* Profiling mode changes

- `-b` option now additionally accepts metric id(s), similar to `-b` option in analyze mode (e.g. 6, 6.2, 6.23)
    - Only counters mentioned in the selected analysis report blocks will be collected
        - Add parsing logic to identify hardware counters from analysis report blocks
        - Add filtering logic to only write filtered counters in perfmon files
        - Log not collected counters in one line
- `--list-metrics` option added in profile mode to list possible metric id(s) similar to analyze mode
- Write arguments provided during profiling in profiling_configuration.yaml file

* Analysis mode changes

- During analysis mode, only show report blocks selected during profiling
    - If `-b` option is provided in analysis mode, then follow provided filters
- Do not show empty tables in analysis report

* Miscellaneous changes

- Update CHANGELOG
- Add test cases
    - Instruction mix report block filter
    - Instruction mix and Memory chart report block filter
    - Instruction mix report block filter and CPC hardware block filter
    - TA hardware block filter
    - --list-metrics in profile mode should work
- Move binary handler fixtures to conftest.py to avoid importing
  fixtures
- cmake file in tests directory has been updated to compile sample/vmem.hip for testing

* Public documentation changes

- Use the term "Hardware report block" instead of "Hardware block"
- Add documentation for "--list-metrics" option in profile mode
- Add example of filtering by hardware report block such as instruction
  mix and wavefront launch statistics
- Add deprecation warning for hardware component (sq, tcc) based filtering

[ROCm/rocprofiler-compute commit: 55cf0e237e]
2025-03-10 14:42:56 -04:00
Peter Park 3335ea5f21 Fix name in package manager install docs (#593)
* Fix post analysis gui in standalone binary (#591)

* Fix post analysis gui in standalone binary

* Add post analysis gui assets and required server libraries for GUI
  server and web page

* Add port forwarding to docker test compose

* Update README me to use `docker compose up` instead of `docker compose run`
  to run containers with port forwarding and to leverage other
  functionalities of docker compose

* Fix rocprofv1 output processing. (#588)

* fix rocprof-compute binary name in package manager install docs

---------

Co-authored-by: vedithal-amd <Vignesh.Edithal@amd.com>
Co-authored-by: xuchen-amd <xuchen@amd.com>

[ROCm/rocprofiler-compute commit: 0aefd15b7b]
2025-03-10 13:47:30 -04:00
cfallows-amd 54ec17a185 FP8 roofline support (#592)
Adding FP8 datatype to roofline feature in rocprof-compute on MI300-based systems.
FP8 now shows in terminal output and roofline csv, and outputs a standalone PDF.

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: 848fa1dc18]
2025-03-07 11:27:01 -05:00
Fei Zheng 5793abe46e fix specs-correction
[ROCm/rocprofiler-compute commit: f64c83fc5e]
2025-03-07 11:27:01 -05:00
xuchen-amd 66d538c2e0 Disable --kokkos-trace in rocprof-compute (#594)
.

[ROCm/rocprofiler-compute commit: 1b6bc89137]
2025-03-07 11:27:01 -05:00
xuchen-amd 663a41075b Fix rocprofv1 output processing. (#588)
[ROCm/rocprofiler-compute commit: b81310070e]
2025-03-07 11:27:01 -05:00
vedithal-amd 536fb5ea26 Fix post analysis gui in standalone binary (#591)
* Fix post analysis gui in standalone binary

* Add post analysis gui assets and required server libraries for GUI
  server and web page

* Add port forwarding to docker test compose

* Update README me to use `docker compose up` instead of `docker compose run`
  to run containers with port forwarding and to leverage other
  functionalities of docker compose

[ROCm/rocprofiler-compute commit: 0b3114fa88]
2025-03-07 11:27:01 -05:00
dependabot[bot] 254592953c Bump rocm-docs-core from 1.15.0 to 1.17.0 in /docs/sphinx (#572)
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.15.0 to 1.17.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.15.0...v1.17.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: 3b78dc9177]
2025-02-28 16:34:11 -07:00
Fei Zheng a8ade68e64 Change normal_unit default to per_kernel
[ROCm/rocprofiler-compute commit: 6ece52fbe8]
2025-02-27 12:46:47 -07:00
vedithal-amd 4b1979912b clear yum metadata before yum install (#582)
[ROCm/rocprofiler-compute commit: bec537e2a1]
2025-02-27 09:39:26 -05:00
Fei Zheng a9f021e17c Add FP8 metrics for MI300
[ROCm/rocprofiler-compute commit: 58217f2c6a]
2025-02-26 18:45:19 -07:00
vedithal-amd 2fc811bbbd Do not fail if VERSION.sha not found (#579)
* Create VERSION.sha file while creating standalone binary

* Do not fail on VERSION.sha not found

* Add git to docker container for testing

[ROCm/rocprofiler-compute commit: 19a9365bb9]
2025-02-26 11:39:37 -05:00
vedithal-amd 4a890ce8d0 Check PATH to verify executable in remaining args (#578)
[ROCm/rocprofiler-compute commit: 649660d54e]
2025-02-24 13:33:55 -05:00
xuchen-amd 69f0312b7b Improve kokkos trace handling. (#573)
* Improve kokkos trace is handling.

* Fix formatting.

* Syntax fix and adding comments.

[ROCm/rocprofiler-compute commit: 10e1d57bfb]
2025-02-22 14:07:14 -05:00
David Galiffi 8c43eec752 Add develop branch to rocm-ci.yml (#571)
Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-compute commit: f5c3e9a48e]
2025-02-21 00:20:02 -05:00
vedithal-amd d045ac8c74 Standalone binary (#546)
* Add cmake function to create standalone binary

* Mention licenses used by dependencies in the LICENSE file

* Add test cases for standalone binary by adding --call-binary option for pytest

* Docker compose file to create standalone binary in standardized RHEL 8 environment

* Add README instructions on how to create and test standalone binary

* Move docker files from utils to docker folder; Add standalone binary testing instructions

* Add CHANGELOG statement

* Use different service names in docker compose files

* Use volume mounting in docker files

[ROCm/rocprofiler-compute commit: 40f79c28b1]
2025-02-20 17:51:57 -05:00
ywang103-amd 216fa7d5f6 Parser: to_int() return None instead of np.nan (#569)
[ROCm/rocprofiler-compute commit: e5803eb243]
2025-02-20 10:20:06 -05:00
ywang103-amd daf72ade4f fix missing parameter of spatial multiplexing for create_df_pmc (#567)
[ROCm/rocprofiler-compute commit: b9fc44992a]
2025-02-14 14:23:16 -05:00
Fei Zheng c6bb033e8b Update changelog
[ROCm/rocprofiler-compute commit: 8c3895e1d1]
2025-02-13 18:05:49 -07:00
ywang103-amd 952b675890 Spatial multiplexing: part2, analysis (#542)
Co-authored-by: Yang Wang <ywang103@amd.com>


[ROCm/rocprofiler-compute commit: 808a9a79ed]
2025-02-13 15:38:59 -08:00
Peter Park a36e280903 Fix links in docs (#564)
[ROCm/rocprofiler-compute commit: 9643afa62d]
2025-02-13 16:24:48 -05:00
cfallows-amd 611704d825 Update CHANGELOG and docs
[ROCm/rocprofiler-compute commit: c03cbf2389]
2025-02-11 10:46:33 -07:00
ywang103-amd 5cc49d6e90 fix crash for running rocprofv3 on mi100 (#557)
* initial hack to fix for v3 stucking on mi100 becasue of -m parameter and missing counter csv file

* proper formating

* refactored profiler option function to take soc arch

* resolve missing step that casued error for profiler option

* fix typo of arch name

* change method of putting soc info into profiler option

* isort and black format

* add comment for the part that handles missing counter csv file

* remove unncecessary import

---------

Co-authored-by: YANG WANG <ywang@ywang-ubuntu.amd.com>

[ROCm/rocprofiler-compute commit: 5ee37b3353]
2025-02-10 17:59:03 -05:00
xuchen-amd 47921fe78d Change profiler mode trace options, the different trace modes (kernel, kokkos (marker), and hip) are now exclusive of each other based on rocprofv3 updates. (#561)
[ROCm/rocprofiler-compute commit: 6391b3ca76]
2025-02-10 16:11:03 -05:00
vedithal-amd 2fcae1b83a Add broken mclk workaround for all arch #453 (#556)
* Add the missing commit from #453

* Remove unnecessary conditional and use 'is' operator

Co-authored-by: Richard Ben <ben.richard@amd.com>

[ROCm/rocprofiler-compute commit: bceddb0943]
2025-02-07 14:54:17 -05:00
xuchen-amd 3891342e95 Improve test run time by editing roofline related tests. (#554)
* Improve test run time by editing roofline related tests.

* Fix formatting.

[ROCm/rocprofiler-compute commit: 3396ba3906]
2025-02-05 14:18:59 -05:00
Vignesh Edithal e68c297cb2 Use github app for develop to amd-staging sync
* Use the token for rocprofiler-compute-runner github app to perform
  auth to bypass amd-staging branch protection


[ROCm/rocprofiler-compute commit: 25b6bbbb3c]
2025-02-03 13:41:14 -05:00
dependabot[bot] bdd0bd0955 Bump rocm-docs-core from 1.14.1 to 1.15.0 in /docs/sphinx (#547)
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.14.1 to 1.15.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.14.1...v1.15.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: 95b600ea58]
2025-01-30 17:25:46 -07:00
xuchen-amd 8039957a53 Enable kokkos trace/features from rocprofv3 in rocprof-compute. (#545)
Signed-off-by: Xuan Chen <xuchen@amd.com>

[ROCm/rocprofiler-compute commit: da1bd045ab]
2025-01-29 13:14:57 -05:00
Cole Ramos aae2e356ea Updates for new default branch (#537)
* Update contributing guide for new default branch

Signed-off-by: coleramos425 <colramos@amd.com>

* Add develop target to related workflows

Signed-off-by: coleramos425 <colramos@amd.com>

* Auto sync develop and staging

Signed-off-by: coleramos425 <colramos@amd.com>

* Run sync every night at 12AM

Signed-off-by: coleramos425 <colramos@amd.com>

* Rename sync workflow

Signed-off-by: coleramos425 <colramos@amd.com>

* Update maintainers guide

Signed-off-by: coleramos425 <colramos@amd.com>

* Update readme

Signed-off-by: coleramos425 <colramos@amd.com>

* Auto accept PRs for daily branch sync

Signed-off-by: coleramos425 <colramos@amd.com>

* Direct merge. No PR for merge required

Signed-off-by: coleramos425 <colramos@amd.com>

---------

Signed-off-by: coleramos425 <colramos@amd.com>

[ROCm/rocprofiler-compute commit: 0a52e6f19d]
2025-01-28 16:40:41 -06:00
Sam Wu c95cfc9bd8 Update documentation requirements (#540)
[ROCm/rocprofiler-compute commit: f58070aff1]
2025-01-24 16:34:03 -07:00
cfallows-amd a64129b34f Add ubuntu 24.04 detection for roofline bin loading. (#541)
Also updated docker script for dev usage.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: 7602341b70]
2025-01-23 19:53:50 -05:00
ywang103-amd 8079e2e10b enable rocprofv3 for all old soc architectures (#539)
* enable rocprofv3 for all old soc archetectures

* remove gfx906 from rocprofv3

[ROCm/rocprofiler-compute commit: 713570908a]
2025-01-23 15:37:00 -05:00
Cole Ramos c5c44a9cba Yearly license update (#538)
* Add license template designation

Signed-off-by: coleramos425 <colramos@amd.com>

* Update license year on *.py

Signed-off-by: coleramos425 <colramos@amd.com>

* Update license year on *.sh

Signed-off-by: coleramos425 <colramos@amd.com>

* Update license year on misc files

Signed-off-by: coleramos425 <colramos@amd.com>

---------

Signed-off-by: coleramos425 <colramos@amd.com>

[ROCm/rocprofiler-compute commit: 34760ff814]
2025-01-23 13:09:32 -06:00
Peter Park 4b097e6832 Specify path to sphinx configuration in .readthedocs.yaml (#536)
[ROCm/rocprofiler-compute commit: 5063e14309]
2025-01-22 15:22:26 -05:00
Peter Park 737feed972 update LICENSE year to 2025 (#530)
[ROCm/rocprofiler-compute commit: bb388b03f1]
2025-01-22 07:03:28 -08:00
dependabot[bot] b0eac39957 Bump rocm-docs-core from 1.12.0 to 1.13.0 in /docs/sphinx (#526)
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.12.0 to 1.13.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.12.0...v1.13.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[ROCm/rocprofiler-compute commit: c99d4525ef]
2025-01-22 07:03:19 -08:00
ywang103-amd 15744be6fc made change on the logic to add roofline file to expected csv list to fix crash on mi100 (#528)
[ROCm/rocprofiler-compute commit: 0dfb87f25f]
2025-01-22 07:03:13 -08:00
vedithal-amd 25888acd3c Quick fix for mpi_support (#527)
[ROCm/rocprofiler-compute commit: c5fec31535]
2025-01-22 07:03:07 -08:00