AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
12,937 Commits 3 Branches 0 Tags
f8d4cca28b3cb2bb0cc8b86b77fa2734bc8abe4d
Commit Graph

12219 Commits

Author SHA1 Message Date
Sarbojit Sarkar a0981a092b SWDEV-343921 - added Max stack size 
Change-Id: I5c1a088e05215ca951afc9d92f8d298c5e3a65f1


[ROCm/clr commit: 27a08a132f]
 2022-08-02 07:13:18 -04:00
Jaydeep Patel cbc97ad59a SWDEV-329516 - Propogate hipErrorSharedObjectInitFailed from getStatFunc. 
Change-Id: I60160f8d0c0dab20649a4e7c03448f4ae9a9c95b


[ROCm/clr commit: c61701323e]
 2022-08-02 01:50:50 -04:00
Laurent Morichetti 7edb46802d Improve hip_prof_api.h's readability 
- Don't pass uint32_t arguments by reference.
- Use nullptr instead of NULL.
- Don't add frivolous typedefs.
- Use correct types when available instead of generic integral types.
- Make all roctracer callbacks extern "C" to prepare for a future change
  that will be removing their declaration from hip_runtime_api.h.
- Rename cb/sem sync and release functions -> reader_lock/writer_lock
  acquire and release.

Change-Id: If203fee077d421a9782fcd34607a413b8c3dcfc8


[ROCm/clr commit: 9f09ca929e]
 2022-08-01 17:11:50 -07:00
Laurent Morichetti 4816acb0b2 Fix a race condition when setting the callbacks 
When acquiring the reader's lock (sem_sync()...sem_release()), it is
possible for a writer to squeeze by if the reader goes into sync_wait().
The writer could re-acquire the entry.sync between entry.sem > 0 and
entry.sync = 0.

void sync_wait(uint32_t id) {
    sem_decrement(id);
    while (entry(id).sync.load()) {}
    // <--- HERE
    sem_increment(id);
}

This could result in both the reader and the writer accessing
{ callback, arg } at the same time, and the reader could read
inconsistent data, for example: { new callback, old arg }.

The solution is to re-test entry.sync when returning from sync_wait():

void sem_sync(uint32_t id) {
    sem_increment(id);
-   if (entry(id).sync.load() == true) sync_wait(id);
+   while (entry(id).sync.load() == true) sync_wait(id);
}

Change-Id: I22f74f4cb9a5f027aac8aa4ed3e633acc19df4b8


[ROCm/clr commit: 6f78083f2a]
 2022-08-01 20:03:10 -04:00
Sarbojit Sarkar 6de0657b08 SWDEV-1 - cleanup 
Change-Id: Ib50424c87cfc76317eb0c114b5dd3553d8ebd9eb


[ROCm/clr commit: e1f1e38d79]
 2022-08-01 00:05:58 -04:00
Chauncey Hui 1d2cb0d3e8 SWDEV-2 - Change OpenCL version number from 3488 to 3489 
[ROCm/clr commit: 2eeb00ba8a]
 2022-07-30 03:00:06 -04:00
Tao Sang 64b9f0a192 SWDEV-286739 - Support hipDeviceAttributeWallClockRate 
Part 3: Add missing declaration of wall_clock64() to fix
compiling issue in device code.
Add querying hipDeviceAttributeWallClockRate.

Change-Id: Ie54771c2f58eeaacdc0248bc116ef193f99eb9b9


[ROCm/clr commit: 9f9fd859db]
 2022-07-28 13:02:42 -04:00
Anusha Godavarthy Surya b66ec1a031 SWDEV-345683 - Fix HIP out of memory 
If for every eventRecord handler is not submitted,
memory is not getting released during hipFree and leads to OOM.

Change-Id: I19b61a0c523502e9e1a3564ce8b791f3e2cea02c


[ROCm/clr commit: 7b1c6d06d5]
 2022-07-28 07:36:38 -04:00
Chauncey Hui 11f9cdebba SWDEV-2 - Change OpenCL version number from 3487 to 3488 
[ROCm/clr commit: 2e98e163a6]
 2022-07-28 03:00:08 -04:00
Ranjith Ramakrishnan 57146de728 SWDEV-346857 - Find ROCM_PATH based on config file path rather than hardcoding 
As per the requirements in SWDEV-287540, config files should not have hard coded /opt/rocm path
Instead of setting ROCM_PATH to /opt/rocm, used hip-config file path to find the rocm path
Validated by printing the CONFIG_PATH and is coming as/opt/rocm-ver/lib/cmake/hip/hip-config.cmake
So need four level up,with file name in the path

Change-Id: Iac01d3a0c0168138c777551165705ed56cf6c3b1


[ROCm/clr commit: f61a87ebb2]
 2022-07-27 15:46:07 -04:00
Maneesh Gupta a2790df62c Revert "SWDEV-264166 - Remove gcnArch" 
This reverts commit d12900e000.

Reason for revert: Moved out to future release

Change-Id: I36b046c8681371baa9e0ccb69d46dad633ee5706


[ROCm/clr commit: d328d72fab]
 2022-07-27 05:22:48 -04:00
Jaydeep Patel 2de8ca99ff SWDEV-338376 - CUDA VMM API mappings 
Change-Id: I47595dbf57fcce352d23842dbbc2b98b4ec97fb5


[ROCm/clr commit: fa786c606a]
 2022-07-27 02:35:13 -04:00
Jaydeep Patel d3daf1ea8b SWDEV-329516 - Don't clear error if setKernels returns false. 
Change-Id: I75f69bcdf01bad63a9273dc37afd69644f6b3b22


[ROCm/clr commit: efedf08327]
 2022-07-27 06:01:00 +00:00
Jaydeep Patel 6f564f9e76 SWDEV-347592 - hipMemAllocationType must be hipMemAllocationTypePinned. 
Change-Id: I36a5c37c6d66587c6804b60a5f0a88efb60801a4


[ROCm/clr commit: 465421e71c]
 2022-07-26 23:46:02 -04:00
Jason Tang d12900e000 SWDEV-264166 - Remove gcnArch 
Change-Id: Ief4bdbdd5373adb73a291633067c9a8e11f05a32


[ROCm/clr commit: ab303e6440]
 2022-07-26 11:49:19 -04:00
Chauncey Hui be8954c04e SWDEV-2 - Change OpenCL version number from 3486 to 3487 
[ROCm/clr commit: 31468d0426]
 2022-07-26 03:00:08 -04:00
Jaydeep Patel f4642fc0d4 SWDEV-347592 - validate hipMemAllocationType & hipMemLocationType 
Change-Id: Ia8c4d3edc7ad96efa429b3530a118199d4f92902


[ROCm/clr commit: 0fed29f77c]
 2022-07-25 23:56:20 -04:00
sdashmiz ab694c23fb SWDEV-346456 - fix test for get/set attr 
- test should allow first calling get function

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I365cd6210a01fd5ae3620711694bdc52e0f90b19


[ROCm/clr commit: 66bde8f336]
 2022-07-25 15:17:27 -04:00
sdashmiz ed46e236d2 SWDEV-346423 - avoid race condition 
- move removing the array from array set earlier to avoid race condition

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I9003c991e3e0f47ed0509ddfdbeaa145b5a1e0f1


[ROCm/clr commit: d0b9e0a4ff]
 2022-07-25 15:17:10 -04:00
sdashmiz fc0d9521f2 SWDEV-347345 - add missing func for nvdia 
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ie2a70778d01948083d724a9d20e1f17541178ec5


[ROCm/clr commit: fefb9ae466]
 2022-07-24 21:38:14 -04:00
Jaydeep Patel a1a75f02f0 SWDEV-345020 - The bit channel description should not allow any channels after a zero channel 
Change-Id: I66e6d25c032d22f9616dc59730f1f094d30c01cf


[ROCm/clr commit: 5b4e0321d4]
 2022-07-24 21:35:26 -04:00
Sarbojit Sarkar 57473658dd SWDEV-343380 - Added hipDrvGetErrorName/String 
Change-Id: If22d87b64f8ffc870c05482d28c7c91fb2b7d041


[ROCm/clr commit: 53be27a84f]
 2022-07-24 21:32:48 -04:00
Ajay 4f985bd9cc SWDEV-342009 SWDEV-340506 - assertion failures in managed variables 
Change-Id: Iac884f2e3cece96e605e353a8851274ba578e8be


[ROCm/clr commit: 789e718549]
 2022-07-22 11:48:34 -04:00
haoyuan2 71bd9ac9b9 SWDEV-342896 - fix incorrect format setting 
Change-Id: I1fa72eefa3b550d41db6a4cc0812771fb0035bdc


[ROCm/clr commit: b96ff76989]
 2022-07-22 11:17:50 -04:00
Satyanvesh Dittakavi 0886b8ad06 SWDEV-340226 - SWDEV-340692 - Fix minor issues with hiprtc Link APIs 
- hiprtcAddLinkData should accept 0 or null as input name
- hiprtcLinkCreate should accept 0 or null as options ptr
- hiprtcCompile should send -fgpu-rdc option to comgr if its present in the options

Change-Id: I84f6e36df5c99b719ee9c67dfc1b4dbcfd8e3172


[ROCm/clr commit: ee27685ac4]
 2022-07-22 07:23:26 -04:00
Anusha Godavarthy Surya 020a8dcede SWDEV-344166 - Updated HIP APIs to return hipErrorNoDevice when there are no devices in the system 
Change-Id: I636828ff39d3b404f89bcc6e2cb7348d92c897ff


[ROCm/clr commit: 0e2b348ef4]
 2022-07-22 06:59:19 -04:00
Satyanvesh Dittakavi 1f258e6eb1 SWDEV-329802 - Refactor PCH to generate the right warp size on Navi GPUs 
Change-Id: I817de9c858c152fee1f586303372820066a09dc9


[ROCm/clr commit: a9935b3257]
 2022-07-22 05:49:59 -04:00
Rakesh Roy 32292bb914 SWDEV-344135 - Enable stream ordered memory and mempool tests 
- Implement CUDA mappings for stream ordered memory allocator and memory pool APIs

Change-Id: I2434118ff043527ec7c3389cd5175e1e21d032bf


[ROCm/clr commit: 9f4214b587]
 2022-07-21 00:05:39 -04:00
Ajay 9ea3a35e5c SWDEV-317716 - Win: hipDeviceGetUuid return default uuid for pal device 
Change-Id: Id102b54c78f031a8e7cc5ab5223cef9a0914d4fd


[ROCm/clr commit: 8b89c05e2f]
 2022-07-21 00:03:33 +00:00
sdashmiz f40f675a64 SWDEV-346448 - fix the missing defines 
for nvdi compile

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ifd0e50a6f8636609fa61680cc719a2f82fb1320c


[ROCm/clr commit: 4bac774783]
 2022-07-20 11:31:50 -04:00
Sarbojit Sarkar bf38d72e0b SWDEV-346461 - Fix for QMCPack tes failure 
Change-Id: I92979f0c16766c28da6b14b6e17364749fe39fe3


[ROCm/clr commit: 7d23707817]
 2022-07-19 02:13:07 -04:00
Sarbojit Sarkar b11cc11a79 SWDEV-1 - Fixed hipGetErrorString 
Change-Id: I7224014b945bafe1cec6d1d0e11184c3459ac1b0


[ROCm/clr commit: 323ed5bd82]
 2022-07-18 03:38:28 -04:00
Ajay 56a71f18a2 SWDEV-327563 - catch2 deviceLib build failure 
Change-Id: I82f95d61f64018a761e45dc8f424af032953fc51


[ROCm/clr commit: 9b18e404ae]
 2022-07-15 21:11:20 -04:00
Brian Sumner 1d88a5df2c SWDEV-343278 - fix conversion functions 
Change-Id: Ib93f886363314e980462ef562c998981bb958569


[ROCm/clr commit: a47887aa0d]
 2022-07-15 16:00:58 -04:00
Ammar ELWazir f72cedce81 SWDEV-345650 - Solving hipKernelNameRefByPtr Stream Issue 
Stream is not important to get the kernel
name from Function that can be found in
the functions_ map.

Change-Id: I164bc3ebcc5552359856e76204d8b124ba0d2f34


[ROCm/clr commit: fb8690f812]
 2022-07-15 15:38:39 -04:00
Chauncey Hui a78bdbd384 SWDEV-2 - Change OpenCL version number from 3485 to 3486 
[ROCm/clr commit: f8627e6121]
 2022-07-15 03:02:41 -04:00
sdashmiz 3389e6077a SWDEV-334233 - add support for p2p in windows 
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I9109120b5444c400e65cfff869cb36e876ffd1fc


[ROCm/clr commit: e176e27bf7]
 2022-07-14 15:07:33 -04:00
Brian Sumner 5a402b9c99 SWDEV-333033 - add safe and unsafe atomic min and max including gfx940 and add missing nvidia support 
Change-Id: I829a0a5fd49c510e77eabbcb92d1a415ef6b5a4c


[ROCm/clr commit: 4375b9f5b9]
 2022-07-14 10:22:42 -04:00
Chauncey Hui f69b6922bb SWDEV-2 - Change OpenCL version number from 3484 to 3485 
[ROCm/clr commit: 782e0f2a8d]
 2022-07-14 03:00:05 -04:00
Jaydeep Patel 40fda3cfe9 SWDEV-343168 - Clean ihipMallocPitch 
Change-Id: Iab1c10ac2aea635ca10cc8bc98141df409ec917c


[ROCm/clr commit: 6b3b62f49e]
 2022-07-14 01:15:08 -04:00
Sarbojit Sarkar 06c0775ca6 SWDEV-345741 - hipDeviceSetLimit windows build error 
Change-Id: I384541b190f1eb9e045553299215345426c5adc2


[ROCm/clr commit: a4d4289382]
 2022-07-13 20:37:32 -04:00
sdashmiz 024e1510b1 SWDEV-321698 - add new enum entries to match cuda 
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: If0a17b3234fd90b1f553a075e02280258000d36a


[ROCm/clr commit: 39dbf65782]
 2022-07-13 10:22:06 -04:00
sdashmiz b0cbdea221 SWDEV-345021 - add check for pointer 
add check for pAllocateArray

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I6c91295c1fe4cffdf22f6b8c07fe0a592c2f4f70


[ROCm/clr commit: 848ae2c06b]
 2022-07-13 10:21:48 -04:00
Maneesh Gupta f34161f293 SWDEV-286739 - VDI needs ROCr 1.6+ 
Change-Id: I5774563edf001eed2994e92713630adbfb75c489


[ROCm/clr commit: 959ba793db]
 2022-07-13 04:15:32 -04:00
Chauncey Hui b6e570ce10 SWDEV-2 - Change OpenCL version number from 3483 to 3484 
[ROCm/clr commit: 39fa4aae1f]
 2022-07-13 03:00:06 -04:00
Saleel Kudchadker 5ba419ac66 SWDEV-301667 - Increase kern arg pool 
Change-Id: Ie4b087ae4aec08fccaaa7958cdf545e4e27ac5c1


[ROCm/clr commit: 6a77f73050]
 2022-07-12 18:42:29 -04:00
Tao Sang 664578080a SWDEV-286739 - Support hipDeviceAttributeWallClockRate 
Part 1: Query constant frequence of wall clock from RocR

Change-Id: I52cbba6d67d11cde6d019c5ab530059f426a9bf2


[ROCm/clr commit: 1e26165cd0]
 2022-07-12 17:53:11 -04:00
Ajay 1a1d2e211e SWDEV-291455 - hiprtc-builtins and hiprtc libraries in install/hip/lib 
Change-Id: I7e499a746e3f7178995863fd27221583a6934e8f


[ROCm/clr commit: 67aa32d697]
 2022-07-12 17:07:15 -04:00
German Andryeyev 4122b89ac6 SWDEV-311271 - Avoid a crash with the default queue 
Move device access after the queue look-up

Change-Id: I799f23ff0299b20437c9a8edae42c38daa3e9ceb


[ROCm/clr commit: ff23c5b716]
 2022-07-12 17:01:06 -04:00
Ajay 39a8a1df8d SWDEV-345188 - hipamd: warnings treated as errors for catch tests 
Change-Id: I8981a530da2e0213c60f7a81b09d9c36e27e9025


[ROCm/clr commit: 9eb45dd1e0]
 2022-07-12 15:34:39 -04:00