Commit Graph

12219 Commits

Author SHA1 Message Date
Christophe Paquot dc2aab85b2 SWDEV-322620 - Virtual Memory Management
Introducing a VirtualMemObj map as it is needed to differentiate
between virtual address ranges and actual physical memory
This is because a whole VA range can have several physical memories
as chunks.

Change-Id: Ie2a972b4faf3f7d552cfa53e77898f80ad75740a


[ROCm/clr commit: 905088e4e7]
2022-06-06 11:32:22 -07:00
Todd tiantuo Li 4f86eae6f8 SWDEV-339551 - Prevent ICD from loading outdated amdocl binary
1.Keep track of library name in KHRicdVendorRec
2.Check if library with the same name has already been loaded before adding it in ICD list
CL#1760530

Change-Id: I1e0356422c71963788b76019b0d8db5b8542f9ee


[ROCm/clr commit: ed40c24fa3]
2022-06-06 05:42:19 -07:00
Cordell Bloor 3805867b8b Merge "SWDEV-337169 - Fix CRLF in oclperf.exclude" into amd-staging
[ROCm/clr commit: 7fdb3d3c97]
2022-06-02 14:59:52 -04:00
Chauncey Hui d08bc8107c SWDEV-2 - Change OpenCL version number from 3469 to 3470
[ROCm/clr commit: 58aaa8472e]
2022-06-01 03:00:07 -04:00
Rakesh Roy f80bffb4ab SWDEV-337776 - Fix hipStreamEndCapture API
- Return hipErrorInvalidValue when pGraph is nullptr

Change-Id: I8846f4448eb15117f98421632885330f132c4fce


[ROCm/clr commit: e2874d5e22]
2022-06-01 00:20:23 -04:00
Sourabh Betigeri ea9847c1fd SWDEV-320640 - Fixes to return right error codes in hipStreamUpdateCaptureDependencies() for negative scenarios
Change-Id: I3c4c54f8955fa9bb17eb595544005fe9f0e8a5f0


[ROCm/clr commit: 5a057af564]
2022-05-31 14:09:22 -04:00
pghafari de626141ee SWDEV-337703 - nullptr check for hipMallocArray
Change-Id: I3b1077e236ccda346d337109014ef7fd2e693ec6


[ROCm/clr commit: 8e28413a9e]
2022-05-31 11:19:59 -04:00
neqochan 996e8ea2b3 SWDEV-1 - Fix illegal atomic initialization
See https://stackoverflow.com/a/21710850 for an extensive discussion.

This is a cherry-pick from a github pull request:
https://github.com/ROCm-Developer-Tools/ROCclr/pull/29

Change-Id: I87a58548d2995ab51a7cd6e684b5442e5b300923


[ROCm/clr commit: ebfa343827]
2022-05-31 09:51:44 -04:00
pghafari 48350aea01 SWDEV-336550 - added nullptr check for svm
Change-Id: Icfd7dab1c7818958108385261542526d4545721d


[ROCm/clr commit: 2870b7ddd5]
2022-05-30 16:58:45 -04:00
kjayapra-amd 9bc0d08679 SWDEV-290384 - Add Linker API support in hiprtc
Change-Id: I4621a033a22e4da0201c3804e2b357470a681ab0


[ROCm/clr commit: 84f94fd134]
2022-05-24 09:16:14 -04:00
Chauncey Hui 2f46f23b66 SWDEV-2 - Change OpenCL version number from 3468 to 3469
[ROCm/clr commit: 5f0b129e26]
2022-05-21 03:00:05 -04:00
German Andryeyev df01016c97 SWDEV-336024 - Clear device heap to 0 in ROCr path
Change-Id: Id100ca6d6d5bd7fb16ca8c98ff0b12c9df1d69ab


[ROCm/clr commit: 830898753d]
2022-05-20 11:51:08 -04:00
Chauncey Hui d9722102c0 SWDEV-2 - Change OpenCL version number from 3467 to 3468
[ROCm/clr commit: 4aee5e21fb]
2022-05-20 03:00:10 -04:00
German Andryeyev 0ecf22bb53 SWDEV-336024 - Clear device heap to 0
This reverts commit 8624574866.

Reason for revert: Fix regressions

Change-Id: I7d883e1c3cbd27bb64b581ec800243ad7dfe24fd


[ROCm/clr commit: 07c1b9a998]
2022-05-19 09:10:08 -04:00
Jason Tang c5495a181c SWDEV-1 - Remove unused code.
To fix Linux hsail build error.

Change-Id: I4cab060e0e8cefb4215cefa61b840a94d51748a4


[ROCm/clr commit: c7000b4f6f]
2022-05-19 08:54:15 -04:00
Maneesh Gupta 2491ef410c SWDEV-324128 - Fix typo in packaging cmake
Fixes typo introduced by 3b13118ea8

Change-Id: I6c9a3fa31df14262f26d1339d3661248fa43eefb


[ROCm/clr commit: 176acb9315]
2022-05-19 09:32:42 +00:00
Chauncey Hui 826e3ad08d SWDEV-2 - Change OpenCL version number from 3466 to 3467
[ROCm/clr commit: 0ed1a369fe]
2022-05-19 03:00:05 -04:00
Sarbojit Sarkar ee5bcf6444 SWDEV-331066 - support for LimitStackSize
Change-Id: Ie6ae74f008b4f72de83663194aafb0ebdddfc8b6


[ROCm/clr commit: 51a00aeefe]
2022-05-19 00:24:06 -04:00
Rakesh Roy 85f42de77c SWDEV-337119 - Validate width isn't exceeding either dpitch or spitch in
ihipMemcpy2D

Change-Id: I8ac68e033762616a42585b26f0b3aa5bbb29ce9c


[ROCm/clr commit: 01a5ddebe6]
2022-05-18 23:25:14 +05:30
Satyanvesh Dittakavi 8e9541dbbd SWDEV-334908 - Guard the __noinline__ macro as it is also supported as keyword by clang
Change-Id: I314b3ac463ea63132a5107f4f24ce769d8112b9b


[ROCm/clr commit: 8dfa7e7f98]
2022-05-18 05:51:32 -04:00
Chauncey Hui 11335d2146 SWDEV-2 - Change OpenCL version number from 3465 to 3466
[ROCm/clr commit: ef041e81b1]
2022-05-18 03:00:06 -04:00
pghafari b2188142d9 SWDEV-336576 - updated graph check
hipGraphExecMemcpyNodeSetParamsFromSymbo was not working in functional
case

Change-Id: I2ad04f6f91519efa075c36fe737a695fa1bc127a


[ROCm/clr commit: bb9e52ab9f]
2022-05-17 17:36:10 -04:00
Christophe Paquot a3c9b7dde6 SWDEV-322620 - Virtual Memory Management
Report virtual memory management support.

Change-Id: I448a66c86ab1b2d28f6052e8896ea505e56eb2d2


[ROCm/clr commit: 60656d9fc9]
2022-05-17 16:24:53 -04:00
German Andryeyev fd78a0d797 SWDEV-334315 - Correct instruction timing API info
Change-Id: I9d291adac076d36776dc7316b411bd093230ca01


[ROCm/clr commit: f0309be0de]
2022-05-17 10:17:07 -04:00
Todd tiantuo Li 02d0c32f2b Merge "SWDEV-315047 - add Raphael(gfx1036) to OCLDeviceQueries" into amd-staging
[ROCm/clr commit: f34c0c2f82]
2022-05-17 05:41:49 -04:00
Chauncey Hui 0cb85dd120 SWDEV-2 - Change OpenCL version number from 3464 to 3465
[ROCm/clr commit: 8d8dc60fb9]
2022-05-17 03:00:12 -04:00
German Andryeyev 43ef8bb204 SWDEV-331660 - Switch PAL interface to 734
Update clientApiId field in PlatformCreateInfo

Change-Id: I445b9712a4c0da9f32e86df8b4a1b8dd7365b11b


[ROCm/clr commit: 893b719181]
2022-05-16 22:58:50 -04:00
German Andryeyev 6c08b9a8a3 SWDEV-336024 - Add a check for nullptr in HeapBuffer()
Change-Id: Ib8a3f2757c8600c4bd5bed417b230a60d4cf3d42


[ROCm/clr commit: 2f04eb90d3]
2022-05-16 09:41:47 -04:00
Satyanvesh Dittakavi 23ba31d7bf SWDEV-332606 - SWDEV-333585 - Fix hipMemcpySymbol* and hipGetSymbol* APIs
This also fixes the QMCPack staging (SWDEV-335826) test failures related
to hipMemcpyToSymbol

Change-Id: Icc3ff04fb1e17999f5bddf12e1a7266e2289032f


[ROCm/clr commit: 8a333a989b]
2022-05-16 04:27:02 -04:00
Cordell Bloor eef8567684 SWDEV-337169 - Fix CRLF in oclperf.exclude
Renormalized line endings in tests/ocltst/module/perf/oclperf.exclude
to fix the Debian packaging problems reported in
https://github.com/RadeonOpenCompute/ROCm-OpenCL-Runtime/issues/140

Change-Id: I4fdc7c52e60078ec6048678679acdc5d5e5b715b
Signed-off-by: Cordell Bloor <Cordell.Bloor@amd.com>


[ROCm/clr commit: 1f5f4271ae]
2022-05-15 19:06:22 -06:00
Chauncey Hui 1357de3873 SWDEV-2 - Change OpenCL version number from 3463 to 3464
[ROCm/clr commit: f41f227a33]
2022-05-13 03:00:08 -04:00
Tao Sang 79d6018cd7 SWDEV-319818 - Revert change on hipResourceViewDesc
Revert part of
http://gerrit-git.amd.com/c/compute/ec/hipamd/+/675588

Change-Id: Iee9dac9f8c50aa9b6a12ca9d8fd792a51973b8cd


[ROCm/clr commit: 4561a207dd]
2022-05-12 12:14:13 -04:00
German Andryeyev 8116b92de6 SWDEV-334315 - Update PAL version and provide API info for RGP
Change-Id: Ied448aada09deabcf26c402a342bdfbd79f22d7b


[ROCm/clr commit: b39dfabb58]
2022-05-12 09:30:19 -04:00
Satyanvesh Dittakavi a206abcaa1 SWDEV-335780 - Address OOM issue with BERT MLPerf
Memory free was not happening due to no flush

Change-Id: Iee9d2c9f8c50aa9b6012ca9d8fd792a51973b8c8


[ROCm/clr commit: f6e21144ae]
2022-05-11 13:03:32 -04:00
German Andryeyev a7d73a753d SWDEV-311271 - Enable MGPU support for memory pool
Change-Id: I36850de282d62139b5cfe342df97bb1204cb7869


[ROCm/clr commit: 8b132beb92]
2022-05-11 11:04:24 -04:00
German Andryeyev 8624574866 SWDEV-336024 - Clear device heap to 0
The heap must be cleared once per device, but ROCclr doesn't
create a queue per device in HIP. Hence, the clear operation will
be performed during the first queue creation.

Change-Id: I52ceb06d67d11cde6d019c5ab510059f426a9bfb


[ROCm/clr commit: 04bfd93569]
2022-05-11 11:03:56 -04:00
Chauncey Hui d63201c1d4 SWDEV-2 - Change OpenCL version number from 3462 to 3463
[ROCm/clr commit: 6c458c7534]
2022-05-11 03:00:08 -04:00
Tao Sang 1a9a5f9bfc SWDEV-319818 - Release restriction on hipResourceViewDesc
Let more types support hipResourceViewDesc.
Add missing symbols to fix cuda build failing.

Change-Id: Ife694cc6491427093863252e257e820b0bb4fa0f


[ROCm/clr commit: a19b767e8a]
2022-05-10 15:57:31 -04:00
Jeremy Newton b53cb9e585 SWDEV-336248 - Use public icd header
HIP uses icd_dispatch.h, which is not a public header. Using the public
CL/cl_icd.h removes inclusion of the private header.

This allows compiling HIP without relying on OCL ICD source, which makes
distributing a standalone ROCclr easier.

For WIN32, a few other headers are required.

Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
Change-Id: I0cab173b9753c5b0ab3be9222aa8bb0545cdeaab


[ROCm/clr commit: d04938a6ad]
2022-05-10 13:46:08 -04:00
Sourabh Betigeri 1171423bcf SWDEV-329829 - Fixes to return right error codes for respective negative scenarios
Change-Id: Icb615a336bb846df1cf2811316d88a0e88381da8


[ROCm/clr commit: 5fa514fea0]
2022-05-10 12:56:20 -04:00
Todd tiantuo Li c75c34f099 SWDEV-315047 - add Raphael(gfx1036) to OCLDeviceQueries
Change-Id: Iaa930c5ea9e39f9c44b1a5d737fc3520e9b6eca8


[ROCm/clr commit: 6c4ab575ca]
2022-05-10 02:37:42 -07:00
Christophe Paquot 2c3faaa3a0 SWDEV-322620 - Virtual Memory Management
Add a virtualMemoryManagement_ flag to device.info.

Change-Id: Iabd039010d83fc51b4bcef600c609f5c65e7b1ae


[ROCm/clr commit: b4645c7d4e]
2022-05-09 22:54:42 -07:00
Rakesh Roy 5a9a25fcb6 Revert "SWDEV-332606 - SWDEV-333585 - Fix hipMemcpySymbol* and hipGetSymbol* APIs"
This reverts commit 1ab7f22334 due to QMCPack test failure (SWDEV-335826)

Change-Id: I40397b345aa60f43afc17853bc72426daf385cf7


[ROCm/clr commit: 84c46047e5]
2022-05-10 11:20:36 +05:30
Alex Xie 9811bbaa4f SWDEV-328156 - Palamida scan remediation
Change-Id: I7e2ae4afea117630cfc43d2cd0f0fd6d98fe4f58


[ROCm/clr commit: aa8a31b1d8]
2022-05-09 19:24:09 -04:00
Jeremy Newton 90d46dc278 SWDEV-336248 - Don't exclude cl_egl.h from install
cl_icd.h includes cl_egl.h, but cl_egl.h is excluded from install. It
was reported by the community that including cl_icd.h would error due to
the missing cl_egl.h file.

I'm assuming that cl_egl.h was excluded because EGL isn't important for
ROCm. Since cl_icd.h has some important typedefs, it makes sense just
to include cl_egl.h, which seems to be a common practice in open source
projects.

Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
Change-Id: I506257c2dc51512ec8e11b1e5dadbe6e48ad785b


[ROCm/clr commit: e9dd848149]
2022-05-09 14:33:00 -04:00
Cordell Bloor 2e0b90e818 SWDEV-335902 - Fix HIP when Git info unavailable
Prior to this change, when Git_FOUND was false, HIP_VERSION_BUILD_ID
would be undefined in the CMake code. The value of HIP_VERSION_BUILD_ID
in <hip/hip_version.h> is taken from the CMake variable, so it was being
defined as nothing in those cases. That would cause compilation failures,
as src/hip_global.cpp contains the function:

    size_t amd_dbgapi_get_build_id() {
      return HIP_VERSION_BUILD_ID;
    }

which would become

    size_t amd_dbgapi_get_build_id() {
      return ;
    }

after preprocessing. To prevent this, we can define the version
information to a default value when Git is not found.

A related problem was reported by Harmen Stoppels in
https://github.com/ROCm-Developer-Tools/HIP/pull/2218. When Git
is not available (or if the library is being built from a tarball),
the HIP_VERSION_GITHASH is not defined. This causes trouble because
HIP_LIB_VERSION_STRING is defined as "X.Y.Z-${HIP_VERSION_GITHASH}"
and therefore becomes "X.Y.Z-".

The incomplete version string becomes a problem when it is appended
to the shared library file name. File names that end with '-' confuse
the linker. They cause strange errors when attempting to link to the
HIP library. This problem can be prevented by dropping the trailing
dash and using "X.Y.Z" as the version string when HIP_VERSION_GITHASH
is not defined.

Change-Id: I6e290c1f1b603ba30c9ded885e125d9ca9a2e688
Signed-off-by: Cordell Bloor <Cordell.Bloor@amd.com>


[ROCm/clr commit: 9c450d6f66]
2022-05-09 13:44:09 -04:00
Rakesh Roy b175689cd2 SWDEV-333598 - Use flags field of amd::Memory UserData for hip flags
Change-Id: I492c7fe54dba4380fcc53eed1df36bf5ac0af852


[ROCm/clr commit: 4e86d538e5]
2022-05-06 13:42:19 +05:30
Chauncey Hui f8a4c3c29f SWDEV-2 - Change OpenCL version number from 3461 to 3462
[ROCm/clr commit: 61895fb39b]
2022-05-06 03:00:04 -04:00
Rakesh Roy 52f85f8475 SWDEV-333598 - Add flags field in amd::Memory UserData
Change-Id: Ie4d59fa34486679fde1027dd113573bda3e7c65c


[ROCm/clr commit: ac2c3b5cad]
2022-05-05 12:24:53 -04:00
Chauncey Hui 324686c9d2 SWDEV-2 - Change OpenCL version number from 3460 to 3461
[ROCm/clr commit: 04b860a20e]
2022-05-05 03:00:05 -04:00