Alex Voicu
f93859cdc2
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
2017-11-16 23:20:15 +00:00
Maneesh Gupta
85975e719d
Merge pull request #261 from gargrahul/fix_module_api_sample
...
Fix module_api sample
2017-11-13 11:55:54 +05:30
Rahul Garg
83adf6525e
Fix module_api sample
2017-11-13 08:56:39 +05:30
Alex Voicu
819e72fba6
Add omitted changes in CMakeLists.txt.
2017-11-10 01:20:50 +00:00
Alex Voicu
bd78459690
Update new tests so as to make them work with new variadic based launch mechanisms.
2017-11-10 00:14:34 +00:00
Alex Voicu
f7726cd416
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
2017-11-09 23:43:07 +00:00
Maneesh Gupta
31bcb59f62
Merge pull request #250 from AlexVlx/feature_add_agent_global_support
...
Support for agent globals
2017-11-09 07:52:09 +05:30
Alex Voicu
3d248927e4
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
# Conflicts:
# tests/src/runtimeApi/stream/hipStreamSync2.cpp
2017-11-08 10:26:30 +00:00
Maneesh Gupta
ebd58d43fa
Merge pull request #255 from AlexVlx/remove_some_trailing_whitespace
...
Clean up trailing whitespace so as to reduce noise in #246 .
2017-11-08 10:29:19 +05:30
Maneesh Gupta
caa7174652
Merge pull request #253 from mangupta/hit_add_cmakecmd
...
[hit] Add support for cmake commands as part of test infra
2017-11-08 09:50:29 +05:30
Alex Voicu
d8e323d4b5
Clean up trailing whitespace so as to reduce noise in #246 .
2017-11-08 00:08:55 +00:00
Ben Sander
9fd6c18ef8
Merge pull request #254 from bensander/event_thread_safe
...
Event thread safe
2017-11-07 17:59:51 +01:00
Maneesh Gupta
247d563114
Merge pull request #252 from phani544/newTests2
...
More tests for memory,stream & error APIs
2017-11-07 10:38:18 +05:30
Phaneendr-kumar Lanka
e06c546283
identation change in hipPeekAtLastError
2017-11-07 09:51:32 +05:30
Alex Voicu
adaf6b8dff
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
2017-11-07 00:01:22 +00:00
Ben Sander
f278f67d2d
Check for null event in hipEventElapsedTime
2017-11-06 23:49:31 +00:00
Ben Sander
16708dd2e0
hipStreamWaitEvent returns success if event created but not recorded
2017-11-06 23:49:31 +00:00
Ben Sander
4a2e6f8955
Make hipEvent_t thread safe.
...
Support re-recording of same event by different threads.
- Add criticalData structure to hipEvent_t, similar to mechanism used
for streams, contexts, device. Events are always locked
after streams to avoid deadlock.
- ihipEvent_t::locked_copyCrit can be used to copy critical state
including marker. The critical state in the event can then
be re-recorded.
- refactor hipEventElapsedTime. Remmove stale debug code, native signal
refs.
2017-11-06 23:49:25 +00:00
Maneesh Gupta
197a7e2600
[hit] Add support for cmake commands as part of test infra
...
Cmake supports several builtin command-line tools. These tools can
now be specified as part of the HIT block. These commands will be
run during cmake configure step.
Change-Id: I32466c94b2fe1ecdc30249755fc027102295617d
2017-11-06 16:53:57 +05:30
Phaneendr-kumar Lanka
9ee330451a
Modified tests as per review
2017-11-06 15:13:36 +05:30
Phaneendr-kumar Lanka
093279b10b
More tests for memory,stream & error APIs
2017-11-06 11:31:52 +05:30
Maneesh Gupta
1131c9e41a
Merge pull request #251 from ROCm-Developer-Tools/fix_event_state
...
Set event state AFTER it is recorded.
2017-11-06 07:28:11 +05:30
Maneesh Gupta
a62d5aa875
Merge pull request #249 from bensander/warn_event
...
Add HIP_DB=warn + message if sync on dangerous event.
2017-11-06 07:25:40 +05:30
Maneesh Gupta
2f4e1983e2
Merge pull request #239 from phani544/newTests
...
[newTests]Adding tests for device APIs
2017-11-06 07:22:13 +05:30
Ben Sander
4c3b65a5cd
Set event state AFTER it is recorded.
2017-11-05 10:33:18 -06:00
Alex Voicu
2932706d47
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
2017-11-03 10:57:12 +00:00
Alex Voicu
bb1176001f
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
# Conflicts:
# src/hip_module.cpp
2017-11-03 10:53:39 +00:00
Phaneendr-kumar Lanka
0599d13b0d
[newTests]modified the test
2017-11-03 14:52:19 +05:30
Phaneendr-kumar Lanka
a764a0980d
[newTests]Modified the test as per review comments
2017-11-03 10:39:47 +05:30
Maneesh Gupta
d90d431490
Merge pull request #248 from mangupta/SWDEV-134531
...
Remove libsupc++ dependency from HIP
2017-11-03 08:01:59 +05:30
Alex Voicu
328c18b886
This introduces correct support for agent global variables, and implements hipModuleGetGlobal as an actual equivalent for cuModuleGetGlobal.
2017-11-03 01:44:48 +00:00
Ben Sander
67dd5303ad
Merge pull request #247 from AlexVlx/feature_cleanup_tests
...
Test cleanup
2017-11-02 11:31:10 +01:00
Maneesh Gupta
f34f5c8684
Remove libsupc++ dependency from HIP
...
Change-Id: Ib843f99dfb3057b7c28029250c2449732ea7f17f
2017-11-02 12:29:09 +05:30
Alex Voicu
a619ac6f92
This corrects some interesting choices that were present in the HIP
...
unit tests such as e.g. de-allocating memory allocated with new[] using
free. All of these were identified via cppcheck.
2017-11-01 22:51:22 +00:00
Alex Voicu
2cacda91bb
Correctly deal with functions from shared objects, wherein the program visible VA == so_base_va + st_value(function_symbol). Remove quaint usage of pfe for hipMemset (which is actually fill_n).
2017-11-01 22:33:13 +00:00
Ben Sander
09d866a639
Merge pull request #237 from bensander/use_ctxptr_for_p2p
...
Use ctxptr for p2p
2017-11-01 18:55:25 +01:00
Ben Sander
70c25bdf8e
Add HIP_DB=warn + message if sync on dangerous event.
2017-11-01 10:44:34 -07:00
Ben Sander
86f62accfd
Merge pull request #245 from scchan/centos_fixes
...
various fixes for centos/rhel
2017-11-01 18:10:29 +01:00
Alex Voicu
c2482d1255
This switches HIP from its currently convoluted macro + pfe based dispatch mechanism to a more natural one partially based on the existing module API. The basic idea is that HCC will always correctly emit __global__ functions: as empty-bodied stubs, on host, and as kernels, on device. It then becomes trivial to obtain the mangled name on host, at dispatch, from the function's address, and then to use the mangled name to retrieve the kernel. This should address all problems stemming from serialisation, dubious mismatches due to the manufactured functor, macro-isms et al. It also immediately enables support for generalised globals as a consequence of that being available in the module API. Finally, it will make debug much easier, since the actual names of the __global__ functions will automatically be used in traces etc. One detail is that due to how dispatch works now (hipLaunchKernel and hipLaunchKernelGGL are themselves variadic function templates which deduce the function type of the callee), in certain cases it may be necesssary to insert explicit casts to ensure that the variadic argument list selects a viable overload - this can be observed in some unit tests. Eventually we may be able to remove this limitation, but for now it does not appear terribly onerous. The code is not extremely HIPpie, nor is it fully optimised, but rather is intended as a starting point for the HIP team to make its own.
2017-11-01 15:09:59 +00:00
Siu Chi Chan
99d32a195f
Centos/RHEL - remove usage of constexpr since libc++ doesn't enable ctor for constexpr pair in C++11
2017-10-31 18:16:12 +00:00
Siu Chi Chan
cd6996614f
use libc++ on centos 7 and rhel 7.4
2017-10-31 18:14:07 +00:00
Maneesh Gupta
f27c2c1715
Merge pull request #197 from bensander/update_coherency_tests
...
Update coherency tests
2017-10-31 17:26:50 +05:30
Maneesh Gupta
4d85b6ab29
Merge pull request #241 from ROCm-Developer-Tools/multi_host
...
Inital codes to remove x86_64 dependency in HIP source build
2017-10-31 16:35:12 +05:30
Maneesh Gupta
7026b73905
Merge pull request #242 from bensander/time_hip_apis
...
Add ns-level timer for HIP API routines
2017-10-31 16:33:46 +05:30
Ben Sander
7e908bdec8
Add ns-level timer for HIP API routines
...
Refactor some miuses of ihipLogStatus, these should only be in top-level
HIP APIs and should be paired with HIP_API_INIT calls.
2017-10-30 20:20:51 +00:00
Wen-Heng (Jack) Chung
92fb244841
Inital codes to remove x86_64 dependency in HIP source build
2017-10-30 15:19:23 -05:00
Ben Sander
2e8ec71e40
Merge pull request #222 from bensander/fix_device_prop
...
Fix device prop
2017-10-30 17:58:48 +01:00
Ben Sander
d610f16c47
Check for null copyEngine before looking at peers.
2017-10-30 16:58:03 +00:00
Ben Sander
f8843ae415
Merge pull request #226 from scchan/add_printf3
...
add printf to HIP device functions
2017-10-30 17:08:18 +01:00
Phaneendr-kumar Lanka
511de63bcb
[newTests]Adding tests for device APIs
2017-10-30 14:34:24 +05:30