Grafico dei commit

6707 Commit

Autore SHA1 Messaggio Data
Ioannis Assiouras 4a96c2fe15 SWDEV-435715 - Acquire the streamSetLock prior to iterating the set in WaitActiveStreams
Change-Id: I0a9721dcde1a3716192d532e290d8a7afc8ac9fc


[ROCm/clr commit: 3c6505c2d5]
2023-12-05 04:12:24 -05:00
Satyanvesh Dittakavi 85e9925335 Revert "SWDEV-431175 - Remove datatypes from HIPRTC"
This reverts commit 6035b47801.

Reason for revert: This is considered a breaking change and requires
multiple apps to change their behavior. This will be reintroduced in later releases.

Change-Id: I0354ce4e0f5e6c402499a7a8c2aaf43bf5b1bfc7


[ROCm/clr commit: 270c6d48f1]
2023-12-05 02:32:38 -05:00
Ioannis Assiouras 73c249bb59 SWDEV-435168 - Added virtual destructor in StreamCallback
Change-Id: I548f34e4f4208658a5a6c35927fc424415186354


[ROCm/clr commit: 8a53c97fd1]
2023-12-04 17:32:45 -05:00
Jatin Chaudhary c9b5c5c657 SWDEV-431399 - add const cast to pointer before casting it to function type.
C++ does not allow const qualifier on function type, even if we add it it will get ignored and clang will fail with failed cast from const void* to func*. const_cast here is necessary to make it work.

Change-Id: I72cec8d9e715bdf9e163cb9b08393dd733dafaf2


[ROCm/clr commit: 5b5213adf5]
2023-12-04 04:34:57 -05:00
Ioannis Assiouras ab411c8f34 SWDEV-434702 - get the nullstream in constant time in iHipWaitActiveStreams
Change-Id: Ib92cc4d2ca1b725cf30b24cdd711c873fd513d95


[ROCm/clr commit: 8bdda90071]
2023-12-03 19:05:18 -05:00
Satyanvesh Dittakavi 66b4a403a6 SWDEV-434362 - Replace __HIP_CLANG_ONLY__ as it is not supported on HIPRTC
__HIP_CLANG_ONLY__ is not recognized in HIPRTC, due to which some
math functions like amd_mixed_dot were not included in hiprtc builtins.

Change-Id: I1fe41e1ddc8911f6a5b5b1405dd4730d0170a4f7


[ROCm/clr commit: f0010f4fdb]
2023-11-29 04:22:19 -05:00
Satyanvesh Dittakavi 6035b47801 SWDEV-431175 - Remove datatypes from HIPRTC
Defining int64_t, uint64_t, int32_t, uint32_t in HIPRTC
seem to result in conflicts with some apps as they use
their own definitions for these types. NVRTC also doesn't
define these. Hence remove them to match the behavior.

Change-Id: I77ef70e846950698cb00375f5d0501b907f01fe3


[ROCm/clr commit: 629e279f72]
2023-11-28 11:32:12 -05:00
Anusha GodavarthySurya 3bdedf0cc7 SWDEV-351966 - Dispatch table for hip runtime
Change-Id: Ie4a44fa8cf1ff9c152146070bbbf6b0636d4e325


[ROCm/clr commit: 5e21f0c6bd]
2023-11-22 01:11:19 -05:00
Ioannis Assiouras 4593cb2ef8 SWDEV-433069 - Fixed hip mempool impl SetAttribute switch-case
Change-Id: I0b1b8414db09051125dae4ea98f70827f10c4b98


[ROCm/clr commit: 3e6b4a528d]
2023-11-17 17:51:39 -05:00
Rahul Garg e1889b77b4 SWDEV-427855 - Revert "SWDEV-427855 - hipamd change for profiler and TF fix"
This reverts commit 7478e90727.

Reason for revert: <Need rocprofiler changes to avoid PSDB failures>

Change-Id: I856b7ea30744f1b7bb099b6adbce2155201be539


[ROCm/clr commit: 57cb840058]
2023-11-16 00:20:54 -05:00
jiabaxie 7478e90727 SWDEV-427855 - hipamd change for profiler and TF fix
Change-Id: If32eb0ee152f3f46741a8277689363181c8753e8


[ROCm/clr commit: 3b9963c499]
2023-11-15 23:36:52 -05:00
Jaydeep Patel 7fc7ba2288 SWDEV-432530 - Change to --hip-path.
Change-Id: I6fb2fd9111750f4fe5a56be440841ec32c0aa53c


[ROCm/clr commit: 067e2a355f]
2023-11-15 23:22:44 -05:00
Saleel Kudchadker cb9a715e04 SWDEV-422207 - Report kernel names for activity profiling
- Report kernel names for optimized graph path
- Refactor code so that we store profiling info in Accumulate command

Change-Id: Ib97735a0239aeb9fc3a50a4bb7126dd0bcadc8af


[ROCm/clr commit: b056686607]
2023-11-15 14:38:07 -05:00
Jatin Chaudhary d3bcc29cd6 SWDEV-422808 - Add entries for missing hipDataType
Change-Id: I6c41f8497564e1d718a3b5bc09c45ec4b53fd25f


[ROCm/clr commit: 7e59460ba0]
2023-11-15 11:15:13 -05:00
Joseph Greathouse 79b9dedbb4 SWDEV-431560 - use XCC_ID in __smid() for gfx941 and gfx942
__smid() needs to use both HW_ID and XCC_ID for gfx940, gfx941, and
gfx942. Previously, we only did this for gfx940 and thus XCC_ID
was incorrectly not passed back on the other two architectures.

Change-Id: I9fb13b6cef3280e15463443a180174629d03f8b2


[ROCm/clr commit: a0f29b454c]
2023-11-15 10:10:47 -05:00
Jatin Chaudhary c2f944f899 SWDEV-432339 - consider HIPCC_VERBOSE output while parsing hipcc output for compiler rt
Change-Id: I146e188c4d47bede25a479933fa41e4c64ce89eb


[ROCm/clr commit: 515d07cb3a]
2023-11-15 04:01:08 -05:00
Jatin Chaudhary 2361cc0dab SWDEV-431399 - fix first set of memory leaks in clr, found in rtc tests
change constexpr variable names to match the C++ style we follow.

Change-Id: Ibc59a65d8ff2ca765da7bf5e653c0650fb3714c4


[ROCm/clr commit: ce27581465]
2023-11-14 20:39:45 -05:00
Ioannis Assiouras 803ef23320 SWDEV-432329 - Remove outdated install instructions from hipamd/rocclr subdirs
Change-Id: Ie6793e0a12689aed201d6f6278b8484d707ebdec


[ROCm/clr commit: f6e0f2613c]
2023-11-14 18:55:10 -05:00
Saleel Kudchadker f3c28c6d5c SWDEV-301667 - StreamwaitEvent may not flush caches
Change-Id: I8d648f96273b36d4930216ffa05bf1adb3c408da


[ROCm/clr commit: 514b7fc470]
2023-11-14 15:59:08 -05:00
Tao Sang 8f417d910b SWDEV-432180 - Support hipArraySurfaceLoadStore
Make hipExternalMemoryGetMappedMipmappedArray() accept
hipArraySurfaceLoadStore.
Make hipCreateSurfaceObject() check hipArraySurfaceLoadStore
flag. If flag is hipArrayDefault, hipCreateSurfaceObject() will
also pass to prevent failure of catch2/swissknife tests.

Change-Id: Ifb7db2db14e0c2208a9661cfa33887ec61ab26a5


[ROCm/clr commit: 1c442658ca]
2023-11-14 10:17:07 -05:00
Satyanvesh Dittakavi cf708607da SWDEV-431466 - Fix rocPRIM build failure
Do not populate AMDGPU_TARGETS when there is no device
detected by amdgpu-arch on the machine

Change-Id: I87fd7081f9e0b72f057aab2eb639808d2f89cfb1


[ROCm/clr commit: e36020f339]
2023-11-14 00:23:49 -05:00
Saleel Kudchadker be743bcd59 SWDEV-422207 - Optimize graph end detection
- Do not use extra barrier to detect graph end. If its a kernel node we
can use a completion signal for the last packet. Saves roughly 6us for
Phantom testcase per graph launch.

Change-Id: I5e0c2479d9964fbeda86ed97533f6718f49a7f91


[ROCm/clr commit: c3bd229f4f]
2023-11-10 11:57:02 -05:00
Saleel Kudchadker 85b95f0a45 SWDEV-301667 - Add error logging
Change-Id: I814399dc0e7083bb7fb0ed8bf46dd96bdf664965


[ROCm/clr commit: f06368fd04]
2023-11-10 11:55:54 -05:00
Satyanvesh Dittakavi 2119d83bfb SWDEV-430963 - Address MIGraphX failures due to unsafe buffer access usage
Compiler seem to be stricter in compiler staging builds related to
safe buffer programming when compared to other component staging builds.
This seem to result in additional errors when -Werror is enabled
in MIGraphX tests.

Removes all the clang pragmas to ignore several type of warnings in all
the headers and adds a single pragma which ignores all warnings using
#pragma clang diagnostic ignored "-Weverything" in hiprtc builtins.

Change-Id: I95f302bb285b2451b19dd5dfdb7df29164b0f750


[ROCm/clr commit: b5d286a6d3]
2023-11-09 04:39:49 -04:00
Saleel Kudchadker bd6a5c399e SWDEV-422207 - Workaround HDP register query bug
Change-Id: Ib886a3166b555fbd6b8e5a249f993f47afd00166


[ROCm/clr commit: 9fdee05aee]
2023-11-08 12:12:15 -05:00
Jaydeep Patel 367d211aa2 SWDEV-430966 - Size to unmap should be same as mapped memory size.
Change-Id: Id59990c655e7bb4bb980efe587275296103e1e73


[ROCm/clr commit: 2415701080]
2023-11-07 23:38:06 -05:00
Jaydeep Patel 86902b4d96 SWDEV-425248 - numerous bug fixes.
Set flag with hipCtxCreate so that get flags works.
Validate hipHostGetDevicePointer for flags!=0.
Validate mem cpy kind and accommodate new type hipMemcpyDeviceToDeviceNoCU.
Match error code for hipGetChannelDesc.

Change-Id: If09a635ac01bc53f1fe2b7df3f3f9c1b0d69a0ab


[ROCm/clr commit: 8e8fb993de]
2023-11-07 22:49:20 -05:00
Jatin Chaudhary 85cfa10a3f SWDEV-367537 - fix style inconsistencies seen in some operators
Change-Id: Ib94a26b931b2aa0237335f07f8557a4830c80f23


[ROCm/clr commit: 794ca0522f]
2023-11-07 10:37:02 -05:00
Ioannis Assiouras 9d1a39bba2 SWDEV-430116 - Fix segfault in Heap::EraseAllocaton
Change-Id: I8c49af081079307118562485cb0d5b3e8a9d906a


[ROCm/clr commit: bc2a4f8450]
2023-11-07 09:49:35 -05:00
Satyanvesh Dittakavi 11cc21c6c9 SWDEV-415548 - Use local device arch if AMDGPU_TARGETS is not passed by the app
Change-Id: If4a1621820a4dcd4274080d36341b1ef4e6ce15e


[ROCm/clr commit: d05d08ddc0]
2023-11-06 23:35:18 -05:00
Jatin Chaudhary 5698bb89ce SWDEV-367537 - Add missing operators to __hip_bfloat16 implementation
Add __host__ and __device__ to bunch of operator/function matching CUDA
Fix some bugs seen in __hisinf

Change-Id: I9e67e3e3eb2083b463158f3e250e5221c89b2896


[ROCm/clr commit: 86bd518981]
2023-11-06 18:08:37 -05:00
Saleel Kudchadker 5f009b7cb1 SWDEV-422207 - Track commands for capture
- Track all captured commands under a new AccumulateCommand
- Add begin() and end() methods to capture commands
- Explicit TS object now passed to certain methods because
profilingBegin() and profilingEnd() now happen separately and thus can
run into threading issues

Change-Id: I171106bdcad72b057836cb2f3fc398db3533119f


[ROCm/clr commit: 40f41f4d0b]
2023-11-03 05:09:04 +00:00
Satyanvesh Dittakavi efbe1365b9 SWDEV-430048 - hipMemcpy2D should return success for zero sized arrays
- This matches the CUDA behavior
- The pitch and width checks removed are already covered in ihipmemcpy2D

Change-Id: I03a6921a78b5d89723830d8dde5865fdc6db0379


[ROCm/clr commit: 6d6465cb96]
2023-11-02 00:40:08 -04:00
taosang2 6ea1a64c56 SWDEV-426270 - Remove duplicated operators
Remove duplicated operators of hipComplexFloat and
hipComplexDouble.
If users need complex number multiplication and division,
they should call
hipCmulf() and hipCdivf() for hipComplexFloat,
hipCmul() and hipCdiv() for hipComplexComplex

SWDEV-428198 - Add missing operators

Add missing operators of vectors in host

Change-Id: Ie58d1642d579e7119997db49a9fd6a6641b666fd


[ROCm/clr commit: d4799b2a3f]
2023-11-01 12:59:28 -04:00
Ioannis Assiouras 16c18d5498 SWDEV-426613 - Do not install hipcc.bat and hipconfig.bat on linux
Change-Id: I0999cf35487686e8c0d863d042f971cf563578c8


[ROCm/clr commit: df0f54ddf1]
2023-11-01 11:54:11 -04:00
sdashmiz 9b297f0006 SWDEV-417075 - add hipDrvAddMemCpyNode
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ie631d7b1788f10171a29d463759a3cba3b2b2007

SWDEV-417075 - add hipDrvGraphAddMemcpyNode

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I6bab3310919643e119cd0004276907e223641cfb


[ROCm/clr commit: 9b567e1799]
2023-10-31 09:55:42 -04:00
taosang2 c709808166 SWDEV-364236 - Fix device buffer to/from image issue
Fix offset of device buffer copied to/from image.

Change-Id: I149a8629769cd0d5848ffefb04f1752668a685b9


[ROCm/clr commit: 9a24e1fb30]
2023-10-30 12:17:14 -04:00
Jaydeep Patel 39ae3fedd5 SWDEV-428198 - Revert "SWDEV-426270 - Remove duplicated operators"
This reverts commit 5f945e937d.

Change-Id: I4973424b5f8d6f2b0d8496dda346b9d6dbba13ae


[ROCm/clr commit: 76e3ffeb81]
2023-10-27 01:51:03 -04:00
Anusha GodavarthySurya d6c3c17c8b SWDEV-422207 - Remove L2 flush when kernelArgs are in device memory
Change-Id: I7b5625cb6d55e83689bff7bbb45be9c517ec4a8d


[ROCm/clr commit: 5fb7536586]
2023-10-26 19:14:58 +00:00
Anusha GodavarthySurya d0b8c99103 SWDEV-422207 - Handle nonkernel nodes for graph opt
- Support graph with different types of nodes with single
branch when DEBUG_CLR_GRAPH_PACKET_CAPTURE flag is enabled

Change-Id: I149a8629769cd0d5849ffefb04f1352668a685b6


[ROCm/clr commit: 38d2c56784]
2023-10-24 18:36:06 +00:00
Ajay 57a7c2965b SWDEV-418100 - HIPNV_DIR error for nvidia build
Change-Id: Id1fb67311fb6a0af98de7c2dcef5cfcf29102d14


[ROCm/clr commit: 6926183974]
2023-10-23 18:04:05 -04:00
Saleel Kudchadker cba9970220 SWDEV-408180 - Address possible cornercases
- Address corner cases that can arise with the new
hipMemcpyDeviceToDeviceNoCU enum
- Better log

Change-Id: I6035b901f8d616741054b7a5ff4f67956329ac57


[ROCm/clr commit: 5662d4037c]
2023-10-23 16:54:08 -04:00
kjayapra-amd 87f90197f2 SWDEV-413997 - Fixing multiple access desc cases for hipMemSetAccess.
Change-Id: Iec7d1207ec0a7136e4e74ef2e390f3347e753d40


[ROCm/clr commit: e226ae109b]
2023-10-23 09:44:04 -04:00
Jaydeep Patel 8229fce863 SWDEV-425568 - Do cpu wait for device sync.
Change-Id: Ia05e09bd10ab623b36c74037e9988e132120dd9f


[ROCm/clr commit: ee00ebc42f]
2023-10-21 01:16:06 -04:00
Saleel Kudchadker 4c9f160818 SWDEV-408180 - Add a new hipMemcpyKind
Add hipMemcpyDeviceToDeviceNoCU to force a non blit copy path. This
helps in cases where an app may determine that CU may be busy and copies
with SDMA may be quicker.

Change-Id: I59b415dd8f6022c244e8d75f265464d5c635df1e


[ROCm/clr commit: f316a30e5d]
2023-10-20 13:18:10 -04:00
taosang2 28524520e6 SWDEV-364236 - Fix layered Image issue
Fix wrong logic to get layer index;
Make layered image's layout match cuda spec;
Fix wrong comparision of element size.
Remove amd::BufferRect from ihipMemcpyAtoHCommand()
and ihipMemcpyHtoACommand().
Change-Id: Icc6a4233fbce2e9b2dc6feb79e6bfbd761684c7d


[ROCm/clr commit: 5a0085e516]
2023-10-19 16:06:20 -04:00
German 648bfdc5cd SWDEV-427689 - Report LUID in Windows
Pass LUID infromation from PAL to HIP device properties.
NodeMask is calculated based on the order of devices in PAL

Change-Id: Ic53707b68b16f392e5284a0105bf1f3941b46653


[ROCm/clr commit: 694fe4bedb]
2023-10-18 15:07:39 -04:00
taosang2 5f945e937d SWDEV-426270 - Remove duplicated operators
Remove duplicated operators of hipComplexFloat and
hipComplexDouble.
If users need complex number multiplication and division,
they should call
hipCmulf() and hipCdivf() for hipComplexFloat,
hipCmul() and hipCdiv() for hipComplexComplex

Change-Id: Ie58d1642d578e7118997db40a9fd6a6641b666fd


[ROCm/clr commit: 0ca61130a2]
2023-10-18 14:56:32 -04:00
Jatin Chaudhary 39fcf57860 SWDEV-306642 - Move the deprecated function/struct to hip_device_deprecated.cpp
Change-Id: Id1f8db09271c537a200bc090ba1feaacfb023b88


[ROCm/clr commit: 56f3b2563c]
2023-10-16 21:42:18 +01:00
Satyanvesh Dittakavi 239fdc3bfd SWDEV-419480 - HIPRTC implementation of standard headers shouldn't be in std namespace
HIPRTC implementation of few type traits are defined in std
namespace which causes conflicts with the std C++ headers when
apps try to include those std headers. Instead, use the
specific implementation of these headers from __hip_internal
namespace to avoid this.

Change-Id: Ia358df159af8783d1eba9a19cd458e192bf7e9e6


[ROCm/clr commit: 353dbe6e3b]
2023-10-16 13:10:55 -04:00