This bug was present all along, but something changed in the order
of de-initialisation performed by llvm that makes it actually
crash now.
The constructor of HipifyPPCallbacks gives:
```
std::unique_ptr<HipifyPPCallbacks>(this)
```
to the LLVM Preprocessor instance. The Preprocessor instance
subsequently frees the HipifyPPCallbacks, which is then freed
again when we leave the stack frame at line 4340.
So: let's leak the HipifyPPCallbacks onto the heap, and leave
the LLVM Preprocessor object responsible for tidying it up.
The Preprocessor smart pointer is held by the CompilerInstance,
and therefore its reference count cannot reach zero until the
CompilerInstance itself is destroyed.
If the CompilerInstance is destroyed, you have more to worry about
than just the preprocessor being deallocated!
Newer versions of the LLVM/Clang API migrated to using
std::shared_ptr, so there is no `Retain()` function (by that
name, anyway). Eliminating this redundant use is a neat and
backward-compatible way to become compatible with newer versions
of the LLVM/Clang API.
Newer versions of llvm/clang mean there is both an
llvm::StringLiteral and a clang::StringLiteral. Since we're
dumping both namespaces wholesale into the global namespace with
`using` declarations, this creates a name collision, which must be
resolved.
This change is backwards-compatible, and fixes a problem you
encounter when using newer versions of the llvm/clang API.
What we actually want to do here is use the StringRef version in
versions newer than 3.8, and the void one in 3.8 and older.
Checking "major-version >= 3 && minor-version >= 9" does not do
what we want. Consider what this will do for version 4.0, for
which minor-version is zero...
PythonInterp is a finder module that ships with cmake. It supports
the conventional interaction with find_package that allows you
to demand success, and particular vesions, without having your
own logic:
https://cmake.org/cmake/help/v3.0/command/find_package.html
SWDEV-2 - Change OpenCL version number from 2522 to 2523.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2270 edit
SWDEV-132888 - OCL kernel execution time is long at the first run on Linux, Vega, HSAIL (ProRender unit test)
Don't finalize ISA binaries if recompilation is not requested.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.cpp#74 edit
SWDEV-2 - Change OpenCL version number from 2521 to 2522.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2269 edit
SWDEV-2 - Change OpenCL version number from 2520 to 2521.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2268 edit
This copies to the output after operation, instead of working
_on_ the output. This allows includes to work correctly, while
supporting output paths anywhere on the filesystem.
Fixes#208Fixes#206
SWDEV-2 - Change OpenCL version number from 2519 to 2520.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2267 edit
SWDEV-2 - Change OpenCL version number from 2518 to 2519.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2266 edit
SWDEV-133886 - [Linux-Pro][VEGA ][Nuke]OpenCL kernel compilation failed" error is observed with Nuke on Vega10
- Port CL#1116855 to OCL/ROCm.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocprogram.cpp#73 edit
SWDEV-2 - Change OpenCL version number from 2517 to 2518.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2265 edit
SWDEV-120036 - Supporting the cl_amd_device_attribute_query on the ROC device
- divided the query of HSA_AMD_AGENT_INFO_MEMORY_WIDTH by 32 to obtained the globale memory channels as done in ORCA and PAL
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#69 edit
[Synopsis]
If any of kernel arguments is a MACRO its location calculation is wrong (location of its definition is actually calculated).
Thus garbage code is being produced on the place of such a MACRO starting from the end of its actual definition.
[Solution]
Add isMacroBodyExpansion and isMacroArgExpansion checks on kernel arguments.
SWDEV-2 - Change OpenCL version number from 2516 to 2517.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2264 edit
SWDEV-2 - Change OpenCL version number from 2515 to 2516.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2263 edit
SWDEV-133815 - PAL support for Linux Pro w/OpenCL 2.0 support
- Fix the clear size in FillBuffer. It's in bytes.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/palvirtual.cpp#61 edit
SWDEV-2 - Change OpenCL version number from 2514 to 2515.
Affected files ...
... //depot/stg/opencl/drivers/opencl/runtime/utils/versions.hpp#2262 edit
Chris Kitching
Evgeny Mankov
foreman
Siu Chi Chan
Jenkins
Evgeny Mankov