Commit Graph

13474 Commits

Author SHA1 Message Date
Tao Sang d504a761ad Remove hip-hcc codes: Part four
Remove __HCC__, __HCC_ONLY__, __HCC_CPP__, __HCC_C__,
__HCC_OR_HIP_CLANG__, __HIP_ROCclr__ and their guarded codes.

Remove Hcc codes from directed_tests and samples.

Remove __HIP_PLATFORM_HCC__ and __HIP_PLATFORM_NVCC__ from
some files where they are not necessary.

Add deprecation notice.

Change-Id: I1ae467eafd749d6c25bca204c1724b026be21fce
2021-01-08 10:53:34 -05:00
Satyanvesh Dittakavi a148a71075 SWDEV-264244 Fix StreamSync
Change-Id: I3a46a607a77aaf46dcd1fcf08db7e926613fe8d1
2021-01-08 02:06:31 -05:00
DURGESH KROTTAPALLI ec794ae051 [dtest] Tests for hipExtLaunchKernelGGL APIs
Added test scenarios for hipExtLaunchKernelGGL
1. verify kernel execution time using events
   passed through argument
2. Verify the API by disabling time flag in
   event creation.

SWDEV-238517 for enhancing hip unit tests

Change-Id: I755adc34a25c58b68041fc927bbffd2a9e6eafde
2021-01-08 00:16:54 -05:00
DURGESH KROTTAPALLI a57968fba9 [dtest] Tests for hipExtModuleLaunchKernel APIs
Added test scenarios for hipExtModuleLaunchKernel/hipModuleLaunchKernel APIs

 1. Negative Test Scenarios for hipExtModuleLaunchKernel API
 2. Negative Test Scenarios for hipModuleLaunchKernel API
 3. hipExtModuleLaunchKernel API Concurrency Verification
    using global variable
 4. hipExtModuleLaunchKernel API Concurrency Verification
    using total time taken by kernels.
 5. hipExtModuleLaunchKernel API verifying the kernel execution time
    of a particular kernel
 6. hipExtModuleLaunchKernel API verifying by disabling the
    time flag during event creation

SWDEV-238517 for enhancing hip unit tests

Change-Id: I33bbab152d47beba62065c461a07cbcacdc01d97
2021-01-08 00:05:57 -05:00
Rupam Chetia 5ba7259ffc [dtest] Enabling all negative tests for hipModule* APIs
Enabling all negative test cases for amd as they are functional now
SWDEV-238517 for enhancing hip unit tests

Change-Id: I0bdbf8c192ef94588403c8f027c0399dd5480a00
2021-01-07 23:50:56 -05:00
Rupam Chetia 328f8ab0ff [dtest] Additional tests for hipDevice APIs
APIs: hipDeviceGetAttribute(), hipGetDeviceProperties(),
      hipDeviceGetByPCIBusId() and hipDeviceGetPCIBusId()
1. New negative test cases for each API.
2. Additional attributes for testing with hipDeviceGetAttribute()

SWDEV-238517  Enhancing hip unit tests

Change-Id: I3c24462426ffaf3a9317b7de9cd33f7c65791a4b
2021-01-07 23:29:14 -05:00
DURGESH KROTTAPALLI b2a93adb82 [dtest] Enhanced tests for hipGetDeviceCount hipSetDevice and hipGetDevice
Added following functional and negative scenario tests for
HIP_VISIBLE_DEVICES (HVD), ROCR_VISIBLE_DEVICES (RVD)
CUDA_VISIBLE_DEVICES(CVD)
1. Verifying HVD and RVD - invalid number in sequence
2. Verifying HVD and RVD - dupliates in the beginning of sequence
3. Verifying HVD and RVD - all the duplicates
4. Device count with RVD(max devices and HVD(min devices)
5. Device count with RVD(min devices and HVD(max devices)
6. Device count - RVD(set), HVD(unset), CVD(set)

SWDEV-238517 for enhancing hip unit tests

Change-Id: Ia83e9e9068cbf8cc61cff17311cda1d1f8a38fee
2021-01-07 23:23:51 -05:00
Rupam Chetia 656a2cb556 [dtest] Tests added for V3 and V4 Code Objects with Static Lds
- Added test for V3 Static Lds code object with sramecc/xnack settings.
- Added test for V4 Static Lds code object.

SWDEV-238517 for enhancing hip unit tests

Change-Id: Ibc4f7e12033dec231d6834ccdd983e3b9e001d60
2021-01-07 23:19:02 -05:00
Jatin Chaudhary 9e35810188 Populate HIP_CLANG_PATH if its not declared
Change-Id: Ibc1f2e9b3389b6cc7a58579cfb293999ad6e9398
2021-01-07 04:15:42 -05:00
Payam 1f9fd14a57 Cleaning lintian warning SWDEV-247996 Part3
Change-Id: I62e5bfc5f17eee12a7a0cfe8ed6fbc35c43ff8c3
2021-01-06 11:56:11 -05:00
Sarbojit Sarkar 7648b2a61b SWDEV-264116: Optimize signal pool size
Change-Id: I4b9cef04d18fbbe453db924bcd88837c0e5924de
2021-01-06 02:14:23 -05:00
agodavar 6838df46eb SWDEV-245381: Updated guarantee error messages to print based on BUILD_TYPE
Change-Id: Ifafbc075d6b9860da040c72859127c4e638a786f
2021-01-05 23:29:50 -05:00
DURGESH KROTTAPALLI 7e6d748f26 [dtest] Tests for hipMemcpy2D and hipMemcpy2DAsync APIs
Added following functional and negative scenario tests
for hipMemcpy2D and hipMemcpy2DAsync APIs
 1. Verifying D2H and H2D functionality
 2. Verifying D2D on same device and peer device
 3. Verifying using pinned host memory on same and peer GPU
 4. Negative test scenarios
 5. Verifying hipMemcpy2DAsync API along with kernel launch

SWDEV-238517  Enhancing hip unit tests

Change-Id: I8f447bc7f6bf13cb895f1809f5a2b501baa8782c
2021-01-05 23:23:09 -05:00
Tao Sang 8a2b0b7424 Remove hip-hcc codes: Part three
1.Rename include/hip/hcc_detail/ as include/hip/amd_detail/

2.Rename include/hip/nvcc_detail/ as include/hip/nvidia_detail/

3.Create __HIP_PLATFORM_AMD__ to replace __HIP_PLATFORM_HCC__

4.Create __HIP_PLATFORM_NVIDIA__ to replace __HIP_PLATFORM_NVCC__

After hcc_detail, nvcc_detail, __HIP_PLATFORM_HCC__ and __HIP_PLATFORM_NVCC__
have been removed from upstream, they will be removed from hip runtime.

Change-Id: I1ae457effd739d6c25bca203c1724b026be21fce
2021-01-05 10:39:31 -05:00
sumanthtg 2624a5654c [dtest] Tests for hipMemset3D/hipMemset3DAsync APIs
Negative, Functional and Regression scenarios for
 - hipMemset3D
 - hipMemset3DAsync

SWDEV-238517 for enhancing hip unit tests

Change-Id: Idc5604f728ca1a96ec13876e006120f7a3d69acf
2021-01-05 07:00:48 -05:00
agodavar 69a786e8d1 SWDEV-245381 : Updated guarantee error messages to print based on BUILD_TYPE
Change-Id: Ia21039326b440f6d807a6495a9a05dd52b384c76
2021-01-05 05:49:09 -05:00
Satyanvesh Dittakavi 15baf7ef6d SWDEV-263678 - fix rocHPCG mgpu perf drop
Change-Id: I33269fe4f6165d1ed172b19033ab9fcb92f338c3
2021-01-05 00:22:12 -05:00
cjatin 7bcd555602 Removing ELF flags and moving them to HIP
Change-Id: I18464fef82d5d14af7d4c46a80318a2922895bb7
2021-01-04 13:43:33 -05:00
cjatin 6faffdffd2 Add ELF Flags moved from rocclr
Change-Id: I5febe7bdca80517e9f9492d7930def72db83c14e
2021-01-04 13:43:16 -05:00
Jatin Chaudhary e14dbaeb6e Adding file command as dependency
Change-Id: Ic719c5ce8ad0d99f6a341b5b46927587080fcf2e
2021-01-04 00:03:53 -05:00
Sarbojit Sarkar f64af513a2 Revert "Fix hipmemset to match CUDA behavior"
This reverts commit 9ba5902be4.

Change-Id: I53052b25bac4956f3efd124eadc936197f2e466a
2021-01-01 00:11:58 -05:00
agodavar f3e350cd12 SWDEV-239065 Refactor hipcc, added new perl module hipvars
Change-Id: I2b71ceb2563501c7b2861cd0f2e23d01207b1bc2
2020-12-31 05:41:36 -05:00
agodavar 7dcf2769ae hipmemcpy2D handle height 0
Change-Id: I46bf89e81559c3bfccac0dd0ccd78eee9058c7e3
2020-12-31 01:41:56 -05:00
agodavar e7c85da68b SWDEV-265171 Remove hcc compiler support from hipcc
Change-Id: Ibd06e68dd1f079b2f9e46606bdbfc0a0a780b638
2020-12-30 06:26:09 -05:00
agodavar c5e3f955bf SWDEV-266089: hipStreamAddCallback argument validation
Change-Id: I3e61006796e88b4e2ba029118c95f3499959257b
2020-12-29 05:42:54 -05:00
Sarbojit Sarkar 567a95b4e4 SWDEV-262810: skip duplicate compile flag inclusion
Change-Id: I02ebfb3cbaf6ec25819de0c4952795c6cc949e4d
2020-12-20 23:26:55 -05:00
Sarbojit Sarkar 872d8b7fc6 SWDEV-265344: fix for dtest build issue
Change-Id: I561546cb792fc0b33c03b17ba2ccf62802f05656
2020-12-20 23:26:20 -05:00
agodavar d74777d2a7 SWDEV-263180 : Fix null ptr dereference
Change-Id: Iefc9fa3f195af45a5c5ebe075056246c930a6d84
2020-12-19 02:02:54 -05:00
jujiang 84db670474 SWDEV-265003-Fix hip faq
Change-Id: Ifd29fd9c20ecc905c63fa39fd0768eaca3953aac
2020-12-18 12:21:36 -05:00
Rahul Garg 9ba5902be4 Fix hipmemset to match CUDA behavior
Make hipMemset asynchronous with respect to the host unless
destination pointer refers to pinned host memory.

Change-Id: I5ba230e0cc622aa076dc94692a4c43a57dd2df7b
2020-12-17 19:13:31 +00:00
German Andryeyev d524514f6a Update comments in the code
Make sure the comments in the code match the actual behavior.
HDP read has internal HDP read cache and doesn't use L2.

Change-Id: I667a4643b0e0d6529008f5e1a0a3269456c55b4e
2020-12-17 09:43:23 -05:00
Sarbojit Sarkar 0e4b4255b2 SWDEV-262857: minor fix for D2D
Change-Id: Ica3cb9108e7a0d40d6a910f318df0a2420145603
2020-12-16 23:13:15 -05:00
Sarbojit Sarkar 673f483879 SWDEV-262734: Fix for Numa policy bug
Change-Id: I4be62c1fc45a59d09aa043af1c998b9e308da604
2020-12-16 11:22:32 -05:00
Evgeny 52b86dfc1c SWDEV-263773 : adding CMAKE_TESTING_TOOL cmake argument
Change-Id: I28df2344d000a0dbef07f45971a9dc92fe07fb27
2020-12-15 17:52:30 -05:00
Evgeny e54f2a1af1 SWDEV-259683 : hipprof: adding hipApiIdByName() method
Change-Id: I1ad2be76efc9fb690ed7c9c2b1091f7eb0c04a31
2020-12-15 15:42:10 -05:00
Vladislav Sytchenko f45cea29b7 [PAL] Clamp max image buffer size...
to the maximum size we can possibly create.

Change-Id: Iade51d84fdada4ae1299d9b2410d373a46357c66
2020-12-15 12:14:09 -05:00
Satyanvesh Dittakavi f06393c75f SWDEV-258754 Fix seg fault hipMemset with device pointer mapped from hipHostRegister
Change-Id: Ifab66b67df172812ebb6eb25c2bac71821f4d614
2020-12-15 07:44:34 -05:00
Satyanvesh Dittakavi 40733e1fff Fix hipPointerGetAttributes
Modified hipPointerGetAttributes to support hipHostRegister ptrs and mapped device ptrs from hipHostRegister
Change-Id: I2f4cf12e09578768308f644123d6d4bdccbd77a8
2020-12-15 01:40:24 -05:00
Payam f134b90199 SWDEV-257937 - ROC_BARRIER_SYNC fix for missing SDMA flush
Change-Id: I93e8902bfcb16bac8ea594e16ea397b1ceafbd79
2020-12-15 00:54:33 -05:00
Jason Tang d4316141b7 SWDEV-263539 - More Target ID fix in GSL path
On behalf of Tony Tye. The bootleg passes CQE Baffin/Ellesmere test.

Change-Id: I4c21d21b3aaba360682ef15b8a4dda239f8af276
2020-12-14 16:48:55 -05:00
jujiang b14bf9e98b SWDEV-249486-Add doxygeny for API hipExtModuleLaunchKernel
Change-Id: Id7451ef4f669238a38ed92ec72008326c85afc4a
2020-12-14 15:34:32 -05:00
Tony eab357b852 Correct parsing of target names and supported targets
Change-Id: I6aed72759e6fb4da6834aa80131897dad641e693
2020-12-14 18:20:56 +00:00
Vladislav Sytchenko ed812e304a Disable oclruntime.OCLDynamic test
This test is causing a PSDB timeout. Not all systems can support
device enqueue on rocm.

Change-Id: I55a209877288e6cc96b2426bf960fa9a431ac7c3
2020-12-14 12:30:10 -05:00
Sarbojit Sarkar 1ef88375c2 Updated review comment
Change-Id: Ic7f9f33dd23c975f2a7a0f0d485a3d2a457c62bb
2020-12-13 11:30:28 -05:00
German Andryeyev 18a821acde Add L2 flush/invalidate after CPU copy
CPU read updates L2 with the latest values and requires
invalidation after, because SDMA doesn't use L2 and data can become
out of sync.

Change-Id: I98d1c91ca78a103fa5409e638f97485d62d5b11e
2020-12-11 23:05:49 -05:00
Jason Tang eef8405041 SWDEV-263539 - Support new Target ID in GSL path
Change-Id: I6827de93b10b312a1b78b69f5cf7d5b3d5bb1e31
2020-12-11 15:56:54 -05:00
German Andryeyev 88bd851f72 Move returned last command under the lock
Change-Id: I4a2b29a6beacd56ea38d91a33b3c5f8b763be3c7
2020-12-11 15:19:06 -05:00
Tao Sang a7aa84f73a Some improvements on hip cmake file
1.Fix unexpected repeated hip runtime lib building
2.Seperate test cmake from top cmake.

Change-Id: I1ae457effd639d6c25bca293c1724b026be21ecd
2020-12-11 13:32:15 -05:00
Aaron En Ye Shi d432615faa Fix hipTestFMA to support older compiler
The older compiler does not promote integral
arguments to double, instead it uses float.
This patch tries to support the old compiler
headers, and also the newer one.

Change-Id: I01e0b96a82ecddc6230cb5baf2573a318b25445b
2020-12-10 14:27:42 -05:00
Alex Xie 2505d68eba SWDEV-256126 - Linux pro Nuke app crash with "Out of memory"
Out of memory while running RIP plugin test

Change-Id: I8d6859a45b871f96ac027f8c7274f716e8524a3c
2020-12-10 11:44:54 -05:00