Graphe des révisions

13474 Révisions

Auteur SHA1 Message Date
Rahul Garg 584771e7a2 Handle overflow
Fixes SWDEV-261712

Change-Id: I730fcdca8c2640fde9cfdfe2f4b4cf4894807fed
2020-12-09 19:09:43 -05:00
Tao Sang 1cba7ec965 Remove hip-hcc codes: Part one
Remove hip-hcc codes from hip code base
Simplify hip CMakeLists.txt to exclude hip-hcc
Simplify cmake cmd for hip-rocclr building
Some minor fixes

Change-Id: I1ae357ecfd638d6c25bca293c1724b026be21ecd
2020-12-09 15:49:47 -05:00
Aaron En Ye Shi f7b5fea916 Add HIP Sample 2_Cookbook/17_llvm_ir_to_executable
HIP supports compiling kernels from LLVM IR into executable.
The device LLVM IR needs to be compiled into a fat binary
object. This device object is embedded into a host object using
llvm-mc directives. Then, any host linker may link the host and
device objects together into an executable. A README was added.

Change-Id: I8ebb6ae86b7ab4290f7cba2eea5584d73a7c453e
2020-12-09 15:48:53 -05:00
Aaron En Ye Shi b8b90f344c Add HIP Sample 2_Cookbook/16_assembly_to_executable
HIP supports compiling kernels from assembly into exec.
The device assembly needs to be compiled into a fat binary
object. This device object is embedded into a host object using
llvm-mc directives. Then, any host linker may link the host and
device objects together into an executable. A README is added.

Change-Id: I59d3a8b5363073810ffc3aa0d57f21b0df272369
2020-12-09 15:48:41 -05:00
Saleel Kudchadker 08a65054ea Honor hipEventDisableTiming event flag
Change-Id: Ia949db96e81b9af467f04ab40d143e8d6faa9394
2020-12-09 15:10:18 -05:00
Saleel Kudchadker d0c35f1c40 Fix event reporting for AMD_DIRECT_DISPATCH
Change-Id: I2ff74b9470da976852228c30fefbd4abd8e1952b
2020-12-09 15:09:41 -05:00
German Andryeyev 1fde842703 Fix a deadlock in ROCr backend
When OCL ROCr backend performs CL_MEM_COPY_HOST_PTR it may attempt
to have access to amd::Memory object it's currently creating,
but it's not ready yet. The logic creates a temporary dummy object
to perform a copy transfer. The new change will make sure runtime
skips allocation of the same device::Memory object second time.

Change-Id: I14c6a00a3941fdcaa6aea299e9f096e4c3f5cadf
2020-12-09 13:23:17 -05:00
Jatin Chaudhary 24b997119f Updating the gcnArchName to now have target id
Change-Id: Ibd5576e0fb5b46e8f212de4ec57cd96eb1d3c157
2020-12-09 01:22:08 -05:00
Sarbojit Sarkar f403b1c079 [SWDEV-259635] explicit allow_access for hipMemcpy2D
Change-Id: Ia3206c08f92f417dc486c5f0dd40474f77b473d9
2020-12-09 01:09:53 -05:00
Aaron En Ye Shi 9c041b1984 Fix hipTestFMA to align with libcxx
The HIP-Clang math headers upstream have been updated
to perform type promotion on math function overloads.
If any argument has integral type, it will be cast to
double.

Change-Id: I38d9e6240c40c4092b946851469498b2ae6500ae
2020-12-08 10:48:29 -08:00
Chauncey Hui 16c7f12078 SWDEV-2 - Change OpenCL version number from 3239 to 3240 2020-12-08 03:00:03 -05:00
Jatin Chaudhary 19e234b420 Adding -Wl,@response_file and @response_file mechanism to hipcc
Change-Id: Ic2053a38034b9366cf82fc01b7ea6b52e0f17077
2020-12-07 13:38:35 -05:00
Jatin Chaudhary dfe6f1ef27 Adding checks for function, size and params in ihipModuleLaunchKernel to have common message for hipModuleLaunch and hipExtModuleLaunch
Change-Id: I11921ad753930872572571dbfd1c12daba83a725
2020-12-07 03:17:14 -05:00
Sudheer Kumar da6de84535 compiler argument update for nvcc
Change-Id: If40caf20543cc29301482deddfb03d6fccb6f3c9
2020-12-06 23:21:14 -05:00
sumanthtg 8ad39c41d8 [dtest] hipOccupancyMaxActiveBlocksPerMultiprocessorWithFlags() - Additional test
Additional test for flag

SWDEV-238517 for enhancing hip unit tests

Change-Id: Ieca443678c122e291b9d4cd16f7198505cd5d6c3
2020-12-06 23:19:23 -05:00
Jason Tang b9520ce4cd SWDEV-263435 - Get code object version the correct way
Change-Id: I18877c116e2f013ec9d04411258c0df8cc0159b3
2020-12-05 15:51:26 -05:00
Chauncey Hui 5ce07e24d5 SWDEV-2 - Change OpenCL version number from 3238 to 3239 2020-12-05 03:00:03 -05:00
German Andryeyev 5b31c69a95 Add batch tracking for direct dispatch
Make sure the logic updates the command status when it's done in
HW, but not on submission.
Add the last command tracking, otherwise queue sync logic in the HIP
upper layer may skip synchronization, assuming the queue is empty.

Change-Id: I2d046792553e74df090a10f7d7a78914610f6df2
2020-12-04 10:16:17 -05:00
Chauncey Hui b334911a58 SWDEV-2 - Change OpenCL version number from 3237 to 3238 2020-12-04 03:00:03 -05:00
Satyanvesh Dittakavi 542d3219dc Modify atomicAdd float to use clang builtin
SWDEV-261229: Change atomicAdd float implementation to use clang builtin
along with deprecating atomicAddNoRet
Change-Id: I5e98034fec54ee1a2b85d5f56273e34945d49ea3
2020-12-03 23:59:10 -05:00
Saleel Kudchadker db7ed1a78c Add a new flag for profilingInfo to record gpu TS
Add a flag to record gpu TS in a marker, also disable marker flush
if there was already a marker submitted before.

Change-Id: I9cdf8e49137690c0050fe9370764dd059855a2f8
2020-12-03 13:45:39 -05:00
Saleel Kudchadker 59c6cb0268 Use barrier packets for event profiling
Use barrier packets for every profile marker that gets submitted
and use the completion signal to get GPU ts. This gives most accurate
dispatch time. Club cache flushes with profile marker if there is a
pending dispatch that needs cache flush. This optimization saves on
extra barrier and helps wall time

Change-Id: Ib62d6d7aabf4743827b561be6c9c5afa813203da
2020-12-03 13:45:14 -05:00
agodavar 273e83ff6c SWDEV-256810 : hipMemcpy2D API handle width, src/dst pitch 0
Change-Id: I4f60b220624f4235c0c3daf68adcd5a496e93696
2020-12-03 10:34:12 -05:00
Sarbojit Sarkar a08ddb4b53 SWDEV-258579: hipMemcpy2D better error handling
Change-Id: I09378d6e31da99451e22cbe9276a5ff1ad4a1840
2020-12-03 05:50:42 -05:00
Chauncey Hui 36c328842f SWDEV-2 - Change OpenCL version number from 3236 to 3237 2020-12-03 03:00:04 -05:00
agodavar ef415ec610 SWDEV-259210 : Handle invalid inputs for hipDeviceGetByPCIBusId and hipDeviceGetPCIBusId APIs
Change-Id: Iab48604941c4c715ee3357ace2e2d26dbc8cad33
2020-12-02 00:01:54 -05:00
Jason Tang 054f256589 SWDEV-260632 - [PAL] Report correct Target ID
Change-Id: Ia39395e2c02e7c95b3df93be1f8030b4fa734583
2020-12-01 18:33:25 -05:00
Sourabh Betigeri 4b3c04c3b0 SWDEV-255397: Added new perf test for hipMemset* APIs
Change-Id: Icb12360ebde003e006cc4dceccac7ebe42712a3f
2020-12-01 12:30:58 -05:00
Yaxun (Sam) Liu b49d801c5d Update documentation for supported clang options
Change-Id: I5d7017cd5c4335959fe5bae322e90aa46cdbc672
2020-12-01 12:00:10 -05:00
Chauncey Hui e13577cc61 SWDEV-2 - Change OpenCL version number from 3235 to 3236 2020-12-01 03:00:03 -05:00
German Andryeyev e4f51e063b Disable worker thread creation for direct dispatch
Change-Id: I28f08ab9352310c9bf843fcb803a48f95ddf4676
2020-11-30 17:50:12 -05:00
Michael LIAO f3b63c004a Fix hostcall test build.
- As `long`/`ulong` on Windows has different bit sizes from Linux
  platforms, even compiled in 64-bit mode. Need to use portable data
  type `int64_t`/`uint64_t` as possible or use `long long` ones to
  match the prototype in LLVM IR.

Change-Id: I62fe16a2e53aa0f2f2b4069b8a1596b8db7050c9
2020-11-30 16:47:16 -05:00
German Andryeyev 4af8b53846 Enable GPU memory in HMM by default
Change-Id: Ifec4733dc7a932163d921ebe1ae9fbd594ea1ef2
2020-11-30 12:39:18 -05:00
German Andryeyev 08b846ae12 Remove obsolete terminate() method
Change-Id: I66b4a74f17977f1af320f402402a2f1b602e9911
2020-11-30 11:46:09 -05:00
Chauncey Hui 00832fe573 SWDEV-2 - Change OpenCL version number from 3234 to 3235 2020-11-28 03:00:04 -05:00
Siu Chi Chan 703816a7e1 Update HIP docs
Purge all obsoleted information that is only relevant to HCC

Change-Id: Ice6ae174a73ccac9dfe2ca05027d1ecdb32558d7
2020-11-27 14:48:09 -05:00
Jason Tang 87762850d3 Make the Target ID ELF definition only visible to HIP
Change-Id: I5a87bed806239839156cc4af56d339bfdefc90c6
2020-11-26 18:17:46 -05:00
Rupam Chetia 4b16d3896d [dtest] Tests for hipExtGetLinkTypeAndHopCount() API
1. Negative Test Cases
2. API functionality tests for hopcount and linktype using rocm-smi library.
3. API functionality test for hopcount when devices are reversed.
4. Disabling test case 7.
5. Implemented External Review Comments.
6. Created a new header file hipP2pLinkTypeAndHopFunc.h.
7. Removed test case 0x7 from directed test.
8. Put testMaskedDevice() under __linux__, placed TODO in line 404 (comments) and replaced '&=' with '='.

SWDEV-238517 for enhancing hip unit tests

Change-Id: I1ae256ecfd637d6c25bca293c1724b026be20eca
2020-11-26 09:30:38 -05:00
Sudheer Kumar 50524ae60c [dtest] Additional tests for d2d transfer
- Test d2d transfer after doing copy from pinned host buffer
- Test d2d transfer after doing copy from unpinned host buffer

SWDEV-238517 for enhancing hip unit tests

Change-Id: Ib262185ce2692036e11c0f95ccb850eb3bce1c81
2020-11-26 08:22:55 -05:00
Rupam Chetia 4f039d1bf5 [dtest] Tests for hipModuleGetTexRef() API
1. Negative Test Cases
2. API functionality test using multiple streams.
3. API functionality validation using multiple GPUs.
4. Setting hipTexRefSetFlags() with HIP_TRSF_READ_AS_INTEGER flag instead of 0 as suggested in SWDEV-256096.
5. Enabling test cases 0x03 (short) and 0x04 (char).
6. Implemented external code review comments.

SWDEV-238517 for enhancing hip unit tests

Change-Id: If42796047ec1cf2e3695dc2b7f40a2d9dd50f5bd
2020-11-26 06:51:49 -05:00
Chauncey Hui 1891cdf86d SWDEV-2 - Change OpenCL version number from 3233 to 3234 2020-11-25 03:00:04 -05:00
Satyanvesh Dittakavi 80cb172fef Fix hipLaunchCooperativeKernel failure on nvidia platform
SWDEV-262064 - compilation fails when hipLaunchCooperativeKernel C++ routine is invoked 
on nvcc path.
Change-Id: Icde35dd1a7008b406401bb3996c06d7acfb27d8d
2020-11-25 01:15:55 -05:00
Sarbojit Sarkar c807f11580 SWDEV-260281: Fixed rpm dependencies
Change-Id: Ifd05db15d5d2098a0623fd6dd9e977d050a9c4a6
2020-11-25 00:24:37 -05:00
Jason Tang 0c62d3bf1c SWDEV-260632 - [PAL] Use new Target ID format
Change-Id: Icd2d95b9c3f5adbd295fb2272bf453ccb9f09678
2020-11-24 17:38:13 -05:00
Alex Xie 6327dbc4cc SWDEV-258808 - OCLSeparateCompile subtest of oclcompiler error
[PAL to KFD/ROCr][ROCr_Runtime][Vega10] OCLSeparateCompile subtest of
oclcompiler from ocltst test package is encountering clLinkProgram()
failed (chksum 0x00000001) error

If runtime does not provide a file name as dump file to ELF library,
ELF library use a temp file in current folder.
The current folder can be not writable for several reasons:
1. The application current folder might be system folder, the user
  does not have write permission.
2. The current folder is under a readonly file system. This happens for
embedded customers.

Tested in VEGA10. Issue was fixed.

Change-Id: Ic0e9f040b7c7583914301673cce237ab28b0c0cb
2020-11-24 15:08:12 -05:00
Michael LIAO 65f3439a0d Add initalize _wassert support.
Change-Id: I8922867ec77c975cdb235276fffc3c6272253a11
2020-11-24 11:24:54 -05:00
Chauncey Hui 7c7e36dd44 SWDEV-2 - Change OpenCL version number from 3232 to 3233 2020-11-24 03:00:04 -05:00
Tony 8493142a22 Add additional targets
Add support for loading the following targets:

- gfx705
- gfx805
- gfx90c
- gfx1031
- gfx1032
- gfx1033

Change-Id: Ib7f61c33662619757409e95fb0b50068f9e11065
2020-11-23 20:31:45 +00:00
Tony 4f8067beab Add additional targets
Add:

- gfx602
- gfx705
- gfx805
- gfx90c
- gfx1032
- gfx1033

Change-Id: Idfe7d42bacd133413ac3ffd058b7ff9d298677e2
2020-11-23 20:00:01 +00:00
Aryan Salmanpour 72277c29b0 don't update maxComputeUnits_ if any exception occurs during conversion of global CU mask string
Change-Id: I7664809fe84d7422b18b1272ffeb642e03a39f1a
2020-11-23 09:51:19 -05:00