Commit Graph

13474 Commits

Author SHA1 Message Date
jujiang 017e3b87b3 Update document for hip_faq.md, hip_porting_guide.md and hip_terms2.md
Change-Id: I2c019f802ad70ed43f1608cfd3c9067f1573741e
2020-05-28 17:51:58 -04:00
Christophe Paquot dfec136725 Revert "Call notifyCmdQueue when building the event wait list"
This reverts commit 1cfc9d1860.

Reason for revert: better fix in ROCclr

Change-Id: I9707e69adf42a662c08fe9b3ec7458655d838bdd
2020-05-28 17:01:10 -04:00
kjayapra-amd f2899243f3 SWDEV-233927 - Crash if binary for current device is not found.
Change-Id: I57281ae6c09110f39155664fca5a83ea57bb62b4
2020-05-28 16:18:27 -04:00
Christophe Paquot 0782acabb5 Use a dedicated lock for last queued command set/get
Change-Id: If3d2144841c7863cf7afe2ca85aea62e0a3a33c7
2020-05-28 12:49:39 -07:00
Joseph Greathouse 766e708535 Fix a build error on signed/unsigned comparison
Change-Id: Ic79eb4c3ec5c6fd36cea7c4810d990619f08b9e1
2020-05-28 14:27:16 -05:00
kjayapra-amd 55cdef8e45 SWDEV-236465 - Return error code as soon as global creation fails.
Change-Id: I790b8b4fdd6ab8818bc5b6b9a79e6900b840372d
2020-05-28 13:28:23 -04:00
Joseph Greathouse 90453b68d3 Fix occupancy calculation functions in ROCclr path
The hipOccupancyMaxPotentialBlockSize API is meant to return the
number of threads for the highest-occupancy workgroup, and the number
of those workgroups. It was previously calculating the number of
maximum-sized workgroups that would fit on a single CU. This is
a mixture of the API we wanted (to calculate max potential block size)
and the MaxBlocksPerMultiprocessor function.

This patch fixes it up so that the internal occupancy calculation
function works for two uses: the traditional function that calculates
the maximum blocks per multiprocessor when a user passes in a fixed
block size (used for hipMaxBlocksPerMultiprocessor style functions)
and a function that calculates the size of a block that would lead
to maximum occupancy, and how many blocks of that size would be
needed to fill the whole GPU (for hipOccupancyMaxPotentialBlockSize
style functions).

This also updates the occupancy calculation function to prepare for
gfx10, which does not have SGPR-based occupancy limits.

Change-Id: Ie007b3f9d5ebc4e166b50a3a051498af35650f35
2020-05-28 10:22:10 -05:00
Evgeny d863edb8ba adding hipKernelNameRefByPtr function
Change-Id: Iefc18967b10394b85a207ffdb5bbfe5e3601474d
2020-05-28 10:59:48 -04:00
Matt Arsenault eb31e45123 Attempt to handle case where git isn't available
Git may not be available, and this may not be a git checkout, as would
happen in a release tarball. Doesn't really attempt to get a nicer
version formatting if some of the git subcommands fail.

Change-Id: Ib568cd1310983a43f2664ded72528d7e41f554c0
2020-05-28 09:23:24 -04:00
Saleel Kudchadker facb05495f Fix elapsed time calculation for null stream
SWDEV-237377 - This fixes time calculation where the event may
be recorded on Null stream and work submitted on other streams

Change-Id: Ie36310dea5cee2fed4a514ed01f04db4b47e571c
2020-05-27 18:42:07 -04:00
Michael LIAO cbe2bedf42 [hip] Those texture interfaces are C interfaces should be always exposed.
Change-Id: Ie34f1420839b17486346149b1672e70ec0088b54
2020-05-27 15:03:59 -04:00
Christophe Paquot 1cfc9d1860 Call notifyCmdQueue when building the event wait list
SWDEV-237846

Change-Id: I8bf70e7ad19903767a080d8c6e516c83b0dc2545
2020-05-27 12:53:46 -04:00
Matt Arsenault d191ba6585 Remove build hacks to support old manually set ROCclr variables
Change-Id: Iba8180b7260616a79723a1a9d2b0b206f178e735
2020-05-27 12:53:27 -04:00
Chauncey Hui eb5b2745e2 SWDEV-2 - Change OpenCL version number from 3149 to 3150 2020-05-27 03:00:03 -04:00
Sarbojit Sarkar e288338e4a [doc]shfl*sync update
1. Updated FAQ with shft*sync not supported hip_faq.md
2. Corrected some of input parameter description in hcc_details/hip_runtime_api.h
3. Redirect shfl*() to shfl_*_sync() for nvcc path where CUDA > 9.0

Change-Id: I3d8184db5fcc622852c9bad96b706348e8dfc16c
2020-05-27 02:17:40 -04:00
Aryan Salmanpour c9b8a19ce0 [dtest] add a test for hipExtStreamCreateWithCUMask API
Change-Id: Ib567e559c5ab7d04ac5c300fd7e15eedfc4fb6e6
2020-05-26 18:15:09 -04:00
Christophe Paquot 9611b5a8b4 hipDeviceSynchronize needs to sync NonBlocking streams as well
SWDEV-237167

Change-Id: Ie916d8f03ce91e8ef05a2b4edc580a7021520f6f
2020-05-26 17:59:22 -04:00
Ramesh Errabolu b941f9243f Remove dependency on hsa-ext-rocr-dev package
Change-Id: I1147a299c31ce1ae5978b7312d82fa83d796b019
2020-05-26 14:40:42 -05:00
Evgeny 4ffe859cee fixing a typo
Change-Id: I2fc113e1f52ae9356636ddd4597c36c822bed49b
2020-05-26 14:49:27 -04:00
Chauncey Hui 8b256dce4e SWDEV-2 - Change OpenCL version number from 3148 to 3149 2020-05-26 03:00:04 -04:00
Jenkins 13c8317917 Merge 'amd-master-next' into 'amd-npi-next'
Change-Id: Idb00a49722b2df682d15451bcb6b1c6698e0a896
2020-05-25 18:20:42 +00:00
German Andryeyev fb401bfe6d Revert "Revert "Reenable cooperative groups""
This reverts commit abc115bda8.

Reason for revert: <INSERT REASONING HERE>

Change-Id: I93c45fae27e0a08b199542d44fb0d65fc74ea13c
2020-05-25 14:11:58 -04:00
Evgeny ed11059230 hip_prof: fixing printing pointer args
Change-Id: I93969723650f7c29d5c00a3809d3701c6a3dca44
2020-05-25 13:17:16 -04:00
Chauncey Hui 3dc756341d SWDEV-2 - Change OpenCL version number from 3147 to 3148 2020-05-24 03:00:17 -04:00
kjayapra-amd 3603272d24 SWDEV-237467 - Adding return type to comply with -Wall compiler flag.
Change-Id: I3c9935105ef262cdbf1c8ee293930b018be0197a
2020-05-23 14:22:54 -04:00
kjayapra-amd ea0137fb22 FEAT-30761 - Fixing fall through in gfxip major/minor detection.
Change-Id: Ib97b3dbe993e01df3360cbeda6bd0d9d366535b6
2020-05-23 12:42:44 -04:00
kjayapra-amd df6994c3f9 SWDEV-229840 - Just adding DDEV_LOG_ENABLE instead of assigning it to -1.
Change-Id: I6859bc55e6e82ffae66ca84ee686c7e76cd8b6f2
2020-05-23 11:00:34 -04:00
kjayapra-amd 6bc01b31d6 SWDEV - 237467 - Return proper hip error codes incase of ROCclr IPC API failures.
Change-Id: I2cc8da543f70bb3d8b82520fa9b2f509d20ce3c0
2020-05-23 10:51:37 -04:00
Dittakavi Satyanvesh ee4688d37e hipIpcCloseMemHandle checks the status of IpcDetach
Change-Id: Ifbe8e5bbda610a1007f881627d0da1c874d03682
2020-05-23 08:47:36 -04:00
Chauncey Hui 3588194e27 SWDEV-2 - Change OpenCL version number from 3146 to 3147 2020-05-23 03:00:04 -04:00
Mahesha Shivamallappa f4e6dec3ac Add support for cooperative group type - thread_block
Change-Id: If3770b6d6718a638b70f527ae2533d9ef3267ff4
2020-05-22 23:08:42 -04:00
kjayapra-amd 53a890b499 SWDEV-237467 - Return proper hip error codes incase of ROCclr IPC API failures.
Change-Id: I1d018918ed71f6d80846b3017f7a15f4ab496554
2020-05-22 22:10:15 -04:00
kjayapra-amd 618d66b5fe SWDEV-236110 - Fixing uninitialized variable.
Change-Id: I26a2a6826da643b57da9746e3ce888a46c4e78f4
2020-05-22 20:40:24 -04:00
kjayapra-amd 32043017ed SWDEV-229840 - Remove false error messages.
Change-Id: I0346768a2a52913d5330bc2007a7706e2a439c47
2020-05-22 18:18:41 -04:00
Matt Arsenault a98920d9a3 Remove ROCclr search hacks
find_package should now be the only way to import ROCclr. Also update
the build example comment.

The build scripts used 2 custom variables to manually specify the
build and source directories for where to find VDI. Once renamed to
ROCclr, these conflicted with the variables automatically set by
find_package(ROCclr). These hacks tried to satisfy this intermediate
step to try satisfying commit ordering problems to get through PSDB.

The INSTALL.md documentation should also be updated, but it's
completely missing any mention of ROCclr now, and still gives
directions for hcc.

Change-Id: I6fc94b6cb36241a9d4f22d24e49523367f803461
2020-05-22 15:52:35 -04:00
Vlad Sytchenko 355661b5da Reenable texture reference tests
Change-Id: I77024476cff77951d61dc48f7e30094d6b47266c
2020-05-22 14:13:50 -04:00
Alex Xie a400051d3a Move rocm include directory to the end of the list for include files
Fix compile error.

Before this change, there is compile error in my build computer. The cause is that /opt/rocm/include has an older version of CL header files.
When compiling, we should use header files from this opencl source code folders first.

This fix changes the order of include directories. Search the header files inside this opencl source code folders first.

Change-Id: I3420a634ed9e1b38b8e5201a0a39a36d61f97986
2020-05-22 11:57:34 -04:00
Tao Sang 51b6c1856c Fix square build failure with static lib in Jenkin
When libamdhip64_static.a is built by Jenkin, sample square cannot been
built successfully because libamdhip64_static.a is archiveved in thin
mode. Thus in the patch it will be archiveved in full mode. Meanwhile
libamdhip64_static_temp.a will be useless and thus removed.

Change-Id: Ifd3882598ef0dc5e7af8db0e389e786025ceb455
2020-05-22 11:49:52 -04:00
Aryan Salmanpour 3a30b9eb8d Add support for hipExtStreamCreateWithCUMask API
Change-Id: I369d0eaca493821c4badc6b18ac02daa2fddc95f
2020-05-22 11:34:06 -04:00
Matt Arsenault aa0c163066 Use option for USE_COMGR_LIBRARY
Use standard cmake option handling, and switch to standard ON/OFF for
boolean. Try to maintain compatability with the "yes" check that build
scripts are now using.

Change-Id: Ia932e93f818c0897a87bfc49b070e36c7be7dd74
2020-05-22 10:28:55 -04:00
Matt Arsenault 1003128925 Don't search ROCclr_DIR for prof_protocol.h
This points to the cmake directory where the find module was found,
not a prefix for where it was found.

Based on the search below looking in roctracer, searching in ROCclr
for the header doesn't make much sense. The header should be either
provided by ROCclr xor roctracer. Having it possibly be provided by
two different dependencies is confusing, and a potential source of
version mismatch problems.

Change-Id: Ic2f6ec03f9a7b86225cf7e5c43f39a1360318a34
2020-05-22 09:59:09 -04:00
Vlad Sytchenko e0009cdbec Merge branch 'amd-master-next' into amd-npi-next
Change-Id: I75be5fbe5ddd6552a6a316ec99ca8833ee02cb6c
2020-05-21 19:17:10 -04:00
Matt Arsenault 8988f34935 Export targets for find_package
Currently the opencl build hardcodes the path and directly includes
amdvdi_staticTargets.cmake. The proper way to find this is through
find_package, so start exporting the expected format.

Change-Id: Ic960a2dd467d57867cb96ab831dbd85bca336535
2020-05-21 13:47:59 -04:00
Laurent Morichetti 161c14c1de load functions when registered if lazy load is disabled
Change-Id: I08c9684ca4ab86a6294ed9e670f3125c1a0cc6c4
2020-05-21 09:19:20 -04:00
Chauncey Hui 17094415f7 SWDEV-2 - Change OpenCL version number from 3145 to 3146 2020-05-21 03:00:06 -04:00
Sarbojit Sarkar 06a0de3567 added null check
Change-Id: I7631965286bad5684bacb7e38c63031b5c691dc0
2020-05-20 23:08:55 -04:00
Aryan Salmanpour fec4adfd19 check for valid queue before accessing cuMask()
Change-Id: I8d4b0dbcd097c2ec5c31dea5a3d0060f0864a7e8
2020-05-20 16:23:09 -04:00
Saleel Kudchadker fe9aa9356b Fix elapsed time calc for hipEventElapsedTime
If the start and stop events have same command internally
then measure command end to command start
Change-Id: Ie70cfa37c06c06573f0ed58dab2bbe4434c1724b
2020-05-20 16:02:48 -04:00
German Andryeyev f56a052243 Add missing memory allocation in printf
Change-Id: I452b676612b54f70106e7ef1bcb5ce2baf7b3ffc
2020-05-20 14:49:59 -04:00
Alex Xie 966448c53b Fix compile error in certain version of GCC
Change-Id: I27f021db908bf114a685427a47cd9f0d6b2e5693
2020-05-20 13:13:55 -04:00