Commit-Graf

12484 Incheckningar

Upphovsman SHA1 Meddelande Datum
Ioannis Assiouras fe2d747bcc SWDEV-401489 - [ABI Break] Removed hipModuleLaunchKernelExt
Change-Id: I0b31d9db755f8a89ead203dbd238a93c18b76855
2023-09-21 23:50:16 -04:00
kjayapra-amd 369fdc4d87 SWDEV-422580 - Adding pcie.function to the PCI address string in hipGetDevicePCIBusId.
Change-Id: Iaa73b6028ac7b1d05cc310405d6fe622d764320f
2023-09-21 12:22:05 -04:00
Sourabh Betigeri 3f88fe850b SWDEV-326798 - [ABI Break] Fixes null stream sync behavior
Change-Id: I84ad21f61779145c198dc68bf0fe02a57d34bf64
2023-09-21 11:57:58 -04:00
Jatin Chaudhary 15ba5c0004 SWDEV-422808 - Add E5M2 and E4M3 for nvidia headers
Change-Id: Ib40e75c1b2e18d75164607a46e95fc322363c08e
2023-09-21 11:57:04 -04:00
Satyanvesh Dittakavi f16d336e32 SWDEV-375607 - Fix hipGraphExecUpdate behavior
Addresses the below scenarios like parameters mismatch
in memcopy node, difference in the count of nodes, difference
in the dependencies of the nodes.

Change-Id: I31c6516fb27cc1007809f1b50306fdb0c2356ccc
2023-09-21 11:17:49 -04:00
Satyanvesh Dittakavi d7d0f11318 SWDEV-395996 - Add HIPRTC support for missing hip headers
hip headers such as hip_math_constants.h, library_types.h,
hip_common.h, channel_descriptor.h, device_functions.h, hip_complex.h,
hip_texture_types.h, math_functions.h, surface_types.h
are added in HIPRTC

Change-Id: I4a4c198449ceb609c3ff55e00b43056c1f085431
2023-09-21 03:11:06 -04:00
German e1d34cb24f SWDEV-404889 - Debugger support, trap handler
Add trap handler code into runtime and compile/load during
device initialization. The current interface for trap handler in
PAL is obsolete and the new interface will be provided later.

Change-Id: I1fa702c5d1f2e6731f781369c980d546cf422328
2023-09-19 16:05:02 -04:00
Ioannis Assiouras 5e51335ef6 SWDEV-416741 - Improve logging in find_package(hip)
Change-Id: Iaaaa595c668e5a8e977c9d2d31beca481748f637
2023-09-18 19:10:38 -04:00
Ajay 2bae1b1387 SWDEV-421102 - make clr compatible with c++20
Change-Id: Ia692817232caa3ee97dc0b2139645a0474b582e1
2023-09-18 11:28:29 -04:00
David Salinas bf88980e0a SWDEV-421615 - Correct required perl modules
Change-Id: I4e7e19e666042c0e8bfdb0ae0bfb2fc8d3ffa565
2023-09-15 11:46:48 -04:00
Jaydeep Patel d18ae85833 SWDEV-415914 - Use settings from device's setting object.
Change-Id: I4b0cbab361e9e2d5b8164066ec37de1fa212e783
2023-09-14 19:16:50 +00:00
Julia Jiang 42799c9f21 SWDEV-401314 - Fix failure on MI300 for progvar_prog_scope_misc basic test
Change-Id: I56701b050023199a3e56dc5a78553c0c330b8537
2023-09-14 11:32:25 -04:00
kjayapra-amd 85b645731c SWDEV-417244 - Create Unique File Desc Store and guarantee no duplicates fds are opened.
Change-Id: I7be7fee52b673f0b1b3facdfbd847b57f2a47cde
2023-09-13 17:03:18 -04:00
Alex Xie 2804aa8e34 SWDEV-421710 - Remove unused GL function pointers
Change-Id: Ifd77314b51d4b1494428bf8b611051245dbc3feb
2023-09-12 18:17:04 -04:00
Jaydeep Patel a37c95d7ed SWDEV-418038 - Drop GPU_ENABLE_WAVE32_MODE from RTC.
Change-Id: Iac11f26714e8b3bae14cbf69933ef7c8c8be47da
2023-09-08 02:13:41 -04:00
Anusha GodavarthySurya 530dc6de2a SWDEV-301667 - Optimize performance when graph has single branch
Three for loops iterate over all graph nodes for UpdateStream, FillCommands and
EnqueueCommands has performance drop for large graphs.

Change-Id: I077accf3a4680d5d944b73200fd6498a7a48f25c
2023-09-07 23:35:36 -04:00
Ioannis Assiouras 315082e554 SWDEV-419996 - Allow both kernelParams and extra arguments to be set to null
When kernel function expects no parameters no error should be returned
if both kernelParams and extra arguments are set to null.

Change-Id: I5941bcc400b6fb380e623bdae0233ae3e4f73815
2023-09-07 12:57:46 -04:00
German 7be3a5e33e SWDEV-407533 - [ABI Break]Remove Wavelimiter
Change-Id: I6a2f6fb5a0c3acea93fa0200a69679783e76f5bd
2023-09-07 09:58:41 -04:00
Ioannis Assiouras 1302d6f119 SWDEV-420328 - Initialize AMD_LOG_MASK with decimals instead of hex
Change-Id: Id25510863c51206bca2e50fc93d6e1e1c5cbbfea
2023-09-07 03:04:37 -04:00
Jacob Lambert 19526e46e6 Revert "SWDEV-410182: Link device-libs when compiling source to bitcode"
This reverts commit f3dc04a50d.

Reason for revert: There are currently some outstanding issues with the COMPILE_SOURCE_WITH_DEVICE_LIBS Comgr action (https://ontrack-internal.amd.com/browse/SWDEV-386072). Once these LLVM issues have been resovled, we can safely re-apply this patch

Change-Id: I8501967af8496ea50d6e4a97399e45db51bbed1e
2023-09-06 21:34:03 -04:00
Saleel Kudchadker 42c9cd0320 SWDEV-301667 - Balance AQL packet scopes
- Acquire and Release scopes for AQL need to be balanced. These were
missing on the AMD_OPT_FLUSH=0 path.

Change-Id: Ibf4132eb96800f155d7b664359c790d68a353e60
2023-09-06 13:26:39 -04:00
David Salinas e1efdfbca1 SWDEV-419396 - hipcc.bin.exe and hipconfig.bin.exe missing from build
Correct HIPAMD cmake file for finding/instaling hipcc.bin

Change-Id: I3aa56331615fa81a489464210a9be734e917aa47
2023-09-06 10:55:54 -04:00
Jaydeep Patel 198b7b412d SWDEV-417317 - Bypass agent init for HIP.
Change-Id: I3396cf7c1feced03d29f5e5ff3c77474f4f7e1ec
2023-09-06 00:40:54 -04:00
Ioannis Assiouras 96ac99b4a0 SWDEV-419664 - Set reserved0 field of hsa_kernel_dispatch_packet to zero
Change-Id: I2e9c503f1c393548aacad47d40da90a2126e522c
2023-09-05 19:10:33 -04:00
Ioannis Assiouras 2bc6661737 SWDEV-420222 - Removed implementation of hipMemcpyArray functions
hipMemcpyArrayToArray, hipMemcpyFromArrayAsync, and hipMemcpyToArrayAsync
are deprecated in cuda and are missing the headers in hip_runtime_api.h.
Removed their implementation from hip_memory.cpp.

Change-Id: I9720aec6241515c56c66b7e90a37b2ed53347eb2
2023-09-04 13:35:08 +01:00
Rahul Garg c9cf3bdc16 SWDEV-418360 - Continue parsing modules even when some module don't have
right binaries built for current device

Change-Id: Icc6a4233fbcede9b2dc6feb78e6bfbd761684c7f
2023-08-31 14:54:59 -04:00
Ioannis Assiouras 209525d6e4 SWDEV-415937 - Make _IMPORT_PREFIX in hip*targets.cmake point to a relative path
Change-Id: Ib0f4321f2954254d0486d741d057f182cb2481a7
2023-08-31 08:10:50 -04:00
Sourabh Betigeri 7dc78d234d SWDEV-418855 - Limits the 'no GWS' approach to gfx940, gfx11and gfx12
Change-Id: Iab2d34d3142902517124cec7ef3461cf7aa4b98c
2023-08-30 23:48:02 -04:00
German ad56c20cd0 SWDEV-418038 - Remove opengl32.lib from linking in runtime
Change-Id: If9416742cd8dc6a35adaccce802d65888e808ef2
2023-08-30 14:07:28 -04:00
Satyanvesh Dittakavi 94e70bee26 SWDEV-419034 - Use MADV_HUGEPAGE for large host allocations
Change-Id: I80bb1839cdd47eb64a97467c8b01fcdf37195ad5
2023-08-30 14:03:26 -04:00
Juan Manuel Martinez f3dc04a50d SWDEV-410182: Link device-libs when compiling source to bitcode
This is related to SWDEV-410182, but it's not enough to fix it.

Functions from device-libs are precompiled into llvm-ir in a "target agnostic" way
(in reality, it's not 100% target agnostic, which brings us many headaches).

When linking builtins (like device-libs) from the command line, we use the flag
-mlink-builtin-bitcode. The difference between regular linking of bitcode and
this flag is that the later propagates target-specific attributes. If this
attributes are not propagated, we can end up with incosistent target attributes.

Comgr provides the action AMD_COMGR_ACTION_COMPILE_SOURCE_WITH_DEVICE_LIBS_TO_BC
for this exact reason. The old action is currently deprecated and this one should
be used.

Change-Id: I518415214debdf4fedf0b1d81456d6e9fb8a3d19
2023-08-30 04:24:17 -04:00
kjayapra-amd 6a0f80a03d SWDEV-381625 - Parse compiler and linker options from environment variable.
Change-Id: Id5a012b678e5973c4b64dff84444a909aefae006
2023-08-29 20:24:27 -04:00
German bd00826446 SWDEV-3 - Move PAL to version 818
Restore PAL platform destruction.
Update CmdAllocatorCreateInfo::AllocInfo for the new interface.

Change-Id: Iea418eed7ee26166039a4a9cc1999438856e9097
2023-08-29 12:46:28 -04:00
Jaydeep Patel d2655d84fd SWDEV-375596 - Device context should not be changed while graph exec update for graph nodes other than empty and host node.
Change-Id: I89d734b111aae5b042386175d2786ce9002771b9
2023-08-27 22:58:32 -04:00
Saleel Kudchadker 1ec0ba3537 SWDEV-301667 - Use large signal pool
Use large signal pool if profiler is connected or profiling forced
enabled. This is needed to mitigate signal creation overhead when
profiling as signals are attached to every packet and deeper batch may
show overhead of signal allocation.

Change-Id: I8034b8a20b55328b87d593bf044f59672f9653e8
2023-08-24 19:17:05 -04:00
German 077311153a SWDEV-407533 - [ABI Break]Purge unused env vars
Change-Id: I627950e8ebb6299affc602754a20d442dbe42b14
2023-08-24 14:11:40 -04:00
Jatin Chaudhary 8fe5100d16 SWDEV-418230 - fix warning seen in HIP headers
This PR fixes warning seen on HIP headers due to -Wignored-attributes.
The warning is attributes for a variable must precede definition.
This also fixes a potential issue with C-style header where templates
were declared outside __cplusplus.

Change-Id: I78bfd391717c7891afb442ef79812ea630c0ff49
2023-08-24 08:41:08 -04:00
Tao Sang d433df4761 SWDEV-417727 - Fix hipSignalExternalSemaphoresAsync()
This reverts commit 44a3935cda.

Implement the right way to make ExternalSemaphores be signalled
only after prior works on the stream have been finished.

Change-Id: I9d5974e05d5f229170b928db4566c14e40e3cbaa
2023-08-23 22:31:27 -04:00
Saleel Kudchadker e1e5d071ba SWDEV-301667 - Port optimization to save extra packet to graphs
Change-Id: Ibaf64a4efe070c42620e6e153c1862a4a0b15664
2023-08-23 16:58:21 -04:00
taosang2 44a3935cda SWDEV-417727 - Fix hipSignalExternalSemaphoresAsync()
Let ExternalSemaphores be signalled only after prior works on the
stream have been finished.

Change-Id: I856917db905f68f55fdf484f5267f7fe8ea3117f
2023-08-23 14:58:37 -04:00
German d97cc0abbd SWDEV-404889 - Inital change for debugger support
- Program unique AQL index for debugger. The logic manages AQL array of packets per HW queue.
- Provide debug state to PAL

Change-Id: I38fa1f5435fa711fd1d44dc391f2e61eb2a25efa
2023-08-23 13:21:58 -04:00
kjayapra-amd 6f5277c701 SWDEV-408473 - Add wait time of 10 us if the waiting signal copy was < 24K.
Change-Id: I438ec9eb07e5034042a4a9a5e6e51d74daba2c83
2023-08-23 10:46:33 -04:00
Jatin Chaudhary 19afdf719e SWDEV-414425 - __half2's member variable should be __half instead of unsigned short
We currently have __half2 made up of unsigned short instead of __half.
This prevents users to do operation seamlessly when they want to operate on individual components.

Change-Id: I856917db905f68055fdf484f526707fe8ea3117d
2023-08-22 04:25:19 -04:00
Satyanvesh Dittakavi 84eae1f0a9 SWDEV-416443 - hipPointerGetAttributes should return correct type for managed memory
Change-Id: Ic197cd8c9d3f5405616ed6e4924ed5577e636b94
2023-08-21 07:47:32 -04:00
Juan Manuel MARTINEZ CAAMAÑO 06dcaae619 Revert "SWDEV-410182: Do not force wave64 for geekbench"
This patch did not consider the dicussions in SWDEV-270908

> "we found that in GeekBench5, forcing Wave64 instead of the default
> Wave32 compute policy yields big gains in every subtest except one"

This reverts commit d6dc82b220.

Change-Id: Ice1728585b9d1b2c1b36a06cfa0b8c47cb2bfa49
2023-08-21 03:29:32 -04:00
Jaydeep Patel 7a10423a44 SWDEV-417691 - Error handling for MemoryMap OS calls.
Change-Id: I0a823289b274e118c8440f2d372a5216bf4ba6aa
2023-08-21 00:01:06 -04:00
German 9bd592e2ff SWDEV-415115 - Fix memory commit in SVM on large bar systems
Skip memory commit for linux only.

Change-Id: I6304607f7c5516c76e59afa6da57de5b088f6a8c
2023-08-18 11:25:28 -04:00
Todd tiantuo Li b4933f1d00 SWDEV-403758 - support new ASIC Revisions for Hawk Point1 and Hawk Point2
Change-Id: Ib8383b16e85abaa0bbf481c1aac71a11cd5b9218
2023-08-18 10:32:09 -04:00
Vikram 62464ca4c3 SWDEV-417558 - Fix dynamic linker error caused by SWDEV-378651 fix
Seems the windows linker error seen with https://gerrit-git.amd.com/c/compute/ec/clr/+/886078
also exists for linux, but only appears with dynamic linker. This fixes both usecases.

Change-Id: I1bb6df151eb1e09f75af4d461ead28bcbaa5f236
2023-08-18 02:21:14 -04:00
Anusha GodavarthySurya f76a40c26d SWDEV-415772, SWDEV-414682 - Fix childgraph node execution
Change-Id: If9ffc08d98a57b8daa5f131f72ef1bf2317f29e1
2023-08-18 00:45:00 -04:00