Commit Graph

12484 Commits

Author SHA1 Message Date
Saleel Kudchadker 9ec8a7306d SWDEV-332512 - Signal pool changes
Create a new signal if the next set of signals are busy

Change-Id: I5108e68c88fe41e3a45bad4495ebdf3742e76dcd
2022-04-18 15:58:38 -04:00
Saleel Kudchadker aace42cfab SWDEV-301667 - Add separate field for event scope
Change-Id: I0e6b50d1a34b275ea4f1a4c659430c406d9a5a7e
2022-04-18 15:48:33 -04:00
German Andryeyev 5957ff9f7b SWDEV-311271 - Make sure memory pool can accept default stream
Add lock protection for access to the pool list.
Remove destroyed stream from the list of the safe streams

Change-Id: I1863b89bd3f5e188c161227cc790c3adaf72cc58
2022-04-18 10:34:21 -04:00
Satyanvesh Dittakavi b06ee8834d SWDEV-308763 - Remove older hiprtc implementation
Change-Id: I1f0a1fe9b6590070905348bf71b901ac77b196be
2022-04-18 05:12:53 -04:00
Satyanvesh Dittakavi 3b525ad298 SWDEV-332371 - Address seg fault with hip event tests on Windows
Change-Id: I0367f6dbb395b3032c97692c5bde6e99d503c6a9
2022-04-18 04:19:23 -04:00
Saleel Kudchadker b6cbfaf499 SWDEV-301667 - Separate scope from marker_ts_
Change-Id: I19f4d394e898bfb8c9d9a2c2edf9d5bf5def3b08
2022-04-16 19:26:31 -04:00
Chauncey Hui 5d9063147c SWDEV-2 - Change OpenCL version number from 3448 to 3449 2022-04-16 03:00:07 -04:00
pghafari 4d54f873b0 SWDEV-324412 - Removing depth24
OGLP fails conformance tests with depth24

Change-Id: I1efd66a81f64a5b999d0f3c3e9314b9e6129a587
2022-04-15 15:31:03 -04:00
Chauncey Hui 6cd647270b SWDEV-2 - Change OpenCL version number from 3447 to 3448 2022-04-15 03:00:06 -04:00
Christophe Paquot b5f555f9ec SWDEV-322620 - Virtual Memory Management
Adding virtual memory management APIs to rocclr.
The HIP layer will handle virtual allocs on devices.

Change-Id: Ia978f105c2c3fed3959c77580ba228e845105754
2022-04-15 00:10:02 -04:00
German Andryeyev 7975a07112 SWDEV-332512 - Add ROC_SIGNAL_POOL_SIZE
Default value is 32 HSA signals in the pool.

Change-Id: Icb69413d3ff6ef228d9a9e22fd024e72c6d8ebe4
2022-04-14 17:32:00 -04:00
Sourabh Betigeri bd851550bd SWDEV-331301 - Fixes error code mismatch
Change-Id: I8dda98609b16ea5c1ce4d9db9471e61e5fb0c12c
2022-04-13 18:51:06 -07:00
Jeremy Newton d1782940f3 SWDEV-321116 - Allow disabling ICD loader
This patch adds an option (BUILD_ICD) to toggle the ICD loader build
with rocm-opencl. This isn't useful for official ROCm use, but distros
or users may want build rocm-opencl with their own OCL ICD loader.

The default option is BUILD_ICD=ON.
If this option is set to OFF, an OpenCL OCD loader must be installed
prior to attempting to build rocm-opencl.

E.g. distros already provide ocl icd loader packages:
sudo yum install ocd-icd-devel
sudo apt-get install ocl-icd-opencl-dev
sudo zypper install ocd-icd-devel

Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
Change-Id: I6006593eceed543cd829e8949ec2256482815673
2022-04-13 18:27:13 -04:00
sdashmiz 9f5685ea0a SWDEV-329349 - add display support for Opencl
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Icf5253ba87f3852153c620fb7b789bd6e90cb52e
2022-04-13 15:11:29 -04:00
Chauncey Hui ac4ad0ab73 SWDEV-2 - Change OpenCL version number from 3446 to 3447 2022-04-13 03:00:06 -04:00
Saleel Kudchadker f320acb797 SWDEV-276210 - Honor scopes for hipEventRecord
Honor hipEventReleaseToDevice and hipEventReleaseToSystem flags.
hipEventRecord would flush caches if no release flags are provided. To
change this behavior set ROC_EVENT_NO_FLUSH=1

Change-Id: I03e41b515b1d0cf963b0c2d5b9901b09e71a0e59
2022-04-13 00:35:19 -04:00
Jaydeep Patel c1503da69b SWDEV-330666 - null(default) stream's priority is 0.
Change-Id: I115effc2ddaa28dee32967ee28041b9b8da095b9
2022-04-13 00:28:52 -04:00
Sourabh Betigeri 345e02358c SWDEV-329848 - Fixes error code mismatch between CUDA and HIP
Change-Id: Ic48de159ca7bdb4b91dadb915972e535518635ae
2022-04-12 15:00:44 -04:00
Saleel Kudchadker 8eeaa998c0 SWDEV-301667 - Add cache state for a device
- Add a global cache state for a device to indicate scopes of submitted
AQL packets
- Remove scopes for TS marker if hipEventReleaseToDevice is passed. Set
env ROC_EVENT_NO_FLUSH=1 to use NOP AQL for event records.
It would flush caches by default with system scope release.
- Calling finish() should ensure if caches are flushed, if not queue a
marker

Change-Id: Ibbbdbb1cd7ac61cb35649169212142545be159e0
2022-04-12 12:27:31 -04:00
Hao Yuan 4d300d1f8a Merge "SWDEV-328274 - Move DLLMain from VDI layer to HIP/OCL layers" into amd-staging 2022-04-12 11:00:51 -04:00
haoyuan2 cb4aabd285 SWDEV-328274 - Move DLLMain from VDI layer to HIP/OCL layers
Change-Id: Ibd3388f0981672cd209d7370f8a28b2883abdea2
2022-04-12 11:00:20 -04:00
Chauncey Hui 857634241b SWDEV-2 - Change OpenCL version number from 3445 to 3446 2022-04-12 03:00:05 -04:00
Sarbojit Sarkar 8657c40721 SWDEV-331126 - Fix to Cuda return type
Change-Id: Iea8e7735ef0c58c1244c92338038d91e61d62c16
2022-04-11 23:35:04 -04:00
haoyuan2 1fbc01a812 SWDEV-328274 - Move DLLMain from VDI layer to HIP/OCL layers
Change-Id: Idc84eb0db92d21a5ced8769fa1eae064b86c31b0
2022-04-11 16:55:59 -04:00
Maxime Chambonnet d45794e985 SWDEV-1 - ROC CLR typos
This is cherry-picked from this github issue:
https://github.com/ROCm-Developer-Tools/ROCclr/issues/28

Change-Id: I236f4f25a2dabe05883159af0fab0bad06ab0fd0
2022-04-11 14:24:39 -04:00
German Andryeyev abf088ea89 SWDEV-307184 - Hidden heap keyword was renamed
Change-Id: I0a72b0cc16bd3d637cbaa79a692640bc922f62c4
2022-04-11 09:26:14 -04:00
Ajay f301bf3962 SWDEV-331095 - Address hipRTC windows test failures
Change-Id: I8c1a36ffd362c6f41449092e4dd85f6ec587206a
2022-04-11 09:40:35 +00:00
Chauncey Hui 66d404f707 SWDEV-2 - Change OpenCL version number from 3444 to 3445 2022-04-09 03:00:05 -04:00
haoyuan2 fe173ed9fb SWDEV-328274 - Move DLLMain from VDI layer to HIP/OCL layers
Change-Id: I89db993ba90783c53546c5290c00e13f5c24edf4
2022-04-08 12:12:07 -07:00
Jeremy Newton b8c124acb5 SWDEV-321118 - Use GNUInstallDirs
Use GNUInstallDirs variables to determine the location of BINDIR,
LIBDIR, DOCDIR, and SYSCONFDIR.

Note that CMAKE_INSTALL_LIBDIR is overriden, since the default for RHEL
is lib64, but ROCm packaging wants it to be lib always. Distros or users
can easily override this.

Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
Change-Id: Ifb38263dce80d80c5ebb4eacd8e49c76bb013a44
2022-04-08 13:52:08 -04:00
German Andryeyev 2be0b1e612 SWDEV-307184 - Report 1 for unused dimensions
Remove assert for kernel arg size, because COv5 reports a value
bigger than the actual usage in the most of cases

Change-Id: I8e15bc45a9e21b58a5894f9977511ca84408ce61
2022-04-08 13:43:37 -04:00
Jeremy Newton 00efdc1cd6 SWDEV-323669 - Improve arch detection
- Clean up detection by using visual studio macros to detect arch; I
  didn't list all possible ARM platforms (can be done later if desired)
- Fixed two incorrect uses of !defined(ATI_ARCH_ARM) to instead use
  defined(ATI_ARCH_X86), as they contain X86 specific code
- Fixed one use of __ARM_ARCH_7A__ to use ATI_ARCH_ARM instead

This is an improvement to the fixes in the last patch for SWDEV-323669

Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
Change-Id: I8568167293c34ad5331902105877f3ab6e25acb3
2022-04-08 12:21:58 -04:00
Christophe Paquot cd447a5aaa SWDEV-322620 - Virtual Memory Management APIs
Adding skeletons.
Implemented:
- hipMemGetAllocationGranularity with basic granularity
- hipMemGetAllocationPropertiesFromHandle
- hipMemCreate

Change-Id: I4bd2c75fae45d6a057efcad19d1d3c9715e9ae67
2022-04-08 11:38:51 -04:00
kjayapra-amd b3b88ef926 SWDEV-331104 - Size passed to fillBuffer should not be 0.
Change-Id: Ifbc6047fafa0e55b5ab956cf3b7254c7e20b1e88
2022-04-08 09:29:55 -04:00
Chauncey Hui f2e2984cb9 SWDEV-2 - Change OpenCL version number from 3443 to 3444 2022-04-08 03:00:04 -04:00
Jaydeep Patel ff78c439ef SWDEV-330661 - devicePointer null checking.
Change-Id: I3366031954330143109d0a79e86fd0e0ec996f01
2022-04-08 00:08:37 -04:00
Jeremy Newton 86c9bb1946 SWDEV-321116 - Drop unnecessary ICD include
This looks unused. This should allow building rocm-opencl without any
dependency on any particular OCL ICD.

Signed-off-by: Jeremy Newton <Jeremy.Newton@amd.com>
Change-Id: Ib9229ede8400fd0e883275659ab99513b03952cb
2022-04-07 14:45:43 -04:00
Satyanvesh Dittakavi c0ada4320b SWDEV-326796 - Fix hipMemset crash when the size passed is more than allocated
Change-Id: If3b15da0960f3af347fca62beedd8003cb958c2e
2022-04-07 08:49:54 -04:00
Saleel Kudchadker b1436f6451 SWDEV-331152 - Add back HIP_HOST_COHERENT support
Change-Id: I1971df55913498df801ad319a20b95380a2c136f
2022-04-06 12:26:01 -04:00
Satyanvesh Dittakavi 0af8904b87 SWDEV-326793 - hipStreamGetFlags should query the flags for null stream
Change-Id: I1d1b833704c135b5a0c695b244380ac6c5b8438e
2022-04-06 04:09:17 -04:00
pghafari 798a304dbd SWDEV-316292 - adding Graph checks
hipGraphExecMemcpyNodeSetParamsFromSymbol negative test cases

Change-Id: I7b6c496a8bca831dc90d1d427273a2a4fea96587
2022-04-05 13:26:46 -04:00
Ajay 18c4458e8c SWDEV-303760 - Windows: to use the HIP found using find_package(hip)
Change-Id: I8dcc0adae5decc17aff45850681c3502c9e19fae
2022-04-05 12:01:51 -04:00
German Andryeyev caa6110c29 SWDEV-307184 - Move local size calculation
With COv5 local size calculation must occur before
runtime programs kernel arguments

Change-Id: I0726c6529bde69b8fcf5360aa83986cf84e04168
2022-04-05 11:19:51 -04:00
German Andryeyev e5a791217e SWDEV-1 - Fix compilation error with PAL staging
Replace compile assert with an error message during execution

Change-Id: I4c054c65845b14bb980e165855693705c097ff80
2022-04-05 11:19:51 -04:00
Payam 8618b1cd07 SWDEV-316819 - graph check ChildGraphNodeGetGraph
Change-Id: Id3a4fb64e6fb5ce37e97f1f3518e09c8bd9a2d0c
2022-04-05 01:24:36 -04:00
Rakesh Roy 5f0f7ffe92 SWDEV-326789 - Mark texture reference APIs as deprecated
Change-Id: I7a39cc1f036cd185ac3aab6c5f44730f16225f69
2022-04-05 00:04:34 -04:00
Julia Jiang 7b4b76b465 SWDEV-329687 - update install.md
Change-Id: Ib39df1cd462aa1644c4e0cc2ab0a3c780700056b
2022-04-03 13:03:02 -04:00
Chauncey Hui 7630e701f6 SWDEV-2 - Change OpenCL version number from 3442 to 3443 2022-04-02 03:00:06 -04:00
German Andryeyev fb835c6f3e SWDEV-328670 - Pass the size of allocation
The actual size of allocation can be different from the original
request due to alignments. Pass the size of the original request
for validation during the arena object look-up

Change-Id: I30000046b1ec56abe743e43113046144fd3edbc6
2022-04-01 11:18:55 -04:00
kjayapra-amd 378a427d8c SWDEV-325776 - Adding device release scope for kernel dispatch packet
Change-Id: I8ea763f4c0239c410143b748c05822e9f6694412
(cherry picked from commit ec4894f8a27a3330b895a0ded385ab96f5ef242d)
2022-04-01 08:17:29 -04:00