Commit Graph

3895 Commits

Author SHA1 Message Date
Rahul Garg fe47b2185c [HACK] Temporary fix for hipFree for hipManagedMalloc 2019-09-13 02:10:21 +05:30
Evgeny Mankov 6739a6d656 Merge pull request #1414 from emankov/master
[HIPIFY] Add unsupported fp16 functions
2019-09-12 18:53:08 +03:00
Evgeny Mankov 34540002dd [HIPIFY] Add unsupported fp16 functions 2019-09-12 18:51:25 +03:00
Evgeny Mankov 63198e0d66 Merge pull request #1413 from emankov/master
[HIPIFY] Add more unsupported device functions
2019-09-12 17:55:43 +03:00
Evgeny Mankov 58c1a144d1 [HIPIFY] Add more unsupported device functions 2019-09-12 17:53:25 +03:00
Evgeny Mankov 2cf9922754 Merge pull request #1410 from emankov/master
[HIPIFY][#1404] Fix: add cooperative_groups.h -> hip/hip_cooperative_groups.h
2019-09-11 18:13:05 +03:00
Evgeny Mankov 0426035468 [HIPIFY][#1404] Fix: add cooperative_groups.h -> hip/hip_cooperative_groups.h 2019-09-11 18:07:09 +03:00
Evgeny Mankov ccf8ffc0c9 Merge pull request #1406 from emankov/master
[HIPIFY][#1400] Fix Template Instantiation kernel launch (clang & perl)
2019-09-11 15:49:46 +03:00
Evgeny Mankov 56ab105e9d [HIPIFY][#1400] Fix Template Instantiation kernel launch (clang & perl)
+ Enclose template instantiation kernel calls into round brackets, leave regular kernel names unchanged (hipify-perl doesn't handle cases with macros).
+ Fix corresponding tests.

PS. hipify-perl couldn't handle correctly the following cases due to macros expansion disability, thus hipify-clang should be used instead:

#define KERNEL_NAME_MACRO axpy<float>
#define KERNEL_CALL_MACRO axpy<float><<<1, 2>>>
#define KERNEL_ARG_LIST_MACRO a, x, y

// CUDA:
KERNEL_NAME_MACRO<<<1, 2>>>(KERNEL_ARG_LIST_MACRO);
KERNEL_CALL_MACRO(KERNEL_ARG_LIST_MACRO);

// hipify-perl:
hipLaunchKernelGGL(KERNEL_NAME_MACRO, dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);
KERNEL_CALL_MACRO(KERNEL_ARG_LIST_MACRO);

// hipify-clang:
hipLaunchKernelGGL((KERNEL_NAME_MACRO), dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);
hipLaunchKernelGGL((axpy<float>), dim3(1), dim3(2), 0, 0, KERNEL_ARG_LIST_MACRO);
2019-09-10 15:59:06 +03:00
Aditya Lad 90acfb809c Replacment of RENAME command in CMakeLists.txt (#1402) 2019-09-10 08:35:16 +00:00
Evgeny Mankov 29d09eb269 Merge pull request #1398 from emankov/master
[HIPIFY] Add device functions support
2019-09-07 19:00:00 +03:00
Evgeny Mankov 6602fadc16 [HIPIFY] Add device functions support
+ Add a corresponding matcher cudaDeviceFuncCall to match only (__device__ or __global__) and not __host__ functions.
+ Add a corresponding device functions mapping:
  only unsupported are listed, cause supported are exactly the same as of CUDA and do not need transformation;
  make FindAndReplace for device functions separated from host API calls.
+ Add a test to distinguish device functions and user-defined.
2019-09-06 18:34:12 +03:00
Jeff Daily 8384f487ad fix bug where HIP_DB=1 seg faults at startup (#1388) 2019-09-05 10:04:19 +00:00
mhbliao 119ee4b671 [hip] Stop using noduplicate and replace it with convergent. (#1390) 2019-09-05 10:03:43 +00:00
Paul Fultz II f6cf7e4e79 Use hcc when building with hcc compiler (#1225)
* Use hcc when building with hcc compiler

* Fix misnamed variable

* Dont set HIP_RUNTIME
2019-09-05 10:03:04 +00:00
Evgeny Mankov 1954af4777 Merge pull request #1395 from emankov/master
[HIPIFY][cmake][#1394] Fix
2019-09-05 12:12:08 +03:00
Evgeny Mankov ab560d8fd2 [HIPIFY][cmake][#1394] Fix
[#1394] cmake's VERSION_GREATER_EQUAL introduced in 3.7
2019-09-05 12:08:56 +03:00
Evgeny Mankov b457b31c82 Merge pull request #1393 from emankov/master
[HIPIFY][perl] Code cleanup (preparation for generating)
2019-09-05 11:54:10 +03:00
Evgeny Mankov 3a034a3427 [HIPIFY][perl] Code cleanup (preparation for generating) 2019-09-05 11:52:59 +03:00
Evgeny Mankov 0ec5b95b69 Merge pull request #1391 from emankov/master
[HIPIFY][perl] Sync hipify-perl with hipify-clang
2019-09-05 09:07:32 +03:00
Evgeny Mankov 2a4c008385 [HIPIFY][perl] Sync hipify-perl with hipify-clang
Sync by means of semi-automatic generation: hipify-clang -perl
2019-09-04 17:07:45 +03:00
Evgeny Mankov 8feb4e1c9c Merge pull request #1389 from emankov/master
[HIPIFY][perl] Code cleanup and formatting
2019-09-04 16:39:12 +03:00
Evgeny Mankov 5b8843a127 [HIPIFY][perl] Code cleanup and formatting 2019-09-04 16:37:26 +03:00
Evgeny Mankov c9eb8fa1e8 Merge pull request #1387 from emankov/master
[HIPIFY][perl][#259] Fix
2019-09-04 16:11:16 +03:00
Evgeny Mankov b98330609b [HIPIFY][perl][#259] Fix
empty<<<1, 2>>> ( );     >>  hipLaunchKernelGGL(empty, dim3(1), dim3(2), 0, 0);
empty<<<1, 2, 0>>>();    >>
empty<<<1, 2, 0, 0>>>(); >>

instead of erroneous:    >> hipLaunchKernelGGL((empty), dim3(1), dim3(2), 0, 0, );
2019-09-03 16:44:20 +03:00
Yaxun (Sam) Liu 8fe8fc18c0 Do not include cuda wappers for OMP for hip-clang (#1382) 2019-09-03 05:13:59 +00:00
Rahul Garg 6545521d6c Revert "Using HSA API for hipMemsetAsync (#1346)" (#1381)
This reverts commit ac62d7a5c0.
2019-09-03 05:13:46 +00:00
Nicholas Malaya 5a6eafcbf1 Fix Broken Link in hip_porting_guide (#1376)
The math library equivalents between CUDA-HIP are broken. This is a key feature for converting to AMD hardware. This fix corrects the broken link and moves the library equivalents to sit under the "Porting a New Cuda Project" header.
2019-09-03 05:13:35 +00:00
Sarbojit2019 e1f9e08ea7 Removed hipLaunchKernel macro got missed in Merge (#1374) 2019-09-03 05:13:07 +00:00
Evgeny Mankov 7b0480aa69 Merge pull request #1385 from emankov/master
[HIPIFY][doc] Update README.md (testing, versions)
2019-09-02 18:20:44 +03:00
Evgeny Mankov fbf23ed231 [HIPIFY][doc] Update README.md (testing, versions) 2019-09-02 18:18:43 +03:00
Evgeny Mankov 0e70229459 Merge pull request #1384 from emankov/master
[HIPIFY][tests] Add occupancy test
2019-09-02 17:56:16 +03:00
Evgeny Mankov 1bf6deb149 [HIPIFY][tests] Add occupancy test 2019-09-02 17:54:06 +03:00
Evgeny Mankov 9f3a90e174 Merge pull request #1383 from emankov/hipify-clang
[HIPIFY][fix] Fix for upcoming LLVM 10.0
2019-09-01 18:16:24 +03:00
Evgeny Mankov ce4140f94d [HIPIFY][fix] Fix for upcoming LLVM 10.0 2019-09-01 18:15:03 +03:00
Rahul Garg 521a162870 Merge pull request #1378 from ssahasra/no-as
remove obsolete test for OCKL Asynchronous Streams
2019-08-30 19:05:37 -07:00
Sameer Sahasrabuddhe 70023c9075 remove obsolete test for OCKL Asynchronous Streams
The implementation for OCKL AS was recently removed from the device
library since that feature is now superseded by hostcall.
2019-08-30 20:41:29 +05:30
Evgeny Mankov 57760c6a57 Merge pull request #1375 from emankov/hipify-clang
[HIPIFY][DNN] cuDNN 7.6.3 support
2019-08-30 17:26:29 +03:00
Evgeny Mankov b45c26361d [HIPIFY][DNN] cuDNN 7.6.3 support 2019-08-29 19:55:38 +03:00
Evgeny Mankov 5d0b628142 Merge pull request #1372 from emankov/master
[HIPIFY][#207][fix] Translate all preprocessor's conditional blocks
2019-08-29 10:30:05 +03:00
Yaxun (Sam) Liu c404312ffe Fix sample 11_texture_driver for hip-clang (#1370) 2019-08-29 01:03:20 +00:00
Yaxun (Sam) Liu b046ec698b Do not change opt level for -g for hip-clang (#1369)
Currently hipcc uses -O3 for hip-clang by default but uses -O0 if -g is used. This
causes surprise for users since -g should not affect default opt level.
2019-08-29 01:03:11 +00:00
Sarbojit2019 0722704f35 Updated hipErrorString and CUDAErrorTohipError (#1365) 2019-08-29 01:02:59 +00:00
Sarbojit2019 5c4f78bac3 [HIP] Reclaiming hipLaunchKernel API (#1353)
* [HIP] Reclaiming hipLaunchKernel API

* Reclaiming hipLaunchKernel : Incorporated review comments

* Incorporated review comments

* Removed hipLaunchKernel Macro from nvcc path
2019-08-29 01:02:41 +00:00
satyanveshd f807cc1a7b [sample] add new cookbook sample - occupancy (#1352)
* occupancy.cpp with Makefile

* occupancy sample changes according tothe comments

* Changes according to the review comments

* Occupancy Sample Changes

* Changes according to review comments
2019-08-29 01:01:49 +00:00
mshivama d75dc4eb29 Device side support for Cooperative Group feature (#1202)
* first cut of the header implementation of cooperative group feature

* add diclarations for device library functions

* fixed various compile time issues in the CG headers

* enabled copy construction and copy assignment

* fixed a minor bug related to conditional compilation macro

* fixed few more CG constructor issues and added a unit testcase

* fixed typo

* extended unit testcase

* compute size of partitioned CG from mask

* bit of code refactoring

* removed boilerplate code

* fixed few of the review comments by Brian

* Changes to the sigantures of few grid and multi-grid related OCKL functions

* changes to declarations of OCKL functions related to CG feature

* removed all the block level support as it is not planned for 2.9

* Have taken care of review comments by Brian

* Have taken care of review comments by Brian

* removed unused functions which were initially intended to use in block level cg support
2019-08-29 01:01:25 +00:00
Evgeny Mankov 24be21495d [HIPIFY][#207][fix] Translate all preprocessor's conditional blocks
+ Start to translate preprocessor's false conditional blocks too:
  based on clang's https://reviews.llvm.org/D66597;
  available only starting from LLVM 10.0 or trunk.
+ Option -skip-excluded-preprocessor-conditional-blocks for skipping excluded conditional blocks:
  the default behavior for hipify-clang built with LLVM < 10.0;
  false by default for hipify-clang built with LLVM 10 or trunk.
+ Add 4 preprocessor unit tests, 2 of which are LLVM 10.0 only
+ Update couple of existing tests by setting -skip-excluded-preprocessor-conditional-blocks option:
  update lit testing accordingly
2019-08-28 21:17:35 +03:00
Evgeny Mankov 1ab81d9ce6 Merge pull request #1371 from emankov/master
[HIPIFY][cmake] Minor refactoring
2019-08-28 20:42:41 +03:00
Evgeny Mankov eeb4452b23 [HIPIFY][cmake] Minor refactoring
1. Fix setting std c++ (11|14)
2. Get rid of WIN32, use MSVC instead
3. Use VERSION_GREATER_EQUAL and VERSION_MAJOR instead of logical expressions
2019-08-28 20:40:10 +03:00
Maneesh Gupta 5d95ffa010 [packaging] update soft-links that already exist (#1364)
Change-Id: Ibe9840802b1765094ef998edf2210e95404cb989
2019-08-26 23:41:14 -04:00