Alex Voicu 23cc46786a This fixes some outright quaint choices made when implementing HIP's bitwise conversion functions, by using simple reinterpret_casts, as is idiomatic. These functions are supposed to be re-entrant, correct and efficient. Sadly, they were neither: they hid a massive race condition against a value stored in global memory, which means that they were also unreasonably slow if they ever managed to be correct, and relied on union based type punning which is in a grey area of the standard. It is difficult to ascertain what may have been the reason for coming up with this quirky solution. ...

[ROCm/hip commit: a401ce6e5d]

2017-11-28 17:23:06 +00:00

projects/hip

This fixes some outright quaint choices made when implementing HIP's bitwise conversion functions, by using simple reinterpret_casts, as is idiomatic. These functions are supposed to be re-entrant, correct and efficient. Sadly, they were neither: they hid a massive race condition against a value stored in global memory, which means that they were also unreasonably slow if they ever managed to be correct, and relied on union based type punning which is in a grey area of the standard. It is difficult to ascertain what may have been the reason for coming up with this quirky solution.

2017-11-28 17:23:06 +00:00

S

Descripción

No description provided

282 MiB

Languages

C++ 67.5%

C 20.6%

Python 6.6%

CMake 3.4%

Shell 0.6%

Otros 1.1%