4fa165ec1a
* Add ToolsApiTable Add ToolsApiTable wrapping for scratch memory tracking * Add initial support for scratch memory tracking Buffering is implemented * cmake formatting (cmake-format) (#525) Co-authored-by: MythreyaK <MythreyaK@users.noreply.github.com> * source formatting (clang-format v11) (#524) Co-authored-by: MythreyaK <MythreyaK@users.noreply.github.com> * Add callback tracing for scratch Fixed the error where scratch tracking init was called irrespective of whether any client requested for it * Apply suggestions from code review Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com> * Fix tools api copy/update Table were saved/updated incorrectly in previous commit. Also adds passing user data through the callback * Fix OpKind sequence for scratch tracking Previously scratch was using OpKind from rocprofiler-sdk, but templates were instantiated using API ID. These differ by 1 * Integration tests for scratch reporting Added buffer and callback integration tests for scratch reporting * source formatting (clang-format v11) (#550) Co-authored-by: MythreyaK <26112391+MythreyaK@users.noreply.github.com> * cmake formatting (cmake-format) (#551) Co-authored-by: MythreyaK <26112391+MythreyaK@users.noreply.github.com> * python formatting (black) (#549) Co-authored-by: MythreyaK <26112391+MythreyaK@users.noreply.github.com> * CI fixes * source formatting (clang-format v11) (#554) Co-authored-by: MythreyaK <26112391+MythreyaK@users.noreply.github.com> * Update api Rebase on main and updates based on PR feedback * Update scratch reporting and address PR comments - Added agent id to buffer records - Updated `test_internal_correlation_ids` - Is almost identical to one in async-copy - Updated scratch test to check for agent id - Updated queue id serialization in callback records (prints handle as nested key) - Remove `marker_api_traces` from scratch `test_internal_correlation_ids` validation test - Rename `amd_tools_api` to `scratch_memory` - Added doxygen comments - Remove scratch callback from `tool.cpp` - Replace assert with `LOF_IF` in `scratch_memory.cpp` * Update tools table Changed to match up with changes to hsa tables in main branch * Rework scratch memory structure * Update tests - Added suggestions from PR review, and updated tests accordingly * Misc cleanup * Update scratch test As of Apr 4th, `hsa_amd_agent_set_async_scratch_limit` is disabled. Note, > This API: `hsa_amd_agent_set_async_scratch_limit` is currently > disabled. We need some changes in CP firmware to be able to do this > and these changes are not ready yet. > With the current code, you will also not get notifications for > alternate-scratch allocations because this feature has been disabled > while CP firmware is making additional changes > We are hoping to have that feature enabled by ROCm-6.3 * Minor update to lib/rocprofiler-sdk/internal_threading.* - delay destruction of shared_ptrs of the tasks to prevent rare (but possible) data race on the destruction of the shared_ptr --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: MythreyaK <MythreyaK@users.noreply.github.com> Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com> Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
350 строки
13 KiB
C++
350 строки
13 KiB
C++
// MIT License
|
|
//
|
|
// Copyright (c) 2023 Advanced Micro Devices, Inc. All rights reserved.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
// of this software and associated documentation files (the "Software"), to deal
|
|
// in the Software without restriction, including without limitation the rights
|
|
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
// copies of the Software, and to permit persons to whom the Software is
|
|
// furnished to do so, subject to the following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included in all
|
|
// copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
|
|
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
|
|
// SOFTWARE.
|
|
|
|
#include <rocprofiler-sdk/fwd.h>
|
|
#include <rocprofiler-sdk/hip/table_id.h>
|
|
#include <rocprofiler-sdk/hsa/table_id.h>
|
|
#include <rocprofiler-sdk/marker/table_id.h>
|
|
#include <rocprofiler-sdk/rocprofiler.h>
|
|
|
|
#include "lib/rocprofiler-sdk/context/context.hpp"
|
|
#include "lib/rocprofiler-sdk/context/domain.hpp"
|
|
#include "lib/rocprofiler-sdk/hip/hip.hpp"
|
|
#include "lib/rocprofiler-sdk/hsa/async_copy.hpp"
|
|
#include "lib/rocprofiler-sdk/hsa/hsa.hpp"
|
|
#include "lib/rocprofiler-sdk/hsa/scratch_memory.hpp"
|
|
#include "lib/rocprofiler-sdk/marker/marker.hpp"
|
|
#include "lib/rocprofiler-sdk/registration.hpp"
|
|
|
|
#include <glog/logging.h>
|
|
|
|
#include <atomic>
|
|
#include <limits>
|
|
#include <vector>
|
|
|
|
#define RETURN_STATUS_ON_FAIL(...) \
|
|
if(rocprofiler_status_t _status; (_status = __VA_ARGS__) != ROCPROFILER_STATUS_SUCCESS) \
|
|
{ \
|
|
return _status; \
|
|
}
|
|
|
|
namespace rocprofiler
|
|
{
|
|
namespace buffer_tracing
|
|
{
|
|
namespace
|
|
{
|
|
#define ROCPROFILER_BUFFER_TRACING_KIND_STRING(CODE) \
|
|
template <> \
|
|
struct buffer_tracing_kind_string<ROCPROFILER_BUFFER_TRACING_##CODE> \
|
|
{ \
|
|
static constexpr auto value = \
|
|
std::pair<const char*, size_t>{#CODE, std::string_view{#CODE}.length()}; \
|
|
};
|
|
|
|
template <size_t Idx>
|
|
struct buffer_tracing_kind_string;
|
|
|
|
ROCPROFILER_BUFFER_TRACING_KIND_STRING(NONE)
|
|
ROCPROFILER_BUFFER_TRACING_KIND_STRING(HSA_CORE_API)
|
|
ROCPROFILER_BUFFER_TRACING_KIND_STRING(HSA_AMD_EXT_API)
|
|
ROCPROFILER_BUFFER_TRACING_KIND_STRING(HSA_IMAGE_EXT_API)
|
|
ROCPROFILER_BUFFER_TRACING_KIND_STRING(HSA_FINALIZE_EXT_API)
|
|
ROCPROFILER_BUFFER_TRACING_KIND_STRING(HIP_RUNTIME_API)
|
|
ROCPROFILER_BUFFER_TRACING_KIND_STRING(HIP_COMPILER_API)
|
|
ROCPROFILER_BUFFER_TRACING_KIND_STRING(MARKER_CORE_API)
|
|
ROCPROFILER_BUFFER_TRACING_KIND_STRING(MARKER_CONTROL_API)
|
|
ROCPROFILER_BUFFER_TRACING_KIND_STRING(MARKER_NAME_API)
|
|
ROCPROFILER_BUFFER_TRACING_KIND_STRING(MEMORY_COPY)
|
|
ROCPROFILER_BUFFER_TRACING_KIND_STRING(KERNEL_DISPATCH)
|
|
ROCPROFILER_BUFFER_TRACING_KIND_STRING(PAGE_MIGRATION)
|
|
ROCPROFILER_BUFFER_TRACING_KIND_STRING(SCRATCH_MEMORY)
|
|
ROCPROFILER_BUFFER_TRACING_KIND_STRING(CORRELATION_ID_RETIREMENT)
|
|
|
|
template <size_t Idx, size_t... Tail>
|
|
std::pair<const char*, size_t>
|
|
get_kind_name(rocprofiler_buffer_tracing_kind_t kind, std::index_sequence<Idx, Tail...>)
|
|
{
|
|
if(kind == Idx) return buffer_tracing_kind_string<Idx>::value;
|
|
// recursion until tail empty
|
|
if constexpr(sizeof...(Tail) > 0) return get_kind_name(kind, std::index_sequence<Tail...>{});
|
|
return {nullptr, 0};
|
|
}
|
|
} // namespace
|
|
} // namespace buffer_tracing
|
|
} // namespace rocprofiler
|
|
|
|
extern "C" {
|
|
rocprofiler_status_t
|
|
rocprofiler_configure_buffer_tracing_service(rocprofiler_context_id_t context_id,
|
|
rocprofiler_buffer_tracing_kind_t kind,
|
|
rocprofiler_tracing_operation_t* operations,
|
|
size_t operations_count,
|
|
rocprofiler_buffer_id_t buffer_id)
|
|
{
|
|
if(rocprofiler::registration::get_init_status() > -1)
|
|
return ROCPROFILER_STATUS_ERROR_CONFIGURATION_LOCKED;
|
|
|
|
static auto unsupported = std::unordered_set<rocprofiler_buffer_tracing_kind_t>{
|
|
ROCPROFILER_BUFFER_TRACING_PAGE_MIGRATION};
|
|
if(unsupported.count(kind) > 0) return ROCPROFILER_STATUS_ERROR_NOT_IMPLEMENTED;
|
|
|
|
auto* ctx = rocprofiler::context::get_mutable_registered_context(context_id);
|
|
|
|
if(!ctx) return ROCPROFILER_STATUS_ERROR_CONTEXT_NOT_FOUND;
|
|
|
|
if(buffer_id.handle == 0) return ROCPROFILER_STATUS_ERROR_BUFFER_NOT_FOUND;
|
|
|
|
constexpr auto invalid_buffer_id =
|
|
rocprofiler_buffer_id_t{std::numeric_limits<uint64_t>::max()};
|
|
|
|
if(!ctx->buffered_tracer)
|
|
{
|
|
ctx->buffered_tracer = std::make_unique<rocprofiler::context::buffer_tracing_service>();
|
|
ctx->buffered_tracer->buffer_data.fill(invalid_buffer_id);
|
|
}
|
|
|
|
if(ctx->buffered_tracer->buffer_data.at(kind).handle != invalid_buffer_id.handle)
|
|
return ROCPROFILER_STATUS_ERROR_SERVICE_ALREADY_CONFIGURED;
|
|
|
|
RETURN_STATUS_ON_FAIL(rocprofiler::context::add_domain(ctx->buffered_tracer->domains, kind));
|
|
|
|
ctx->buffered_tracer->buffer_data.at(kind) = buffer_id;
|
|
|
|
for(size_t i = 0; i < operations_count; ++i)
|
|
{
|
|
RETURN_STATUS_ON_FAIL(rocprofiler::context::add_domain_op(
|
|
ctx->buffered_tracer->domains, kind, operations[i]));
|
|
}
|
|
|
|
return ROCPROFILER_STATUS_SUCCESS;
|
|
}
|
|
|
|
rocprofiler_status_t
|
|
rocprofiler_query_buffer_tracing_kind_name(rocprofiler_buffer_tracing_kind_t kind,
|
|
const char** name,
|
|
uint64_t* name_len)
|
|
{
|
|
auto&& val = rocprofiler::buffer_tracing::get_kind_name(
|
|
kind, std::make_index_sequence<ROCPROFILER_BUFFER_TRACING_LAST>{});
|
|
|
|
if(name) *name = val.first;
|
|
if(name_len) *name_len = val.second;
|
|
|
|
return (val.first) ? ROCPROFILER_STATUS_SUCCESS : ROCPROFILER_STATUS_ERROR_KIND_NOT_FOUND;
|
|
}
|
|
|
|
rocprofiler_status_t
|
|
rocprofiler_query_buffer_tracing_kind_operation_name(rocprofiler_buffer_tracing_kind_t kind,
|
|
uint32_t operation,
|
|
const char** name,
|
|
uint64_t* name_len)
|
|
{
|
|
if(kind < ROCPROFILER_BUFFER_TRACING_NONE || kind >= ROCPROFILER_BUFFER_TRACING_LAST)
|
|
return ROCPROFILER_STATUS_ERROR_KIND_NOT_FOUND;
|
|
|
|
const char* val = nullptr;
|
|
switch(kind)
|
|
{
|
|
case ROCPROFILER_BUFFER_TRACING_NONE:
|
|
case ROCPROFILER_BUFFER_TRACING_LAST:
|
|
{
|
|
return ROCPROFILER_STATUS_ERROR_INVALID_ARGUMENT;
|
|
}
|
|
case ROCPROFILER_BUFFER_TRACING_HSA_CORE_API:
|
|
{
|
|
val = rocprofiler::hsa::name_by_id<ROCPROFILER_HSA_TABLE_ID_Core>(operation);
|
|
break;
|
|
}
|
|
case ROCPROFILER_BUFFER_TRACING_HSA_AMD_EXT_API:
|
|
{
|
|
val = rocprofiler::hsa::name_by_id<ROCPROFILER_HSA_TABLE_ID_AmdExt>(operation);
|
|
break;
|
|
}
|
|
case ROCPROFILER_BUFFER_TRACING_HSA_IMAGE_EXT_API:
|
|
{
|
|
val = rocprofiler::hsa::name_by_id<ROCPROFILER_HSA_TABLE_ID_ImageExt>(operation);
|
|
break;
|
|
}
|
|
case ROCPROFILER_BUFFER_TRACING_HSA_FINALIZE_EXT_API:
|
|
{
|
|
val = rocprofiler::hsa::name_by_id<ROCPROFILER_HSA_TABLE_ID_FinalizeExt>(operation);
|
|
break;
|
|
}
|
|
case ROCPROFILER_BUFFER_TRACING_MEMORY_COPY:
|
|
{
|
|
val = rocprofiler::hsa::async_copy::name_by_id(operation);
|
|
break;
|
|
}
|
|
case ROCPROFILER_BUFFER_TRACING_SCRATCH_MEMORY:
|
|
{
|
|
val = rocprofiler::hsa::scratch_memory::name_by_id(operation);
|
|
break;
|
|
}
|
|
case ROCPROFILER_BUFFER_TRACING_MARKER_CORE_API:
|
|
{
|
|
val = rocprofiler::marker::name_by_id<ROCPROFILER_MARKER_TABLE_ID_RoctxCore>(operation);
|
|
break;
|
|
}
|
|
case ROCPROFILER_BUFFER_TRACING_MARKER_CONTROL_API:
|
|
{
|
|
val = rocprofiler::marker::name_by_id<ROCPROFILER_MARKER_TABLE_ID_RoctxControl>(
|
|
operation);
|
|
break;
|
|
}
|
|
case ROCPROFILER_BUFFER_TRACING_MARKER_NAME_API:
|
|
{
|
|
val = rocprofiler::marker::name_by_id<ROCPROFILER_MARKER_TABLE_ID_RoctxName>(operation);
|
|
break;
|
|
}
|
|
case ROCPROFILER_BUFFER_TRACING_HIP_RUNTIME_API:
|
|
{
|
|
val = rocprofiler::hip::name_by_id<ROCPROFILER_HIP_TABLE_ID_Runtime>(operation);
|
|
break;
|
|
}
|
|
case ROCPROFILER_BUFFER_TRACING_HIP_COMPILER_API:
|
|
{
|
|
val = rocprofiler::hip::name_by_id<ROCPROFILER_HIP_TABLE_ID_Compiler>(operation);
|
|
break;
|
|
}
|
|
case ROCPROFILER_BUFFER_TRACING_KERNEL_DISPATCH:
|
|
case ROCPROFILER_BUFFER_TRACING_PAGE_MIGRATION:
|
|
case ROCPROFILER_BUFFER_TRACING_CORRELATION_ID_RETIREMENT:
|
|
{
|
|
return ROCPROFILER_STATUS_ERROR_NOT_IMPLEMENTED;
|
|
}
|
|
};
|
|
|
|
if(!val)
|
|
{
|
|
if(name) *name = nullptr;
|
|
if(name_len) *name_len = 0;
|
|
|
|
return ROCPROFILER_STATUS_ERROR_OPERATION_NOT_FOUND;
|
|
}
|
|
|
|
if(name) *name = val;
|
|
if(name_len) *name_len = strnlen(val, 4096);
|
|
|
|
return ROCPROFILER_STATUS_SUCCESS;
|
|
}
|
|
|
|
rocprofiler_status_t
|
|
rocprofiler_iterate_buffer_tracing_kinds(rocprofiler_buffer_tracing_kind_cb_t callback, void* data)
|
|
{
|
|
for(uint32_t i = 0; i < ROCPROFILER_BUFFER_TRACING_LAST; ++i)
|
|
{
|
|
auto _success = callback(static_cast<rocprofiler_buffer_tracing_kind_t>(i), data);
|
|
if(_success != 0) break;
|
|
}
|
|
|
|
return ROCPROFILER_STATUS_SUCCESS;
|
|
}
|
|
|
|
rocprofiler_status_t
|
|
rocprofiler_iterate_buffer_tracing_kind_operations(
|
|
rocprofiler_buffer_tracing_kind_t kind,
|
|
rocprofiler_buffer_tracing_kind_operation_cb_t callback,
|
|
void* data)
|
|
{
|
|
auto ops = std::vector<uint32_t>{};
|
|
switch(kind)
|
|
{
|
|
case ROCPROFILER_BUFFER_TRACING_NONE:
|
|
case ROCPROFILER_BUFFER_TRACING_LAST:
|
|
{
|
|
return ROCPROFILER_STATUS_ERROR_INVALID_ARGUMENT;
|
|
}
|
|
case ROCPROFILER_BUFFER_TRACING_HSA_CORE_API:
|
|
{
|
|
ops = rocprofiler::hsa::get_ids<ROCPROFILER_HSA_TABLE_ID_Core>();
|
|
break;
|
|
}
|
|
case ROCPROFILER_BUFFER_TRACING_HSA_AMD_EXT_API:
|
|
{
|
|
ops = rocprofiler::hsa::get_ids<ROCPROFILER_HSA_TABLE_ID_AmdExt>();
|
|
break;
|
|
}
|
|
case ROCPROFILER_BUFFER_TRACING_HSA_IMAGE_EXT_API:
|
|
{
|
|
ops = rocprofiler::hsa::get_ids<ROCPROFILER_HSA_TABLE_ID_ImageExt>();
|
|
break;
|
|
}
|
|
case ROCPROFILER_BUFFER_TRACING_HSA_FINALIZE_EXT_API:
|
|
{
|
|
ops = rocprofiler::hsa::get_ids<ROCPROFILER_HSA_TABLE_ID_FinalizeExt>();
|
|
break;
|
|
}
|
|
case ROCPROFILER_BUFFER_TRACING_MEMORY_COPY:
|
|
{
|
|
ops = rocprofiler::hsa::async_copy::get_ids();
|
|
break;
|
|
}
|
|
case ROCPROFILER_BUFFER_TRACING_SCRATCH_MEMORY:
|
|
{
|
|
ops = rocprofiler::hsa::scratch_memory::get_ids();
|
|
break;
|
|
}
|
|
case ROCPROFILER_BUFFER_TRACING_MARKER_CORE_API:
|
|
{
|
|
ops = rocprofiler::marker::get_ids<ROCPROFILER_MARKER_TABLE_ID_RoctxCore>();
|
|
break;
|
|
}
|
|
case ROCPROFILER_BUFFER_TRACING_MARKER_CONTROL_API:
|
|
{
|
|
ops = rocprofiler::marker::get_ids<ROCPROFILER_MARKER_TABLE_ID_RoctxControl>();
|
|
break;
|
|
}
|
|
case ROCPROFILER_BUFFER_TRACING_MARKER_NAME_API:
|
|
{
|
|
ops = rocprofiler::marker::get_ids<ROCPROFILER_MARKER_TABLE_ID_RoctxName>();
|
|
break;
|
|
}
|
|
case ROCPROFILER_BUFFER_TRACING_HIP_RUNTIME_API:
|
|
{
|
|
ops = rocprofiler::hip::get_ids<ROCPROFILER_HIP_TABLE_ID_Runtime>();
|
|
break;
|
|
}
|
|
case ROCPROFILER_BUFFER_TRACING_HIP_COMPILER_API:
|
|
{
|
|
ops = rocprofiler::hip::get_ids<ROCPROFILER_HIP_TABLE_ID_Compiler>();
|
|
break;
|
|
}
|
|
case ROCPROFILER_BUFFER_TRACING_KERNEL_DISPATCH:
|
|
case ROCPROFILER_BUFFER_TRACING_PAGE_MIGRATION:
|
|
case ROCPROFILER_BUFFER_TRACING_CORRELATION_ID_RETIREMENT:
|
|
{
|
|
return ROCPROFILER_STATUS_ERROR_NOT_IMPLEMENTED;
|
|
}
|
|
}
|
|
|
|
for(const auto& itr : ops)
|
|
{
|
|
auto _success = callback(kind, itr, data);
|
|
if(_success != 0) break;
|
|
}
|
|
return ROCPROFILER_STATUS_SUCCESS;
|
|
}
|
|
}
|
|
|
|
#undef RETURN_STATUS_ON_FAIL
|