Jonathan R. Madsen
63a999481c
- instead of args="<list-of-string>" in perfetto, each argument is added
individually, enabling matching pointer values, etc.
## Previous behavior
Previously, all function arguments were wrapped into a single string,
e.g.:
## New Behavior
With the exception of the HIP API (whose args are provided as a single
string via `hipApiString`), all functions from MPI, RCCL, pthreads, etc.
have individual arguments in perfetto, e.g.:
In the above, previously, this would have been:
| | |
| - | - |
| args | `pthread_rwlock_t*=0x1c1cc50` |
The key benefit enabled is the ability to find slices with same arg
values:
<img width="753" alt="Screen Shot 2022-09-12 at 11 59 18 PM"
src="https://user-images.githubusercontent.com/6001865/189812915-0342f841-e5ce-4f8e-8169-0cb52f3425b5.png">
Previously, the entire "args" field would have had to match, which
essentially never happened if the pointer was used in two different
functions with different function signatures
## Example
[ROCm/rocprofiler-systems commit: 4ed8f8f762]
