Files
rocm-systems/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/buffer.cpp
T
Benjamin Welton d496bcef18 Fix dimension mismatch for multi-GPU systems with identical architect… (#1440)
* Fix dimension mismatch for multi-GPU systems with identical architectures

This change addresses an issue where counter dimensions were incorrectly
shared across all GPU agents with the same architecture name, even when
those agents had different hardware configurations (e.g., different CU counts).

Changes:
- Updated getBlockDimensions() to accept agent ID instead of architecture name
- Made dimension cache agent-specific instead of architecture-specific
- Updated set_dimensions() in AST evaluation to use specific agent ID
- Modified all API functions to handle agent-specific dimension lookups
- Updated tests to work with agent-specific dimensions

This fix ensures that dimensions accurately reflect the actual hardware
configuration of each individual GPU agent, preventing dimension mismatches
in multi-GPU systems where GPUs share the same architecture but have
different physical configurations.

Counter ID Representation Changes:
- Modified counter_id encoding to include agent information in bits 37-32
- Agent logical_node_id is encoded as (value + 1) to ensure agent 0 is detectable
- Counter records internally store only 16-bit base metric IDs (bits 15-0)
- Tool reconstructs agent-encoded counter IDs from base metric ID & agent info
- Instance record counter_id field uses bitwise AND mask to extract base metric ID
  (counter_id.handle & 0xFFFF) to fit in 16-bit storage
- Output generators (CSV, JSON, Perfetto) use agent-encoded IDs for consistency
- Updated counter_config.cpp and metrics.cpp to extract base metric ID when needed
- All counter lookups now properly handle agent-encoded vs base metric IDs

This ensures counter IDs are consistent between metadata and output records while
maintaining compact storage in instance records.
2025-10-27 07:58:20 -07:00

345 lines
12 KiB
C++

// MIT License
//
// Copyright (c) 2023-2025 Advanced Micro Devices, Inc. All rights reserved.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in all
// copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
// SOFTWARE.
#include "lib/rocprofiler-sdk/buffer.hpp"
#include "lib/common/container/stable_vector.hpp"
#include "lib/common/static_object.hpp"
#include "lib/common/utility.hpp"
#include "lib/rocprofiler-sdk/context/context.hpp"
#include "lib/rocprofiler-sdk/context/domain.hpp"
#include "lib/rocprofiler-sdk/hsa/hsa.hpp"
#include "lib/rocprofiler-sdk/internal_threading.hpp"
#include "lib/rocprofiler-sdk/pc_sampling/service.hpp"
#include "lib/rocprofiler-sdk/registration.hpp"
#include <rocprofiler-sdk/fwd.h>
#include <atomic>
#include <exception>
#include <mutex>
#include <random>
#include <vector>
namespace rocprofiler
{
namespace buffer
{
namespace
{
using reserve_size_t = common::container::reserve_size;
auto&
get_buffers_mutex()
{
static auto _v = std::mutex{};
return _v;
}
uint64_t
get_buffer_offset()
{
static uint64_t _v = []() {
auto gen = std::mt19937{std::random_device{}()};
auto rng = std::uniform_int_distribution<uint64_t>{std::numeric_limits<uint8_t>::max(),
std::numeric_limits<uint16_t>::max()};
return rng(gen);
}();
return _v;
}
} // namespace
bool
is_valid_buffer_id(rocprofiler_buffer_id_t id)
{
if(!get_buffers()) return false;
auto nbuffers = get_buffers()->size();
auto offset = get_buffer_offset();
return (id.handle >= offset && id.handle < (offset + nbuffers));
}
unique_buffer_vec_t*
get_buffers()
{
static auto*& _v = common::static_object<unique_buffer_vec_t>::construct(
reserve_size_t{unique_buffer_vec_t::chunk_size});
return _v;
}
instance*
get_buffer(rocprofiler_buffer_id_t buffer_id)
{
if(is_valid_buffer_id(buffer_id) && get_buffers())
{
for(auto& itr : *get_buffers())
{
if(itr && itr->buffer_id == buffer_id.handle)
{
return itr.get();
}
}
}
return nullptr;
}
std::optional<rocprofiler_buffer_id_t>
allocate_buffer()
{
if(registration::get_fini_status() > 0) return std::nullopt;
// ensure buffer has thread to handle flushing it
static auto _init_threads_once = std::once_flag{};
std::call_once(_init_threads_once, []() { internal_threading::initialize(); });
// ... allocate any internal space needed to handle another context ...
auto _lk = std::unique_lock<std::mutex>{get_buffers_mutex()};
// initial context identifier number
auto _idx = get_buffer_offset() + CHECK_NOTNULL(get_buffers())->size();
// make space in registered
CHECK_NOTNULL(get_buffers())->emplace_back(nullptr);
// create an entry in the registered
auto& _cfg_v = CHECK_NOTNULL(get_buffers())->back();
_cfg_v = std::make_unique<buffer::instance>();
auto* _cfg = _cfg_v.get();
if(!_cfg) return std::nullopt;
// set the buffer id value
_cfg_v->buffer_id = _idx;
return rocprofiler_buffer_id_t{_idx};
}
rocprofiler_status_t
flush(rocprofiler_buffer_id_t buffer_id, bool wait)
{
if(registration::get_fini_status() > 0)
{
ROCP_ERROR << "ignoring rocprofiler buffer flush (handle=" << buffer_id.handle
<< ") request after finalization";
return ROCPROFILER_STATUS_ERROR_FINALIZED;
}
if(registration::get_fini_status() < 0 && !wait) wait = true;
auto offset = get_buffer_offset();
if(!is_valid_buffer_id(buffer_id)) return ROCPROFILER_STATUS_ERROR_BUFFER_NOT_FOUND;
auto* buff = get_buffer(buffer_id);
if(!buff) return ROCPROFILER_STATUS_ERROR_BUFFER_NOT_FOUND;
auto* task_group =
internal_threading::get_task_group(rocprofiler_callback_thread_t{buff->task_group_id});
ROCP_FATAL_IF(!task_group)
<< "buffer (" << buffer_id.handle
<< ") flush request received after the task group for handling request was destroyed";
if(wait) task_group->wait();
// buffer is currently being flushed or destroyed
if(buff->syncer.test_and_set())
{
if(!wait) return ROCPROFILER_STATUS_ERROR_BUFFER_BUSY;
while(buff->syncer.test_and_set())
{
std::this_thread::yield();
std::this_thread::sleep_for(std::chrono::microseconds{10});
}
}
auto idx = buff->buffer_idx++;
auto _task = [buffer_id, idx, offset]() {
ROCP_ERROR_IF(registration::get_fini_status() > 0)
<< "executing buffer (" << buffer_id.handle << ") flush task finalization!";
auto& buff_v = CHECK_NOTNULL(get_buffers())->at(buffer_id.handle - offset);
auto& buff_internal_v = buff_v->get_internal_buffer(idx);
if(!buff_internal_v.is_empty())
{
// designates that buffer should be cleared after functor is invoked
constexpr auto clear_buffer_v = std::true_type{};
// invoke the callback within the scoped lock of process_record_headers.
auto num_processed = buff_internal_v.process_record_headers(
clear_buffer_v, [&buffer_id, &idx, &offset, &buff_v](auto&& _headers) {
// invoke buffer callback
try
{
if(buff_v->callback)
{
ROCP_INFO << fmt::format("invoking buffer callback for {} records "
"[buffer_id={}, idx={}, offset={}]",
_headers.size(),
buffer_id.handle,
idx,
offset);
buff_v->callback(rocprofiler_context_id_t{buff_v->context_id},
rocprofiler_buffer_id_t{buff_v->buffer_id},
_headers.data(),
_headers.size(),
buff_v->callback_data,
buff_v->drop_count);
}
else
{
ROCP_TRACE << fmt::format("no buffer callback for {} records "
"[buffer_id={}, idx={}, offset={}]",
_headers.size(),
buffer_id.handle,
idx,
offset);
}
} catch(std::exception& e)
{
ROCP_CI_LOG(ERROR) << fmt::format(
"buffer callback threw an exception: {} [buffer_id={}, idx={}, "
"offset={}, context_id={}, callback={}, callback_data={}, records={}, "
"first_record_ptr={}, drop_count={}]",
e.what(),
buffer_id.handle,
idx,
offset,
buff_v->context_id,
reinterpret_cast<const void*>(buff_v->callback),
buff_v->callback_data,
_headers.size(),
(!_headers.empty() ? static_cast<const void*>(&_headers[0]) : nullptr),
buff_v->drop_count.load());
}
});
ROCP_INFO << fmt::format(
"completed buffer callback for {} records [buffer_id={}, idx={}, offset={}]",
num_processed,
buffer_id.handle,
idx,
offset);
}
else
{
ROCP_INFO << "buffer at " << buffer_id.handle << " is empty...";
}
buff_v->syncer.clear();
};
task_group->exec(std::move(_task));
if(wait)
{
task_group->join();
}
return ROCPROFILER_STATUS_SUCCESS;
}
} // namespace buffer
} // namespace rocprofiler
extern "C" {
rocprofiler_status_t
rocprofiler_create_buffer(rocprofiler_context_id_t context,
size_t size,
size_t watermark,
rocprofiler_buffer_policy_t action,
rocprofiler_buffer_tracing_cb_t callback,
void* callback_data,
rocprofiler_buffer_id_t* buffer_id)
{
if(rocprofiler::registration::get_init_status() > -1)
return ROCPROFILER_STATUS_ERROR_CONFIGURATION_LOCKED;
auto* existing_buff = rocprofiler::buffer::get_buffer(*buffer_id);
if(existing_buff)
{
ROCP_ERROR << "buffer (handle=" << buffer_id->handle
<< ") already allocated: handle=" << existing_buff->buffer_id;
return ROCPROFILER_STATUS_ERROR_SERVICE_ALREADY_CONFIGURED;
}
auto opt_buff_id = rocprofiler::buffer::allocate_buffer();
if(!opt_buff_id) return ROCPROFILER_STATUS_ERROR_BUFFER_NOT_FOUND;
buffer_id->handle = opt_buff_id->handle;
auto& buff = CHECK_NOTNULL(rocprofiler::buffer::get_buffers())
->at(opt_buff_id->handle - rocprofiler::buffer::get_buffer_offset());
// allocate the buffers. if it is lossless, we allocate a second buffer to store data while
// other buffer is being flushed
buff->buffers.front().allocate(size);
if(action == ROCPROFILER_BUFFER_POLICY_LOSSLESS) buff->buffers.back().allocate(size);
buff->watermark = watermark;
buff->policy = action;
buff->callback = callback;
buff->callback_data = callback_data;
buff->context_id = context.handle;
buff->buffer_id = buffer_id->handle;
buff->buffer_idx = 0;
return ROCPROFILER_STATUS_SUCCESS;
}
rocprofiler_status_t
rocprofiler_flush_buffer(rocprofiler_buffer_id_t buffer_id)
{
#if ROCPROFILER_SDK_HSA_PC_SAMPLING > 0
// Drain internal PC sampling buffers, if needed.
auto status = rocprofiler::pc_sampling::flush_internal_agent_buffers(buffer_id);
if(status != ROCPROFILER_STATUS_SUCCESS) return status;
#endif
return rocprofiler::buffer::flush(buffer_id, true);
}
rocprofiler_status_t
rocprofiler_destroy_buffer(rocprofiler_buffer_id_t buffer_id)
{
if(!rocprofiler::buffer::is_valid_buffer_id(buffer_id))
return ROCPROFILER_STATUS_ERROR_BUFFER_NOT_FOUND;
auto offset = rocprofiler::buffer::get_buffer_offset();
auto* buffers = CHECK_NOTNULL(rocprofiler::buffer::get_buffers());
auto& buff = buffers->at(buffer_id.handle - offset);
if(!buff) return ROCPROFILER_STATUS_ERROR_BUFFER_NOT_FOUND;
// buffer is currently being flushed or destroyed
if(buff->syncer.test_and_set()) return ROCPROFILER_STATUS_ERROR_BUFFER_BUSY;
for(auto& itr : buff->buffers)
itr.reset();
buff->syncer.clear();
buff.reset();
return ROCPROFILER_STATUS_SUCCESS;
}
}