fa772be675
## Overview and rationale This reverts https://github.com/ROCm/rocm-systems/pull/1886, which... * Re-applies https://github.com/ROCm/rocm-systems/pull/1866 * Reverts https://github.com/ROCm/rocm-systems/pull/1728 (So it restores the [`amdgpu-windows-interop/`](https://github.com/ROCm/rocm-systems/tree/develop/shared/amdgpu-windows-interop) folder back to the state from a few weeks ago) The rationale for this change is at https://github.com/ROCm/rocm-systems/pull/1866: > Last PAL update broke applications on gfx12 Windows. ## Cross-repository change details That PR failed to build but was merged with this explanation: > TheRock CI Windows build fails as expected with this revert. > > References to these PAL members need to be stripped out in a patch on TheRock. > > ``` > 11.3 C:\home\runner\_work\rocm-systems\rocm-systems\projects\clr\rocclr\device\pal\palubercapturemgr.cpp(152): error C2039: 'RegisterTraceStateChangeCallback': is not a member of 'GpuUtil::TraceSession' > 11.4 C:\home\runner\_work\rocm-systems\rocm-systems\shared\amdgpu-windows-interop\pal\inc\gpuUtil\palTraceSession.h(372): note: see declaration of 'GpuUtil::TraceSession' > 11.4 C:\home\runner\_work\rocm-systems\rocm-systems\projects\clr\rocclr\device\pal\palubercapturemgr.cpp(195): error C2039: 'UnregisterTraceStateChangeCallback': is not a member of 'GpuUtil::TraceSession' > 11.4 C:\home\runner\_work\rocm-systems\rocm-systems\shared\amdgpu-windows-interop\pal\inc\gpuUtil\palTraceSession.h(372): note: see declaration of 'GpuUtil::TraceSession' > ``` The patch in TheRock was updated in https://github.com/ROCm/TheRock/pull/2154. This rolls forward by updating the ref for TheRock. That original PR could have been sequenced differently to avoid a build break - perhaps by * Pointing to a branch in TheRock with the patch rebased * Deleting the patch in the workflows here but holding a local copy of the path to be applied in workflows * Landing the patch as a normal commit instead of carrying it at all ## Test plan 1. Watch TheRock CI here (https://github.com/ROCm/rocm-systems/actions/runs/19447202693/job/55644411119?pr=1893) 2. Build locally: ```bash # In rocm-systems git am --whitespace=nowarn D:\projects\TheRock\patches\amd-mainline\rocm-systems\0001-Revert-SWDEV-543498-Some-compute-Ubertrace-profiles-.patch git am --whitespace=nowarn D:\projects\TheRock\patches\amd-mainline\rocm-systems\0003-Use-is_versioned-true-consistently-in-both-Comgr-Loa.patch git am --whitespace=nowarn D:\projects\TheRock\patches\amd-mainline\rocm-systems\0006-Explicitly-load-libamdhip64.so.7.patch # Note: the build fails with the observed errors if patch 0001 is not applied! # In TheRock cmake -DCMAKE_BUILD_TYPE=Release \ -DCMAKE_C_COMPILER=cl.exe -DCMAKE_CXX_COMPILER=cl.exe \ -DCMAKE_C_COMPILER_LAUNCHER=ccache -DCMAKE_CXX_COMPILER_LAUNCHER=ccache \ -DPython3_EXECUTABLE=d:/projects/TheRock/.venv/Scripts/python \ -DTHEROCK_ROCM_SYSTEMS_SOURCE_DIR=d:/projects/TheRock/../rocm-systems \ # IMPORTANT -DTHEROCK_AMDGPU_FAMILIES=gfx110X-all \ -DBUILD_TESTING=ON \ -DTHEROCK_ENABLE_ALL=ON \ -Damd-llvm_BUILD_TYPE=RelWithDebInfo \ -S D:/projects/TheRock \ -B D:/projects/TheRock/build \ -G Ninja cmake --build D:/projects/TheRock/build --target hip-clr # [build] Build finished with exit code 0 cmake --build D:/projects/TheRock/build --target ocl-clr+dist # [build] Build finished with exit code 0 ```
157 líneas
5.5 KiB
YAML
157 líneas
5.5 KiB
YAML
name: TheRock CI Windows
|
|
|
|
on:
|
|
workflow_call:
|
|
inputs:
|
|
cmake_options:
|
|
type: string
|
|
project_to_test:
|
|
type: string
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
therock-build-windows:
|
|
name: Build Windows Packages
|
|
runs-on: azure-windows-scale-rocm
|
|
outputs:
|
|
AMDGPU_FAMILIES: ${{ env.AMDGPU_FAMILIES }}
|
|
permissions:
|
|
contents: read
|
|
id-token: write
|
|
defaults:
|
|
run:
|
|
shell: bash
|
|
env:
|
|
BUILD_DIR: B:\build
|
|
CCACHE_DIR: "${{ github.workspace }}/.container-cache/ccache"
|
|
CCACHE_MAXSIZE: "700M"
|
|
# TODO(geomin12): Add matrix of families
|
|
# To get a fast signal of windows building for TheRock, adding gfx110X
|
|
AMDGPU_FAMILIES: "gfx110X-dgpu"
|
|
steps:
|
|
- name: "Checking out repository for rocm-systems"
|
|
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
|
|
|
|
- name: Checkout TheRock repository
|
|
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
|
|
with:
|
|
repository: "ROCm/TheRock"
|
|
path: "TheRock"
|
|
ref: eb8f187ff47eb6af9cd5aaa0b8d9a04b06b12796 # 2025-11-15 commit
|
|
|
|
- name: Set up Python
|
|
uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6.0.0
|
|
with:
|
|
python-version: '3.12'
|
|
|
|
- name: Install python deps
|
|
run: |
|
|
pip install -r TheRock/requirements.txt
|
|
|
|
- name: Patch rocm-systems
|
|
run: |
|
|
# Remove patches here if they cannot be applied cleanly, and they have not been deleted from TheRock repo
|
|
# rm ./TheRock/patches/amd-mainline/rocm-systems/*.patch
|
|
git -c user.name="therockbot" -c "user.email=therockbot@amd.com" am --whitespace=nowarn ./TheRock/patches/amd-mainline/rocm-systems/*.patch
|
|
|
|
- name: Install requirements
|
|
run: |
|
|
choco install --no-progress -y ccache
|
|
# ninja pinned due to a bug in the 1.13.0 release:
|
|
# https://github.com/ninja-build/ninja/issues/2616
|
|
choco install --no-progress -y ninja --version 1.12.1
|
|
choco install --no-progress -y strawberryperl
|
|
echo "$PATH;C:\Strawberry\c\bin" >> $GITHUB_PATH
|
|
choco install --no-progress -y awscli
|
|
echo "$PATH;C:\Program Files\Amazon\AWSCLIV2" >> $GITHUB_PATH
|
|
|
|
- uses: iterative/setup-dvc@4bdfd2b0f6f1ad7e08afadb03b1a895c352a5239 # v2.0.0
|
|
with:
|
|
version: '3.62.0'
|
|
|
|
# After other installs, so MSVC get priority in the PATH.
|
|
- name: Configure MSVC
|
|
uses: ilammy/msvc-dev-cmd@0b201ec74fa43914dc39ae48a89fd1d8cb592756 # v1.13.0
|
|
|
|
- name: Runner health status
|
|
run: |
|
|
ccache --zero-stats
|
|
python ./TheRock/build_tools/health_status.py
|
|
|
|
- name: Fetch sources
|
|
timeout-minutes: 30
|
|
run: |
|
|
git config --global core.longpaths true
|
|
python ./TheRock/build_tools/fetch_sources.py --jobs 12 --no-include-rocm-systems --no-include-rocm-libraries --no-include-ml-frameworks
|
|
dvc pull
|
|
|
|
- name: Configure Projects
|
|
env:
|
|
amdgpu_families: ${{ env.AMDGPU_FAMILIES }}
|
|
package_version: "ADHOCBUILD"
|
|
extra_cmake_options: "-DTHEROCK_ROCM_SYSTEMS_SOURCE_DIR=../ ${{ inputs.cmake_options }}"
|
|
run: |
|
|
# clear cache before build and after download
|
|
ccache -z
|
|
python TheRock/build_tools/github_actions/build_configure.py
|
|
|
|
- name: Build therock-dist
|
|
run: cmake --build "${{ env.BUILD_DIR }}" --target therock-dist
|
|
|
|
- name: Build therock-archives
|
|
run: cmake --build "${{ env.BUILD_DIR }}" --target therock-archives
|
|
|
|
- name: Report
|
|
if: ${{ !cancelled() }}
|
|
run: |
|
|
echo "Build dir:"
|
|
echo "------------"
|
|
ls -lh "${{ env.BUILD_DIR }}"
|
|
echo "Artifact Archives:"
|
|
echo "------------------"
|
|
ls -lh "${{ env.BUILD_DIR }}"/artifacts/*.tar.xz
|
|
echo "Artifacts:"
|
|
echo "----------"
|
|
du -h -d 1 "${{ env.BUILD_DIR }}"/artifacts
|
|
echo "CCache Stats:"
|
|
echo "-------------"
|
|
ccache -s
|
|
|
|
- name: "Build size report"
|
|
if: always()
|
|
shell: powershell
|
|
run: |
|
|
$fs = Get-PSDrive -PSProvider "FileSystem"
|
|
$fsout = $fs | Select-Object -Property Name,Used,Free,Root
|
|
$fsout | % {$_.Used/=1GB;$_.Free/=1GB;$_} | Write-Host
|
|
get-disk | Select-object @{Name="Size(GB)";Expression={$_.Size/1GB}} | Write-Host
|
|
|
|
- name: Configure AWS Credentials
|
|
if: ${{ always() && !github.event.pull_request.head.repo.fork }}
|
|
uses: aws-actions/configure-aws-credentials@ececac1a45f3b08a01d2dd070d28d111c5fe6722 # v4.1.0
|
|
with:
|
|
aws-region: us-east-2
|
|
role-to-assume: arn:aws:iam::692859939525:role/therock-ci-external
|
|
special-characters-workaround: true
|
|
|
|
- name: Post Build Upload
|
|
if: always()
|
|
run: |
|
|
python TheRock/build_tools/github_actions/post_build_upload.py \
|
|
--run-id ${{ github.run_id }} \
|
|
--artifact-group ${{ env.AMDGPU_FAMILIES }} \
|
|
--build-dir ${{ env.BUILD_DIR }} \
|
|
--upload
|
|
|
|
therock-test-windows:
|
|
name: "Test"
|
|
needs: [therock-build-windows]
|
|
uses: ./.github/workflows/therock-test-packages.yml
|
|
with:
|
|
project_to_test: ${{ inputs.project_to_test }}
|
|
amdgpu_families: ${{ needs.therock-build-windows.outputs.AMDGPU_FAMILIES }}
|
|
test_runs_on: "windows-strix-halo-gpu-rocm"
|
|
platform: "windows"
|