AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Set minimum ROCm version for MSCCLPP to 6.2 (#1401)

Browse Source 
* Added ROCm version check around setting `ENABLE_MSCCLPP` flag.
This commit is contained in:
corey-derochie-amd
2024-10-30 16:48:54 -06:00
committed by GitHub
parent d6006f0425
commit 6db2644766
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CMakeLists.txt
+7 -6
View File
@@ -297,11 +297,13 @@ endif()
## Disable building MSCCL++ if the build environment is invalid
## Currently MSCCL++ is supported only on gfx942
if (ENABLE_MSCCLPP)
if(NOT ("gfx942" IN_LIST GPU_TARGETS OR "gfx942:xnack-" IN_LIST GPU_TARGETS OR "gfx942:xnack+" IN_LIST GPU_TARGETS))
set(ENABLE_MSCCLPP OFF)
message(WARNING "Can only build MSCCL++ for gfx942; disabling MSCCL++ build")
endif()
if (ENABLE_MSCCLPP AND NOT ("gfx942" IN_LIST GPU_TARGETS OR "gfx942:xnack-" IN_LIST GPU_TARGETS OR "gfx942:xnack+" IN_LIST GPU_TARGETS))
set(ENABLE_MSCCLPP OFF)
message(WARNING "Can only build MSCCL++ for gfx942; disabling MSCCL++ build")
endif()
if (ENABLE_MSCCLPP AND ROCM_VERSION VERSION_LESS "60200")
set(ENABLE_MSCCLPP OFF)
message(WARNING "MSCCL++ integration only supported on ROCm 6.2 or greater; disabling MSCCL++ build")
endif()
# Determine version from makefiles/version.mk and fill in templates
@@ -828,7 +830,6 @@ endif()
if(ENABLE_MSCCLPP)
include(cmake/MSCCLPP.cmake)
message(STATUS "Building MSCCL++ with NCCL API support")
endif()
## Track linking time