## Motivation
Resolved: SWDEV-566226
The current implementation of agents inside of rocprof-systems keeps just the minimal necessary set of information required for populating the `info_agent` table inside of rocpd database. There is a sufficient amount of data that is being left out from database, so this change should fix that and store the additional agent information as an `extdata` row inside of `info_agent` table.
## Technical Details
This PR introduces additional filed inside of `agent` structure inside which is representing the JSON formatted string of all the additional information we can acquire about particular agent. This data is processed and added during the initial fetching of agents, and afterwards pushed inside of the database.
---------
Co-authored-by: David Galiffi <David.Galiffi@amd.com>
* SWDEV-557412 - Incorporate proper chunk offset when remapping virtual memory (#1848)
* SWDEV-557412 - Incorporate proper offset when remapping virtual memory
* Fix condition to check if VMHeap allocation address matches a chunk address
* Move offset calculation outside if/else block
---------
Co-authored-by: JeniferC99 <150404595+JeniferC99@users.noreply.github.com>
* SWDEV-567852 - Clean-up hip::init() (#1948)
* SWDEV-559267 - Use CLPrint to DevLogPrintf with Log Level - detail debug. (#1160)
* SWDEV-548892 - Stop using ocml isinf wrapper (#1854)
* SWDEV-562708 - change default maximum SVM size to 256GB (#1731)
* SWDEV-503089 - Fix and enable disabled HIP tests from math group (#1319)
* SWDEV-503089 - Fix and enable disabled HIP tests from math group
* SWDEV-503089 - Move single precision reduced run to a common function
* SWDEV-548892 - Stop using ockl steadyctr function (#1882)
Directly use the builtin
* Implement PTL support (#1957)
* Implement PTL support
Signed-off-by: adapryor <Adam.pryor@amd.com>
(cherry picked from commit 45bc31292e7940a3b8fca044ef7df22047b95733)
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
---------
Signed-off-by: adapryor <Adam.pryor@amd.com>
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Co-authored-by: Maisam Arif <Maisam.Arif@amd.com>
* SWDEV-558080 - Add recommended granularity (#1176)
* Add recommended granularity
* Improve granularity testing
* Update based on feedback
* Fix and enable VMM tests on cuda (#1855)
* Fix and enable VMM tests on cuda
* Minor syntax fixes
---------
Co-authored-by: Rahul Manocha <rmanocha@amd.com>
* [rocprofiler-systems] Add support for ompt_callback_thread_begin (#1681)
* Add thread_begin callback
* Make OMPT callbacks that are instant have start_ts = end_ts
* SWDEV-567514: Remove default stream wait (#1977)
- when virtual map command is called
- can create deadlock
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
* Fix flaky test Unit_hipStreamAddCallback_StrmSyncTiming (#2022)
* Review comments
* skip the 3 failing tests to merge hip-tests rocm-systems PR
---------
Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com>
Signed-off-by: adapryor <Adam.pryor@amd.com>
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Co-authored-by: GunaShekar <agunashe@amd.com>
Co-authored-by: agunashe <ajay.gunashekar@amd.com>
Co-authored-by: Ethan Trinh <Ethan.Trinh@amd.com>
Co-authored-by: JeniferC99 <150404595+JeniferC99@users.noreply.github.com>
Co-authored-by: Victor Zhang <111778801+victzhan@users.noreply.github.com>
Co-authored-by: German Andryeyev <56892148+gandryey@users.noreply.github.com>
Co-authored-by: usrihari123 <srihari.u@amd.com>
Co-authored-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com>
Co-authored-by: anujshuk-amd <anujshuk@amd.com>
Co-authored-by: itrowbri <Ian.Trowbridge@amd.com>
Co-authored-by: marantic-amd <marantic@amd.com>
Co-authored-by: David Galiffi <David.Galiffi@amd.com>
Co-authored-by: cadolphe-amd <chris.adolphe@amd.com>
Co-authored-by: Karthik Jayaprakash <54370791+kjayapra-amd@users.noreply.github.com>
Co-authored-by: Matt Arsenault <Matthew.Arsenault@amd.com>
Co-authored-by: Todd tiantuo Li <88386084+lttamd@users.noreply.github.com>
Co-authored-by: amilanov-amd <Aleksandar.Milanov@amd.com>
Co-authored-by: Adam Pryor <61172547+adam360x@users.noreply.github.com>
Co-authored-by: Maisam Arif <Maisam.Arif@amd.com>
Co-authored-by: AidanBeltonS <abeltons@amd.com>
Co-authored-by: Rahul Manocha <153310294+manocharahul@users.noreply.github.com>
Co-authored-by: Rahul Manocha <rmanocha@amd.com>
Co-authored-by: Kian Cossettini <Kian.Cossettini@amd.com>
Co-authored-by: Shadi Dashmiz <94885391+shadidashmiz@users.noreply.github.com>
Co-authored-by: Ioannis Assiouras <38722728+iassiour@users.noreply.github.com>
Co-authored-by: Ajay GunaShekar <86270081+agunashe@users.noreply.github.com>
Add a test to verify VGPRs.
Make hipInfo show maxAddressableVgprsPerThread.
Change-Id: Ibfc2c912a54ccd1686a3930a1008c472a8465136
Co-authored-by: taosang2 <tao.sang@amd.com>
* SWDEV-532676 - Pass hip-path instead of rocm-path
Commit 7b7537c1703db0cc53ee1f36089406b555ae9a9e in llvm-project enforces that no hip-device-lib-path is forwarded by hipcc. To ensure that runtime is found, pass hip-path instead.
* SWDEV-532676 - Fix comment
Co-authored-by: Lambert, Jacob <Jacob.Lambert@amd.com>
---------
Co-authored-by: Lambert, Jacob <Jacob.Lambert@amd.com>
[ROCm/hip-tests commit: 65158bc9f1]
Modified target_link_libraries to link with the hip::amdhip64
target instead of directly linking to the amdhip64 library.
This ensures that all sub-dependent libraries that are necessary
for static build are included.
Change-Id: Idf69477708172604ba9c349735d3230ae765923a
[ROCm/hip-tests commit: ef9558a160]
This reverts commit e495390b7f.
Reason for revert: Observing issue SWDEV-488249 due to catch test permission settings.
Change-Id: Ifdc55e4eb3938c9bc0b9af0a4e9dc9ba366614b3
[ROCm/hip-tests commit: c2671515df]
The variable is set as cache, so that user can override.
But the hard coded setting is preventing override. Removed the same
Change-Id: Ica5f9074a6532f465705a8dd1a8f21c6643ef49e
[ROCm/hip-tests commit: 173abcfba0]
This commit disables samples that directly call hipcc when
building in a static environment. In its current state, hipcc
requires all static libraries to be explicitly provided
in order to succesfully link the sample binary.
Change-Id: I74c94a57867bc1fe0e6134ddd633b465bd6c0f83
[ROCm/hip-tests commit: 90b441a804]
hip-samples package should depends on hip-dev/devel and hipcc rather than hip-runtime-amd
Updated the same for static package as well
DependsOn: Iacab7993dffaa00efd1344d3eafb55f6317d1509
Change-Id: I1470475ddbaf9201ba0e39977aeb48b0382f59c9
[ROCm/hip-tests commit: 0b28ca3f04]
Hip-lang test is failing in static build environment. Disabling it for time being
TODO: Need to renable the test once its fixed
Change-Id: Ie15f02a157a13b3f105596ad673a8a1da6e78b67
[ROCm/hip-tests commit: c7e0c65779]
This change allows to build smaples repo with different build tools like ninja
Signed-off-by: Sebastian Luzynski <Sebastian.Luzynski@amd.com>
Change-Id: I232efc3f19895e84b9de0d410ea43ec55b913ab4
[ROCm/hip-tests commit: 65512f5872]
- force hipcc.bin on windows
- avoids perl, which randomly can't spawn processes
- force hipconfig.bat on windows
- hipconfig.bin does not print hip version for some reason
- i will file a ticket for this
Change-Id: Ib9fb981844213b038f6d1cc3288148116295b58c
[ROCm/hip-tests commit: 80722e5505]
Recent compiler patch https://github.com/llvm/llvm-project/pull/81700/
introduced changes to certain hip external symbols clang emits. This patch
makes the tests "16_assembly_to_executable" and "17_llvm_ir_to_executable"
follow these changes. I expect comments on whether this is an unintended
compiler behaviour that needs fix in compiler or this is the proper fix.
Change-Id: I3943f5365600f683a65c98c6d17c14a5e4192351
[ROCm/hip-tests commit: fba826fc3c]
Jaydeep
Jatin Chaudhary
MachineTom
systems-assistant[bot]
Danylo Lytovchenko
Patel, Jaydeepkumar
Godavarthy Surya, Anusha
Deshpande, Chinmay Diwakar
Guan, Zichuan
kjayapra-amd
Pankaj Kumar Divedi
Ioannis Assiouras
jofernau
Julia Jiang
AravindanC
Ranjith Ramakrishnan
Rahul Manocha
Sebastian Luzynski
Konstantin Zhuravlyov
Jatin Chaudhary
Vikram
Rakesh Roy
Rahul Manocha