76333 Commits

Author SHA1 Message Date
Apurv Mishra 610f8a1e0f rocr: Uninitialized scalar variables and pointer
Added check and initialized parameters for PtrInfo().

v1: Checking if PtrInfo() returns success.
v2: Initialization for variables being passed to PtrInfo().

Change-Id: If3ec4608c8e58be259b4fd51ad681b9bc34ddff6
Signed-off-by: Apurv Mishra <apurv.mishra@amd.com>
Reviewed-by: David Yat Sin <david.yatsin@amd.com>
2024-11-22 16:23:29 -05:00
Apurv Mishra 6ff8fb022a rocr: Uninitialized scalar variables and pointer
Added check and initialized parameters for PtrInfo().

v1: Checking if PtrInfo() returns success.
v2: Initialization for variables being passed to PtrInfo().

Change-Id: If3ec4608c8e58be259b4fd51ad681b9bc34ddff6
Signed-off-by: Apurv Mishra <apurv.mishra@amd.com>
Reviewed-by: David Yat Sin <david.yatsin@amd.com>


[ROCm/ROCR-Runtime commit: 610f8a1e0f]
2024-11-22 16:23:29 -05:00
Joe Narlo 35d8e827b9 SWDEV-497305 [AMDSMI] Consistent string lengths
Unify max string length to AMDSMI_MAX_STRING_LENGTH 256
Replace AMDSMI_NORMAL_STRING_LENGTH, AMDSMI_256_LENGTH

Signed-off-by: Joe Narlo <Joseph.Narlo@amd.com>
Change-Id: Ia81d738be0eefb9683ee53d51c969598fe587f50
2024-11-22 15:37:24 -05:00
Joe Narlo b07c57b2cd SWDEV-497305 [AMDSMI] Consistent string lengths
Unify max string length to AMDSMI_MAX_STRING_LENGTH 256
Replace AMDSMI_NORMAL_STRING_LENGTH, AMDSMI_256_LENGTH

Signed-off-by: Joe Narlo <Joseph.Narlo@amd.com>
Change-Id: Ia81d738be0eefb9683ee53d51c969598fe587f50


[ROCm/amdsmi commit: 35d8e827b9]
2024-11-22 15:37:24 -05:00
Giovanni Baraldi 3f437a9c41 Fix for cache invalidation in stitch.py
Change-Id: I81fa7bd7006feb20fead5eca2003886f58e3ca53
2024-11-22 13:24:57 -06:00
Giovanni Baraldi 9ccbdb8630 Fix for cache invalidation in stitch.py
Change-Id: I81fa7bd7006feb20fead5eca2003886f58e3ca53


[ROCm/rocprofiler commit: 3f437a9c41]
2024-11-22 13:24:57 -06:00
Kiriti Gowda 26edb2e2fe Docs - Updates for 6.3 (#81)
[ROCm/rocjpeg commit: 241f9d731c]
2024-11-22 13:52:10 -05:00
Kiriti Gowda 241f9d731c Docs - Updates for 6.3 (#81) 2024-11-22 13:52:10 -05:00
Ioannis Assiouras 569a4cac67 SWDEV-500124 - Removed Unit_hipHostAlloc_AllocateUseMoreThanAvailGPUMemory
Change-Id: I549ec451df2211378f421f35abc822d02cb0af24


[ROCm/hip-tests commit: ab395147d2]
2024-11-22 13:20:50 -05:00
Ioannis Assiouras ab395147d2 SWDEV-500124 - Removed Unit_hipHostAlloc_AllocateUseMoreThanAvailGPUMemory
Change-Id: I549ec451df2211378f421f35abc822d02cb0af24
2024-11-22 13:20:50 -05:00
Joe Narlo 3052ad4220 SWDEV-495787 [AMDSMI] Different license headers
Change copyrights to MIT and remove date

Signed-off-by: Joe Narlo <Joseph.Narlo@amd.com>
Change-Id: I16f5b412f2b9ddefaaa1771aa714cc18829a1be4
2024-11-22 08:55:28 -05:00
Joe Narlo bad2cc9c23 SWDEV-495787 [AMDSMI] Different license headers
Change copyrights to MIT and remove date

Signed-off-by: Joe Narlo <Joseph.Narlo@amd.com>
Change-Id: I16f5b412f2b9ddefaaa1771aa714cc18829a1be4


[ROCm/amdsmi commit: 3052ad4220]
2024-11-22 08:55:28 -05:00
Ioannis Assiouras aff8088c47 SWDEV-492356 - Install artifacts needed by UUID tests at the top level directory
Change-Id: I960efecfdfc7a0c39a8beec6a334e6aa08095f9c


[ROCm/hip-tests commit: b06dda1f09]
2024-11-22 11:02:23 +00:00
Ioannis Assiouras b06dda1f09 SWDEV-492356 - Install artifacts needed by UUID tests at the top level directory
Change-Id: I960efecfdfc7a0c39a8beec6a334e6aa08095f9c
2024-11-22 11:02:23 +00:00
Benjamin Welton 39db3e8a1d Add rocprofiler_load_counter_definition (#1193)
Adds rocprofiler_load_counter_definition. This function allows a counter definition file to be supplied to rocprofiler-sdk directly. Takes in a string containing the counter definition YAML, its size (in bytes), and a flag value to state whether this is an append operation or not.

---------

Co-authored-by: Benjamin Welton <ben@amd.com>
Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>
Co-authored-by: usrihari123 <srihari.u@amd.com>

[ROCm/rocprofiler-sdk commit: 7ddc72ad45]
2024-11-22 01:55:47 -08:00
Benjamin Welton 7ddc72ad45 Add rocprofiler_load_counter_definition (#1193)
Adds rocprofiler_load_counter_definition. This function allows a counter definition file to be supplied to rocprofiler-sdk directly. Takes in a string containing the counter definition YAML, its size (in bytes), and a flag value to state whether this is an append operation or not.

---------

Co-authored-by: Benjamin Welton <ben@amd.com>
Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>
Co-authored-by: usrihari123 <srihari.u@amd.com>
2024-11-22 01:55:47 -08:00
Gopesh Bhardwaj 5bea1772ea SDK doc updates (#1183)
* correcting usage example

* rccl trace

* Adding Navi power state limitation

* Addressed feedback

* kernel-rename

* kokkos trace

* more information on kookos tracing

* Corecting tool library hardcoding

* summary domains

* Updating domain stats file

* updating images

* rocprofv3 default behavior update

* Removing README from API documentation

* Added missing description in Topics

* Fixed wrong rendering of README in API document

* Fixing Topics in API docs

* Removing API doc for details/rccl.h

* Addressed review comments

[ROCm/rocprofiler-sdk commit: 7ea9ced493]
2024-11-22 12:05:11 +05:30
Gopesh Bhardwaj 7ea9ced493 SDK doc updates (#1183)
* correcting usage example

* rccl trace

* Adding Navi power state limitation

* Addressed feedback

* kernel-rename

* kokkos trace

* more information on kookos tracing

* Corecting tool library hardcoding

* summary domains

* Updating domain stats file

* updating images

* rocprofv3 default behavior update

* Removing README from API documentation

* Added missing description in Topics

* Fixed wrong rendering of README in API document

* Fixing Topics in API docs

* Removing API doc for details/rccl.h

* Addressed review comments
2024-11-22 12:05:11 +05:30
Ioannis Assiouras a22553fb33 SWDEV-494409 - Fixed segfault caused by aligned_free called on unaligned memory
Change-Id: I8ddea5c309b568db25c92789bf71be341d19c3ba


[ROCm/clr commit: 2cc9f59774]
2024-11-22 03:08:04 +00:00
Ioannis Assiouras 2cc9f59774 SWDEV-494409 - Fixed segfault caused by aligned_free called on unaligned memory
Change-Id: I8ddea5c309b568db25c92789bf71be341d19c3ba
2024-11-22 03:08:04 +00:00
Saleel Kudchadker 7d8304e100 SWDEV-497886 - Fix unaligned size copy for kernel args
Change-Id: If6675b98178aeb35f376d6994555cbf941b048c3


[ROCm/clr commit: 2273a1dbdc]
2024-11-21 14:30:04 -05:00
Saleel Kudchadker 2273a1dbdc SWDEV-497886 - Fix unaligned size copy for kernel args
Change-Id: If6675b98178aeb35f376d6994555cbf941b048c3
2024-11-21 14:30:04 -05:00
Ioannis Assiouras b5d95b82c0 SWDEV-454316 - Disabled atomicMin/Max tests that fail on linux PSDB
Change-Id: If0605233b7b869d3b3eb97feab1fe3be77c7ceba


[ROCm/hip-tests commit: b1d409634b]
2024-11-21 18:16:07 +00:00
Ioannis Assiouras b1d409634b SWDEV-454316 - Disabled atomicMin/Max tests that fail on linux PSDB
Change-Id: If0605233b7b869d3b3eb97feab1fe3be77c7ceba
2024-11-21 18:16:07 +00:00
Vladimir Indic e11b553a26 PC sampling services provides dispatch id (#1209)
[ROCm/rocprofiler-sdk commit: 8d2ce4b475]
2024-11-21 11:10:31 -06:00
Vladimir Indic 8d2ce4b475 PC sampling services provides dispatch id (#1209) 2024-11-21 11:10:31 -06:00
Chen Gong 251fcbe49d rocprofiler: add valu utilization
SWDEV-475242

For the description of "FP32 Engine Activity" and "FP64 Engine Activity" in dcgm,
It seems that we do not have an equivalent to these pipe-utilizations on our hardware.

In rocprofiler, I think VALU Utilization is the closest to what we want.

Change-Id: Ibce8835ef4757084cdfd73258de6fc1606ca0158
Signed-off-by: Chen Gong <curry.gong@amd.com>
2024-11-21 15:24:01 +08:00
Chen Gong a8086b484d rocprofiler: add valu utilization
SWDEV-475242

For the description of "FP32 Engine Activity" and "FP64 Engine Activity" in dcgm,
It seems that we do not have an equivalent to these pipe-utilizations on our hardware.

In rocprofiler, I think VALU Utilization is the closest to what we want.

Change-Id: Ibce8835ef4757084cdfd73258de6fc1606ca0158
Signed-off-by: Chen Gong <curry.gong@amd.com>


[ROCm/rdc commit: 251fcbe49d]
2024-11-21 15:24:01 +08:00
Maneesh Gupta 7ff1426782 Revert "SWDEV-475482 - hipTexObjectCreate align with cuda"
This reverts commit 84fb57e7f9.

Reason for revert: Even though this change is valid, this would break backward compatibility.

Change-Id: I9c7cab83198c8d5c8485b11194099162e3e7a874


[ROCm/clr commit: ec6f83b544]
2024-11-21 00:55:32 -05:00
Maneesh Gupta ec6f83b544 Revert "SWDEV-475482 - hipTexObjectCreate align with cuda"
This reverts commit efce2f77c4.

Reason for revert: Even though this change is valid, this would break backward compatibility.

Change-Id: I9c7cab83198c8d5c8485b11194099162e3e7a874
2024-11-21 00:55:32 -05:00
Giovanni Lenzi Baraldi a9256ea070 SWDEV-484742+SWDEV-489158: Dynamic record size for counter collection (#1208)
* Rebased optizations for rocprofv3 tool

* Fixing merge conflicts

* Formatting

* Open from within mutex

* Small name changes

* Added operator

[ROCm/rocprofiler-sdk commit: 6ae441f785]
2024-11-20 15:43:11 -06:00
Giovanni Lenzi Baraldi 6ae441f785 SWDEV-484742+SWDEV-489158: Dynamic record size for counter collection (#1208)
* Rebased optizations for rocprofv3 tool

* Fixing merge conflicts

* Formatting

* Open from within mutex

* Small name changes

* Added operator
2024-11-20 15:43:11 -06:00
Giovanni Baraldi a5192bb9b3 Small fix for stitch.py
Change-Id: I8435aaeb4452b54e5563bbdb47b269f9d0a97b3a
2024-11-20 15:28:51 -06:00
Giovanni Baraldi 3979438e90 Small fix for stitch.py
Change-Id: I8435aaeb4452b54e5563bbdb47b269f9d0a97b3a


[ROCm/rocprofiler commit: a5192bb9b3]
2024-11-20 15:28:51 -06:00
Vladimir Indic 42c6ffc0eb Host trap PC sampling uses new record type (#1207)
* Host trap PC sampling uses new record type

* removing redundant field

* formatting

* simplifying templates in the parser - no need for HostTrap boolean

* reviving some parser tests

* hw_id decoding on GFX9

* HW id parser test

* parser CID test

* Parser multigpu test

* removing rocprofiler_pc_sampling_record_t and some fields from hw_id

* simplifying parser context

* keep bench test internally

* initializing gfx9_hw_id_t differently

* anonymous struct first

* avoiding inlining initialization of struct

[ROCm/rocprofiler-sdk commit: bc52c17e64]
2024-11-20 14:02:47 -06:00
Vladimir Indic bc52c17e64 Host trap PC sampling uses new record type (#1207)
* Host trap PC sampling uses new record type

* removing redundant field

* formatting

* simplifying templates in the parser - no need for HostTrap boolean

* reviving some parser tests

* hw_id decoding on GFX9

* HW id parser test

* parser CID test

* Parser multigpu test

* removing rocprofiler_pc_sampling_record_t and some fields from hw_id

* simplifying parser context

* keep bench test internally

* initializing gfx9_hw_id_t differently

* anonymous struct first

* avoiding inlining initialization of struct
2024-11-20 14:02:47 -06:00
spolifroni-amd a4726c3ce7 reverted README.md (#78)
* reverted README.md

* Update README.md

* Update README.md

---------

Co-authored-by: Aryan Salmanpour <aryan.salmanpour@amd.com>

[ROCm/rocjpeg commit: fd32c06049]
2024-11-20 14:11:58 -05:00
spolifroni-amd fd32c06049 reverted README.md (#78)
* reverted README.md

* Update README.md

* Update README.md

---------

Co-authored-by: Aryan Salmanpour <aryan.salmanpour@amd.com>
2024-11-20 14:11:58 -05:00
spolifroni-amd 94aed66ec3 reverted readme (#459)
* reverted readme

* Update README.md

---------

Co-authored-by: Kiriti Gowda <kiriti.nageshgowda@amd.com>

[ROCm/rocdecode commit: 4e36702f03]
2024-11-20 13:32:22 -05:00
spolifroni-amd 4e36702f03 reverted readme (#459)
* reverted readme

* Update README.md

---------

Co-authored-by: Kiriti Gowda <kiriti.nageshgowda@amd.com>
2024-11-20 13:32:22 -05:00
Jonathan Kim 0f02ed6ffb kfdtest: exclude negative testing from gfx908
GFX 9.0.8 may not properly support pipe reset capabilities so disable
test for now.

Change-Id: I3061cdad87eb979ba884c194f4229c0cbb144ee2
2024-11-20 12:23:09 -05:00
Jonathan Kim 65ebb89e70 kfdtest: exclude negative testing from gfx908
GFX 9.0.8 may not properly support pipe reset capabilities so disable
test for now.

Change-Id: I3061cdad87eb979ba884c194f4229c0cbb144ee2


[ROCm/ROCR-Runtime commit: 0f02ed6ffb]
2024-11-20 12:23:09 -05:00
German Andryeyev a9daa4c8f4 SWDEV-486602 - Disable sysmem pool
Currently amd::Monitor can work in FILO mode for the active waits
and cause a delay in wakeup of some threads. That may have a problem
with the current sysmem pool design.

Change-Id: I145081478d1e0b282d8838855c5718f09cf54b69


[ROCm/clr commit: 9473f143c2]
2024-11-20 11:35:28 -05:00
German Andryeyev 9473f143c2 SWDEV-486602 - Disable sysmem pool
Currently amd::Monitor can work in FILO mode for the active waits
and cause a delay in wakeup of some threads. That may have a problem
with the current sysmem pool design.

Change-Id: I145081478d1e0b282d8838855c5718f09cf54b69
2024-11-20 11:35:28 -05:00
Giovanni Lenzi Baraldi 3291f05e2e Remove check for instance count in aql_tests (#1214)
[ROCm/rocprofiler-sdk commit: 55aea3ef10]
2024-11-20 12:45:30 +01:00
Giovanni Lenzi Baraldi 55aea3ef10 Remove check for instance count in aql_tests (#1214) 2024-11-20 12:45:30 +01:00
Ioannis Assiouras 3be38db6a3 SWDEV-490855 - Add test cases to evaluate kernel launch performance with increasing number of idle streams
Change-Id: I466c57190259d4f5995b06974cc7f589580400b0


[ROCm/hip-tests commit: 22e27ec97f]
2024-11-20 04:19:23 -05:00
Ioannis Assiouras 22e27ec97f SWDEV-490855 - Add test cases to evaluate kernel launch performance with increasing number of idle streams
Change-Id: I466c57190259d4f5995b06974cc7f589580400b0
2024-11-20 04:19:23 -05:00
Rahul Manocha 572eb13c5c SWDEV-454316 - Fix for Atomic Min Max Testcases
Change-Id: Ieca965e6e17f4b17769938228340791b9bbe45ab


[ROCm/hip-tests commit: 0c230d3cf0]
2024-11-19 23:32:30 -05:00
Rahul Manocha 0c230d3cf0 SWDEV-454316 - Fix for Atomic Min Max Testcases
Change-Id: Ieca965e6e17f4b17769938228340791b9bbe45ab
2024-11-19 23:32:30 -05:00