76333 Commits

Author SHA1 Message Date
limeng12 853d3b0cc5 Backgroud health check
Add the RdcSmiHealth module, which will call rocm_smi_lib.
It will support following health:
 - XGMI error detected
 - PCIE replay count detected
 - Memory check
 - InfoROM check
 - Power/Thermal check
The grpc client and server side health function is added.
The health module is added to the rdci.

At present, XGMI/PCIE and a part of Memory have been implemented.
Others will be added as soon as possible.

Change-Id: I1bd99290bdc7dea733f21a41a8c4bcefb2138112
2024-11-19 14:00:49 +08:00
limeng12 71e2727a8f Backgroud health check
Add the RdcSmiHealth module, which will call rocm_smi_lib.
It will support following health:
 - XGMI error detected
 - PCIE replay count detected
 - Memory check
 - InfoROM check
 - Power/Thermal check
The grpc client and server side health function is added.
The health module is added to the rdci.

At present, XGMI/PCIE and a part of Memory have been implemented.
Others will be added as soon as possible.

Change-Id: I1bd99290bdc7dea733f21a41a8c4bcefb2138112


[ROCm/rdc commit: 853d3b0cc5]
2024-11-19 14:00:49 +08:00
Gopesh Bhardwaj a71d6dc340 Format rocporfv3 help (#1199)
* Format rocporfv3 help

* python formatter fix

[ROCm/rocprofiler-sdk commit: a976ed0783]
2024-11-18 20:51:02 -06:00
Gopesh Bhardwaj a976ed0783 Format rocporfv3 help (#1199)
* Format rocporfv3 help

* python formatter fix
2024-11-18 20:51:02 -06:00
Jonathan R. Madsen 1ea688c447 Runtime Initialization Tracing (#1105)
* Runtime initialization tracing

- calbacks and buffer entries notifying when a runtime has been initialized

* Minor cleanup to registration.cpp

* JSON tool implementation

* Increase perfetto_reader timeout

* Handle perfetto_reader timeout when attr doesn't exist

* clang-tidy fixes to memory_allocation.cpp

[ROCm/rocprofiler-sdk commit: 249c50fc40]
2024-11-18 20:50:29 -06:00
Jonathan R. Madsen 249c50fc40 Runtime Initialization Tracing (#1105)
* Runtime initialization tracing

- calbacks and buffer entries notifying when a runtime has been initialized

* Minor cleanup to registration.cpp

* JSON tool implementation

* Increase perfetto_reader timeout

* Handle perfetto_reader timeout when attr doesn't exist

* clang-tidy fixes to memory_allocation.cpp
2024-11-18 20:50:29 -06:00
itrowbri 94f4f56c40 Memory Allocation Tracking (#1142)
* Initial commit: Need to implement wrapper function to collect data and test that wrapper function is correctly replacing core HSA functions

* Attempted to implement wrapper implementation for hsa memory allocation functions. Need to modify generate record files and test if implementation is working as expected

* Debugging and implementing generateCSV function

* Memory allocation size and starting address outputted to csv and json file formats

* Formatting

* Initial setup for OTF2 and Perfetto generation

* Collecting agent id for memory_allocation and formatting

* Modified memory_allocation.cpp to set up code for AMD_EXT commands

* Support for memory_pool_allocate added

* Removed accidently added file

* Made flag optional and added more OTF2 and Perfetto code. Needs testing to ensure perfetto and OTF2 works

* Formatting

* Fixed perfetto and otf2 output

* Fixed flag issue due to incorrect buffer use

* Updated documentation

* Small cleaning and comments

* Added test for HSA memory allocation tracing

* Fixed summary test validation errors due to allocation tracing. Added type to location_base to create unique event ids for allocation due to OTF2 trace error

* Decreased lower limit of hip calls for test

* Modified summary tests to vary number of allocate requests

* Minor fixes to address comments. Still need to address OTF2 comments

* Fix docs and changed OTF2 to use enum for type specified in location_base construction

* Fixed schema error

* Added vmem command tracking. Need to add test

* Updated test to work with vmem command and updated generateCSV to output int instead of hex string.

* OTF2 enum update and mispelling fix

* CI does not support Virtual Memory API. Removed vmem test. Will add back if CI is modifed to suport vmem API

* Update CMakeLists.txt for memory allocation test

* Updated summary test

* Minor fixes to address comments

* Moved domain_type.hpp enum to before LAST

* Fixed compile errors and formatting

* Fixed stats summary domain name error

* Added rocprofv3 test

* Page migration test fix

* Undo page migration test changes. Failures do not appear to have to do with memory allocation

[ROCm/rocprofiler-sdk commit: 3bd7773cf7]
2024-11-18 20:22:14 -06:00
itrowbri 3bd7773cf7 Memory Allocation Tracking (#1142)
* Initial commit: Need to implement wrapper function to collect data and test that wrapper function is correctly replacing core HSA functions

* Attempted to implement wrapper implementation for hsa memory allocation functions. Need to modify generate record files and test if implementation is working as expected

* Debugging and implementing generateCSV function

* Memory allocation size and starting address outputted to csv and json file formats

* Formatting

* Initial setup for OTF2 and Perfetto generation

* Collecting agent id for memory_allocation and formatting

* Modified memory_allocation.cpp to set up code for AMD_EXT commands

* Support for memory_pool_allocate added

* Removed accidently added file

* Made flag optional and added more OTF2 and Perfetto code. Needs testing to ensure perfetto and OTF2 works

* Formatting

* Fixed perfetto and otf2 output

* Fixed flag issue due to incorrect buffer use

* Updated documentation

* Small cleaning and comments

* Added test for HSA memory allocation tracing

* Fixed summary test validation errors due to allocation tracing. Added type to location_base to create unique event ids for allocation due to OTF2 trace error

* Decreased lower limit of hip calls for test

* Modified summary tests to vary number of allocate requests

* Minor fixes to address comments. Still need to address OTF2 comments

* Fix docs and changed OTF2 to use enum for type specified in location_base construction

* Fixed schema error

* Added vmem command tracking. Need to add test

* Updated test to work with vmem command and updated generateCSV to output int instead of hex string.

* OTF2 enum update and mispelling fix

* CI does not support Virtual Memory API. Removed vmem test. Will add back if CI is modifed to suport vmem API

* Update CMakeLists.txt for memory allocation test

* Updated summary test

* Minor fixes to address comments

* Moved domain_type.hpp enum to before LAST

* Fixed compile errors and formatting

* Fixed stats summary domain name error

* Added rocprofv3 test

* Page migration test fix

* Undo page migration test changes. Failures do not appear to have to do with memory allocation
2024-11-18 20:22:14 -06:00
Lakshmi Kumar 2a0fde6173 bug fix for batch sample (#456)
[ROCm/rocdecode commit: 3da7e20b86]
2024-11-18 15:45:56 -05:00
Lakshmi Kumar 3da7e20b86 bug fix for batch sample (#456) 2024-11-18 15:45:56 -05:00
Pran Swarup 4599eda13e Fix GPU resource data of GPU power and temperature is not present on … (#23)
* Fix GPU resource data of GPU power and temperature is not present on MI300A traces

[ROCm/rocprofiler-systems commit: 7b966f7515]
2024-11-18 14:18:21 -05:00
Pran Swarup 7b966f7515 Fix GPU resource data of GPU power and temperature is not present on … (#23)
* Fix GPU resource data of GPU power and temperature is not present on MI300A traces
2024-11-18 14:18:21 -05:00
ajanicijamd 0c579dcc43 Changed libdir for external libraries built with autotools (#24)
[ROCm/rocprofiler-systems commit: 4e34700892]
2024-11-18 14:18:21 -05:00
ajanicijamd 4e34700892 Changed libdir for external libraries built with autotools (#24) 2024-11-18 14:18:21 -05:00
David Galiffi 42580afbb4 Update cmake version installed in dockerfiles (#25)
* Update cmake version installed in dockerfiles
* Standardize the cmake_minimum_required to 3.18.4 across dockerfiles
* Fix link to perl repo in opensuse docker.

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-systems commit: 7633d86c62]
2024-11-18 14:18:21 -05:00
David Galiffi 7633d86c62 Update cmake version installed in dockerfiles (#25)
* Update cmake version installed in dockerfiles
* Standardize the cmake_minimum_required to 3.18.4 across dockerfiles
* Fix link to perl repo in opensuse docker.

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2024-11-18 14:18:21 -05:00
David Galiffi d8c98d2d4d OMPT Target Offload Support (#17)
- Porting from https://github.com/ROCm/omnitrace/pull/411
- Improve OMPT support
- Add OpenMP target example to testing
- Update Timemory submodule to use ROCm/Timemory rather than NERSC/Timemory
- Update `actions/upload-artifacts` to v4
- Standardize the `cmake_minimum_required` to 3.18.4 across workflows, project, and examples
- Updated Ubuntu 20.04 workflows

[ROCm/rocprofiler-systems commit: 9da7365471]
2024-11-18 14:18:21 -05:00
David Galiffi 9da7365471 OMPT Target Offload Support (#17)
- Porting from https://github.com/ROCm/omnitrace/pull/411
- Improve OMPT support
- Add OpenMP target example to testing
- Update Timemory submodule to use ROCm/Timemory rather than NERSC/Timemory
- Update `actions/upload-artifacts` to v4
- Standardize the `cmake_minimum_required` to 3.18.4 across workflows, project, and examples
- Updated Ubuntu 20.04 workflows
2024-11-18 14:18:21 -05:00
David Galiffi 86a2901239 Update CODEOWNERS
[ROCm/rocprofiler-systems commit: 6d28b071f5]
2024-11-18 14:18:21 -05:00
David Galiffi 6d28b071f5 Update CODEOWNERS 2024-11-18 14:18:21 -05:00
David Galiffi 7a4d9685de Update CODEOWNERS
[ROCm/rocprofiler-systems commit: 0e9d77c365]
2024-11-18 14:18:21 -05:00
David Galiffi 0e9d77c365 Update CODEOWNERS 2024-11-18 14:18:21 -05:00
Peter Park 89950ccd37 Add CHANGELOG.md (#18)
[ROCm/rocprofiler-systems commit: 09f5ac643b]
2024-11-18 14:18:21 -05:00
Peter Park 09f5ac643b Add CHANGELOG.md (#18) 2024-11-18 14:18:21 -05:00
David Galiffi affeda8783 Fix for proto files not being viewable in Perfetto UI (#16)
- Fix for proto files not being viewable in Perfetto UI
  - Ported from https://github.com/ROCm/omnitrace/pull/411

- Update Workflows

- Use V47 trace_processor_shell for certain OS releases.
  - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.
  - Incompatible version of GLIBC.

- Remove notes about Perfetto workaround in documentation.

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-systems commit: 46ca5ca265]
2024-11-18 14:18:21 -05:00
David Galiffi 46ca5ca265 Fix for proto files not being viewable in Perfetto UI (#16)
- Fix for proto files not being viewable in Perfetto UI
  - Ported from https://github.com/ROCm/omnitrace/pull/411

- Update Workflows

- Use V47 trace_processor_shell for certain OS releases.
  - RedHat 8, SUSE 15.5, and Ubuntu 20.04 are no longer compatible with the latest trace_processor_shell.
  - Incompatible version of GLIBC.

- Remove notes about Perfetto workaround in documentation.

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2024-11-18 14:18:21 -05:00
dependabot[bot] 07b9f39ab2 Bump rocm-docs-core[api_reference] from 1.8.2 to 1.8.3 in /docs/sphinx (#12)
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.8.2 to 1.8.3.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.8.2...v1.8.3)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[ROCm/rocprofiler-systems commit: 83451e04ae]
2024-11-18 14:18:21 -05:00
dependabot[bot] 83451e04ae Bump rocm-docs-core[api_reference] from 1.8.2 to 1.8.3 in /docs/sphinx (#12)
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.8.2 to 1.8.3.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.8.2...v1.8.3)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-18 14:18:21 -05:00
gabrpham fc9d18dd3e [SWDEV-498453] Enabled for virtual environments
Signed-off-by: gabrpham <Gabriel.Pham@amd.com>
Change-Id: Ic7b274cf8e579b733515efe84fc0f325256ef8b1
2024-11-18 11:57:04 -05:00
gabrpham f7a77c2539 [SWDEV-498453] Enabled for virtual environments
Signed-off-by: gabrpham <Gabriel.Pham@amd.com>
Change-Id: Ic7b274cf8e579b733515efe84fc0f325256ef8b1


[ROCm/amdsmi commit: fc9d18dd3e]
2024-11-18 11:57:04 -05:00
Maisam Arif ed58196e35 Revert "[SWDEV-446215] Update cmake to put test libs in proper lib dir"
This reverts commit 6e01df00ca.

Reason for revert: Incorrect Path

Change-Id: I88bb304cfab997460a916e1a130fdb75435c648b
2024-11-18 11:15:22 -05:00
Maisam Arif e578a46e54 Revert "[SWDEV-446215] Update cmake to put test libs in proper lib dir"
This reverts commit a33cdd7da6.

Reason for revert: Incorrect Path

Change-Id: I88bb304cfab997460a916e1a130fdb75435c648b


[ROCm/amdsmi commit: ed58196e35]
2024-11-18 11:15:22 -05:00
David Galiffi 8500f9128d Update weekly-mainline-sync.yml
Restrict job to the ROCm/rocprofiler-systems repository. 
No need to run on forks.

[ROCm/rocprofiler-systems commit: 043aa81baf]
2024-11-18 10:46:29 -05:00
David Galiffi 043aa81baf Update weekly-mainline-sync.yml
Restrict job to the ROCm/rocprofiler-systems repository. 
No need to run on forks.
2024-11-18 10:46:29 -05:00
Bertan Dogancay df51937f09 Fix typo in ncclGetKernelIndex macro (#1424)
[ROCm/rccl commit: dfe4a3ed81]
2024-11-18 10:40:05 -05:00
Bertan Dogancay dfe4a3ed81 Fix typo in ncclGetKernelIndex macro (#1424) 2024-11-18 10:40:05 -05:00
dependabot[bot] 97a2dd1c1f Bump rocm-docs-core[api_reference] from 1.8.3 to 1.8.4 in /docs/sphinx
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.8.3 to 1.8.4.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.8.3...v1.8.4)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

[ROCm/rocprofiler-systems commit: 915aa50560]
2024-11-18 09:54:15 -05:00
dependabot[bot] 915aa50560 Bump rocm-docs-core[api_reference] from 1.8.3 to 1.8.4 in /docs/sphinx
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.8.3 to 1.8.4.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.8.3...v1.8.4)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-11-18 09:54:15 -05:00
David Galiffi bd491addd6 Weekly promotion of staging to mainline
Perform an ff-only merge of `amd-staging` into an `amd-mainline` staging branch and open a pull request.


[ROCm/rocprofiler-systems commit: 3c1db92d9e]
2024-11-18 09:41:48 -05:00
David Galiffi 3c1db92d9e Weekly promotion of staging to mainline
Perform an ff-only merge of `amd-staging` into an `amd-mainline` staging branch and open a pull request.
2024-11-18 09:41:48 -05:00
dependabot[bot] 6f113dc279 Bump rocm-docs-core[api_reference] from 1.8.3 to 1.8.4 in /docs/sphinx (#75)
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.8.3 to 1.8.4.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.8.3...v1.8.4)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[ROCm/rocjpeg commit: a3f35079cb]
2024-11-18 08:19:10 -05:00
dependabot[bot] a3f35079cb Bump rocm-docs-core[api_reference] from 1.8.3 to 1.8.4 in /docs/sphinx (#75)
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.8.3 to 1.8.4.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.8.3...v1.8.4)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-11-18 08:19:10 -05:00
SrinivasaRao 2f2e5fb958 SWDEV-475134-[catch2][dtest] Functional graph tests for hipUserObject
Change-Id: If4dbe6a3cc6a929e2e4a9521f05dfa2836f0855b


[ROCm/hip-tests commit: 68cc5bdd6e]
2024-11-18 04:58:40 -05:00
SrinivasaRao 68cc5bdd6e SWDEV-475134-[catch2][dtest] Functional graph tests for hipUserObject
Change-Id: If4dbe6a3cc6a929e2e4a9521f05dfa2836f0855b
2024-11-18 04:58:40 -05:00
Satyanvesh Dittakavi 964df84367 SWDEV-498067 - Fix catch tests build failure on nvidia
Change-Id: Idbaa78407f95749b4ae645a52d086056edea4715


[ROCm/hip-tests commit: adf2a4c586]
2024-11-18 04:48:39 -05:00
Satyanvesh Dittakavi adf2a4c586 SWDEV-498067 - Fix catch tests build failure on nvidia
Change-Id: Idbaa78407f95749b4ae645a52d086056edea4715
2024-11-18 04:48:39 -05:00
Ioannis Assiouras 0b9b6d49f5 SWDEV-483134 - Reverted the deprecation of hipHostMalloc/hipHostFree
Change-Id: I065031b8438330c5eb7a7ae510b8d6619b500d04


[ROCm/clr commit: 0fa632c52c]
2024-11-18 04:30:31 -05:00
Ioannis Assiouras 0fa632c52c SWDEV-483134 - Reverted the deprecation of hipHostMalloc/hipHostFree
Change-Id: I065031b8438330c5eb7a7ae510b8d6619b500d04
2024-11-18 04:30:31 -05:00
Ioannis Assiouras 9b00af6f56 SWDEV-483134 - Reverted the deprecation of hipHostMalloc/hipHostFree
Change-Id: I550cdcf8b20bbafa5569be69dfb1e26d4fdb1ad4


[ROCm/hip commit: 5f2d2d109c]
2024-11-18 04:30:27 -05:00
Ioannis Assiouras 5f2d2d109c SWDEV-483134 - Reverted the deprecation of hipHostMalloc/hipHostFree
Change-Id: I550cdcf8b20bbafa5569be69dfb1e26d4fdb1ad4
2024-11-18 04:30:27 -05:00