Vlad Sytchenko
02641f4f43
Correct texture element size calculations
...
hipChannelFormatDesc contains size of each channel in bits. There's 8 bits per byte, not 4, so we should divide by 8.
Change-Id: I38ae2d28ad54740823c98908ca2afecad0ba0183
[ROCm/clr commit: 81b15ed36e ]
2020-06-19 11:39:03 -04:00
Yaxun (Sam) Liu
8849a591f7
Fix missing ldexp(float,int)
...
Change-Id: I2c1553407dfc26948d3ab7aa532eef42a0f6b204
[ROCm/clr commit: 2461135d8a ]
2020-06-18 15:16:59 -04:00
rohit pathania
11ef0984f4
[ dtest ] Added different test scenario with hipMemcpyWithStream
...
- Test with one, two streams
- Test Multi-gpu (one stream per gpu)
- Test D-D (on same device/different devices). Can discover issues
when devices are on same or different root complexes.
- Test H-D/Default
SWDEV-238517 for enhancing hip unit tests
Change-Id: I8031a7eebe2f9c8c0e0996e2c7accb09ac0b96d4
[ROCm/clr commit: 226c438559 ]
2020-06-18 10:31:01 -04:00
Vlad Sytchenko
0a3e99aa14
Support creating textures from user ptr with offset
...
Change-Id: Ied0af9a842fc6ef067e068a9d89dde63ff5dfce1
[ROCm/clr commit: ba2d3fbbb3 ]
2020-06-17 14:10:14 -04:00
Vlad Sytchenko
7a902e0788
Fix -Wsign-compare warnings
...
Change-Id: I874dc007ac657c25a72c6752c1a2da74c028a822
[ROCm/clr commit: 8db45328d9 ]
2020-06-17 11:20:45 -04:00
Jason Tang
ab081f39cc
Add asicRevision
...
Change-Id: I59f3ad20b9bdadf77bd1e0725f7a401d7ad423a3
[ROCm/clr commit: 8933c078f6 ]
2020-06-16 17:54:20 -04:00
Tao Sang
315cd2f959
Make hipHostMalloc() respect hipSetDevice()
...
Change-Id: I2410240f91b108c24597ee0fa7cf31e7b1f3ac5d
[ROCm/clr commit: 63ce69224a ]
2020-06-15 23:20:09 -04:00
kjayapra-amd
b079478641
SWDEV-240589 - Remove guarantee @ __hipRegisterFunction flow for now.
...
Change-Id: Ic51e2a1f951ac7745c2bbd11cfd2b92521c6966a
[ROCm/clr commit: 2467e37f3f ]
2020-06-15 22:32:24 -04:00
Vlad Sytchenko
e5f959ce02
Enable the use of some warnings when building HIP-ROCclr
...
Similar to http://gerrit-git.amd.com/c/compute/ec/vdi/+/375385 , except no -Wno-strict-aliasing.
With this change only two warnings show up during the build - -Wsign-compare and -Wmisleading-indentation.
Change-Id: Iffa436c65ab6312aeaa6def71ee6af38ed1b4a4e
[ROCm/clr commit: 509a38f50c ]
2020-06-15 20:33:30 -04:00
German Andryeyev
17bf7b0138
Initial support for HIP managed memory
...
- Call the new ROCclr interfaces for HMM
Change-Id: I2cd1bf438f712a9e9e328340e7d0c025257ca6c1
[ROCm/clr commit: b182ad9574 ]
2020-06-15 18:10:41 -04:00
Aryan Salmanpour
c60c625688
expose five missing memcpy hip APIs
...
exposing the following hip APIs which have been previously implemented:
hipMemcpy2DFromArray
hipMemcpy2DFromArrayAsync
hipMemcpyAtoH
hipMemcpyHtoA
hipMemcpyParam2DAsync
Change-Id: I3f8635bd4265d2bf5aa2084f4eabb51f74fb18ba
[ROCm/clr commit: 02c62165b8 ]
2020-06-15 12:30:31 -04:00
kjayapra-amd
1ed6d978a8
SWDEV-236178 - Store texture reference metadata for dynamically loaded modules.
...
Change-Id: I99ecc80da7e29c691341a01a09e4532972f1e3e5
[ROCm/clr commit: 0b788c4c67 ]
2020-06-11 22:34:50 -04:00
kjayapra-amd
fb0c0122af
SWDEV-236178 - Remove __hip_pinned_shadow reference from dtests and add hipModuleUnload for all corresponding hipModuleLoad calls.
...
Change-Id: I405789b430ffbb8fccda1cebdb5d18e83a85c926
[ROCm/clr commit: 3fab381493 ]
2020-06-11 22:34:36 -04:00
Rahul Garg
c2eb3cd2f7
Addback __mbcnt_lo and __mbcnt_hi
...
Change-Id: Ic3facba2e2245461515799f6a17842da0f5d9933
[ROCm/clr commit: 2d4b865d63 ]
2020-06-11 21:21:36 -04:00
Vlad Sytchenko
b9efee6df8
Revert "Let hipcc not pass -mllvm option to HIP-Clang on Windows"
...
This reverts commit 23a8dfc8f3 .
Change-Id: If29906b9c63f03d6e51144f510d3a956d90935e8
[ROCm/clr commit: e82e9355f2 ]
2020-06-11 16:36:48 -04:00
kjayapra-amd
d6ccf1209c
SWDEV-236178 - Reorganizing Platform/Modules code for easy access.
...
Change-Id: Ie8920260ffc4ff01e44b48af8cec9ea5aed1aa9b
[ROCm/clr commit: 840347f0d0 ]
2020-06-11 10:11:20 -04:00
Siu Chi Chan
3d7612af8d
fix uninitialized value in hipcc
...
Change-Id: I90b070c491f0efc328fcf97de0e111658ec772de
[ROCm/clr commit: 32f3374af9 ]
2020-06-10 16:07:51 -04:00
jujiang
83c3939c6c
Fix for SWDEV-239415 to handle hipGetDevice properly while no GPU present
...
Change-Id: I252cbbf9a89fc76fe1be1fbb8f45778e96c70fb2
[ROCm/clr commit: bb32492438 ]
2020-06-10 14:18:56 -04:00
kjayapra-amd
5593475c37
SWDEV-231701 - Remove amd::memory->svm_ptr from MemObj, instead of the ptr to the object.
...
Change-Id: I5aab450a2320cfa5417c284e2a8454102df6f99d
[ROCm/clr commit: 9ff22151d2 ]
2020-06-10 11:49:02 -04:00
Dittakavi Satyanvesh
a0fbc8fd08
SWDEV-236670 Address Eigen unit test failure by adding __host__ attribute to half2 functions
...
Change-Id: Ifdc852c30a1b3704871e0ee58cb7a55d3d37fc6e
[ROCm/clr commit: bb785840b9 ]
2020-06-10 03:01:42 -04:00
Christophe Paquot
4206cfddc5
Do not deferred stream creation now that we multiplex HW queues
...
SWDEV-239856
Change-Id: I156650faf832f86891f00ee167269509edd844ec
[ROCm/clr commit: 20ae4d709f ]
2020-06-09 19:16:25 -04:00
Yaxun (Sam) Liu
0d8425ee5a
Fix include path and wrapper header
...
Currently std::complex and some other std functions require uses to
include hip_runtime.h before any other headers to work, which is not
reliable.
changes are made in clang to fix this issue:
https://reviews.llvm.org/D81176
which requires hipcc and HIP headers to make corresponding changes.
This patch will make sure the clang change will not break
HIP/ROCclr during this transition.
After the transition is done, we can remove explicitly setting
include path for HIP-Clang and HIP header in hipcc and hip config
cmake files and rely on clang driver to set it automatically.
Change-Id: I5d226861c2560ffa6c5ab17343a43cc378048061
[ROCm/clr commit: 0a513d8a02 ]
2020-06-09 17:37:20 -04:00
jujiang
b815322dd6
To fix a format in hip_porting_guide.md
...
Change-Id: I5faa4ec9b3d17625b7cb5cea86b9f44766b1cfa9
[ROCm/clr commit: 06c6951205 ]
2020-06-09 13:14:52 -04:00
Rahul Garg
8e4c48bd25
Bump version to 3.6
...
Change-Id: I739a7bd03a4ed102bbc7c2f60d108e20132f5423
[ROCm/clr commit: 6aab5fa993 ]
2020-06-09 11:22:20 -04:00
Saleel Kudchadker
3f07846c7e
Modify HIP_RETURN to print useful details
...
Change-Id: I23892c2d9a738b0298cdf24106d688a792937c73
[ROCm/clr commit: fbba37070c ]
2020-06-06 02:05:21 -04:00
kjayapra-amd
edcdf621b9
SWDEV-239327 - Remove amd_mem_obj during unregistervar
...
Change-Id: I2130eaa21369b9634a9459680061138c61eaaaa4
[ROCm/clr commit: ee2ff4bc5e ]
2020-06-05 23:24:38 -04:00
kjayapra-amd
db1b21b1fa
SWDEV-235295 - Move addDeviceProgram() to lazy loading
...
Change-Id: I8fe07e370e58844496e18c858bb528393556854f
[ROCm/clr commit: 1dc24194a3 ]
2020-06-05 18:03:32 -04:00
Jason Tang
7735b228ec
SWDEV-227909 - Add gcnArchName
...
Change-Id: Iea6d16b5d693dd0d900fa424d7a321c39315430e
[ROCm/clr commit: 14c699e9de ]
2020-06-05 15:33:55 -04:00
kjayapra-amd
70e90419a9
SWDEV-234295 - Pass flag to ROCclr to not clear device programs during program::build()
...
Change-Id: I50b9fa1a96da6895f73fdf4a7c0d3f096b1188da
[ROCm/clr commit: 9261a35be9 ]
2020-06-05 09:53:11 -04:00
rohit pathania
16af0aebc0
[ dtest ] hipModuleLaunchKernel multiThreaded n multiGPU scenarios
...
1.Added hipModuleLaunchKernel multithreaded multi GPU scenario.
2.removed hipCtxCreate API from earlier test as it is deprecated.
SWDEV-238517 for enhancing hip unit tests
Change-Id: Id102d80887b6ff61a59938dbeb9fa2a26a3275b2
[ROCm/clr commit: 0920bac577 ]
2020-06-05 09:40:58 -04:00
Lakhan Singh Thakur
bedadf571d
[dtest] merge 'Adding the two test cases to cover scenarios observed in SWDEV-181598.'
...
SWDEV-238517 for enhancing hip unit tests
Change-Id: Ie61145b46c89b2e970af0ab11e22b6f6286ec90f
[ROCm/clr commit: 6f87616103 ]
2020-06-05 09:10:23 -04:00
Aryan Salmanpour
1c329fee60
Add support for setting hip stream priority
...
this change follows CUDA convention where lower number is greater priority
Change-Id: I72596a36449e818cbd8c175bf8519c51f46b1610
[ROCm/clr commit: 83b8e1fbac ]
2020-06-04 22:50:30 -04:00
Payam
8bdf07bb9c
Observed softhang while running hipStreamAddCallbackCatch SWDEV-236746
...
Workaround hipStream deadlock issue as the same lock was used twice SWDEV-236746
Change-Id: Icc60104ce6edf4cfd2a3a889bab78a6caadd50b7
[ROCm/clr commit: f3ee29cdb2 ]
2020-06-04 14:11:22 -04:00
Aaron En Ye Shi
4d51dbf4f1
Add gfx908 to hip-config.cmake
...
Support gfx908 as part of the default AMDGPU_TARGETS. MIGraphX requires this change.
Change-Id: I692f87f27829778e04f59c9ca655c6e8cbc00abc
[ROCm/clr commit: 29c7c9b1c2 ]
2020-06-04 11:00:09 -04:00
Siu Chi Chan
1f7c745330
add constexpr constructor for vector types
...
Change-Id: I45bb0537d6a24ee50b548c2fd8b4f20518764813
[ROCm/clr commit: 4b56aaefd6 ]
2020-06-04 01:57:03 -04:00
Evgeny
ecdca97a00
adding hipGetStreamDeviceId() profiling API
...
Change-Id: I5ccf88ddac123260d7c17defefcf20ff3b2504e2
[ROCm/clr commit: 0c0a8fc108 ]
2020-06-03 18:57:49 -04:00
Aaron En Ye Shi
b2f9e1c299
Add compiler-rt library for __fp16 and _Float16
...
Similar to HCC, link with compiler-rt to support __fp16 and _Float16 type conversions in ONNX models. This should resolve SWDEV-238491.
Change-Id: Iad8dcff568831719f501f562a04023326ae8036c
[ROCm/clr commit: d93134e727 ]
2020-06-03 18:53:14 +00:00
Siu Chi Chan
85d781ba65
update device library path
...
fix device lib directory
add missing --hip-link switch for link phase
Change-Id: I4b2eeb32648ca3cec72ec1f4e3381ce1fc0a90a5
[ROCm/clr commit: c414c70e8f ]
2020-06-03 14:44:23 -04:00
Jatin
216873e9c8
Adding changes for hipExtLaunchKernel for rocCLR
...
Change-Id: Iba52bc3bde7c37f3fb375a55ba0947e87b3cdc9b
[ROCm/clr commit: 126573df4c ]
2020-06-02 14:16:41 -04:00
Rahul Garg
247e111c91
Use right perl-which rpm package
...
Change-Id: I22106a7d1b4b50c99f945bc6416ff3bd8486d15c
[ROCm/clr commit: db471e5ed9 ]
2020-06-02 02:17:54 -04:00
Aaron En Ye Shi
d2bcb05dfb
HIP-Clang Temporarily include HIP_HCC_FLAGS for PyT
...
Change-Id: I0f5895fba69f5bf0c6cc13e9402bdc44726dcc5a
[ROCm/clr commit: a436ab865a ]
2020-06-01 15:28:04 -04:00
Aryan Salmanpour
e4052cd66b
Add support for missig hipStreamGetPriority API
...
Change-Id: I2be4b055e5f977eb6ecad0b1f5f9535e72345fe7
[ROCm/clr commit: bf11ffd175 ]
2020-06-01 13:33:14 -04:00
agodavar
a3feb53a30
hipMemset dont enqueue command if size bytes is 0
...
Change-Id: I63bf896f9f23edf254acdf7a8c11c92f8b5ac039
[ROCm/clr commit: 3375920638 ]
2020-05-30 10:33:44 -04:00
Rahul Garg
3e397c620a
Add libfile-which-perl dependency SWDEV-237642
...
Change-Id: I0799fdcbc58a35c957a3bc69a8a1c6a013a3f57c
[ROCm/clr commit: 27e306686c ]
2020-05-29 20:04:23 -04:00
kjayapra-amd
776af02dfe
SWDEV-229840 - fixing return HIP_RETURN instances in hip.
...
Change-Id: I48763d7268bf5649bf2242c962c185f5f4af159c
[ROCm/clr commit: ab17b43d45 ]
2020-05-29 09:43:58 -04:00
Aryan Salmanpour
5aec64346f
[dtest] add a multi stream test for (SWDEV-237846)
...
Change-Id: I4a1d764df75af7019d0f38313e5e0a6a224818f8
[ROCm/clr commit: 200ab30084 ]
2020-05-28 23:36:10 -04:00
jujiang
4fad481033
Update document for hip_faq.md, hip_porting_guide.md and hip_terms2.md
...
Change-Id: I2c019f802ad70ed43f1608cfd3c9067f1573741e
[ROCm/clr commit: 017e3b87b3 ]
2020-05-28 17:51:58 -04:00
Christophe Paquot
c5e4607065
Revert "Call notifyCmdQueue when building the event wait list"
...
This reverts commit df67d8971a .
Reason for revert: better fix in ROCclr
Change-Id: I9707e69adf42a662c08fe9b3ec7458655d838bdd
[ROCm/clr commit: dfec136725 ]
2020-05-28 17:01:10 -04:00
kjayapra-amd
b91ab37e8d
SWDEV-233927 - Crash if binary for current device is not found.
...
Change-Id: I57281ae6c09110f39155664fca5a83ea57bb62b4
[ROCm/clr commit: f2899243f3 ]
2020-05-28 16:18:27 -04:00
Joseph Greathouse
9b1faa7db0
Fix a build error on signed/unsigned comparison
...
Change-Id: Ic79eb4c3ec5c6fd36cea7c4810d990619f08b9e1
[ROCm/clr commit: 766e708535 ]
2020-05-28 14:27:16 -05:00