Commit Graph

137 Commits

Author SHA1 Message Date
Jatin Chaudhary 260a83c546 Replacing deprecated HSA API calls with newer ones
Change-Id: Iebe2c00e717ab0e47c61611752b717966c719994


[ROCm/clr commit: cd1e364911]
2020-07-08 00:32:24 -04:00
Aryan Salmanpour 8d083a3c61 Always print error message with the returned error code before abort
Change-Id: I8479abc586937a50c90b2785c4ce7364e6e9732b


[ROCm/clr commit: 4a901f3dd3]
2020-07-07 16:28:30 -04:00
Tao Sang 7591ff8172 Fix static lib crash by setting top init_priority
Set top init_priority on affecting global variables so that
they will be created firstly and destroyed lastly.

Change-Id: Ied59fbecab66ba8195c4a7a02b6bef9fa2fad3af


[ROCm/clr commit: f7bf882981]
2020-07-06 16:54:10 -04:00
Matt Arsenault c9239f4f78 Remove .value_type from code object v3 metadata
This seems to not actually have any function. The OpenCL API test
passes without it, and the way it's produced is problematic.

Change-Id: I384bfa01dee7023484348b184ddd1b2d44a91f7d


[ROCm/clr commit: cfed3f310d]
2020-07-06 11:07:30 -04:00
Matt Arsenault 8892ba072f Fix unused function warnings for conditionally used functions
Change-Id: Ied23c571b949abef1816914986f19b14aca3d2f3


[ROCm/clr commit: c56a82fd05]
2020-07-06 10:28:43 -04:00
Matt Arsenault 2c395913a7 Remove unused functions
Change-Id: I55db791019c511de83d8b895e3a48b3d7475aeac


[ROCm/clr commit: 9e3e41ca2e]
2020-07-06 10:27:29 -04:00
German Andryeyev 67c2bf6df4 Return always true for P2P validation under ROCr
Change-Id: Id32a5a94a642e708d1d042c5247af38501bec153


[ROCm/clr commit: 059832b526]
2020-07-04 11:38:04 -04:00
Aryan Salmanpour 934763278b remove unused argument from enableHostcalls/disableHostcalls functions
Change-Id: I351a6b4e23cd9f118310c5c79b1afcb4758fde1b


[ROCm/clr commit: 34b82eb998]
2020-06-26 16:33:30 -04:00
Tao Sang 9273cfaa15 Support numa policy set by user
Add hostNumaAlloc() to support numa policy set by user

Change-Id: Ib6c3e838aa53e3d9b3db9735c585df46a1c98944


[ROCm/clr commit: da94cd0de1]
2020-06-23 18:57:03 -04:00
Dittakavi Satyanvesh b7801b2035 SWDEV-240566 adds error message before abort
Change-Id: I4dbd089daa5e6fde5e8722dc2395225dd822561c


[ROCm/clr commit: 7a3b8c6dd2]
2020-06-22 10:12:49 -04:00
Jason Tang b2e264b2c1 For apu: call commitSvmMemory() from Device::svmAlloc()
Change-Id: Ic6e9b2ad4624e7e1c50835d3825254c76e764bf0


[ROCm/clr commit: 532083f87c]
2020-06-22 10:09:32 -04:00
Jason Tang f1110d715e Set the tiled_ flag according to ImageCreateInfo
Change-Id: I3e1b2fdd15e32c3c24f4341001b068738c98e388


[ROCm/clr commit: 138b2d3ce2]
2020-06-19 12:34:07 -04:00
kjayapra-amd 5a1e09a37d SWDEV-229840 - Add Debug prints when the element is already present in MemObjMap_
Change-Id: I21129d087e73cc2a9e35f03e6a1a2dc527626f48


[ROCm/clr commit: 71c05075ba]
2020-06-19 12:33:20 -04:00
German Andryeyev a1974c06e9 Switch PAL to interface 610
Change-Id: Ida563f38513789f5ba105ac92a9737c59cd5d90d


[ROCm/clr commit: 01fcf82448]
2020-06-19 11:40:12 -04:00
Jason Tang fb0be5d639 Merge pal Resource mapLayers/unmapLayers logic into map/unmap
Change-Id: I0198fb96f104539fb557f91160665e60ba576132


[ROCm/clr commit: 155ff5bdcc]
2020-06-19 10:51:48 -04:00
Aryan Salmanpour 6943b4fa83 move hostcall-based implementation of messages/printf from rocm backend to the common device layer
SWDEV-232428

Change-Id: I14b774e66a1783569c6d34d8759c1faa5f340e27


[ROCm/clr commit: 1bd265f8d6]
2020-06-18 13:49:28 -04:00
Saleel Kudchadker f00b041e6c Reset GPU_FORCE_BLIT_COPY_SIZE as its fixed in KFD
Commit ebcfa85cf7ebb26c96fca48a34292d88e74dd675
fixes programming of SDMA*_ULV_CNTL.HYSTERIS register

Change-Id: Ibb1d824bf3f8e351f840adbc099601b322f935f6


[ROCm/clr commit: d8efc31c34]
2020-06-17 13:23:41 -07:00
Vlad Sytchenko 0b3fc7bc5d Fix some -Wunused-but-set-variable warnings
Change-Id: I281583b5abdfc09d5dd8b7dfb20b8821581db193


[ROCm/clr commit: 5b9af8f28d]
2020-06-15 17:51:01 -04:00
German Andryeyev cfe7062be1 Fix compile error in ATI make build
Change-Id: Id9d23b8f46bf1b97c0f02c8ae0edd94e6963b1b5


[ROCm/clr commit: afe825c506]
2020-06-15 10:31:57 -04:00
Tao Sang e3c1bb153b Deduce hops from numa distance
Rocr won't return real hops so that we have to deduce hops from
numa distance as a workaround. This will be subject to change
as driver team will provide a long term solution in rocm3.7

Change-Id: Ifb939ed848db190c3d544bb7f30a5821161921e6


[ROCm/clr commit: b14d9e0a36]
2020-06-13 17:04:17 -04:00
Jason Tang e762c29a30 Get gpu asicRevision_
Change-Id: I8afb53e027d912843655823eebaec29901c33d28


[ROCm/clr commit: 30e36a4925]
2020-06-12 14:51:52 -04:00
German Andryeyev 0a6056ac82 Initial HMM support
- Expose ROCclr interfaces for HIP usage
- ROCr interfaces aren't available in staging, thus control the
build with AMD_HMM_SUPPORT define

Change-Id: Iadc2bcc230e78d3b0dc22b235189c8cc80843446


[ROCm/clr commit: c5afd5d412]
2020-06-12 09:06:07 -04:00
Rahul Garg d9aa6e2375 Fix IPC create memory failure
ROCr expects granular size in hsa_amd_ipc_memory_create

Change-Id: I7c266aa2eef8304f105298a7a668f4c4b3fb5f5a


[ROCm/clr commit: 617538074c]
2020-06-11 13:02:54 -04:00
Saleel Kudchadker fca301772c Add logging support for AQL packet
Use AMD_LOG_LEVEL=4 and AMD_LOG_MASK=8 to print AQL log
explicitly
Change-Id: I4209d91b460e64be44261d3ab773580067e47c29


[ROCm/clr commit: 2b771d2f5f]
2020-06-10 14:04:47 -07:00
Aryan Salmanpour a760a90d35 reuse available queue with the same priority if queue creation fails
Change-Id: I1522935ce1a73c4724135668d039e88a9097710b


[ROCm/clr commit: 5203c5271b]
2020-06-09 17:56:18 -04:00
Aryan Salmanpour 6059c30804 fix a build error on TeamCity due to order of initialization in rocm Device class
Change-Id: I2e45e71e53272b7a7813422d3b949e3835077ab0


[ROCm/clr commit: 1d938697a1]
2020-06-08 13:56:39 -04:00
kjayapra-amd 01737d2472 SWDEV-239327 - Dont call hsa_amd_memory_pool_free from ~amd::Memory() for obj created by passing devptr.
Change-Id: I315fd502df6bb1bf66dd24eac9325f1439e432ad


[ROCm/clr commit: 1b0882e061]
2020-06-05 18:42:03 -04:00
German Andryeyev d4a985dcd3 Make sure runtime sync before CPU access
Change-Id: I52882788ded187b3f735257a188b1b08d8502147


[ROCm/clr commit: 3828a61413]
2020-06-05 12:00:08 -04:00
German Andryeyev 566684b6f4 Add the sync of the current queue
Make sure runtime waits for the current queue before
synching with device queue

Change-Id: I753b6fc0bb15a3a3d4bf03fef1152842550850c0


[ROCm/clr commit: 86e0f337fc]
2020-06-05 11:57:59 -04:00
kjayapra-amd d6a2b2247a FEAT-30761 - Adding defaults to all Switch cases in PalDevice gfx detection.
Change-Id: Ic998dba44d3287484d6b0da4f07f320de8e6d92b


[ROCm/clr commit: 1982c16e46]
2020-06-04 20:49:58 -04:00
Aryan Salmanpour 55c58ebfaa Add support for setting queue priority for ROCm backend
Change-Id: I67ed5a6868af79538f7f4522d8d11c043cdf3c1e


[ROCm/clr commit: b5552aa97f]
2020-06-04 20:16:32 -04:00
Saleel Kudchadker 2a42d5838d Set hidden mem witholding to 0 by default
TF doesn't reserve all available memory now. If any
client wants to reserve they can explicitly set
HIP_HIDDEN_FREE_MEM env var
Change-Id: Ied3a948b79f49aa7327f6a820e9789e39cec143b


[ROCm/clr commit: d8ca3c632c]
2020-06-04 14:37:40 -04:00
Saleel Kudchadker 0bdb497c1a Fix a potential mem leak
If a offset of the pointer is passed to free it may release
the mem object but may not release from MemObjMap. Erase the map
by getting the parent pointer.
Change-Id: I06b92548de2d49b4029efe6b511329225007cc55


[ROCm/clr commit: 2b6fea4348]
2020-06-04 14:05:11 -04:00
Vlad Sytchenko 20c5916b32 Handle the option USE_COMGR_LIBRARY correctly
This is a follow up to http://gerrit-git.amd.com/c/compute/ec/vdi/+/359563. The setting is now either ON or OFF, never "yes".

Change-Id: I031d013a8d239dc72ef610da81bd31b8b78a3ba8


[ROCm/clr commit: 3a84fcd13e]
2020-06-03 17:25:47 -04:00
Tao Sang a0506189a1 Fix TC linux build issue due to previous Numa patch
Change-Id: I6068edaf38cac6fad187c8429707afdb727e8d41


[ROCm/clr commit: fabfc42b68]
2020-06-03 16:42:53 -04:00
Tao Sang 6041b06b61 Support Numa-aware cpu selection
Select cpu in terms of the smallest Numa distance for a GPU device.
This will improve performance of hipMemcpy in the mode of
hipMemcpyHostToDevice or hipMemcpyDeviceToHost for small buffer.
`

Change-Id: I2860f1f83b79be0dff7bf5e64cf68ab4448db0a1


[ROCm/clr commit: aedb9590be]
2020-06-01 21:01:24 -04:00
German Andryeyev 3abb1347cf Revert "Revert "Reenable cooperative groups""
This reverts commit c6c208099b.

Reason for revert: <INSERT REASONING HERE>

Change-Id: I93c45fae27e0a08b199542d44fb0d65fc74ea13c


[ROCm/clr commit: fb401bfe6d]
2020-05-25 14:11:58 -04:00
kjayapra-amd c7b79be23d SWDEV-237467 - Adding return type to comply with -Wall compiler flag.
Change-Id: I3c9935105ef262cdbf1c8ee293930b018be0197a


[ROCm/clr commit: 3603272d24]
2020-05-23 14:22:54 -04:00
kjayapra-amd e44ec607ef FEAT-30761 - Fixing fall through in gfxip major/minor detection.
Change-Id: Ib97b3dbe993e01df3360cbeda6bd0d9d366535b6


[ROCm/clr commit: ea0137fb22]
2020-05-23 12:42:44 -04:00
kjayapra-amd c1e072980d SWDEV-237467 - Return proper hip error codes incase of ROCclr IPC API failures.
Change-Id: I1d018918ed71f6d80846b3017f7a15f4ab496554


[ROCm/clr commit: 53a890b499]
2020-05-22 22:10:15 -04:00
kjayapra-amd 0cbaf84fa6 SWDEV-236110 - Fixing uninitialized variable.
Change-Id: I26a2a6826da643b57da9746e3ce888a46c4e78f4


[ROCm/clr commit: 618d66b5fe]
2020-05-22 20:40:24 -04:00
kjayapra-amd 95d6ff1279 SWDEV-229840 - Remove false error messages.
Change-Id: I0346768a2a52913d5330bc2007a7706e2a439c47


[ROCm/clr commit: 32043017ed]
2020-05-22 18:18:41 -04:00
Aryan Salmanpour 009eed8763 check for valid queue before accessing cuMask()
Change-Id: I8d4b0dbcd097c2ec5c31dea5a3d0060f0864a7e8


[ROCm/clr commit: fec4adfd19]
2020-05-20 16:23:09 -04:00
German Andryeyev e6b1dc9771 Add missing memory allocation in printf
Change-Id: I452b676612b54f70106e7ef1bcb5ce2baf7b3ffc


[ROCm/clr commit: f56a052243]
2020-05-20 14:49:59 -04:00
Alex Xie 48068bdb89 Fix compile error in certain version of GCC
Change-Id: I27f021db908bf114a685427a47cd9f0d6b2e5693


[ROCm/clr commit: 966448c53b]
2020-05-20 13:13:55 -04:00
German Andryeyev e20f40119c Fix async mem clear
Optimization for the fence release removed a sync for mem fill.
Add simple const buffer management forr the filled pattern to avoid
pattern overwriting with the async fills.

Change-Id: I63773ac09ceec31d5396d24570e4647ff096326b


[ROCm/clr commit: 2ce6bbebc4]
2020-05-20 11:13:41 -04:00
Chauncey Hui d400543947 Modified IpcDetach to return status instead of void.
Change-Id: I68ed94b93f0383babe25eb046b4047d249a0fdc1


[ROCm/clr commit: 0af9c06968]
2020-05-20 03:38:21 -04:00
Matt Arsenault d2cb056d06 Remove include/ from #includes
These are unnecessary and an obstacle to producing a relocatable
package.

Change-Id: I0059bf7a2d11fcece0cd7ab47d7545d0df4d7099


[ROCm/clr commit: 1d267c9c08]
2020-05-19 19:35:09 -04:00
Aakash Sudhanwa c6c208099b Revert "Reenable cooperative groups"
This reverts commit 7b00a525ba.

Reason for revert: <INSERT REASONING HERE>

Change-Id: I8954b37c354382804a139d80e2551c381fd9b2ed


[ROCm/clr commit: abc115bda8]
2020-05-19 18:21:48 -04:00
Jason Tang f94e958680 Add major/minor/stepping to device layer
Change-Id: If82ea55a46b166b243a98089a6e9c40ccfdb479f


[ROCm/clr commit: cd2a713d63]
2020-05-17 12:57:34 -04:00