Commit Graph

3661 Commits

Author SHA1 Message Date
kjayapra-amd 16e6b65b5c SWDEV-240165 - Move all amd::MemObjMap_ reference to ROCclr and only allow base ptr to get ipc handle.
Change-Id: I9de10a0c4ba4dee3b3c8b972966840ab807001d8
2020-07-09 21:19:45 -04:00
Chauncey Hui 1b69c85913 SWDEV-2 - Change OpenCL version number from 3172 to 3173 2020-07-08 03:00:03 -04:00
Jatin Chaudhary cd1e364911 Replacing deprecated HSA API calls with newer ones
Change-Id: Iebe2c00e717ab0e47c61611752b717966c719994
2020-07-08 00:32:24 -04:00
Aryan Salmanpour 4a901f3dd3 Always print error message with the returned error code before abort
Change-Id: I8479abc586937a50c90b2785c4ce7364e6e9732b
2020-07-07 16:28:30 -04:00
Chauncey Hui 5c2e64a43c SWDEV-2 - Change OpenCL version number from 3171 to 3172 2020-07-07 03:00:03 -04:00
Tao Sang f7bf882981 Fix static lib crash by setting top init_priority
Set top init_priority on affecting global variables so that
they will be created firstly and destroyed lastly.

Change-Id: Ied59fbecab66ba8195c4a7a02b6bef9fa2fad3af
2020-07-06 16:54:10 -04:00
Tao Sang 2c551e44cc Fix crashing of private elf apis in static lib
When rocr and hip-rocclr are static libs, rorc will wrongly reference
private elf apis, then crash will happen. By renaming asm symbol
names of private elf apis, rocr will reference public elf apis, thus
crashing won't happen.

Change-Id: I7cf552f1fae5fe09adeac3aec1a24445f39d406c
2020-07-06 13:41:09 -04:00
Matt Arsenault cfed3f310d Remove .value_type from code object v3 metadata
This seems to not actually have any function. The OpenCL API test
passes without it, and the way it's produced is problematic.

Change-Id: I384bfa01dee7023484348b184ddd1b2d44a91f7d
2020-07-06 11:07:30 -04:00
Matt Arsenault 3a564bc6cb Enable warnings on unused functions
There weren't all that many to fix, and it's not even the most
prevalent warning.

Change-Id: I286aaa42e3c4e305b1e1918f302bbf71e41dd47d
2020-07-06 10:29:29 -04:00
Matt Arsenault c56a82fd05 Fix unused function warnings for conditionally used functions
Change-Id: Ied23c571b949abef1816914986f19b14aca3d2f3
2020-07-06 10:28:43 -04:00
Matt Arsenault 7124974148 Fix -Wunused-private-field
Change-Id: Iedf121025a33bf08eed310e3d85302f8bf3ac7d9
2020-07-06 10:27:43 -04:00
Matt Arsenault 9e3e41ca2e Remove unused functions
Change-Id: I55db791019c511de83d8b895e3a48b3d7475aeac
2020-07-06 10:27:29 -04:00
Matt Arsenault a430215067 Fix compiler test for clang
Change-Id: I06e01d3422ec4aa8d0fb8f5d9a44e2a840531a87
2020-07-06 10:27:11 -04:00
Chauncey Hui f9f7508578 SWDEV-2 - Change OpenCL version number from 3170 to 3171 2020-07-05 03:00:03 -04:00
German Andryeyev 059832b526 Return always true for P2P validation under ROCr
Change-Id: Id32a5a94a642e708d1d042c5247af38501bec153
2020-07-04 11:38:04 -04:00
Chauncey Hui f07fedd00a SWDEV-2 - Change OpenCL version number from 3169 to 3170 2020-07-01 03:00:03 -04:00
Payam 07848d7926 update debug print time to be us
Change-Id: I6f49304414ffc209f0fa1cb7199557c8423fcfa7
2020-06-29 18:45:24 -04:00
Chauncey Hui 38ae71d10b SWDEV-2 - Change OpenCL version number from 3168 to 3169 2020-06-27 03:00:05 -04:00
Aryan Salmanpour 34b82eb998 remove unused argument from enableHostcalls/disableHostcalls functions
Change-Id: I351a6b4e23cd9f118310c5c79b1afcb4758fde1b
2020-06-26 16:33:30 -04:00
Chauncey Hui 01d8a13065 SWDEV-2 - Change OpenCL version number from 3167 to 3168 2020-06-24 03:00:03 -04:00
Tao Sang da94cd0de1 Support numa policy set by user
Add hostNumaAlloc() to support numa policy set by user

Change-Id: Ib6c3e838aa53e3d9b3db9735c585df46a1c98944
2020-06-23 18:57:03 -04:00
Vlad Sytchenko 20c24cae93 Revert "Added file logging for rocclr & HIP"
This reverts commit 5f055d227d.

This change broke the legacy-complib build in p4. It seems that we can't use any flags in debug.cpp.

Change-Id: I17bb83651b85d6f415d9074634b479658fd4c3f9
2020-06-23 16:46:56 -04:00
Jason Tang 6f2dfea285 Remove finding OpenCL library
Change-Id: I44faa5c3d40430ae9c9bc5440252812a8e7f717d
2020-06-23 12:42:42 -04:00
Sarbojit Sarkar 5f055d227d Added file logging for rocclr & HIP
Change-Id: Ic0a54f6ee82d010b011739e0059778ed31833518
2020-06-23 04:30:36 -04:00
Chauncey Hui bafbbe663e SWDEV-2 - Change OpenCL version number from 3166 to 3167 2020-06-23 03:00:03 -04:00
German Andryeyev c18892a590 Remove extra barriers
Don't flush current batch if the dependent wait is a nop

Change-Id: I8a8722b9011fe042c1a4ce195938290fc75e7c86
2020-06-22 12:41:02 -04:00
Dittakavi Satyanvesh 7a3b8c6dd2 SWDEV-240566 adds error message before abort
Change-Id: I4dbd089daa5e6fde5e8722dc2395225dd822561c
2020-06-22 10:12:49 -04:00
Jason Tang 532083f87c For apu: call commitSvmMemory() from Device::svmAlloc()
Change-Id: Ic6e9b2ad4624e7e1c50835d3825254c76e764bf0
2020-06-22 10:09:32 -04:00
Chauncey Hui 836ee7eddb SWDEV-2 - Change OpenCL version number from 3165 to 3166 2020-06-20 03:00:03 -04:00
Tao Sang 53264a8a4a Support numa policy set by user
Add CL_MEM_FOLLOW_USER_NUMA_POLICY

Change-Id: I90a19dac7641827dff2ceb9ef8ae5f3467ed87a1
2020-06-19 18:16:47 -04:00
Jason Tang 138b2d3ce2 Set the tiled_ flag according to ImageCreateInfo
Change-Id: I3e1b2fdd15e32c3c24f4341001b068738c98e388
2020-06-19 12:34:07 -04:00
kjayapra-amd 71c05075ba SWDEV-229840 - Add Debug prints when the element is already present in MemObjMap_
Change-Id: I21129d087e73cc2a9e35f03e6a1a2dc527626f48
2020-06-19 12:33:20 -04:00
German Andryeyev 01fcf82448 Switch PAL to interface 610
Change-Id: Ida563f38513789f5ba105ac92a9737c59cd5d90d
2020-06-19 11:40:12 -04:00
Jason Tang 155ff5bdcc Merge pal Resource mapLayers/unmapLayers logic into map/unmap
Change-Id: I0198fb96f104539fb557f91160665e60ba576132
2020-06-19 10:51:48 -04:00
Aryan Salmanpour 1bd265f8d6 move hostcall-based implementation of messages/printf from rocm backend to the common device layer
SWDEV-232428

Change-Id: I14b774e66a1783569c6d34d8759c1faa5f340e27
2020-06-18 13:49:28 -04:00
Chauncey Hui c9c4250bbe SWDEV-2 - Change OpenCL version number from 3164 to 3165 2020-06-18 03:00:03 -04:00
Saleel Kudchadker d8efc31c34 Reset GPU_FORCE_BLIT_COPY_SIZE as its fixed in KFD
Commit ebcfa85cf7ebb26c96fca48a34292d88e74dd675
fixes programming of SDMA*_ULV_CNTL.HYSTERIS register

Change-Id: Ibb1d824bf3f8e351f840adbc099601b322f935f6
2020-06-17 13:23:41 -07:00
Chauncey Hui 7475e17537 SWDEV-2 - Change OpenCL version number from 3163 to 3164 2020-06-17 03:00:03 -04:00
German Andryeyev 01c2727a3a Disable P2P emulation for HIP
Some apps use P2P transfer without any validation for peer access.
Report an error if runtime has found such a request.

Change-Id: I3bf728f1fc3969697ade97bb1d2f1dce294078e2
2020-06-16 11:21:54 -04:00
Vlad Sytchenko b835120dfa Fix typo from previous change
Change-Id: Ib8f3418a3460d86d75fc5529ed6270a164e9b10e
2020-06-16 11:12:33 -04:00
Chauncey Hui e9cee93786 SWDEV-2 - Change OpenCL version number from 3162 to 3163 2020-06-16 03:00:03 -04:00
Vlad Sytchenko 5b9af8f28d Fix some -Wunused-but-set-variable warnings
Change-Id: I281583b5abdfc09d5dd8b7dfb20b8821581db193
2020-06-15 17:51:01 -04:00
Vlad Sytchenko e50a9eec9d Fix -Wsequence-point warning
Change-Id: Ib6322e06f83887da4a29f8eafb99b743211e851d
2020-06-15 17:40:11 -04:00
Vlad Sytchenko 947dbe82fb Enable the use of some warnings when building ROCclr
Enabling anything beyond -Wall like -Wextra or -pedantic seems impossible as our code base explodes in thousands of warnings.

-Wno-unused-{variable/function} is not present in the p4 build, but with gcc7.4.0 we get hundreds of instances of this warning being triggered in the code base.

With this change only two warnings show up during the build - -Wsequence-point and -Wunused-but-set-variable. The fix for the first is alredy in review.

Change-Id: I2ff37981377487b0e07fd9490498e38a60792c0c
2020-06-15 17:32:45 -04:00
German Andryeyev afe825c506 Fix compile error in ATI make build
Change-Id: Id9d23b8f46bf1b97c0f02c8ae0edd94e6963b1b5
2020-06-15 10:31:57 -04:00
Chauncey Hui 57eb9064ce SWDEV-2 - Change OpenCL version number from 3161 to 3162 2020-06-14 03:00:10 -04:00
Tao Sang b14d9e0a36 Deduce hops from numa distance
Rocr won't return real hops so that we have to deduce hops from
numa distance as a workaround. This will be subject to change
as driver team will provide a long term solution in rocm3.7

Change-Id: Ifb939ed848db190c3d544bb7f30a5821161921e6
2020-06-13 17:04:17 -04:00
Chauncey Hui 7ea8407f82 SWDEV-2 - Change OpenCL version number from 3160 to 3161 2020-06-13 03:00:03 -04:00
Tao Sang db10d42e50 Make hipHostMalloc() respect hipSetDevice()
Change-Id: Ibdb666fe8dd049735df2288878501a66f7eedc28
2020-06-12 18:32:10 -04:00
German Andryeyev e4177b75bc Add missing return
Change-Id: Ibe9c1ccb377ce14ad69a0e9828ea70b707acba34
2020-06-12 17:35:45 -04:00