Todd tiantuo Li
170e45b879
SWDEV-472357 - support Rect copy with staging buffer for 2D & 3D memcpy in PAL
...
Change-Id: Ie32f3e5a6fa077f6b2db20fc1ab1e2e0da8344cb
[ROCm/clr commit: 41dc4545fc ]
2024-10-10 18:00:19 -04:00
kjayapra-amd
55945b16c0
SWDEV-486510 - Delete hip::Function object, in case compiler passes duplicate hostFunction ptr.
...
Change-Id: Ic8714eb9022a0f2150b2ea5dc008cecd7a9fae27
[ROCm/clr commit: e7c0e06b5e ]
2024-10-10 12:45:58 -04:00
Vladana Stojiljkovic
af3e9cb9e2
SWDEV-489823 - Fix hipStreamEndCapture leak when capture is invalidated
...
Change-Id: If8f5163d70e04d34a75fd0a7ba6c0a15ea59bb8b
[ROCm/clr commit: 6f2bad3998 ]
2024-10-10 04:38:06 -04:00
Jaydeep Patel
7983801b0c
SWDEV-485866 - Return OOM if stream creation fails due to insufficient memory.
...
Change-Id: I4e57ecc81921bde274bb6a4e0890f0fc6a17955a
[ROCm/clr commit: 5ccc140e1b ]
2024-10-10 00:44:54 -04:00
Jatin Chaudhary
da59165313
SWDEV-486137 - match behavior of int variants of hadd/uhadd/rhadd/urhadd
...
Match cases and handle cases where it can overflow.
Change-Id: I3d6f802686af230a622ef9891a844135ad3d1ae5
[ROCm/clr commit: b977101893 ]
2024-10-09 13:47:33 -04:00
kjayapra-amd
3a2d835272
SWDEV-486573 - Check the return type of commit memory.
...
Change-Id: Id158cd7a0dff37b382b858cf7113aa4cf326300a
[ROCm/clr commit: 74ebbe17e9 ]
2024-10-09 05:10:03 -04:00
Julia Jiang
5d7b767788
SWDEV-479940 - Correct changelog in staging for 6.2.1
...
Change-Id: I3f35a85b9834841d27fa35abc52b9838d6f1c9e7
[ROCm/clr commit: d6bcabdc2c ]
2024-10-08 17:04:43 -04:00
Ioannis Assiouras
d452c4ad28
SWDEV-483134 - Deprecate hipHostMalloc and hipHostFree APIs
...
Change-Id: I230ab2de2e4bdfdd9bfb0a3e59c6130a25b8b0cd
[ROCm/clr commit: 80043d38f4 ]
2024-10-08 15:58:25 -04:00
Satyanvesh Dittakavi
815b9ffc36
SWDEV-489280 - Add missing hipGraphNodeSetParams API in dispatch table
...
Change-Id: I41dfd045fa4e29b49e605b8d583ec9f51dd6a6cc
[ROCm/clr commit: 15ecf834a1 ]
2024-10-08 13:56:02 -04:00
Jaydeep Patel
566984676e
SWDEV-487988 - Reserve event flag in hip::Event.
...
Don't create new hip:Function if it is already registered.
Change-Id: I3ecd5d61146659be6ba434717b0f21d3fc04cfc9
[ROCm/clr commit: a6c5c6a95a ]
2024-10-08 05:29:32 -04:00
Jaydeep Patel
b31bf885a3
SWDEV-482692, SWDEV-485802, SWDEV-485489 - Handle refcounts owned by graph for user objects.
...
Change-Id: Ic739ab1ec5d3dc3143e3ae70f9591922bc0e3d9f
[ROCm/clr commit: e74ac6f580 ]
2024-10-08 03:44:44 -04:00
Jaydeep Patel
3130b4639f
SWDEV-487905 - device_ptr_ is being removed and its amd:Memory obj is being deleted during ihipFree in hip::StatCO::removeFatBinary.
...
Change-Id: I89d9fdeb53dc4ce0699f1f445a28486917a36e72
[ROCm/clr commit: 164cbcc531 ]
2024-10-08 03:38:15 -04:00
Branislav Brzak
491d3828dd
SWDEV-482130 - Fix release of virtual mem obj
...
Change-Id: I893a8353aa1a25d00e36c8e601caf31cc0fc1f22
[ROCm/clr commit: 43fcac1739 ]
2024-10-08 01:37:39 -04:00
Satyanvesh Dittakavi
57c5264937
SWDEV-483241 - Add a compile option to avoid including default hiprtc header
...
Change-Id: Ic23b41395588e6183abac36cb7543da02b0aba29
[ROCm/clr commit: 522ae8ead4 ]
2024-10-07 07:56:29 -04:00
Saleel Kudchadker
b9497ea70e
SWDEV-301667 - Enable ROCr logging
...
- Use AMD_LOG_LEVEL=5 to dump AQL packets in ROCr
Change-Id: I2c044a5304c4eaf3d3af20e62d1f54c98d4fbaa4
[ROCm/clr commit: e36666e536 ]
2024-10-04 19:22:12 -04:00
Saleel Kudchadker
375ed9d848
SWDEV-478065 - Revert "SWDEV-478065 - Embed host thread in shared_ptr"
...
This reverts commit 274fd2628f .
Reason for revert: This blocks multithreaded callbacks
Change-Id: I9944417e4fb63c9eea2b286c828c7dfa621c4fe8
[ROCm/clr commit: d3d0ca5fc6 ]
2024-10-04 19:19:28 -04:00
Branislav Brzak
169423798f
SWDEV-476542 - Unable to link to hipGraphExecGetFlags
...
Change-Id: I572baaeee31c6a73e533f9ef956bf111e9d2e688
[ROCm/clr commit: d29ebea7ac ]
2024-10-04 13:39:06 -04:00
Saleel Kudchadker
5296c77138
SWDEV-301667 - Logging upgrades
...
- Use AMD_LOG_LEVEL_SIZE in MBs to set log file size truncation, by default its 2048 MB
Change-Id: Ia2f87e8c6b94148e30edfb602b279f93630817c3
[ROCm/clr commit: 35e03ea0d0 ]
2024-10-04 13:26:25 -04:00
Jaydeep Patel
91b343c758
SWDEV-471422 - Free memory being double deducted on APUs due to system_total_alloced var holds local memory.
...
Change-Id: I3fbbc8f8aaa156881ff95cad6a4f82fd3df651d1
[ROCm/clr commit: 292842ad28 ]
2024-10-04 04:49:20 -04:00
pghafari
38ad03660a
SWDEV-467263 - Allow hipMalloc to use sys memory
...
PAL supports allocating from system memory once device memory is used up
or allocation is larger than the device memory.
Change-Id: Iccd3377e95a6cc6d23e45d4738a17af8b9ee32d7
[ROCm/clr commit: b07178618c ]
2024-10-03 11:14:08 -04:00
Ioannis Assiouras
00cb623a67
SWDEV-488851 - Correctly remove the queue from the active set on windows
...
Change-Id: I4d21743ecf7a44636121f85566f898e62ff61e97
[ROCm/clr commit: 07bcc283f9 ]
2024-10-02 12:06:59 +01:00
Satyanvesh Dittakavi
b758610a55
SWDEV-478708 - Remove forced wait of 10us in hipEventQuery
...
Change-Id: I868aae14311c3cdfc09aa03252ac324c4b79b864
[ROCm/clr commit: ade1954015 ]
2024-10-01 06:27:42 -04:00
Rahul Manocha
9f10e89d97
SWDEV-487903 - Fix for Empty Kernel Segfault in PAL
...
Change-Id: Ia1c19cf4ea24188cdb2d374b07f975f794e02dba
[ROCm/clr commit: 9da90fe848 ]
2024-09-30 13:00:15 -04:00
Jaydeep Patel
bc3f3b09df
SWDEV-487905 - Managed vars are registered in __hipRegisterManagedVar however not freed.
...
Change-Id: Ic5a72ac4d64a9f7f5a3a7a88e1ed813e6dcc1f57
[ROCm/clr commit: 614b00c20b ]
2024-09-30 11:54:31 -04:00
Julia Jiang
493e9c7884
SWDEV-412099 - Fix CTS clFillImage sub-tests failures
...
Change-Id: I082476837c539e6ccf93cba6b1e97aae2509e65c
[ROCm/clr commit: 17c8b9f855 ]
2024-09-30 11:13:52 -04:00
Branislav Brzak
6a9b977def
SWDEV-478034 - Unable to link to hipGraphExecNodeSetParams
...
Change-Id: I0b6b8d1a4281ecda3c1789d8829ade9771aed741
[ROCm/clr commit: 939c788779 ]
2024-09-30 02:13:43 -04:00
Anusha GodavarthySurya
c0ceb1cf12
SWDEV-477324 - Capture Memcpy1D pinned H2D D2H
...
Change-Id: I1f4744f20a9caeed005ec68da44e5fde737e09f7
[ROCm/clr commit: 742b0210d3 ]
2024-09-30 01:01:30 -04:00
Vladana Stojiljkovic
887b11894b
SWDEV-482086 - Fix hipGraphInstantiate leak
...
* In a scenario where kernel is launched with hipExtLaunchKernelGGL and stop event is used, hipGraphInstantiate leaks. Since stop event is used, profiling is enabled and Timestamp (ReferencedCountedObject) is created, but it doesn't get released.
* The idea behind this solution is that profiling should be disabled when command is captured, hence the timestamp should not be created. Because information about capturing isn't available when kernel command is created, packet capturing state is used to determine whether to create a timestamp or not.
Change-Id: Ia23adac4592ded4fb5e236acf99e12e729f63692
[ROCm/clr commit: da5f1a6146 ]
2024-09-29 11:36:53 -04:00
Jaydeep Patel
98539759f1
SWDEV-483436 - User spt stream as def with -fgpu-default-stream=per-thread for hipMemsetAsync.
...
Change-Id: Ia85c2b4c40fc9250754d3b64fb9fd1c615362572
[ROCm/clr commit: d6193a2f23 ]
2024-09-29 01:42:33 -04:00
Rahul Manocha
da48c3b185
[SWDEV-467733] - Add Param checking for SetCacheConfig APIs
...
Change-Id: I9e777fa0fae6791ebab539e49346e6956a6ff196
[ROCm/clr commit: 0d20383ef9 ]
2024-09-27 11:32:58 -04:00
Jonathan R. Madsen
43a1d720d5
Fix HIP API trace versioning
...
Change-Id: I33f2be4668c96e2225d4ca9a253e61ec2dc65102
[ROCm/clr commit: 07c9c7fe56 ]
2024-09-25 10:32:14 -04:00
Ajay
98a1b3b42a
SWDEV-486816 - RenderOpDispatch usage in pal client
...
Change-Id: I11cae3e625b287b998c9500c547efdacf1034a2b
[ROCm/clr commit: 7a288ea8bf ]
2024-09-24 14:28:16 -04:00
pghafari
1157776b30
SWDEV-479260,SWDEV-483599 - Check griddim Y,Z <= 65536
...
Gfx12 has 16 bits for grid dim Y/Z. Detect gfxIp and return error if dim y/z > 16 bits
Change-Id: I43dd14affc9e4073d0b1232e7523967f0180fa31
[ROCm/clr commit: 0a918c8f96 ]
2024-09-23 11:36:13 -04:00
Jatin Chaudhary
0a850d8725
SWDEV-466747 - call device sync once while unregistering
...
Basically embed hipDeviceSync in std::call_once.
Change-Id: I29ca926d61ed80e21acba5c388a8256d913487e4
[ROCm/clr commit: f8beeede22 ]
2024-09-23 08:00:10 -04:00
German Andryeyev
f8fc11c2d8
SWDEV-483586 - Unblock staging H2D transfers
...
Although unpinned copies require synchronizations
in HIP, runtime can avoid syncs for H2D copies with
a staging buffer
Change-Id: If2203c6bc0cbd89742823688dc8e89e9acd873b2
[ROCm/clr commit: 29cc678d8d ]
2024-09-21 10:25:27 -04:00
Maneesh Gupta
e87bf2096d
SWDEV-485179 - Revert "SWDEV-459254 - Overwrite cacheline size to 256 for gfx12, as it is used for kernarg alignment."
...
This reverts commit 1f63650bf96e01e48f879aa58b80e2130dd4a567.
Reason for revert: <INSERT REASONING HERE>
Change-Id: I6d7ed87c09d9b77116548dce1f30ac4711c2c09d
[ROCm/clr commit: 2d1c6ee23e ]
2024-09-20 11:33:34 -04:00
Anusha GodavarthySurya
f278ac9ea0
SWDEV-485904 - Fix virtual,physical mem obj leaks
...
Change-Id: Ie0456b5dcfec206ae54a6aabfc2a15a620cac693
[ROCm/clr commit: 870842201d ]
2024-09-19 23:04:20 -04:00
Saleel Kudchadker
d5c396e820
SWDEV-301667 - Improve logging
...
Change-Id: I3fa06791b7ac73d84b8a9586e6b3435fa8858d25
[ROCm/clr commit: 8c84a20b01 ]
2024-09-19 15:09:03 -04:00
kjayapra-amd
f19260d568
SWDEV-480772 - Remove name variable from amd::Monitor class.
...
Change-Id: Ie2a4fa44f485786227230f8a892e090e718aa30e
[ROCm/clr commit: 12a39fbf22 ]
2024-09-19 11:55:01 -04:00
Marko Arandjelovic
a261d1f49c
Revert "SWDEV-441296 - Allign hipTexObjectCreate error handling to CUDA"
...
This reverts commit 2e7581a69a .
Changing the error code is considered as a breaking change,
so it should be done in major releases only.
The other reason for reverting the commit is that this change itself
is incorrect. Cuda behaves in the same way as hip when
pResDesc or pTexDesc are nullptr.
Change-Id: I3abee6b79279b81ab01c7f8466c7f8e3776c4109
[ROCm/clr commit: cfdc9dfc36 ]
2024-09-18 16:38:16 -04:00
Rahul Manocha
c4cab41cc2
SWDEV-479575 - Add marker to parent graph dependencies in childgraph node
...
1) Child Graph nodes need to have parent graph dependencies in waitlist.
2) Marker is placed on base stream with parent graph waitlist
Change-Id: Iec65a0171ea387be05b0733abcc708fb630e4be4
[ROCm/clr commit: 4d1ded9eaf ]
2024-09-18 15:12:50 -04:00
pghafari
3fc58e93b3
SWDEV-444447 - Fix regression for verbose printing for AMD_LOG_LEVEL=4
...
Change-Id: Id245caef711b7ccdf4e999e934993beb43d7c3d5
[ROCm/clr commit: 365ffd4805 ]
2024-09-18 13:08:10 -04:00
Rahul Manocha
e46733affe
SWDEV-439234 - Fix for Segfault in ValidateMemAccess
...
Change-Id: I251d277eb5af16ba5c0de85ffd142a5f64fa469d
[ROCm/clr commit: 07261002b1 ]
2024-09-18 10:52:32 -04:00
Daniel Livingston
7c0ff614a2
SWDEV-77148 - Add UberTrace support to PAL device
...
This PR adds UberTrace-based tracing support to ROCclr's PAL device class.
Legacy RGP-based tracing is still available and is the default.
If UberTrace support is enabled tool-side, this new code path will activate.
Change-Id: I268b2dcef70e850a50e2caef8355f38bf51d4641
[ROCm/clr commit: e550032d25 ]
2024-09-17 16:06:37 -04:00
Satyanvesh Dittakavi
1ef9123b54
SWDEV-478776 - Fix segfault with streamsync using hipStreamLegacy
...
Change-Id: Ifb412d0bcfa33bc1130b47b757ee276ca9bc1c3a
[ROCm/clr commit: 8ee065c5bd ]
2024-09-17 15:02:18 -04:00
Jatin Chaudhary
274fd2628f
SWDEV-478065 - Embed host thread in shared_ptr
...
This shows up in some valgrind runs. Make sure the resources are
released.
Change-Id: I34c25c00370a221585895655744831215136d5f4
[ROCm/clr commit: 4b03017e8a ]
2024-09-17 09:53:51 -04:00
Jaydeep Patel
7b2cd9111c
SWDEV-478049 - Clear packets list as it is being added back later during submitKernelInternal while setting params for graph node.
...
Change-Id: I7451ffda93d94eeda5e1be05bb87558ae86d2a19
[ROCm/clr commit: 2494992695 ]
2024-09-16 23:10:32 -04:00
Ioannis Assiouras
b5a8d775d6
SWDEV-476929 - Introduce an activeQueues set
...
The new set tracks only the queues that have a command
submitted to them. This allows for fast iteration
in waitActiveStreams.
Change-Id: I2c832eefa01280d9a87a5f57874d36d2e9441de7
[ROCm/clr commit: bcc545e6b8 ]
2024-09-16 15:53:49 -04:00
kjayapra-amd
196e2a53bc
SWDEV-484188 - Change few std::array style globals to C style to avoid optimization on Static Libs.
...
Change-Id: Iab6d3c040b8d088013daa08093898be99dd3a971
[ROCm/clr commit: d81c5d3d7f ]
2024-09-16 09:46:56 -04:00
kjayapra-amd
e05182981a
SWDEV-484188 - Moving std::maps into struct const and into amd::Kernel class.
...
Change-Id: Ie4d5a64511412fdb498b045aaffb52c3a1286de6
[ROCm/clr commit: 4ecd77df5e ]
2024-09-15 09:14:51 -04:00